Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw merged PR #233: URL: https://github.com/apache/creadur-rat/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1567942299 ## apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml: ## @@ -59,7 +58,7 @@ - + Review Comment: I guess we should a

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1567906675 ## apache-rat-tasks/pom.xml: ## @@ -105,7 +105,7 @@ - +

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1566295110 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1566294449 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1566045733 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1566018593 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1566000528 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1565988070 ## apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml: ## @@ -59,7 +58,7 @@ - + Review Comment: format is deprecated

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1565985468 ## apache-rat-tasks/pom.xml: ## @@ -105,7 +105,7 @@ - +

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on PR #233: URL: https://github.com/apache/creadur-rat/pull/233#issuecomment-2054220779 @Claudenw thanks for these big changes with tests and documentation. It's a lot of code that changed, but the examples and tests seem much more simple and straightforward to me. --

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564980464 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564979664 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564979233 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564978793 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564978657 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564978150 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564977706 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564977476 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564975996 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564975740 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564975345 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564974753 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564974001 ## src/site/apt/matcher_def.apt.vm: ## @@ -0,0 +1,364 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564973518 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564972954 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564972536 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564970399 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564969756 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564969176 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564969396 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564969032 ## src/site/apt/license_def.apt.vm: ## @@ -0,0 +1,143 @@ + +~~ Licensed to the Apache

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564968102 ## src/site/apt/index.apt.vm: ## @@ -63,6 +63,16 @@ Apache Rat {{{./issue-management.html}patch}} or {{{./mailing-lists.html}talk to us}} whenever Rat falls

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564967796 ## src/site/apt/index.apt.vm: ## @@ -63,6 +63,16 @@ Apache Rat {{{./issue-management.html}patch}} or {{{./mailing-lists.html}talk to us}} whenever Rat falls

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564966381 ## apache-rat-tasks/src/test/resources/antunit/report-bad-configurations.xml: ## @@ -59,7 +58,7 @@ - + Review Comment: Does that mean we need

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564965074 ## apache-rat-tasks/pom.xml: ## @@ -105,7 +105,7 @@ - +

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on PR #233: URL: https://github.com/apache/creadur-rat/pull/233#issuecomment-2054033781 Just a FYI: I have an implementation of a program that will write ANT tasks for any given command line configuration. So adding new matchers in Ant is fairly easy. -- This is an

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564549846 ## apache-rat-core/src/test/java/org/apache/rat/analysis/matchers/AbstractMatcherTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564538194 ## apache-rat-core/src/test/java/org/apache/rat/analysis/matchers/AbstractMatcherTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564536412 ## apache-rat-core/src/test/java/org/apache/rat/ReportTest.java: ## @@ -55,9 +61,9 @@ public void testDefaultConfiguration() throws ParseException, IOException {

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564527324 ## apache-rat-core/src/main/resources/org/apache/rat/plain-rat.xsl: ## @@ -53,42 +53,58 @@ Files with unapproved licenses: Archives: - + + +

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564526816 ## apache-rat-core/src/main/java/org/apache/rat/utils/Log.java: ## @@ -59,51 +59,105 @@ public enum Level { */ void log(Level level, String message);

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564525024 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java: ## @@ -525,24 +548,36 @@ private void writeAttributeContent(CharSequence

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564522497 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java: ## @@ -514,6 +526,17 @@ private void writeAttributeContent(CharSequence

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564520043 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/impl/xml/SimpleXmlClaimReporter.java: ## @@ -140,9 +100,9 @@ public void startReport() throws

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564518136 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/impl/ClaimAggregator.java: ## @@ -19,84 +19,80 @@ package org.apache.rat.report.claim.impl;

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564515824 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564515299 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564513148 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564500995 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564500839 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java: ## @@ -32,22 +31,22 @@ public class SpdxBuilder extends AbstractBuilder {

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564500321 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564497770 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564496622 ## apache-rat-core/src/main/java/org/apache/rat/license/LicenseSetFactory.java: ## @@ -220,5 +221,5 @@ public static ILicense search(ILicense target, SortedSet

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564487716 ## apache-rat-core/src/main/java/org/apache/rat/document/impl/ArchiveEntryDocument.java: ## @@ -37,44 +36,44 @@ public class ArchiveEntryDocument implements

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564487716 ## apache-rat-core/src/main/java/org/apache/rat/document/impl/ArchiveEntryDocument.java: ## @@ -37,44 +36,44 @@ public class ArchiveEntryDocument implements

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564479047 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/NotBuilder.java: ## @@ -19,24 +19,23 @@ package org.apache.rat.configuration.builders;

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564476180 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/ChildContainerBuilder.java: ## @@ -99,11 +102,11 @@ public AbstractBuilder add(Collection

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

jbonofre commented on PR #233: URL: https://github.com/apache/creadur-rat/pull/233#issuecomment-2053896244 Sorry guys, I'm late on this one. I will take a look today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564262038 ## apache-rat-core/src/main/resources/org/apache/rat/plain-rat.xsl: ## @@ -53,42 +53,58 @@ Files with unapproved licenses: Archives: - + + +

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564260890 ## apache-rat-core/src/main/java/org/apache/rat/utils/Log.java: ## @@ -59,51 +59,105 @@ public enum Level { */ void log(Level level, String message);

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564259367 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java: ## @@ -525,24 +548,36 @@ private void

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564259075 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java: ## @@ -525,24 +548,36 @@ private void

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564258632 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java: ## @@ -525,24 +548,36 @@ private void

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564258251 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java: ## @@ -514,6 +526,17 @@ private void writeAttributeContent(CharSequence

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564257079 ## apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/IXmlWriter.java: ## @@ -66,8 +76,8 @@ public interface IXmlWriter extends AutoCloseable {

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564255897 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/impl/xml/SimpleXmlClaimReporter.java: ## @@ -140,9 +100,9 @@ public void startReport() throws

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564254665 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/impl/ClaimAggregator.java: ## @@ -19,84 +19,80 @@ package org.apache.rat.report.claim.impl;

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564252944 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564253245 ## apache-rat-core/src/main/java/org/apache/rat/report/claim/ClaimStatistic.java: ## @@ -19,100 +19,62 @@ package org.apache.rat.report.claim; +import

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564252525 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564251427 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564251232 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564250926 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564250356 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564249322 ## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564247820 ## apache-rat-core/src/main/java/org/apache/rat/policy/DefaultPolicy.java: ## @@ -45,6 +46,7 @@ public DefaultPolicy(final Collection approvedLicenseFamilies) {

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564247234 ## apache-rat-core/src/main/java/org/apache/rat/license/LicenseSetFactory.java: ## @@ -220,5 +221,5 @@ public static ILicense search(ILicense target, SortedSet

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564235828 ## apache-rat-core/src/main/java/org/apache/rat/license/ILicense.java: ## @@ -22,42 +22,58 @@ import java.util.Objects; import java.util.SortedSet; +import

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564221716 ## apache-rat-core/src/main/java/org/apache/rat/document/impl/ArchiveEntryDocument.java: ## @@ -37,44 +36,44 @@ public class ArchiveEntryDocument implements

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564218868 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/TextBuilder.java: ## @@ -22,27 +22,24 @@ import org.apache.commons.lang3.StringUtils;

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564217809 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java: ## @@ -32,22 +31,22 @@ public class SpdxBuilder extends AbstractBuilder {

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564214513 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/NotBuilder.java: ## @@ -19,24 +19,23 @@ package org.apache.rat.configuration.builders;

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564204184 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/MatcherRefBuilder.java: ## @@ -56,31 +68,53 @@ public MatcherRefBuilder setMatchers(Map

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564202140 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/MatcherRefBuilder.java: ## @@ -20,19 +20,26 @@ import java.util.Map; +import

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564201219 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/MatcherRefBuilder.java: ## @@ -20,19 +20,26 @@ import java.util.Map; +import

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564199293 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/ChildContainerBuilder.java: ## @@ -99,11 +102,11 @@ public AbstractBuilder add(Collection

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564198283 ## apache-rat-core/src/main/java/org/apache/rat/configuration/builders/ChildContainerBuilder.java: ## @@ -52,39 +52,42 @@ protected ChildContainerBuilder() {

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564196856 ## apache-rat-core/src/main/java/org/apache/rat/configuration/XMLConfigurationReader.java: ## @@ -279,14 +334,13 @@ private ILicense parseLicense(Node licenseNode)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1563980407 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1563972537 ## apache-rat-core/src/main/java/org/apache/rat/analysis/LicenseCollection.java: ## @@ -22,33 +22,37 @@ import java.util.Collections; import

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1556240399 ## apache-rat-core/src/main/java/org/apache/rat/analysis/HeaderCheckWorker.java: ## @@ -47,98 +53,103 @@ class HeaderCheckWorker { private final int

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555989822 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555987496 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555986918 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555985106 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555955647 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555953422 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Description.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555930879 ## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Component.java: ## @@ -0,0 +1,48 @@ +package org.apache.rat.config.parameters; +/* + * Licensed

Re: [PR] RAT-355 and RAT-366 fixes in one package [creadur-rat]

ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1555914329 ## apache-rat-core/src/main/java/org/apache/rat/api/MetaData.java: ## @@ -18,340 +18,128 @@ */ package org.apache.rat.api; -import java.util.ArrayList;

  1   2   >