Claudenw commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536599628
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -79,12 +79,10 @@ usage: java -jar
apache-rat/target/apache-rat-${project.version}.jar
[options]
[
https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830061#comment-17830061
]
Claude Warren commented on RAT-366:
---
Fix in [pull 228|https://github.com/apache/creadur-rat/pull/228]
>
nielsbasjes commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016494164
@Claudenw I think the testing issue
https://github.com/apache/creadur-rat/pull/230 should be fixed first because
otherwise there is no way to show this actually works on all JDK
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663580
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -303,15 +314,13 @@ static Options buildOptions() {
opts.addOption(null,
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663808
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -79,12 +79,10 @@ usage: java -jar
apache-rat/target/apache-rat-${project.version}.jar
[options]
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663898
##
src/site/apt/index.apt.vm:
##
@@ -111,6 +113,17 @@ java -jar apache-rat-${project.version}.jar --help
+--+
Read
Niels Basjes created RAT-367:
Summary: Not all tests are run during the build
Key: RAT-367
URL: https://issues.apache.org/jira/browse/RAT-367
Project: Apache Rat
Issue Type: Bug
ottlinger commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016547369
@nielsbasjes pls rebase your branch in order for all build checks to run
again (as RAT-367 is merged now). Thanks
--
This is an automated message from the Apache Git Service.
To
nielsbasjes commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016491170
For the tests I created this https://issues.apache.org/jira/browse/RAT-367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-367:
--
Description:
There are some tests that use the old Junit 3 APIs and these are not run by
default
[
https://issues.apache.org/jira/browse/RAT-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830107#comment-17830107
]
Philipp Ottlinger commented on RAT-336:
---
Maybe we could get rid of jUnit3 tests as well while
[
https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830108#comment-17830108
]
ASF subversion and git services commented on RAT-367:
-
Commit
ottlinger commented on PR #230:
URL: https://github.com/apache/creadur-rat/pull/230#issuecomment-2016545480
Thanks for the catch, I'll add a changelog entry accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ottlinger merged PR #230:
URL: https://github.com/apache/creadur-rat/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-362:
--
Summary: plugin: .gitignore not correctly applied - bugfix in underlying
gitignore-reader library
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger reassigned RAT-362:
-
Assignee: Philipp Ottlinger (was: Jean-Baptiste Onofré)
> plugin: .gitignore not
[
https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-345:
--
Description:
h1. Updates via dependabot in RAT 0.17
h2. (/) Update Bump assertj-core from 3.25.1
[
https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-367:
--
Component/s: build
Fix Version/s: 0.17
Affects Version/s: 0.16.1
> Older junit3
[
https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830111#comment-17830111
]
ASF subversion and git services commented on RAT-367:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger resolved RAT-367.
---
Resolution: Fixed
Thanks
> Older junit3 tests are not run during the build after migrating to
nielsbasjes commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016552089
I suspect the new test will fail on Windows because I expect to get a drive
letter in the middle.
--
This is an automated message from the Apache Git Service.
To respond to the
nielsbasjes commented on code in PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#discussion_r1536664496
##
apache-rat-plugin/src/test/resources/unit/RAT-362-GitIgnore/pom.xml:
##
@@ -0,0 +1,43 @@
+
+
+http://maven.apache.org/POM/4.0.0;
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830169#comment-17830169
]
ASF subversion and git services commented on RAT-362:
-
Commit
ottlinger merged PR #229:
URL: https://github.com/apache/creadur-rat/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830171#comment-17830171
]
ASF subversion and git services commented on RAT-362:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830168#comment-17830168
]
ASF subversion and git services commented on RAT-362:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830170#comment-17830170
]
ASF subversion and git services commented on RAT-362:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830172#comment-17830172
]
ASF subversion and git services commented on RAT-345:
-
Commit
ottlinger commented on PR #223:
URL: https://github.com/apache/creadur-rat/pull/223#issuecomment-2016621846
Thanks for spotting this error and providing a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830175#comment-17830175
]
ASF subversion and git services commented on RAT-362:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830176#comment-17830176
]
ASF subversion and git services commented on RAT-345:
-
Commit
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663580
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -303,15 +314,13 @@ static Options buildOptions() {
opts.addOption(null,
[
https://issues.apache.org/jira/browse/RAT-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated RAT-77:
-
Fix Version/s: 0.17
> output missing headers inline from plugin
>
[
https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830181#comment-17830181
]
ASF subversion and git services commented on RAT-345:
-
Commit
ottlinger merged PR #223:
URL: https://github.com/apache/creadur-rat/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/RAT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830179#comment-17830179
]
ASF subversion and git services commented on RAT-333:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830180#comment-17830180
]
ASF subversion and git services commented on RAT-333:
-
Commit
[
https://issues.apache.org/jira/browse/RAT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger resolved RAT-333.
---
Resolution: Fixed
Merged.
> --force option will change the file permissions
>
ottlinger commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016612423
@Claudenw I do hope it is fine with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger resolved RAT-362.
---
Resolution: Fixed
[~engelen] would you mind giving feedback if the current 0.17-SNAPSHOT fixes
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536701128
##
src/site/apt/index.apt.vm:
##
@@ -111,6 +113,17 @@ java -jar apache-rat-${project.version}.jar --help
+--+
Read
nielsbasjes commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016485876
> @nielsbasjes do you have a test that shows failure before this fix is
applied?
Yes.
In this case it is a problem in the upstream library (which I wrote) where I
have
nielsbasjes commented on PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016492427
Also a merge request to fix this testing issue
https://github.com/apache/creadur-rat/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830109#comment-17830109
]
ASF subversion and git services commented on RAT-367:
-
Commit
ottlinger commented on code in PR #229:
URL: https://github.com/apache/creadur-rat/pull/229#discussion_r1536662289
##
apache-rat-plugin/src/test/resources/unit/RAT-362-GitIgnore/pom.xml:
##
@@ -0,0 +1,43 @@
+
+
+http://maven.apache.org/POM/4.0.0;
45 matches
Mail list logo
