Github user njhill commented on the issue:
https://github.com/apache/curator/pull/281
Great, thanks @cammckenzie @Randgalt. And I just noticed something odd
which may be contributing to the confusion ... at least for me right now the
commits on the Commits tab are showing
Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/281#discussion_r236832802
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -422,6 +422,9 @@ protected void deleteNode
Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/281#discussion_r233958695
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -445,7 +445,8 @@ private void createNode
Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/281#discussion_r233243506
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -445,7 +445,8 @@ private void createNode
Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/281#discussion_r231591529
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -444,8 +447,19 @@ private void createNode
Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/281#discussion_r231356314
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
@@ -445,7 +445,8 @@ private void createNode
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/281
@cammckenzie sure, I've now added one
---
GitHub user njhill opened a pull request:
https://github.com/apache/curator/pull/281
[CURATOR-483] Fix path used when re-creating sequential PersistentNode with
protection
Would previously result in creation of a second non-sequential znode.
See https://issues.apache.org
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
Thanks alot @dragonsinth for going through this so carefully. I like your
additional simplifications, and sorry for the project style inconsistencies
that I missed!
I've pulled in your
Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/250#discussion_r167715799
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
@@ -728,13 +710,12 @@ private TreeNode find(String
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
@dragonsinth any interest in these changes? Maybe I should rename the PR
since as you pointed out the memory saving aspect isn't very significant (I
measured about 2% on a cache of 50k empty nodes
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
@dragonsinth I've removed the `outstandingOps` change commit from the PR,
and added a new commit which reverts the `TreeNode extends
AtomicReference` change. Hopefully that helps to make this more
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
Thanks @dragonsinth, there's of course no rush at all!
I agree that `TreeNode extends AtomicReference` isn't a "win" as such, it
just looked cleaner to me than usi
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
@dragonsinth @Randgalt any interest in these updates? FWIW I've had them
running in production for some time.
---
GitHub user njhill opened a pull request:
https://github.com/apache/curator/pull/250
[CURATOR-447] TreeCache: Improve memory usage and thread safety
Jira https://issues.apache.org/jira/browse/CURATOR-374 reduced per-node
memory usage in `TreeCache`. It can be improved further via
15 matches
Mail list logo
