Re: Swagger2Feature bug caused by removal of isScan() check

2017-10-10 Thread Sergey Beryozkin
I've introduced the property but it is set to false in 3.2.x Sergey On 07/10/17 17:17, Sergey Beryozkin wrote: Hi Dennis Thanks very much, my fault really as I did not see a point in keeping this property in 3.2.x and indeed, as you imply, all tests were/are still passing, but I guess more

Re: Swagger2Feature bug caused by removal of isScan() check

2017-10-07 Thread Sergey Beryozkin
Hi Dennis Thanks very much, my fault really as I did not see a point in keeping this property in 3.2.x and indeed, as you imply, all tests were/are still passing, but I guess more preparation should've gone into it. Setting a scan to true did never work in OSGI as far as I know, may be in

Re: Swagger2Feature bug caused by removal of isScan() check

2017-10-07 Thread Dennis Kieselhorst
Hi Taylor! > This causes the subsequent code (line 196): > > BeanConfig beanConfig = appInfo == null > ? new BeanConfig() > : new ApplicationBeanConfig(appInfo.getProvider()); > > …to always instantiate an ApplicationBeanConfig object. Our production code > relied on the BeanConfig’s

Swagger2Feature bug caused by removal of isScan() check

2017-10-06 Thread Burke, Taylor
Hi all, I think I may have found a potential bug in the Swagger2Feature.java file caused by the removal and subsequent changes made with regards to removing the if ( !isScan() ) check at the beginning of the addSwaggerResource implementation. Previously, the appInfo object was only populated