[GitHub] johnament commented on issue #331: [CXF-7535] Adding client & server support for Project Reactor

2017-10-29 Thread GitBox
johnament commented on issue #331: [CXF-7535] Adding client & server support for Project Reactor URL: https://github.com/apache/cxf/pull/331#issuecomment-340328466 Hi @deki thanks for the tip. What profiles would you recommend? note that I only have the jaxrs systests module open in my

[GitHub] deki commented on issue #331: [CXF-7535] Adding client & server support for Project Reactor

2017-10-29 Thread GitBox
deki commented on issue #331: [CXF-7535] Adding client & server support for Project Reactor URL: https://github.com/apache/cxf/pull/331#issuecomment-340284830 Usually I have this issue if I miss some Maven profile selections. Adjusting the checkboxes normally fixes this.

JIRA Karma?

2017-10-29 Thread John D. Ament
Hi, Could someone give me karma on JIRA to assign tickets to myself? John

[GitHub] johnament opened a new pull request #331: [CXF-7535] Adding client & server support for Project Reactor

2017-10-29 Thread GitBox
johnament opened a new pull request #331: [CXF-7535] Adding client & server support for Project Reactor URL: https://github.com/apache/cxf/pull/331 This is still a WIP, so not ready to be merged. I'm looking to add support for Project Reactor as an rx invoker for CXF. It

[GitHub] johnament commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
johnament commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340283415 In general, there are no issues using CXF with CDI 2, the

[GitHub] reta commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340282842 To be fair, we haven't tested with CDI 2 yet :-) But if you could

[GitHub] johnament commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
johnament commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340282232 LGTM as well. FWIW, I was able to cause it to fail using a CDI

[GitHub] reta closed pull request #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta closed pull request #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330 This is a PR merged from a forked repository. As GitHub hides the original diff on

[GitHub] reta commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340281055 Done, https://issues.apache.org/jira/browse/CXF-7544. @rmannibucau

[GitHub] rmannibucau commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
rmannibucau commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340280475 +1, that's why it was a side note ;)

[GitHub] rmannibucau commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
rmannibucau commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340279887 @ApplicationScoped the provider, will be proxied so the

[GitHub] reta commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on issue #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330#issuecomment-340279707 Thanks @rmannibucau, we should be good here as `@Context` members

[GitHub] reta opened a new pull request #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta opened a new pull request #330: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/330 Using proper CDI bean resolution with fallback to default strategy. The `@Vetoed`

[GitHub] reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147586312 ## File path:

[GitHub] rmannibucau commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
rmannibucau commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147586166 ## File path:

[GitHub] johnament commented on issue #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
johnament commented on issue #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#issuecomment-340273268 Could you double check with an explicitly @Vetoed provider? I

[GitHub] rmannibucau commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
rmannibucau commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147585617 ## File path:

[GitHub] reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147585376 ## File path:

[GitHub] reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147585376 ## File path:

[GitHub] reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147585253 ## File path:

[GitHub] rmannibucau commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
rmannibucau commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147585124 ## File path:

Re: JAX-RS Features not used for ClientProxies

2017-10-29 Thread John D. Ament
Done, submitted https://issues.apache.org/jira/browse/CXF-7543 On 2017-10-29 10:16, Andriy Redko wrote: > One of the long standing ones :-), I think we should make both equally > supported. John, could you please create a JIRA for this issue? > > JDA> Hey guys > > JDA>

Re: JAX-RS Features not used for ClientProxies

2017-10-29 Thread Andriy Redko
One of the long standing ones :-), I think we should make both equally supported. John, could you please create a JIRA for this issue? JDA> Hey guys JDA> Earlier today I was looking at an issue noted where proxies created for CXF JDA> weren't leveraging JAX-RS Features registered as providers.

[GitHub] reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

2017-10-29 Thread GitBox
reta commented on a change in pull request #329: CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext) URL: https://github.com/apache/cxf/pull/329#discussion_r147582392 ## File path:

Re: JAX-RS Features not used for ClientProxies

2017-10-29 Thread Jean-Baptiste Onofré
Makes sense. +1. Regards JB On Oct 29, 2017, 08:44, at 08:44, Romain Manni-Bucau wrote: >+1 to align both, makes way more sense for end users IMHO > >Le 29 oct. 2017 02:53, "John D. Ament" a écrit >: > >> Hey guys >> >> Earlier today I was looking

Re: JAX-RS Features not used for ClientProxies

2017-10-29 Thread Romain Manni-Bucau
+1 to align both, makes way more sense for end users IMHO Le 29 oct. 2017 02:53, "John D. Ament" a écrit : > Hey guys > > Earlier today I was looking at an issue noted where proxies created for CXF > weren't leveraging JAX-RS Features registered as providers. > > After