RE: Review of 18 Daffodil 3.5.0 tickets

2023-04-18 Thread Interrante, John A (GE Research, US)
I looked at the tickets; I don't believe any of them affect our Daffodil usage right now. They can wait for 3.5.1 unless someone else speaks up. John -Original Message- From: Mike Beckerle Sent: Tuesday, April 18, 2023 2:54 PM To: dev@daffodil.apache.org Subject: EXT: Review of 18

RE: draft 2023 March quarterly daffodil board report

2023-03-05 Thread Interrante, John A (GE Research, US)
Quarterly report looks complete enough; can't think of what more needs to be added to the draft. Project Activity's last two sentences look a little funny to me since their subjects are software but their verbs are our PMC's actions. Here's a possible rewording (I also guessed at more precise

Checklist for configuring Scala projects

2023-03-02 Thread Interrante, John A (GE Research, US)
Interesting article from latest Scala Times newsletter about a checklist for new Scala projects. Checklist was reviewed by several Scala developers at SoftwareMill, so it's worth looking at although some of the items are a little SoftwareMill-centric. My takeaways are 1) configuration files

RE: 3.5.0 changes are breaking - should this be 4.0.0?

2023-02-28 Thread Interrante, John A (GE Research, US)
Has anyone written code outside of the Daffodil codebase which will be broken by any of the 3.5.0 changes? Is a Scala test file which uses the TDML runner to run one TDML test case affected by the minor change to the TDML runner? Do the package name changes break the compilation of Scala/Java

RE: Issues with runtime2 tests

2023-02-21 Thread Interrante, John A (GE Research, US)
Josh, Your stack trace's error message tells me that when you ran the ex_nums test case with TDMLImplementation.DaffodilC, the C-compiled executable exited abnormally with the numeric exit code 132 instead of the normal (successful) exit code 0. When a program dies because of a signal, its

How to run scalafmt manually

2023-02-14 Thread Interrante, John A (GE Research, US)
I wondered how to run scalafmt manually after merging Mike's scalafmt PR. I found out that I can run scalafmt from sbt using the scalafmt plugin's task keys: sbt:daffodil> scalafmtCheck [info] scalafmt: Checking 5 Scala sources (/home/interran/apache/daffodil-tuxji/daffodil-tdml-lib)... ...

RE: Re: Discussion about merging Runtime2DataProcessor.scala into Runtime2TDMLDFDLProcessor.scala

2023-02-07 Thread Interrante, John A (GE Research, US)
one trait, that is I'm not sure if you can implement it once and satisfy both traits. If that's a problem maybe DFDLProcesor needs to inherit from TDMLDFDLProcessor, so those signatures exist in exactly one trait? -mikeb On Mon, Feb 6, 2023 at 1:47 PM Interrante, John A (GE Research, US

Discussion about merging Runtime2DataProcessor.scala into Runtime2TDMLDFDLProcessor.scala

2023-02-06 Thread Interrante, John A (GE Research, US)
I want to merge Runtime2DataProcessor.scala into Runtime2TDMLDFDLProcessor.scala since doing so will reduce codegen-c's number of lines of code and number of classes. My experience writing a TDMLDFDProcessor for another code generator (not released yet) and writing unit tests for it has shown

Rename daffodil-runtime2 to daffodil-generator-c

2023-02-06 Thread Interrante, John A (GE Research, US)
ging the jar names. The jar names probably do always want to have the daffodil- prefix. For example, a jar named just "lib-XYZ.jar" instead of "daffodil-lib-XYZ.jar" could cause a lot of confusion otherwise. On 2023-02-03 08:11 PM, Interrante, John A (GE Research, US) wrote: >

Rename daffodil-runtime2 to daffodil-generator-c

2023-02-03 Thread Interrante, John A (GE Research, US)
l why we didn't. ) On Fri, Feb 3, 2023 at 5:31 PM Interrante, John A (GE Research, US) < john.interra...@ge.com> wrote: > Eventually Daffodil will support multiple code generators. I have > already sent a pull request to generalize Daffodil's CLI so we can > call "daffodil g

Rename daffodil-runtime2 to daffodil-generator-c

2023-02-03 Thread Interrante, John A (GE Research, US)
Eventually Daffodil will support multiple code generators. I have already sent a pull request to generalize Daffodil's CLI so we can call "daffodil generate " for additional languages. Now I want to discuss renaming daffodil-runtime2's module, package, and class names to new names that are

Scala state of union article

2023-01-27 Thread Interrante, John A (GE Research, US)
The latest Scala Times newsletter had a link to an "Scala state of union" article written by a long-time Scala user and CEO of a Scala ecosystem company. His message is that commercial companies, non-profits, and open source committers need to collaborate to make Scala 3 a natively

Enumeratum

2022-12-15 Thread Interrante, John A (GE Research, US)
Dec 11, 2022 at 9:42 AM Interrante, John A (GE Research, US) < john.interra...@ge.com> wrote: > The latest Scala Times newsletter mentioned an enumeration macro library. > I looked at its README and was impressed at how many integrations it > has, which also shows how large S

RE: Direct download links to releases?

2022-12-15 Thread Interrante, John A (GE Research, US)
+1 Using direct download links sounds better to me too. Both curl and wget have curl -o, --output file and wget -O, --output-document=file options to avoid needing to rename the file after downloading it. We can mention these options somewhere in the same places where we already mention that

Enumeratum

2022-12-11 Thread Interrante, John A (GE Research, US)
The latest Scala Times newsletter mentioned an enumeration macro library. I looked at its README and was impressed at how many integrations it has, which also shows how large Scala's ecosystem is. Not saying we should use it in Daffodil, just saying FYI, this is a library worth knowing about.

RE: What bug to fix? - Bug scrub for Daffodil 3.5.0 (and beyond)

2022-12-09 Thread Interrante, John A (GE Research, US)
I want to save time not having to point out or fix formatting issues during pull request reviews (I've had to spend time doing both). I would like someone to obtain a scalafmt configuration for the standard Scala code style, provide guidance how to configure IDE's that do autoformatting to use

Reason for not performing full validation with reloaded parser?

2022-12-09 Thread Interrante, John A (GE Research, US)
I got curious and searched the codebase and website, but I couldn't find an explanation why Daffodil lets you save and reload a parser, but restricts you from doing one thing with a restored parser that you can do with a normal parser. The only restriction Daffodil imposes is that you can't

RE: new daffodil module to reduce regression testing difficulties ?

2022-11-30 Thread Interrante, John A (GE Research, US)
I believe both Maven and SBT handle transitive dependencies similarly? My own build.sbt for schema projects has 4 dependencies, all of which are test-only dependencies: scalaVersion := "2.12.17" libraryDependencies ++= Seq( "com.github.sbt" % "junit-interface" % "0.13.3" % "test", "junit"

RE: [jira] [Commented] (DAFFODIL-2743) remove all deprecated methods/classes/objects

2022-11-18 Thread Interrante, John A (GE Research, US)
Steve, Mike, Shane, Should we hold off resolving DAFFODIL-2743 a little bit longer? I grep’ed “deprecated” in my daffodil source tree after pulling commit 11a11afc3f99fca8446cc5206f74446d6e825a33 and I found comments indicating we might want to change one or more places in Compiler.scala.

RE: [VOTE] Release Apache Daffodil 3.4.0-rc2

2022-11-04 Thread Interrante, John A (GE Research, US)
+1 (binding) [OK] verified signature of git tag [OK] verified hashes and signatures of 1 source and 1 helper binary [OK] verified signatures use key in KEYS with apache email address [OK] verified source has no unexpected binary files [OK] verified source and git tag are same minus KEYS file

RE: [VOTE] Release Apache Daffodil 3.4.0-rc1

2022-11-01 Thread Interrante, John A (GE Research, US)
-0 (need to discuss) I verified the following: [OK] verified signature of git tag [OK] verified hashes and signatures of source and helper binaries [OK] verified signatures use key in KEYS with apache email address [OK] verified source has no unexpected binary files [OK] verified source and git

RE: draft board report

2022-09-08 Thread Interrante, John A (GE Research, US)
Definitely mention that you plan to give a Daffodil talk at ApacheCon. Also, if new unreleased Daffodil features are worth mentioning at the level of the ASF board despite not being released yet, the additional support of EXI format for infosets may be worth mentioning. commit

RE: Re: [RESULT][VOTE] Release Apache Daffodil VS Code 1.1.0-rc2

2022-08-22 Thread Interrante, John A (GE Research, US)
Agreed. I think this vote went fine and Shane just needs to formally add his +1 and name to make it pass. -Original Message- From: Steve Lawrence Sent: Monday, August 22, 2022 11:24 AM To: dev@daffodil.apache.org Subject: EXT: Re: [RESULT][VOTE] Release Apache Daffodil VS Code

RE: Re: Daffodil Debugger Scala Source Code

2022-07-20 Thread Interrante, John A (GE Research, US)
The motivation for putting dap into the main daffodil repo is that bundling dap into the daffodil cli (allowing "daffodil dap" to start dap) will simplify configuring the VS Code debugger extension to work with different daffodil and dap versions. I suggest that there is almost certainly a

RE: the update treadmill - bot update implied work considered excessive

2022-07-18 Thread Interrante, John A (GE Research, US)
I have been ignoring bot PRs for daffodil-vscode because I am not interested in TypeScript/npm/VSCode extension programming, so I can't speak for anyone who has to review those bot PRs. Speaking only of the bot PRs for the daffodil Scala/Java codebase and a few other projects I maintain, I

RE: CLI -I sax feature - remove?

2022-07-11 Thread Interrante, John A (GE Research, US)
+1 from me. Sounds like the right way to go. -Original Message- From: Mike Beckerle Sent: Monday, July 11, 2022 3:19 PM To: dev@daffodil.apache.org Subject: EXT: CLI -I sax feature - remove? WARNING: This email originated from outside of GE. Please validate the sender's email address

RE: draft of Apache Daffodil Quarterly Board Report

2022-06-05 Thread Interrante, John A (GE Research, US)
Looks good. The only typos I notice are that some sentences are missing punctuation (a period). -Original Message- From: Mike Beckerle Sent: Friday, June 3, 2022 1:57 PM To: dev@daffodil.apache.org Subject: EXT: draft of Apache Daffodil Quarterly Board Report WARNING: This email

Scala 2.13, Scala 3 migration

2022-04-05 Thread Interrante, John A (GE Research, US)
To be sure, upgrading Daffodil from Scala 2.12 to Scala 2.13 is a prerequisite and that upgrade will be as much work as the upgrade from Scala 2.13 to Scala 3.x so we're talking about two major efforts, not just one. If Daffodil users are happy with Scala 2.12 and aren't requesting support for

RE: [VOTE] Release Apache Daffodil VS Code 1.0.0-rc3

2022-03-31 Thread Interrante, John A (GE Research, US)
+1 I checked that all libs used in both Apache Daffodil 3.3.0 and Apache Daffodil VS Code 1.0.0-rc3's daffodil-debugger-3.3.0 zip have the same versions now. As expected, both have some libs that the other doesn't use, too. I checked that the 1.0.0-rc3 .vsix file looks clean (my own .vsix

[RESULT][VOTE] Release Apache Daffodil 3.3.0-rc1

2022-03-21 Thread Interrante, John A (GE Research, US)
The VOTE to release Apache Daffodil 3.3.0-rc1 is now closed. The vote passes with: 6 binding +1 The VOTE thread: https://lists.apache.org/thread/yk32g06xk31ryd3k2rsnmc2lfvtj044c The vote breakdown is: +1 Mike Beckerle (binding) +1 Joshua Adams (binding) +1 Steve Lawrence (binding) +1

[VOTE] Release Apache Daffodil 3.3.0-rc1

2022-03-21 Thread Interrante, John A (GE Research, US)
CE information needs to be included. That said, considering these all Apache licenses with standard notices, I'm okay keeping my vote a +1, as long as we ensure they are added in the next release. On 3/21/22 12:47 PM, Interrante, John A (GE Research, US) wrote: > I downloaded the helper binaries

[VOTE] Release Apache Daffodil 3.3.0-rc1

2022-03-21 Thread Interrante, John A (GE Research, US)
ies? On 3/21/22 12:00 PM, Interrante, John A (GE Research, US) wrote: > +1 > > FYI, apache-daffodil-3.3.0-bin/lib has 6 new jars in it. Those new > jars are new transitive dependencies added by the bump of Saxon-HE > from 10.6 to 11.2. Their names are: > > commons-cod

RE: [VOTE] Release Apache Daffodil 3.3.0-rc1

2022-03-21 Thread Interrante, John A (GE Research, US)
] verified online JavaDoc and ScalaDoc docs look correct [OK] compiled source and ran all tests & ratCheck [OK] verified jars built from source have same content as helper binary jars John -Original Message- From: Interrante, John A (GE Research, US) Sent: Friday, March 18, 2022 9:07 AM To:

GPG signature verification warnings

2022-03-18 Thread Interrante, John A (GE Research, US)
Yes, it's either that or it's even simpler than that. I see the same warning when verifying Mike's signature: interran@GH3WPL13E:/u/Downloads$ gpg --verify apache-daffodil-3.2.1-src.zip.asc apache-daffodil-3.2.1-src.zip gpg: Signature made Mon Dec 20 09:18:16 2021 PST gpg:

[VOTE] Release Apache Daffodil 3.3.0-rc1

2022-03-18 Thread Interrante, John A (GE Research, US)
osed as "not a bug". I wouldn't normally list those. Ex: DAFFODIL-2618. On Fri, Mar 18, 2022 at 12:06 PM Interrante, John A (GE Research, US) < john.interra...@ge.com> wrote: > Hi PMC members, > > I'd like to call a vote to release Apache Daffodil 3.3.0-rc1. >

[DISCUSS] need to release Daffodil 3.3.0

2022-03-18 Thread Interrante, John A (GE Research, US)
;Text", the "Edit/Copy Release Notes" box at the bottom has something almost perfect for the website. Just needs a tweak to use the %jira macro. On 3/17/22 10:03 PM, Interrante, John A (GE Research, US) wrote: > I don't think I have enough permission to move issues in JIRA

[VOTE] Release Apache Daffodil 3.3.0-rc1

2022-03-18 Thread Interrante, John A (GE Research, US)
Hi PMC members, I'd like to call a vote to release Apache Daffodil 3.3.0-rc1. All distribution packages, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/daffodil/3.3.0-rc1/ Staging artifacts can be found at:

RE: [DISCUSS] need to release Daffodil 3.3.0

2022-03-17 Thread Interrante, John A (GE Research, US)
ers to {% jira %} format, and editing the category titles. John -----Original Message----- From: Interrante, John A (GE Research, US) Sent: Thursday, March 17, 2022 10:19 AM To: mbecke...@apache.org Cc: dev@daffodil.apache.org Subject: EXT: [DISCUSS] need to release Daffodil 3.3.0 Please review a

[DISCUSS] need to release Daffodil 3.3.0

2022-03-17 Thread Interrante, John A (GE Research, US)
l-site (github.com)<https://github.com/apache/daffodil-site/pull/82>. From: Mike Beckerle Sent: Thursday, March 17, 2022 6:54 AM To: Interrante, John A (GE Research, US) Cc: dev@daffodil.apache.org Subject: EXT: Re: [DISCUSS] need to release Daffodil 3.3.0 WARNING: This email originated

[DISCUSS] need to release Daffodil 3.3.0

2022-03-15 Thread Interrante, John A (GE Research, US)
ra/browse/DAFFODIL-2673 >> >> I am going to try to fix this in the next day, and if it proves to be >> harder than that, postpone it until post 3.3.0. >> >> >> >> On Fri, Mar 11, 2022 at 10:37 AM Steve Lawrence >> >> wrote: >> >>> Agreed.

[DISCUSS] need to release Daffodil 3.3.0

2022-03-10 Thread Interrante, John A (GE Research, US)
;big hammer" property or tunable that >>> > simply turns off alignment, as a workaround for all these sorts of >>> > alignment issues. I am wondering if we will need that so that >>> > users can work >>> around >>> > these alignment issues in their

Interesting reading: Effective Scala Case Class Patterns

2022-02-28 Thread Interrante, John A (GE Research, US)
The latest Scala Times newsletter included this link to an article called Effective Scala Case Patterns: Article: Effective Scala Case Class Patterns - The guide I wished I had read years ago when starting my Scala journey

RE: [DISCUSS] need to release Daffodil 3.3.0

2022-02-22 Thread Interrante, John A (GE Research, US)
+1 I personally have no blocker or urgent issues that must be fixed before the next release (only some things I will need to start working on in the C backend, "Runtime 2," to handle some more complicated schemas). How will the roadmap for upcoming releases

RE: [jira] [Commented] (DAFFODIL-567) lengthKind="endOfParent" for simpleTypes

2022-01-25 Thread Interrante, John A (GE Research, US)
I was just looking at this bug yesterday since I'd found it after reading that Daffodil doesn't implement endOfParent yet (https://daffodil.apache.org/unsupported/), which'd disappointed me since I'd wanted to use endOfParent in a complicated DFDL schema I'm trying to simplify enough for

RE: [VOTE] Release Apache Daffodil 3.2.1 (Urgent Patch Release) (RC2)

2021-12-20 Thread Interrante, John A (GE Research, US)
I'm on vacation, so I'm unable to check rc2 at this time. However, here's my +1 if no one else offers a third +1 since the only difference in rc2 should be a newer log4j jar than all the jars that were in rc1. John -Original Message- From: Mike Beckerle Sent: Monday, December 20,

RE: [VOTE] Release Apache Daffodil 3.2.1 (Urgent Patch Release)

2021-12-17 Thread Interrante, John A (GE Research, US)
+1 (binding) Tested on Ubuntu 20.04.3 with OpenJDK 11.0.13+8, SBT 1.5.7, gcc 9.3.0, libmxml-dev 3.1 John [OK] Downloaded both apache-daffodil-3.2.0-bin.zip and apache-daffodil-3.2.1-bin.zip [OK] Verified signatures against KEYS and signatures have Apache email addresses [OK] Unpacked and

RE: [DISCUSS] release 3.2.1 - was: Re: Need to create daffodil 3.2.1 ?

2021-12-15 Thread Interrante, John A (GE Research, US)
. On Wed, Dec 15, 2021 at 9:33 AM Interrante, John A (GE Research, US) wrote: > > I agree too. Let's do the normal release workflow, only calling the release > 3.2.1 instead of 3.3.0 because of how little time has passed since we > released 3.2.0. In that period of time (9 days), we'

Need to create daffodil 3.2.1 ?

2021-12-15 Thread Interrante, John A (GE Research, US)
I agree too. Let's do the normal release workflow, only calling the release 3.2.1 instead of 3.3.0 because of how little time has passed since we released 3.2.0. In that period of time (9 days), we've merged 10 pull requests: Update sbt to 1.5.7 #706 merged 9 minutes ago Update os-lib to

RE: draft of board report

2021-12-06 Thread Interrante, John A (GE Research, US)
Report is terse, but covers the important points. -Original Message- From: Mike Beckerle Sent: Monday, December 6, 2021 3:46 PM To: dev@daffodil.apache.org Subject: EXT: draft of board report WARNING: This email originated from outside of GE. Please validate the sender's email address

RE: [VOTE] Release Apache Daffodil 3.2.0-rc1

2021-12-06 Thread Interrante, John A (GE Research, US)
+1 (binding) Didn't have much time and others already did a lot of checking, but I checked: [OK] visited each link in email [OK] read Summary of Changes, looks good [OK] downloaded daffodil zip, runtime2 javadoc/sources/jar/pom [OK] no unexpected binaries in source [MINOR] inspected runtime2

RE: [VOTE] Release Apache Daffodil 3.2.0-rc1

2021-12-05 Thread Interrante, John A (GE Research, US)
Hi Brandon, I don't know what the first type of error is (SAX parse output not matching DataProcessor Parse output, ), ??bcde != ?bcde), but I know what the second type of error is (undefined reference to `mxmlNewOpaquef'). Your Linux Mint 19.1 system is based on Ubuntu 18.04 LTS and you're

RE: ICU upgrade

2021-11-24 Thread Interrante, John A (GE Research, US)
I believe DAFFODIL-2534 is now moot, but I'm not sure how to check. When I reviewed the auto-bump to the ICU library, I wrote: ``` +1 [ICU 70 release notes](https://icu.unicode.org/download/70) [ICU4J API Comparison: ICU4J 69.1 with ICU4J

RE: [DISCUSS] Are we ready to release 3.2.0 Daffodil ?

2021-11-01 Thread Interrante, John A (GE Research, US)
I checked the Daffodil JIRA to see how many blocker, critical, and major issues we have so far: Blocker issues: 0 Critical issues: 1 https://issues.apache.org/jira/browse/DAFFODIL-2400 - New SAX API causes performance degradations Major issues: 132

RE: Odd-even cycle for daffodil bug-fix and functional releases

2021-10-18 Thread Interrante, John A (GE Research, US)
I'm fine with staggering new features and bug fixes in even and odd point releases if that helps reduce the large JIRA issue count. We can plan to get the bug fix releases out more quickly (give them a deadline of, say, two months and then it's time for new features). -Original

RE: github issues vs. JIRA for VSCode Debugger - Fw: Apache JIRA vs. github "issues"

2021-09-23 Thread Interrante, John A (GE Research, US)
+1 for using GitHub issues in Apache's VSCode Debugger repo. -Original Message- From: Beckerle, Mike Sent: Thursday, September 23, 2021 10:30 AM To: dev@daffodil.apache.org Subject: EXT: github issues vs. JIRA for VSCode Debugger - Fw: Apache JIRA vs. github "issues" So, I inquired

Main development branch name change?

2021-09-02 Thread Interrante, John A (GE Research, US)
a bad merge or something) we can manually create a main off of asf/main, do the fix, then delete the local main. There's maybe some potential downsides of it not being very obvious what's been added to main during a fetch. - Steve On 9/2/21 3:39 PM, Interrante, John A (GE Research, US) wrot

Main development branch name change?

2021-09-02 Thread Interrante, John A (GE Research, US)
Steve, I'm fine with adding the Daffodil repos to the Conscious Language Checker scans (opt-in) since we've already done the work. I noticed your instructions for updating local checkouts of forked repos differ slightly from the instructions I see on GitHub after I rename my forked repo's

RE: Main development branch name change?

2021-08-30 Thread Interrante, John A (GE Research, US)
+1 It is easier to write/say aloud "the main branch" rather than "dev", "develop", or "development". -Original Message- From: Sood, Harinder Sent: Monday, August 30, 2021 7:44 AM To: dev@daffodil.apache.org Subject: EXT: Re: Main development branch name change? 1 vote for Main

RE: Please review: DFDL parity calculations also - was: Fw: Please review mock up idea for checksum calculations in DFDL

2021-08-10 Thread Interrante, John A (GE Research, US)
Mike, I'll take a look. When you say these pull requests aren't working yet, what are the missing parts? I know at a minimum you need to implement the following transform names: Do you plan to implement these transform names in Scala within the Daffodil codebase or as pluggable

RE: trying to rerun checks on PR - no option for it?

2021-07-30 Thread Interrante, John A (GE Research, US)
CI won't run when the PR has conflicts with the main branch. That's why the button isn't there. Darryl needs to rebase his PR, fix the conflict, and push his PR again with " git push --force-with-lease". From: Beckerle, Mike Sent: Friday, July 30, 2021 10:51 AM To: dev@daffodil.apache.org

How to list offset and length of DFDL elements within native data?

2021-07-01 Thread Interrante, John A (GE Research, US)
I've been asked a Daffodil / DFDL question that I don't know how to answer. The question is: How to implement a function like get_offset_len(data, schema, field_path) -> (offset, length) ? Do you know a good way (using Daffodil library functions or DFDL

RE: Squash last commit and newest commit

2021-06-28 Thread Interrante, John A (GE Research, US)
Correction, I had to do a git rebase -i HEAD~2 but the two commits are squashed together now. -Original Message- From: Interrante, John A (GE Research, US) Sent: Monday, June 28, 2021 3:38 PM To: dev@daffodil.apache.org Subject: EXT: RE: Squash last commit and newest commit I force

RE: Squash last commit and newest commit

2021-06-28 Thread Interrante, John A (GE Research, US)
the master branch and do a git rebase -i HEAD~ to squash them together, then do a force-push directly to the master branch. Just a few more minutes and then all should be done. -Original Message- From: Interrante, John A (GE Research, US) Sent: Monday, June 28, 2021 3:19 PM To: dev

Squash last commit and newest commit

2021-06-28 Thread Interrante, John A (GE Research, US)
The last (latest) commit on the master branch is still Bump sonarsource/sonarcloud-github-action from 1.5 to 1.6 * apache/daffodil@303cb5a which broke CI because it was missing one change. After I merge the new

RE: SonarCloud Code Smell Reduction?

2021-06-17 Thread Interrante, John A (GE Research, US)
Hello Helge, I looked at both commits [1] and pull requests [2]. I found no commits or pull requests that plausibly could explain the drop in code smells from March 26 to April 27 on the chart [3] you linked to. No one had mentioned doing anything to reduce SonarQube code smells on the dev

RE: ICU library version - was: IBM DFDL is upgrading ICU level

2021-05-19 Thread Interrante, John A (GE Research, US)
The fix to ICU's Java code changes only a single line and adds a new test case. But that single line was causing 400 test cases in IBM DFDL to fail because it'd made ICU's Java code behave differently than ICU's C code (ouch). The difference seems to be mostly rounding of real numbers, e.g.,

RE: 224 legacy Resolved Daffodil JIRA tickets

2021-05-19 Thread Interrante, John A (GE Research, US)
No one seems to have expressed an opinion, so I think it would be acceptable to close all those resolved tickets over two years old. :) John From: Thompson, Dave Sent: Tuesday, May 18, 2021 1:12 PM To: dev@daffodil.apache.org Subject: EXT: 224 legacy Resolved Daffodil JIRA tickets All, There

[VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-18 Thread Interrante, John A (GE Research, US)
More than 72 hours have passed and we're up to 5 +1's now with no 0's or -1's. When will the release come out? :-) John -Original Message- From: John Wass Sent: Tuesday, May 18, 2021 8:55 AM To: dev@daffodil.apache.org Subject: EXT: Re: [VOTE] Release Apache Daffodil 3.1.0-rc2 +1 I

RE: [VOTE] Release Apache Daffodil 3.1.0-rc2

2021-05-17 Thread Interrante, John A (GE Research, US)
+1 I checked (for most items, using WSL2/Ubuntu 20.04 on my laptop): [OK] rpm installs correctly on Fedora Workstation 34 [OK] some daffodil CLI commands work (generate c, test on runtime2 examples) [OK] signature of git tag is correct [OK] hash and signature of each download is correct [OK]

RE: [VOTE] Release Apache Daffodil 3.1.0-rc1

2021-05-12 Thread Interrante, John A (GE Research, US)
+1 I checked (for most items, using WSL2/Ubuntu 20.04 on my work laptop): [OK] rpm works on Fedora 24 (ran some daffodil CLI commands by hand) [OK] hash and signature of src.zip is correct [OK] signature of git tag is correct [OK] source release matches git tag (minus KEYS file) [OK] no

release 3.1.0 critical bugs still outstanding

2021-05-12 Thread Interrante, John A (GE Research, US)
a gpg key so that when it does come time to do a release, at least that part is out of the way. On 5/11/21 10:10 AM, Interrante, John A (GE Research, US) wrote: > Yes, we will be in good shape for the 3.1.0 release after we update the CLI > help information, which I'd like to complete today.

RE: release 3.1.0 critical bugs still outstanding

2021-05-11 Thread Interrante, John A (GE Research, US)
portant. Was a user-reported issue I believe. > > The 5th critical ticket is for a new feature (bitwise and/or/xor, and shift > functions), so we can postpone that one. > > So only DAFFODIL-2183 really needs someone to take it on. > > >

RE: draft may board report - due on 12th.

2021-05-03 Thread Interrante, John A (GE Research, US)
Report looks good. Are any of the 5 critical bugs (2 of which need developers to work on them) going to hold up the 3.1.0 release? The report doesn't say so, but I had the impression you'd added the remaining critical bugs (which were unlikely to be hit by people) to the 3.1.0 release notes

flakey windows CI build? Or real issue?

2021-04-27 Thread Interrante, John A (GE Research, US)
Once you drill down into and expand the "Run Unit Tests" log, GitHub lets you search that log with a magnifying lens icon and input search text box above the log. Searching for "failed:" makes it easier to find the specific failures. I found one failure and three warnings: [error] Test

codecov - annotation to suppress false positives?

2021-04-27 Thread Interrante, John A (GE Research, US)
I think you'd want "informational" mode, not "only_pulls". It looks like the latter might lose the information from merged commits: only_pulls Only post a status to pull requests, defaults to false. If true no status will be posted for commits not on a pull request. If code

RE: Forgot to squash commits

2021-04-21 Thread Interrante, John A (GE Research, US)
Yep. My pull request had no conflicts and I just merged it (after all the checks passed) without any problem. -Original Message- From: Beckerle, Mike Sent: Wednesday, April 21, 2021 4:34 PM To: dev@daffodil.apache.org Subject: EXT: Re: Forgot to squash commits I decided to

RE: Forgot to squash commits

2021-04-21 Thread Interrante, John A (GE Research, US)
My pull request (runtime2, #532) has been approved and I'm just waiting for the checks to finish before merging it. I'm not sure how a force push to the master branch would affect any outstanding pull requests. But I'm willing to wait for the force-push before merging my pull request if you

all this github spam ?

2021-04-21 Thread Interrante, John A (GE Research, US)
I've observed that typically only Daffodil committers who already have write access to the daffodil-site repo create pull requests to make changes to the website. We did get a drive-by contribution once from a developer outside the Daffodil community using a bot that offered to fix misspelled

editconfig

2021-04-19 Thread Interrante, John A (GE Research, US)
andard in all the projects I've been involved with; it's > > supported by > the > > language creators and matches the previously mentioned features. > > > > .. Adam > > > > [1] https://scalameta.org/scalafmt/ > > > > On Mon, Apr 19, 2021 at 8:2

RE: editconfig

2021-04-19 Thread Interrante, John A (GE Research, US)
I agree, an .editorconfig file at the root of daffodil coupled with IDE plugins (some IDEs such as IDEA already support .editorconfig without any plugin needed) could autoconfigure the following IDE settings automatically (if we felt we needed to specify all of these settings): root = true #

RE: [daffodil-site] branch asf-site updated: Publishing from 64abbf0df41a006a7a19d7daad29749b0a7dd6b5

2021-04-16 Thread Interrante, John A (GE Research, US)
@@ -155,8 +193,7 @@ and structuring our comments that way. DSOM "fixed" getter Note: If we change runtime1 to validate "fixed" values -like runtime2 does, then -we can close https://issues.apache.org/jira/browse/DAFFODIL-117;>DAFFODIL-117. +like runtime2 does, then we can resolve {% jira 117

Warning: Rebasing/squashing runtime2-2202 on April 15

2021-04-14 Thread Interrante, John A (GE Research, US)
Hi developers, I'm going to prepare a pull request to merge the runtime2-2202 branch into the master branch. In order to prepare that pull request, I need to squash all the commits on the runtime2-2202 branch, rebase the new commit on the latest changes in the master branch, and force-push

[Discuss] creating Release 3.1.0 and 96 JIRA tickets marked "Major" or higher

2021-04-12 Thread Interrante, John A (GE Research, US)
I found the list of open and in-progress issues sorted by priority (https://issues.apache.org/jira/issues/?jql=project%20%3D%20DAFFODIL%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC).

RE: XML String in Binary Data Question

2021-04-05 Thread Interrante, John A (GE Research, US)
I was waiting for someone to offer an opinion but it seems it's up to me. First of all, please write an actual test case of binary data with a well-formed piece of XML data inside a string. Please round trip it through Daffodil so we can actually find out how well both the parser and the

Rebased runtime2-2202 on asf/master

2021-03-30 Thread Interrante, John A (GE Research, US)
. If you have checked out the runtime2-2202 branch, you will need to update your checkout of the branch using "git pull --rebase" in order to get my rebased commits without any error messages. John -Original Message----- From: Interrante, John A (GE Research, US) Sent: Satur

Rebase runtime2-2202 on asf/master soon

2021-03-27 Thread Interrante, John A (GE Research, US)
I want to warn any Daffodil developer who has checked out the runtime2-2202 branch that I plan to rebase the runtime2-2202 branch on the latest asf/master branch and force-push the different commits to the runtime2-2202 branch. I will wait 72 hours (until Tuesday, March 30) to make sure no one

RE: Acceptance criteria for merging DFDL-to-C backend (runtime2-2202)?

2021-03-11 Thread Interrante, John A (GE Research, US)
. From: Interrante, John A (GE Research, US) Sent: Thursday, March 11, 2021 11:34 AM To: dev@daffodil.apache.org Subject: RE: Acceptance criteria for merging DFDL-to-C backend (runtime2-2202)? Is that all? :-). I would add some criteria testing runtime2's conformance

RE: Acceptance criteria for merging DFDL-to-C backend (runtime2-2202)?

2021-03-11 Thread Interrante, John A (GE Research, US)
ure that people working on other aspects of Daffodil will not be inadvertently breaking the C backend indetectably. That's one major concern I would have. ________ From: Interrante, John A (GE Research, US) Sent: Wednesday, March 10, 2021 4:24 PM To: dev@daffodil.apache.org Subje

Acceptance criteria for merging DFDL-to-C backend (runtime2-2202)?

2021-03-10 Thread Interrante, John A (GE Research, US)
Thanks to Mike's suggestion, I have moved the Runtime2 ToDos (changes requested by reviewers) from the DAFFODIL-2202 issue to an AsciiDoc document in the dev/design-notes subtree of the Daffodil website which you can read here:

RE: Scala Steward for dependency updates?

2021-03-04 Thread Interrante, John A (GE Research, US)
P.S. I've been meaning to pass along another useful Scala ecosystem article I read recently [1]. Library writers are being asked to define a `ThisBuild / versionScheme` setting to declare a library's semantic versioning scheme (like Daffodil's in our case) so that sbt can issue more reliable

RE: Scala Steward for dependency updates?

2021-03-04 Thread Interrante, John A (GE Research, US)
I like the idea of using the Scala Stewart bot to keep Daffodil's library dependencies and sbt plugins up-to-date very much. In fact, I noticed two more benefits you didn't mention due to a significant part of the Scala ecosystem already using the Scala Stewart bot: [1]

runtime2: how to find "fixed" attribute in compiled schema objects?

2021-02-16 Thread Interrante, John A (GE Research, US)
or the fixed attribute would add new properties to the DSOM, which would then make it available in the Grammar and runtimes. On 2/15/21 4:23 PM, Interrante, John A (GE Research, US) wrote: > I have a question for more experienced Daffodil maintainers.

runtime2: how to find "fixed" attribute in compiled schema objects?

2021-02-15 Thread Interrante, John A (GE Research, US)
I have a question for more experienced Daffodil maintainers. Suppose a schema contains some fixed="constant" attributes: If a TDML test suite turns on validation="on", Daffodil runtime1 will call Xerces to perform validation on an XML

avoiding redundant comment and commit messages

2021-02-03 Thread Interrante, John A (GE Research, US)
I'm receiving both GitHub and GitBox notifications and I have a caveat about relying only on GitBox notifications besides missing comments in the "Review Changes" box. The GitBox notifications seem to be sent out in batches considerably later (sometimes hours later) than the GitHub

RE: [VOTE] Contributors - Graduate Apache Daffodil (Incubating) to a top-level project

2021-01-29 Thread Interrante, John A (GE Research, US)
+1 Congratulations on starting the graduation process! John -Original Message- From: Mike Beckerle Sent: Thursday, January 28, 2021 6:09 PM To: dev@daffodil.apache.org Subject: EXT: [VOTE] Contributors - Graduate Apache Daffodil (Incubating) to a top-level project One of the first

RE: Generating WarnIdGen.scala

2021-01-11 Thread Interrante, John A (GE Research, US)
The file you need to edit is: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd All other occurrences are simply copies of this file made during the sbt build process: daffodil-lib/resource_managed/main/org/apache/daffodil/xsd/dafext.xsd

RE: rfc: sbt-tdml

2021-01-09 Thread Interrante, John A (GE Research, US)
I like the idea of removing the Scala TDML test boilerplate as much as possible. Does your sbt plugin handle the use case where some Scala test files define customized or multiple TDML runners in the same file? For example, see

RE: thoughts on runtime2-2202

2020-12-01 Thread Interrante, John A (GE Research, US)
My thoughts: Currently we keep the C source files in daffodil-runtime2/src/main/resources/c. I'm fine with us keeping the c directory while splitting and moving the C source files into two new subdirectories called "libruntime2" and "libruntime2cli". I want to keep the "c" directory because

RE: Rebasing runtime2-2202 on asf/master

2020-11-30 Thread Interrante, John A (GE Research, US)
still remain open and GitHub should do the right thing, although ideally those PRs would be merged before the rebase to avoid any potential issues. John -Original Message- From: Interrante, John A (GE Research, US) Sent: Monday, November 23, 2020 7:15 PM To: dev@daffodil.apache.org S

RE: Rebasing runtime2-2202 on asf/master

2020-11-23 Thread Interrante, John A (GE Research, US)
t runtime2-2202 then git pull asf master. There are like 5 conflicting files, but looks pretty manageable. I am looking forward to working on runtime2 more soon. ________ From: Interrante, John A (GE Research, US) Sent: Monday, November 23, 2020 10:56:32 AM To: dev@da

  1   2   >