Re: [VOTE] Release Apache Daffodil (Incubating) 2.1.0-rc1

[Dave Fisher]

Hi John,

I am too. I think Roy Fielding is there as well. It will be good for Legal to 
be definitive so that we can put the question to rest.

Regards,
Dave

> On Feb 12, 2018, at 4:14 PM, John D. Ament  wrote:
> 
> Heh, and I just commented on DAFFODIL-1900.  I tend to be on the opposite
> side of the boat, leaning towards not needing headers.  At the end of the
> day, I don't care.  Whatever route you guys want to go is fine.
> 
> Agreed on all other points.
> 
> John
> 
> On Mon, Feb 12, 2018 at 5:24 PM Steve Lawrence  wrote:
> 
>> Thanks for the review!
>> 
>> 1a) I've created LEGAL-369 to get guidance on the OGF document.
>> 
>> 1b) I've created DAFFODIL-1899 to fix the LICENSE/NOTICE issues.
>> 
>> 2a) The current version of rat 0.12 when run from the command line says
>> the excluded files are "Files with unapproved licenses". It does not
>> seem to detect them as non-Apache but permissible. Perhaps the licenses
>> aren't included in a way RAT can detect. Will investigate this issue.
>> 
>> 2b) I've created DAFFODIL-1900 for this, but have assigned it to our
>> next release to investigate best how to handle this.
>> 
>> Thanks,
>> - Steve
>> 
>> 
>> On 02/12/2018 03:46 PM, Dave Fisher wrote:
>>> Hi -
>>> 
>>> A few quick comments from a partial review of the Source and Binary
>> release.
>>> 
>>> (1) LICENSE & NOTICE.
>>> 
>>> (a) The copyright portions that are in the LICENSE on the various
>> licenses
>>> should be moved to the NOTICE. The LICENSE should still include which
>> files are
>>> under the other licenses.
>>> 
>>> (b) The Open Grid Forum DFDL v1.0 license needs to be confirmed as
>> permissible
>>> by the Legal Affairs committee. This should include guidance about
>> NOTICE vs.
>>> LICENSE. Legal JIRA issues can be created in the issue tracker.
>>> https://issues.apache.org/jira/projects/LEGAL
>>> 
>>> (2) .rat-excludes
>>> 
>>> (a) The following should not be excluded. RAT should pick up the
>> licenses as
>>> category A if they are present.
>>> # passera is 3-clause BSD
>>> passera
>>> 
>>> # copyright Scala BSD license
>>> Utility.scala
>>> UniquenessCache.scala
>>> 
>>> # copyright w3c with permissive license
>>> XMLSchema.dtd
>>> XMLSchema.xsd
>>> XMLSchema_for_DFDL.xsd
>>> datatypes.dtd
>>> xml.xsd
>>> 
>>> (b) Test files.
>>> 
>>> For the future, but not now. There have been debates in other projects.
>> Guidance
>>> from some on legal-discuss@ has been to include license headers in test
>> files
>>> and then have the test tooling eliminate the license so that tests do
>> not have
>>> to take it into account or be rewritten.
>>> 
>>> Regards,
>>> Dave
>>> 
 On Feb 12, 2018, at 11:24 AM, Steve Lawrence > wrote:
 
 I believe we have now resolved all issues raised so far in 2.1.0-rc1.
 The name changes in dist/dev/daffodil will go into effect for the rc2
 release files.
 
 John or Dave, have either of you had a chance to review the release any
 further? We'd definitely like to incorporate any of your feedback before
 we create an rc2 release.
 
 Thanks,
 - Steve
 
 On 02/08/2018 01:24 PM, John D. Ament wrote:
> Well, before starting a new let's review the existing.  I would like a
>> bit
> of time to review the whole release archive.
> 
> What you mentioned is correct, effectively anything on the /dist/dev
>> should
> comply with the package naming scheme.  You should consider whether or
>> not
> you want to put everything on /dist/dev (we tend to recommend only the
> source release goes there, to avoid confusion).  When projects do stage
> other artifacts there, they should all be named the same way.
> 
> I have a long standing disagreement with many IPMC members.  I tend to
> follow the release requirements very closely and push back on an over
> assumption of the requirements.  Most projects implement the
>> -incubating
> suffix as a part of the version #, but that's not required.  So my
> interpretation is that maven distributions do not need to include
> -incubating.  We have set this precedent before with Apache Groovy
>> where
> only the source release was staged and voted upon, the actual maven
>> central
> distribution omitted the -incubating and I'm in full support of that
> approach.
> 
> John
> 
> On Thu, Feb 8, 2018 at 12:58 PM Steve Lawrence  > wrote:
> 
>> Multiple issues have been found with this release, so I am officially
>> canceling this vote. We would still ask for continued review of the
>> 2.1.0-rc1 release so that any issues found can be fixed in the
>> 2.1.0-rc2
>> release.
>> 
>> Thanks,
>> - Steve
>> 
>> On 02/08/2018 11:30 AM, Steve Lawrence wrote:
>>> Hi all,
>>> 
>>> I'd like to call a vote to release 

[jira] [Commented] (DAFFODIL-1900) Test files should include licenses, TDMLRunner should strip before tests

[John D. Ament (JIRA)]

[ 
https://issues.apache.org/jira/browse/DAFFODIL-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361622#comment-16361622
 ] 

John D. Ament commented on DAFFODIL-1900:
-

We generally allow test data files to skip license headers, since they tend to 
not work with license headers present.  You should consider that when deciding 
if you need to add these headers.

> Test files should include licenses, TDMLRunner should strip before tests
> 
>
> Key: DAFFODIL-1900
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1900
> Project: Daffodil
>  Issue Type: Bug
>  Components: TDML Runner
>Reporter: Steve Lawrence
>Priority: Major
> Fix For: 2.2.0
>
>
> Ideally separate test files, both inputs and expected outputs, would contain 
> the Apache license. In general, include an apache license header in the files 
> would causes tests to fail since the header is not expected. One potential 
> solution to this is to modify the TDML Runner so that if a file begins with 
> an apache license header then the header is stripped off before use. This 
> does add some difficulties (e.g. manual tests require removing the license 
> header, etc.) so care should be taken to make this work without getting in 
> the way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (DAFFODIL-1900) Test files should include licenses, TDMLRunner should strip before tests

[Steve Lawrence (JIRA)]

Steve Lawrence created DAFFODIL-1900:


 Summary: Test files should include licenses, TDMLRunner should 
strip before tests
 Key: DAFFODIL-1900
 URL: https://issues.apache.org/jira/browse/DAFFODIL-1900
 Project: Daffodil
  Issue Type: Bug
  Components: TDML Runner
Reporter: Steve Lawrence
 Fix For: 2.2.0


Ideally separate test files, both inputs and expected outputs, would contain 
the Apache license. In general, include an apache license header in the files 
would causes tests to fail since the header is not expected. One potential 
solution to this is to modify the TDML Runner so that if a file begins with an 
apache license header then the header is stripped off before use. This does add 
some difficulties (e.g. manual tests require removing the license header, etc.) 
so care should be taken to make this work without getting in the way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (DAFFODIL-1899) Fix NOTICE and LICENSE files

[Steve Lawrence (JIRA)]

Steve Lawrence created DAFFODIL-1899:


 Summary: Fix NOTICE and LICENSE files
 Key: DAFFODIL-1899
 URL: https://issues.apache.org/jira/browse/DAFFODIL-1899
 Project: Daffodil
  Issue Type: Bug
  Components: Infrastructure
Reporter: Steve Lawrence
Assignee: Steve Lawrence
 Fix For: 2.1.0


The copyright portions that are in the LICENSE on the various licenses should 
be moved to the NOTICE. The LICENSE should still include which files are under 
the other licenses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Daffodil (Incubating) 2.1.0-rc1

[Dave Fisher]

Hi -

A few quick comments from a partial review of the Source and Binary release.

(1) LICENSE & NOTICE.

(a) The copyright portions that are in the LICENSE on the various licenses 
should be moved to the NOTICE. The LICENSE should still include which files are 
under the other licenses.

(b) The Open Grid Forum DFDL v1.0 license needs to be confirmed as permissible 
by the Legal Affairs committee. This should include guidance about NOTICE vs. 
LICENSE. Legal JIRA issues can be created in the issue tracker. 
https://issues.apache.org/jira/projects/LEGAL

(2) .rat-excludes

(a) The following should not be excluded. RAT should pick up the licenses as 
category A if they are present.
# passera is 3-clause BSD
passera

# copyright Scala BSD license
Utility.scala
UniquenessCache.scala

# copyright w3c with permissive license
XMLSchema.dtd
XMLSchema.xsd
XMLSchema_for_DFDL.xsd
datatypes.dtd
xml.xsd

(b) Test files.

For the future, but not now. There have been debates in other projects. 
Guidance from some on legal-discuss@ has been to include license headers in 
test files and then have the test tooling eliminate the license so that tests 
do not have to take it into account or be rewritten.

Regards,
Dave

> On Feb 12, 2018, at 11:24 AM, Steve Lawrence  wrote:
> 
> I believe we have now resolved all issues raised so far in 2.1.0-rc1.
> The name changes in dist/dev/daffodil will go into effect for the rc2
> release files.
> 
> John or Dave, have either of you had a chance to review the release any
> further? We'd definitely like to incorporate any of your feedback before
> we create an rc2 release.
> 
> Thanks,
> - Steve
> 
> On 02/08/2018 01:24 PM, John D. Ament wrote:
>> Well, before starting a new let's review the existing.  I would like a bit
>> of time to review the whole release archive.
>> 
>> What you mentioned is correct, effectively anything on the /dist/dev should
>> comply with the package naming scheme.  You should consider whether or not
>> you want to put everything on /dist/dev (we tend to recommend only the
>> source release goes there, to avoid confusion).  When projects do stage
>> other artifacts there, they should all be named the same way.
>> 
>> I have a long standing disagreement with many IPMC members.  I tend to
>> follow the release requirements very closely and push back on an over
>> assumption of the requirements.  Most projects implement the -incubating
>> suffix as a part of the version #, but that's not required.  So my
>> interpretation is that maven distributions do not need to include
>> -incubating.  We have set this precedent before with Apache Groovy where
>> only the source release was staged and voted upon, the actual maven central
>> distribution omitted the -incubating and I'm in full support of that
>> approach.
>> 
>> John
>> 
>> On Thu, Feb 8, 2018 at 12:58 PM Steve Lawrence  wrote:
>> 
>>> Multiple issues have been found with this release, so I am officially
>>> canceling this vote. We would still ask for continued review of the
>>> 2.1.0-rc1 release so that any issues found can be fixed in the 2.1.0-rc2
>>> release.
>>> 
>>> Thanks,
>>> - Steve
>>> 
>>> On 02/08/2018 11:30 AM, Steve Lawrence wrote:
 Hi all,
 
 I'd like to call a vote to release Apache Daffodil (Incubating)
>>> 2.1.0-rc1.
 
 All distribution packages, including signatures, digests, etc. can be
 found at:
 
 https://dist.apache.org/repos/dist/dev/incubator/daffodil/2.1.0-rc1/
 
 Staging artifacts can be found at:
 
 
>>> https://repository.apache.org/content/repositories/orgapachedaffodil-1000/
 
 This release has been signed with PGP key 033AE661, corresponding to
 slawre...@apache.org, which is included in the repository's KEYS file.
 This key can be found on keyservers, such as:
 
 http://pgp.mit.edu/pks/lookup?op=get=0x033AE661
 
 It is also listed here:
 
 https://people.apache.org/keys/committer/slawrence.asc
 
 The release candidate has been tagged in git with v2.1.0-rc1.
 
 For reference, here is a list of all closed JIRAs tagged with 2.1.0:
 
 
>>> https://issues.apache.org/jira/browse/DAFFODIL-1864?jql=project%20%3D%20DAFFODIL%20AND%20fixVersion%20%3D%202.1.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
 
 For a summary of the changes in this release, see:
 
 https://daffodil.apache.org/releases/2.1.0/
 
 Please review and vote. The vote will be open for at least 72 hours
 (ends on Sunday, 11 February 2018, 12 Noon EST).
 
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove (and reason why)
 
 My vote: +1
 
 Thanks,
 - Steve
 
>>> 
>>> 
>> 
> 



signature.asc
Description: Message signed with OpenPGP

[jira] [Resolved] (DAFFODIL-1895) Eclipse classpath for daffodil-core needs fix

[Michael Beckerle (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DAFFODIL-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Beckerle resolved DAFFODIL-1895.

Resolution: Fixed
  Assignee: Dave Thompson  (was: Michael Beckerle)

Fixed in 5fd83a46f05c1a90b2939c432aa556a744a63ced


> Eclipse classpath for daffodil-core needs fix
> -
>
> Key: DAFFODIL-1895
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1895
> Project: Daffodil
>  Issue Type: Bug
>  Components: Infrastructure
>Affects Versions: 2.1.0
>Reporter: Michael Beckerle
>Assignee: Dave Thompson
>Priority: Major
> Fix For: 2.1.0
>
>
> Need to remove src/main/resources, as that directory no longer exists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (DAFFODIL-1884) Regression in bitOrder changing

[Michael Beckerle (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DAFFODIL-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Beckerle resolved DAFFODIL-1884.

Resolution: Fixed
  Assignee: Dave Thompson  (was: Michael Beckerle)

Fixed in ac39c932e53cef4ec3361d04b93fd998db0864ef

> Regression in bitOrder changing
> ---
>
> Key: DAFFODIL-1884
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1884
> Project: Daffodil
>  Issue Type: Bug
>  Components: Back End
>Affects Versions: 2.1.0
>Reporter: Steve Lawrence
>Assignee: Dave Thompson
>Priority: Major
> Fix For: 2.1.0
>
>
> test_bitOrderOVC1 in 
> ./daffodil-test/src/test/scala-new/edu/illinois/ncsa/daffodil/section00/general/TestUnparserGeneral2.scala
>  currently fails. It appears to be a regression with recent changes to how 
> bitOrder works, but was not discovered because the test is in scala-new. This 
> test should be fixed and moved into the scala directory since the scala-new 
> directory is no longer used and ignored.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] mbeckerle closed pull request #37: Fix bitOrder bug detected by Link16 schema.

[GitBox]

mbeckerle closed pull request #37: Fix bitOrder bug detected by Link16 schema.
URL: https://github.com/apache/incubator-daffodil/pull/37
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/FramingUnparsers.scala
 
b/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/FramingUnparsers.scala
index 41b695540..19b5df45d 100644
--- 
a/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/FramingUnparsers.scala
+++ 
b/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/FramingUnparsers.scala
@@ -25,7 +25,7 @@ import org.apache.daffodil.processors.TermRuntimeData
 class SkipRegionUnparser(
   skipInBits: Int,
   override val context: TermRuntimeData)
-  extends PrimUnparser {
+  extends AlignmentPrimUnparser {
 
   override def runtimeDependencies = Nil
 
@@ -65,7 +65,7 @@ class AlignmentFillUnparserSuspendableOperation(
 class AlignmentFillUnparser(
   alignmentInBits: Int,
   override val context: TermRuntimeData)
-  extends PrimUnparser
+  extends AlignmentPrimUnparser
   with SuspendableUnparser {
 
   override def runtimeDependencies = Nil
diff --git 
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/Unparser.scala
 
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/Unparser.scala
index db623fe78..9442a67e2 100644
--- 
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/Unparser.scala
+++ 
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/Unparser.scala
@@ -41,33 +41,36 @@ sealed trait Unparser
 val savedProc = ustate.maybeProcessor
 ustate.setProcessor(this)
 
-//
-// Since the state is being overwritten (in most case) now,
-// we must explicitly make a copy when debugging so we can compute a delta
-// after
-//
 // ?? TODO: Should this be after the split below ??
 if (ustate.dataProc.isDefined) ustate.dataProc.get.before(ustate, this)
-try {
-  unparse(ustate)
 
-  // TODO: Remove this call to ustate.bitOrder below.
-  // Figure out where this is needed elsewhere in unparser code.
-  //
-  // Clearly calling this here is overkilling the problem.
-  //
-  // In theory some places in the unparser code dealing with 
splitting/suspending
-  // or outputValueCalc elemetns are missing proper checking of bitOrder, 
or
-  // keeping track of prior bit order. Finding those has been problematic. 
-  //
-  // So this is a temporary fix, until we can figure out where else to do 
this.
-  //
-  this.context match {
-case trd: TermRuntimeData => 
-  ustate.bitOrder // asking for bitOrder checks bit order changes.
+// TODO: Remove this call to ustate.bitOrder below.
+// Figure out where this is needed elsewhere in unparser code.
+//
+// Clearly calling this here is overkilling the problem.
+//
+// In theory some places in the unparser code dealing with 
splitting/suspending
+// or outputValueCalc elements are missing proper checking of bitOrder, or
+// keeping track of prior bit order. Finding those has been problematic.
+//
+// So this is a temporary fix, until we can figure out where else to do 
this.
+//
+this match {
+  // bit order only applies to primitives, not combinators, nor "noData" 
unparsers.
+  case af: AlignmentPrimUnparser => // ok. Don't check bitOrder before 
Aligning.
+  case u: PrimUnparser => {
+u.context match {
+  case trd: TermRuntimeData =>
+ustate.bitOrder // asking for bitOrder checks bit order changes.
   // this splits DOS on bitOrder changes if absoluteBitPos not known
-case _ => //ok
+  case rd: RuntimeData => Assert.invariantFailed("Primitive unparser " 
+ u + " has non-Term runtime data: " + rd)
+}
   }
+  case _ => // ok
+}
+try {
+  unparse(ustate)
+
 } finally {
   ustate.resetFormatInfoCaches()
 }
@@ -95,6 +98,17 @@ trait PrimUnparser
   extends Unparser
   with PrimProcessor
 
+/**
+ * A marker trait for the unparsers that perform alignment.
+ *
+ * Needed to distinguish alignment operations from regular primitives so that
+ * we can inspect for bitOrder changes on most primitives, but not
+ * alignments - since their purpose may be to align so that the bitOrder change
+ * is on the right boundary. Checking bit order before them defeats the purpose
+ * of alignment.
+ */
+trait AlignmentPrimUnparser extends PrimUnparser
+
 /**
  * An unparser that is primitive (no sub-unparsers), but doesn't write anything
  * to a data 

[GitHub] mbeckerle closed pull request #35: Remove src/main/resources from daffodil-core classpath.

[GitBox]

mbeckerle closed pull request #35: Remove src/main/resources from daffodil-core 
classpath.
URL: https://github.com/apache/incubator-daffodil/pull/35
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/eclipse-projects/core/.classpath b/eclipse-projects/core/.classpath
index e3656528a..b469a2e2e 100644
--- a/eclipse-projects/core/.classpath
+++ b/eclipse-projects/core/.classpath
@@ -1,6 +1,6 @@
 
 
-

[GitHub] stevedlawrence closed pull request #36: Change names of zip/tar/rpm binary artifacts

[GitBox]

stevedlawrence closed pull request #36: Change names of zip/tar/rpm binary 
artifacts
URL: https://github.com/apache/incubator-daffodil/pull/36
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/daffodil-cli/build.sbt b/daffodil-cli/build.sbt
index c855c8827..089445180 100644
--- a/daffodil-cli/build.sbt
+++ b/daffodil-cli/build.sbt
@@ -25,11 +25,11 @@ enablePlugins(RpmPlugin)
 
 executableScriptName := "daffodil"
 
-packageName in Universal := "daffodil-" + version.value + "-bin" //tarball name
+packageName in Universal := "apache-daffodil-" + version.value + 
"-incubating-bin" //tarball name
 
 packageName in Linux := executableScriptName.value
 
-packageName in Rpm := executableScriptName.value
+packageName in Rpm := "apache-" + executableScriptName.value
 
 mappings in Universal ++= Seq(
   baseDirectory.value / "LICENSE" -> "LICENSE",
@@ -59,11 +59,12 @@ and validation.
 
 version in Rpm := {
   val parts = version.value.split("-", 2)
-  parts(0) // removes snapshot/beta/rc/etc, that should only be in the 
rpmRelease
+  val ver = parts(0) // removes snapshot if it exists
+  ver + ".incubating"
 }
 
 rpmRelease := {
-  val parts = version.value.split("-", 2) // parts(0) is the version, parse(1) 
is snapshot/beta/rc/etc if it exists
+  val parts = version.value.split("-", 2) // parts(0) is the version, parse(1) 
is snapshot if it exists
   if (parts.length > 1) "0." + parts(1).toLowerCase else "1"
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] stevedlawrence closed pull request #39: Fix typo in url to website

[GitBox]

stevedlawrence closed pull request #39: Fix typo in url to website
URL: https://github.com/apache/incubator-daffodil/pull/39
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala 
b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
index e36de2868..a5f9078ed 100644
--- a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
+++ b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
@@ -461,7 +461,7 @@ class DataProcessor private[japi] (dp: SDataProcessor)
   /**
* Read external variables from a Daffodil configuration file
*
-   * @see Daffodil Configuration 
File - Daffodil configuration file format
+   * @see Daffodil Configuration 
File - Daffodil configuration file format
*
* @param extVars file to read DFDL variables from.
*/


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (DAFFODIL-1890) Update user related links from the wiki to daffodil.apache.org

[Steve Lawrence (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DAFFODIL-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Lawrence updated DAFFODIL-1890:
-
Component/s: Infrastructure

> Update user related links from the wiki to daffodil.apache.org
> --
>
> Key: DAFFODIL-1890
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1890
> Project: Daffodil
>  Issue Type: Bug
>  Components: Infrastructure
>Reporter: Steve Lawrence
>Assignee: Steve Lawrence
>Priority: Major
> Fix For: 2.1.0
>
>
> User related documentation has been moved from the wiki to 
> daffodil.apache.org. Those pages should be removed from the wiki, so links 
> should be updated to reference the daffodil.apache.org pages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (DAFFODIL-1890) Update user related links from the wiki to daffodil.apache.org

[Dave Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DAFFODIL-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Thompson reassigned DAFFODIL-1890:
---

Assignee: Steve Lawrence  (was: Dave Thompson)

> Update user related links from the wiki to daffodil.apache.org
> --
>
> Key: DAFFODIL-1890
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1890
> Project: Daffodil
>  Issue Type: Bug
>Reporter: Steve Lawrence
>Assignee: Steve Lawrence
>Priority: Major
> Fix For: 2.1.0
>
>
> User related documentation has been moved from the wiki to 
> daffodil.apache.org. Those pages should be removed from the wiki, so links 
> should be updated to reference the daffodil.apache.org pages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (DAFFODIL-1897) Some Schemas fail to compile with latest updates (v2.1.0-rc1)

[Steve Lawrence (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DAFFODIL-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Lawrence resolved DAFFODIL-1897.
--
Resolution: Fixed
  Assignee: Dave Thompson  (was: Steve Lawrence)

Fixed in commit 7fac84af9e9c27f3a9959bb17f86c9f05f18d728

> Some Schemas fail to compile with latest updates (v2.1.0-rc1)
> -
>
> Key: DAFFODIL-1897
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1897
> Project: Daffodil
>  Issue Type: Bug
>  Components: DFDL Schemas
>Affects Versions: 2.1.0
>Reporter: Dave Thompson
>Assignee: Dave Thompson
>Priority: Blocker
> Fix For: 2.1.0
>
>
> Attempted to execute the nightly test suite on incubator-daffodil commit 
> add8c5a6f82f25073475a4d6c7ae94fb5ca6e01a.
> Four dfdl schemas failed to compile for the following formats: army-drrs,  
> ato-rep, csvMixedNarrow and pcap.
> The command and error are provided below.
> Attempting to save parser for army-drrs.
> Test name is: army-drrs_10t_all_1000
> CMD: 
> /home/dfdl/incubator-daffodil/daffodil-cli/target/universal/stage/bin/daffodil
>  -v save-parser -s 
> /home/dfdl/ngf-dfdl/daffodil-perf/src/test/resources/edu/illinois/ncsa/daffodil/fouo_disa/army_drrs_lh/army_drrs_lh.dfdl.xsd
>  > /home/dfdl/dfdl-testharness/saved_parsers/0.0.0/army-drrs.parser.bin
> process return code: 1
> Failed to Save Parser - army-drrs
> Error: [error] Schema Definition Error: No schema document at location 
> file:/home/dfdl/ngf-dfdl/daffodil-perf/src/test/resources/org/apache/daffodil/fouo_disa/army_drrs_lh/army_drrs_lh.dfdl.xsd.
> Schema context: Import Location in file:unknown
> [warning] Schema Definition Warning: schemaLocation property uses deprecated 
> edu/illinois/ncsa/daffodil path instead of org/apache/daffodil. Converting to 
> new path.
> Schema context: Import Location in file:unknown
> [info] Time (compiling): 219ms
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] stevedlawrence closed pull request #38: Move built-in-formats.xsd to test and the backwards compatibility added for it

[GitBox]

stevedlawrence closed pull request #38: Move built-in-formats.xsd to test and 
the backwards compatibility added for it
URL: https://github.com/apache/incubator-daffodil/pull/38
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build.sbt b/build.sbt
index d61bf9079..76826948f 100644
--- a/build.sbt
+++ b/build.sbt
@@ -54,11 +54,11 @@ lazy val core = Project("daffodil-core", 
file("daffodil-core")).conf
   .settings(commonSettings)
 
 lazy val japi = Project("daffodil-japi", 
file("daffodil-japi")).configs(TestDebug)
-  .dependsOn(core)
+  .dependsOn(core, core % "test->test")
   .settings(commonSettings)
 
 lazy val sapi = Project("daffodil-sapi", 
file("daffodil-sapi")).configs(TestDebug)
-  .dependsOn(core)
+  .dependsOn(core, core % "test->test")
   .settings(commonSettings)
 
 lazy val tdml = Project("daffodil-tdml", 
file("daffodil-tdml")).configs(TestDebug)
@@ -75,11 +75,11 @@ lazy val test = Project("daffodil-test", 
file("daffodil-test")).conf
   .settings(commonSettings, nopublish)
 
 lazy val testIBM1 = Project("daffodil-test-ibm1", 
file("daffodil-test-ibm1")).configs(TestDebug)
-  .dependsOn(tdml)
+  .dependsOn(tdml, core % "test->test")
   .settings(commonSettings, nopublish)
 
 lazy val tutorials= Project("daffodil-tutorials", 
file("tutorials")).configs(TestDebug)
-  .dependsOn(tdml)
+  .dependsOn(tdml, core % "test->test")
   .settings(commonSettings, nopublish)
 
 lazy val testStdLayout= Project("daffodil-test-stdLayout", 
file("test-stdLayout")).configs(TestDebug)
diff --git a/daffodil-cli/src/test/resources/clitests.tdml 
b/daffodil-cli/src/test/resources/clitests.tdml
deleted file mode 100644
index 81fcb074d..0
--- a/daffodil-cli/src/test/resources/clitests.tdml
+++ /dev/null
@@ -1,35 +0,0 @@
-
-
-
-http://www.ibm.com/xmlns/dfdl/testData; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
-  xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/; 
xmlns:tdml="http://www.ibm.com/xmlns/dfdl/testData;>
-
-
-  
-
-  org/apache/daffodil/CLI/input/input5.txt
-
-
-  
-HAT400
-  
-
-  
-  
-
diff --git a/daffodil-cli/src/test/scala/org/apache/daffodil/CLI/Util.scala 
b/daffodil-cli/src/test/scala/org/apache/daffodil/CLI/Util.scala
index e678ab310..c2b497fcc 100644
--- a/daffodil-cli/src/test/scala/org/apache/daffodil/CLI/Util.scala
+++ b/daffodil-cli/src/test/scala/org/apache/daffodil/CLI/Util.scala
@@ -84,7 +84,9 @@ object Util {
   }
 
   def getShell(cmd: String, spawnCmd: String, expectErr: Boolean = false, 
envp: Map[String, String] = Map.empty[String, String], timeout: Long): Expect = 
{
-val newEnv = System.getenv().asScala ++ envp
+// combine existing environment with envp and daffodil-lib test resources 
(needed for built-in-formats.xsd)
+val newEnv = System.getenv().asScala ++ envp + (("DAFFODIL_CLASSPATH", 
daffodilPath("daffodil-lib/src/test/resources/")))
+
 val envAsArray = newEnv.toArray.map { case (k, v) => k + "=" + v }
 val process = Runtime.getRuntime().exec(spawnCmd, envAsArray)
 val inputStream = if (expectErr) {
@@ -111,7 +113,9 @@ object Util {
   // The inputStream will be at index 0
   // The errorStream will be at index 1
   def getShellWithErrors(cmd: String, spawnCmd: String, envp: Map[String, 
String] = Map.empty[String, String], timeout: Long): Expect = {
-val newEnv = System.getenv().asScala ++ envp
+// combine existing environment with envp and daffodil-lib test resources 
(needed for built-in-formats.xsd)
+val newEnv = System.getenv().asScala ++ envp + (("DAFFODIL_CLASSPATH", 
daffodilPath("daffodil-lib/src/test/resources/")))
+
 val envAsArray = newEnv.toArray.map { case (k, v) => k + "=" + v }
 val process = Runtime.getRuntime().exec(spawnCmd, envAsArray)
 val shell = new ExpectBuilder()
diff --git 
a/daffodil-cli/src/test/scala/org/apache/daffodil/performance/TestCLIPerformance.scala
 
b/daffodil-cli/src/test/scala/org/apache/daffodil/performance/TestCLIPerformance.scala
index c3ed1d5e0..9d27b26a6 100644
--- 
a/daffodil-cli/src/test/scala/org/apache/daffodil/performance/TestCLIPerformance.scala
+++ 
b/daffodil-cli/src/test/scala/org/apache/daffodil/performance/TestCLIPerformance.scala
@@ -24,7 +24,6 @@ import net.sf.expectit.ExpectIOException
 import