[GitHub] jadams-tresys opened a new pull request #87: Allow same character for escapeBlockEnd and escapeEscapeCharacter

2018-07-26 Thread GitBox
jadams-tresys opened a new pull request #87: Allow same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/87 This commit fixes the issue where the escapeBlockEnd and escapeEscapeCharacter are the same character. This is

[GitHub] jadams-tresys closed pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter

2018-07-26 Thread GitBox
jadams-tresys closed pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] jadams-tresys commented on issue #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter

2018-07-26 Thread GitBox
jadams-tresys commented on issue #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter URL: https://github.com/apache/incubator-daffodil/pull/84#issuecomment-408222012 Closing pull request. I think I confused github by deleting the branch I

[jira] [Created] (DAFFODIL-1972) escapeBlock doesn't work correctly when escapeBlockEnd is the same as 2 escapeEscapeCharacters

2018-07-26 Thread Josh Adams (JIRA)
Josh Adams created DAFFODIL-1972: Summary: escapeBlock doesn't work correctly when escapeBlockEnd is the same as 2 escapeEscapeCharacters Key: DAFFODIL-1972 URL:

[GitHub] stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep

2018-07-26 Thread GitBox
stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/86#discussion_r205426082 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala

[GitHub] stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep

2018-07-26 Thread GitBox
stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/86#discussion_r205427929 ## File path:

[GitHub] stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep

2018-07-26 Thread GitBox
stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/86#discussion_r205422765 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala

[GitHub] stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep

2018-07-26 Thread GitBox
stevedlawrence commented on a change in pull request #86: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/86#discussion_r205430313 ## File path: