[GitHub] [incubator-daffodil] bsloane1650 commented on issue #225: Implement daf:lookAhead

2019-06-03 Thread GitBox
bsloane1650 commented on issue #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#issuecomment-498388966 @mbeckerle I don't think we can merge DState with P/UState. We need to have a (degenerate) DState without a P/UState for constant folding. I also t

[GitHub] [incubator-daffodil] mbeckerle commented on issue #225: Implement daf:lookAhead

2019-06-03 Thread GitBox
mbeckerle commented on issue #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#issuecomment-498393483 w.r.t the issue of merging DState and P/UState I see your point that it's better to keep them separate, but we need a trait that defines the dependen

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #224: Generate DaffodilTunables and WarnID from dafext.xsd

2019-06-04 Thread GitBox
stevedlawrence merged pull request #224: Generate DaffodilTunables and WarnID from dafext.xsd URL: https://github.com/apache/incubator-daffodil/pull/224 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-daffodil] stevedlawrence commented on issue #223: Daffodil 1444 schema comp simple types

2019-06-04 Thread GitBox
stevedlawrence commented on issue #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#issuecomment-498643528 +1 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r290262183 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala ## @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290264328 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290271477 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290264686 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290266903 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290268801 ## File path: daffodil-test/src/test/scala/org/apache/daffodil/extensions/TestLookAhead.scala ## @@ -0,0 +1,

[GitHub] [incubator-daffodil] mbeckerle merged pull request #223: Daffodil 1444 schema comp simple types

2019-06-04 Thread GitBox
mbeckerle merged pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-daffodil] mbeckerle opened a new pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-04 Thread GitBox
mbeckerle opened a new pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226 This small change is another incremental improvement. I was getting NPE quite a bit due to things running up the DSOM o

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290328907 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,63 @

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290338037 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,63 @

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #225: Implement daf:lookAhead

2019-06-04 Thread GitBox
mbeckerle commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r290439158 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DAFFunctions.scala ## @@ -72,3 +78,63 @@

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290463690 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Specifi

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290497131 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLe

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290496851 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ##

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290497887 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ##

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290495993 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLe

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290510472 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Specif

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-04 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290512525 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLe

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226#discussion_r291138145 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Sche

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r291157355 ## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ## @@ -193,7 +193,1

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-06 Thread GitBox
mbeckerle commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226#discussion_r291167815 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaCom

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-06 Thread GitBox
mbeckerle commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226#discussion_r291169337 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaCom

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-06 Thread GitBox
mbeckerle commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226#discussion_r291169337 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaCom

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226#discussion_r291171653 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Sche

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r291174481 ## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd ## @@ -364,6 +364,15 @@

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead

2019-06-06 Thread GitBox
bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r291192253 ## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd ## @@ -364,6 +364,15 @@

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #225: Implement daf:lookAhead

2019-06-06 Thread GitBox
stevedlawrence merged pull request #225: Implement daf:lookAhead URL: https://github.com/apache/incubator-daffodil/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-daffodil] bsloane1650 opened a new pull request #227: Fix depreceated new JLong() constructor

2019-06-06 Thread GitBox
bsloane1650 opened a new pull request #227: Fix depreceated new JLong() constructor URL: https://github.com/apache/incubator-daffodil/pull/227 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-daffodil] jadams-tresys commented on issue #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
jadams-tresys commented on issue #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#issuecomment-499579416 All thread safety issues should hopefully be addressed now. This

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #227: Fix depreceated new JLong() constructor

2019-06-06 Thread GitBox
stevedlawrence merged pull request #227: Fix depreceated new JLong() constructor URL: https://github.com/apache/incubator-daffodil/pull/227 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291311227 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Choice

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291314575 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Specif

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291320423 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Specif

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291310989 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ## @@

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291310406 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scal

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291317277 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ##

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291320137 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Suppre

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291323267 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ## @@ -

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291323652 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Specifi

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291323872 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ###

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291324294 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ## @@

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291325283 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/Specifi

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291326128 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ##

[GitHub] [incubator-daffodil] codecov-io commented on issue #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
codecov-io commented on issue #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#issuecomment-499647012 # [Codecov](https://codecov.io/gh/apache/incubator-daffodil/pull/218?src=pr&el=h1) Report > Merging [#218](https://codecov.io/gh

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291429717 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ##

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291430696 ## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLe

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-06 Thread GitBox
mbeckerle commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291431174 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ## @@ -24,6

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-07 Thread GitBox
jadams-tresys commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291613998 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ## @@ -

[GitHub] [incubator-daffodil] mbeckerle opened a new pull request #228: WIP: Daffodil 1444 schema comp

2019-06-07 Thread GitBox
mbeckerle opened a new pull request #228: WIP: Daffodil 1444 schema comp URL: https://github.com/apache/incubator-daffodil/pull/228 Has features to allow navigation of multiple backpointers from referenced components to the places referencing them. This enables sharing in the future

[GitHub] [incubator-daffodil] bsloane1650 opened a new pull request #229: Daffodil 2146 enum support fix1

2019-06-07 Thread GitBox
bsloane1650 opened a new pull request #229: Daffodil 2146 enum support fix1 URL: https://github.com/apache/incubator-daffodil/pull/229 There were 2 minor bugs this fixes: 1) Enumerations assumed that any repType has a corresponding typeDef. This is not true when the repType is a prim

[GitHub] [incubator-daffodil] stevedlawrence commented on issue #218: Implement dfdl:choiceLength='explicit'

2019-06-07 Thread GitBox
stevedlawrence commented on issue #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#issuecomment-499939266 +1 :+1: This is an automated message from the Apache Git Servic

[GitHub] [incubator-daffodil] jadams-tresys merged pull request #218: Implement dfdl:choiceLength='explicit'

2019-06-07 Thread GitBox
jadams-tresys merged pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-07 Thread GitBox
stevedlawrence opened a new pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230 - Use xs:anyAttribute and xs:any defined in the DFDL namespace to enable validation for attribute-form and short-fo

[GitHub] [incubator-daffodil] mbeckerle merged pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type

2019-06-07 Thread GitBox
mbeckerle merged pull request #226: Sick of NPE. lexicalParent is now optLexicalParent and is Option type URL: https://github.com/apache/incubator-daffodil/pull/226 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-daffodil] mbeckerle commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#issuecomment-500033772 A thought. This change introduces 41 deprecation errors. I had to switch off the checking that fail

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291749658 ## File path: build.sbt ## @@ -110,7 +110,7 @@ lazy val commonSet

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291750159 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Schema

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291750610 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Schema

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291751451 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Root.sc

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291751591 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Root.sc

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291751591 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Root.sc

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r291752876 ## File path: daffodil-core/src/test/scala/org/apache/daffodil/dsom/TestRe

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230#discussion_r291768671 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/extensions/type

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230#discussion_r291768192 ## File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/XMLSchema_fo

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-07 Thread GitBox
mbeckerle commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230#discussion_r291768357 ## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_par

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-10 Thread GitBox
stevedlawrence commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230#discussion_r291972583 ## File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/XMLSche

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-10 Thread GitBox
stevedlawrence commented on a change in pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230#discussion_r291975690 ## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFD

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #230: Enable schema validation of attribute- and short-form properties

2019-06-10 Thread GitBox
stevedlawrence merged pull request #230: Enable schema validation of attribute- and short-form properties URL: https://github.com/apache/incubator-daffodil/pull/230 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292030028 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Ne

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292032247 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Ne

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292026653 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/I

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
stevedlawrence commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292021428 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/E

[GitHub] [incubator-daffodil] stevedlawrence commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
stevedlawrence commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#issuecomment-500444559 > A thought. This change introduces 41 deprecation errors. I had to switch off the checking th

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292066462 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Nesting

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292068715 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Initia

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292069132 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Elemen

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292069487 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Initia

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-10 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292070570 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Nesting

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #229: Daffodil 2146 enum support fix1

2019-06-10 Thread GitBox
stevedlawrence merged pull request #229: Daffodil 2146 enum support fix1 URL: https://github.com/apache/incubator-daffodil/pull/229 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #231: Add support for namespacing DFDL extension properties and functions

2019-06-11 Thread GitBox
stevedlawrence opened a new pull request #231: Add support for namespacing DFDL extension properties and functions URL: https://github.com/apache/incubator-daffodil/pull/231 Create a new dfdlx namespace and move a handful of extensions properties and functions to it. This is where all fu

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #232: Simplify how we show text differences when a TDML test fails

2019-06-12 Thread GitBox
stevedlawrence opened a new pull request #232: Simplify how we show text differences when a TDML test fails URL: https://github.com/apache/incubator-daffodil/pull/232 We previously found every character that differed and showed its path, index, and expected/actual characters. But when an

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails

2019-06-12 Thread GitBox
mbeckerle commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails URL: https://github.com/apache/incubator-daffodil/pull/232#discussion_r292915620 ## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/XMLUtils.scala #

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails

2019-06-12 Thread GitBox
stevedlawrence commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails URL: https://github.com/apache/incubator-daffodil/pull/232#discussion_r292926360 ## File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/XMLUtils.scala

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #233: Warn when DFDL properties are ignored

2019-06-13 Thread GitBox
stevedlawrence opened a new pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233 During schema compilation, a cache of properties exists to speed up subsequent property lookups. This patch takes advantage of that cache to

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-14 Thread GitBox
mbeckerle commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293897385 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ## @@ -107,10 +108,43

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-14 Thread GitBox
mbeckerle commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293901806 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section12/aligned_data/Aligned_Data.tdml

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-14 Thread GitBox
mbeckerle commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293903681 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProp

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-14 Thread GitBox
stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293918216 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section12/aligned_data/Aligned_Data.t

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-14 Thread GitBox
stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293918808 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ## @@ -107,10 +1

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-14 Thread GitBox
stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293921127 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumbe

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-14 Thread GitBox
mbeckerle commented on a change in pull request #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r293927747 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Nesting

[GitHub] [incubator-daffodil] mbeckerle commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-14 Thread GitBox
mbeckerle commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#issuecomment-502219324 One must turn off both deprecation warnings and Xfatal-warnings to successfully compile. Because ev

[GitHub] [incubator-daffodil] mbeckerle commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue.

2019-06-14 Thread GitBox
mbeckerle commented on issue #228: Incremental progress on Daffodil 1444 schema compiler space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/228#issuecomment-502230783 I've concluded the right thing is to remove as many deprecated calls as possible (some calls were f

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #232: Simplify how we show text differences when a TDML test fails

2019-06-17 Thread GitBox
stevedlawrence merged pull request #232: Simplify how we show text differences when a TDML test fails URL: https://github.com/apache/incubator-daffodil/pull/232 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #231: Add support for namespacing DFDL extension properties and functions

2019-06-17 Thread GitBox
stevedlawrence merged pull request #231: Add support for namespacing DFDL extension properties and functions URL: https://github.com/apache/incubator-daffodil/pull/231 This is an automated message from the Apache Git Service

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored

2019-06-17 Thread GitBox
stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r294318549 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumbe

<    3   4   5   6   7   8   9   10   11   12   >