Re: [PATCH] FGCP: advertise delete action when cimi system has no machines

2013-04-25 Thread David Lutterkort
ACK - Original Message - > From: Dies Koper > > --- > server/lib/deltacloud/drivers/fgcp/fgcp_driver_cimi_methods.rb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/lib/deltacloud/drivers/fgcp/fgcp_driver_cimi_methods.rb > b/server/lib/deltacloud/drivers

Re: [PATCH] FGCP: fix system template component descriptor name to ensure created machine name complies with spec

2013-04-24 Thread David Lutterkort
ACK - Original Message - > From: Dies Koper > > --- > server/lib/deltacloud/drivers/fgcp/fgcp_driver_cimi_methods.rb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/lib/deltacloud/drivers/fgcp/fgcp_driver_cimi_methods.rb > b/server/lib/deltacloud/drivers

Re: [VOTE] Release Apache Deltacloud 1.1.3, rc1

2013-04-19 Thread David Lutterkort
On Wed, 2013-04-17 at 11:30 +0200, Michal Fojtik wrote: > Good news everyone! > > I am very pleased to announce the availability of RC1 for Deltacloud > 1.1.3. The release candidate is available at > http://people.apache.org/~mfojtik/deltacloud/1.1.3rc1/ > > Please vote on the release candidate b

Re: deltacloud as a lib and broker

2013-04-10 Thread David Lutterkort
n the Delta Cloud > library itself. > > Yours sincerely, > Arvind, > Creatrix IT Soft. > -Original Message- > From: Jozef Zigmund > Sent: Tuesday, April 9, 2013 7:28 PM > To: dev@deltacloud.apache.org > Cc: Martin Povolny ; aeolus-devel > Subject: Re

Re: deltacloud as a lib and broker

2013-04-10 Thread David Lutterkort
Hi Martin, On Wed, 2013-04-10 at 15:53 +0200, Martin Povolny wrote: > I think that Jan's original idea was to expose sort-of-cleaned-up driver > API as the universal library API. > > That is mainly work through the controller methods that implement the > API calls and > > * identify and fix th

[jira] [Assigned] (DTACLOUD-536) cimi: machine disks GET returns error

2013-04-09 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lutterkort reassigned DTACLOUD-536: - Assignee: David Lutterkort > cimi: machine disks GET returns er

[jira] [Resolved] (DTACLOUD-536) cimi: machine disks GET returns error

2013-04-09 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lutterkort resolved DTACLOUD-536. --- Resolution: Fixed Pacthes in PR https://github.com/deltacloud/core/pull/4

Re: RHEVm - Allow for user selectable 1st boot device (round 2)

2013-04-09 Thread David Lutterkort
On Fri, 2013-04-05 at 15:25 -0400, jvl...@redhat.com wrote: > 2nd attempt > > The 1st attempt had an unnecessary fix for bundle failures for excon. > > This patch addresses: > > The default first boot device has been changed in the rbovirt gem > to hard disk, followed by network. This push allow

Re: deltacloud as a lib and broker

2013-04-08 Thread David Lutterkort
On Mon, 2013-04-08 at 14:44 +0200, Jan Provaznik wrote: > > There are some other downsides to using DC in process (as a library): it > > also significantly changes where DC can go architecturally. So far, the > > classic DC API has worked very hard to be stateless - CIMI isn't, and it > > wouldn't

Re: Wish to contribute to Delta Cloud project-How I do proceed further

2013-04-08 Thread David Lutterkort
the PMI > > of the Delta Cloud project—I dont know that also. > > > > David Lutterkort, is the guy to contact. Just to be clear: patches should go to this mailing list, as should go pretty much everything else, like questions about how some aspect of the code works etc. Also, you can reach most people via #deltacloud on freenode/ David

[jira] [Commented] (DTACLOUD-525) Unable to perform operations on CIMI::Model

2013-04-05 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624303#comment-13624303 ] David Lutterkort commented on DTACLOUD-525: --- I started looking into it,

Re: deltacloud as a lib and broker

2013-04-05 Thread David Lutterkort
Hi Jan, On Fri, 2013-04-05 at 14:37 +0200, Jan Provazník wrote: > During this discussion we touched (again) the "Deltacloud as a lib" > topic, Michal asked me to send a mail here if we have a feature request. > If you look at the possible solutions (the link above), having this lib > would be h

Re: [PATCH] FGCP: advertise and implement cimi system start and stop

2013-04-04 Thread David Lutterkort
On Fri, 2013-04-05 at 09:29 +1100, Koper, Dies wrote: > Hi David, > > Yes they should. They were going into the list of things I won't be able to > implement myself before the plugfest and need you guys to look at :) > Same for system state retrieval. It should probably ignore the system state >

Re: [PATCH core 1/5] Client: Added base64#encode for user_data (DTACLOUD-522)

2013-04-04 Thread David Lutterkort
On Thu, 2013-04-04 at 16:06 -0700, David Lutterkort wrote: > On Wed, 2013-04-03 at 16:20 +0200, mfoj...@redhat.com wrote: > > From: Michal Fojtik > > > > ACK nm .. just saw that they were ack'd already in tracker. David

Re: [PATCH core 1/5] Client: Added base64#encode for user_data (DTACLOUD-522)

2013-04-04 Thread David Lutterkort
On Wed, 2013-04-03 at 16:20 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > ACK

Re: [PATCH core] Core: Add 'public_key' feature for :keys collection

2013-04-04 Thread David Lutterkort
On Thu, 2013-04-04 at 18:14 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > This feature indicate wheter cloud provider support > uploading of custom PEM keys or not. Is the public_key for the create operation truly optional ? Also, we need an update for the docs to go with this. Da

Re: storage_volumes and cimi volumes include system volumes?

2013-04-04 Thread David Lutterkort
Hi Dies, are these truly volumes (i.e., storage that as its own lifecycle, not connected to that of the machine to which it is attached ?) If so, I believe they should be included - if they vanish when the machine vanishes, they are 'disks' not 'volumes' in CIMI lingo. David On Fri, 2013-04-05 a

Re: [PATCH core] Core: Added url_for helpers for Rabbit subcollections (DTACLOUD-526)

2013-04-04 Thread David Lutterkort
On Thu, 2013-04-04 at 16:57 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > This patch add URL helpers for all Rabbit subcollections, like: > > system_volumes(:id => system_id) > => "http://localhost:3001/cimi/systems/system_id/volumes"; > > system_volumes(:id => system_id, :ent_id

Re: RHEVm - Allow for user selectable 1st boot device

2013-04-04 Thread David Lutterkort
On Thu, 2013-04-04 at 18:14 -0400, jvl...@redhat.com wrote: > RHEVm - Provide for user selectable first boot device. > > The default first boot device has been changed in the rbovirt gem > to hard disk, followed by network. This push allows the user to > explicitly specify the first boot device as

Re: [PATCH] FGCP: advertise and implement cimi system start and stop

2013-04-04 Thread David Lutterkort
On Fri, 2013-04-05 at 00:23 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper > > --- > .../drivers/fgcp/fgcp_driver_cimi_methods.rb | 48 > +- > 1 file changed, 46 insertions(+), 2 deletions(-) ACK. Looking at mock_driver_cimi_methods and the start/stop syst

Re: [PATCH] FGCP: advertise and implement cimi system start and stop

2013-04-04 Thread David Lutterkort
On Fri, 2013-04-05 at 00:23 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper > > --- > .../drivers/fgcp/fgcp_driver_cimi_methods.rb | 48 > +- > 1 file changed, 46 insertions(+), 2 deletions(-) ACK, with one comment: > diff --git a/server/lib/deltacloud/dri

[jira] [Commented] (DTACLOUD-525) Unable to perform operations on CIMI::Model

2013-04-04 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622878#comment-13622878 ] David Lutterkort commented on DTACLOUD-525: --- Most of the Service.find met

[jira] [Commented] (DTACLOUD-525) Unable to perform operations on CIMI::Model

2013-04-04 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622616#comment-13622616 ] David Lutterkort commented on DTACLOUD-525: --- The problem is that System.

Re: [PATCH] added Template subcollections to SystemTemplate

2013-04-03 Thread David Lutterkort
On Tue, 2013-04-02 at 10:41 +0200, Michal Fojtik wrote: > On 04/02/2013 02:26 AM, David Lutterkort wrote: > > On Thu, 2013-03-28 at 12:19 +1100, Koper, Dies wrote: > >> A bit of background on this patch: > >> It contains my latest work on implementing cimi systems an

Re: [PATCH] added Template subcollections to SystemTemplate

2013-04-01 Thread David Lutterkort
ectly. Michal ? BTW, attached is a patch that addresses a few URL conversion problems I found in the mock driver; feel free to commit if it doesn't make things worse ;) David >From c06a92816926fa24780721241be03ff507fa95e9 Mon Sep 17 00:00:00 2001 From: David Lutterkort Date: Fri, 1

Re: [PATCH] added Template subcollections to SystemTemplate

2013-03-27 Thread David Lutterkort
On Thu, 2013-03-28 at 11:11 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper > > --- > server/lib/cimi/collections/systems.rb | 58 +-- > server/lib/cimi/models.rb | 12 ++- > server/lib/cimi/models/machine_template.rb | 6 +- >

Re: [PATCH] added Template subcollections to SystemTemplate

2013-03-27 Thread David Lutterkort
On Thu, 2013-03-28 at 09:27 +1100, Koper, Dies wrote: > The error message is the same, but the line number it occurs in has changed > (was schema.rb:273:in > `to_xml'). After adding extract(model) to it there it works fine. Thanks! > > Not sure where to move the "def extract" method declaration t

Re: [PATCH] added Template subcollections to SystemTemplate

2013-03-27 Thread David Lutterkort
gs for you - if it does, please include it with your patch series. David >From d33c82eb6b450dfda7290d799ed7cfed810d1589 Mon Sep 17 00:00:00 2001 From: David Lutterkort Date: Wed, 27 Mar 2013 12:26:36 -0700 Subject: [PATCH] CIMI schema: tolerate nil hash_map attributes --- server/lib/cimi/mod

Re: Adventures with oVirt

2013-03-15 Thread David Lutterkort
On Thu, 2013-03-14 at 17:42 -0700, Ian Main wrote: > On Thu, Mar 14, 2013 at 03:19:06PM -0700, David Lutterkort wrote: > > Hi Ian, > > > > On Thu, 2013-03-14 at 13:36 -0700, Ian Main wrote: > > > A possibly more overarching issue is hardware profiles. Hardware profi

Re: Adventures with oVirt

2013-03-14 Thread David Lutterkort
Hi Ian, On Thu, 2013-03-14 at 13:36 -0700, Ian Main wrote: > A possibly more overarching issue is hardware profiles. Hardware profiles > are rather different in ovirt as compared to most other providers I've > worked with. Generally they just define 2 profiles, neither of which > really define a

Re: [PATCH] SITE: Update test recording instructions

2013-03-14 Thread David Lutterkort
On Wed, 2013-03-13 at 17:28 -0400, jvlcek wrote: > On 03/13/2013 01:41 PM, David Lutterkort wrote: > > On Wed, 2013-03-13 at 08:50 -0400, jvlcek wrote: > >> On 03/12/2013 06:26 PM, David Lutterkort wrote: > >>> On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com

Re: [VOTE] Release Apache Deltacloud 1.1.2, rc1

2013-03-14 Thread David Lutterkort
On Wed, 2013-03-13 at 13:38 -0400, Michal Fojtik wrote: > I am very pleased to announce the availability of RC1 for Deltacloud > 1.1.1. The release candidate is available at > http://people.apache.org/~mfojtik/deltacloud/1.1.2rc1/ > > Please vote on the release candidate by Saturday 0900 EST (New

Re: RFC: Separate CIMI (de)serialization from server functionality (rev 3)

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 17:33 -0700, lut...@redhat.com wrote: > This is the third take on splitting server-side functionality out of our > models. As in previous attempts, CIMI::Model is now solely concerned with > (se)serialization, whereas CIMI::Service does all the actual server-side > functionali

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 08:50 -0400, jvlcek wrote: > On 03/12/2013 06:26 PM, David Lutterkort wrote: > > On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote: > >> From: Joe VLcek > >> > >> This is required to better describe recent changes > >&

Re: [PATCH] SITE: Update test recording instructions

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 10:05 +1100, Koper, Dies wrote: > I've been wondering something about this re-recording. > In the fgcp unit tests I have ' :record => :new_episodes' in default cassette > options. > The first time I run new tests, it does a recording. If I want to rerecord, I > delete the re

Re: coloured dots

2013-03-13 Thread David Lutterkort
On Wed, 2013-03-13 at 20:57 +1100, Koper, Dies wrote: > Hi Michal, > > I tried adding the following to Gemfile but it made no difference. > > platforms :mswin do > gem 'win32console' > end > > However, when I run the tests directly (i.e. ruby > tests\cimi\collections\system_templates_test.rb),

Re: [PATCH] SITE: Update test recording instructions

2013-03-12 Thread David Lutterkort
On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote: > From: Joe VLcek > > This is required to better describe recent changes > for parameterizing recording and provider configuration > of credentials and resources to avoid having to edit > test source code in order to record test fixtures

RFC: CIMI::Models split (rev 3)

2013-03-11 Thread David Lutterkort
I uploaded the latest version of the patches as http://tracker.deltacloud.org/set/384 It's still broken, but in new more interesting ways (especially when running the blackbox tests) Besides simple syntax errors, the model classes also still depend on the DB, which they shouldn't. David

[jira] [Commented] (DTACLOUD-487) Keypair support for ovirt backend

2013-03-11 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599504#comment-13599504 ] David Lutterkort commented on DTACLOUD-487: --- Just to be clear: what we ca

Re: Parametrize RHEV-M unit tests

2013-03-11 Thread David Lutterkort
Hi Joe, On Fri, 2013-03-08 at 10:03 -0500, jvlcek wrote: > nack and 2 nits > > nack because the ec2 gogrid and rhevm driver tests fail with this patch > applied. > > See attached file: failing_tests I fixed up the patch series, and rerecorded it as http://tracker.deltacloud.org/set/382 The ne

Re: rake test in server/

2013-03-07 Thread David Lutterkort
On Thu, 2013-03-07 at 14:23 -0500, jvlcek wrote: > The latest bits seem to run fine. See the attached. What RUby version do you use ? Can you send me your Gemfile.lock ? > I believe the issue is the patch: > 0001-RHEVM-tests-have-VCR-match-only-on-path-and-query-no.path > the match_request_on is

Re: [PATCH] SITE: Improvements Add white box unit test description.

2013-03-07 Thread David Lutterkort
Hi Joe, looks fine to me, couple comments: On Wed, 2013-03-06 at 17:49 -0500, jvl...@redhat.com wrote: > diff --git a/site/content/running-the-white-box-tests.md > b/site/content/running-the-white-box-tests.md > new file mode 100644 > index 000..542cd34 > --- /dev/null > +++ b/site/content/r

Re: rake test in server/

2013-03-07 Thread David Lutterkort
On Thu, 2013-03-07 at 09:14 -0500, jvlcek wrote: > On 03/06/2013 08:31 PM, David Lutterkort wrote: > > Am I the only one who runs into errors running 'rake test' ? I've got a > > bunch of fixes that I'll send out in a minute, but I still get errors > >

rake test in server/

2013-03-06 Thread David Lutterkort
Am I the only one who runs into errors running 'rake test' ? I've got a bunch of fixes that I'll send out in a minute, but I still get errors from test:drivers:rhevm - seems like the fixtures need to be rerecorded. Can others run rake test successfully ? David

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

2013-03-06 Thread David Lutterkort
On Wed, 2013-03-06 at 15:41 +0100, Michal Fojtik wrote: > On 03/05, David Lutterkort wrote: > > I've addressed that issue and uploaded a new patch series > > ( http://tracker.deltacloud.org/set/368 ) > > For some reason, all patches have empty body :-) (tracker upload

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

2013-03-06 Thread David Lutterkort
On Mon, 2013-03-04 at 10:57 +0100, Michal Fojtik wrote: > On 03/01, David Lutterkort wrote: > > On Fri, 2013-03-01 at 14:40 +0100, Michal Fojtik wrote: > > > - ResourceMetada are now broken and need to be fixed. > > > (an informative warning included ;-) > > &

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

2013-03-05 Thread David Lutterkort
I run it by itself with 'ruby tests/cimi/collections/volumes_test.rb) but it fails when I run rake test:cimi because the collection of volume configs is empty in make_volume_create ... David On Mon, 2013-03-04 at 17:35 -0800, David Lutterkort wrote: > On Fri, 2013-03-01 at 17:25 -0800, Dav

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

2013-03-04 Thread David Lutterkort
On Fri, 2013-03-01 at 17:25 -0800, David Lutterkort wrote: > On Fri, 2013-03-01 at 14:40 +0100, Michal Fojtik wrote: > > - ResourceMetada are now broken and need to be fixed. > > (an informative warning included ;-) > > I added one more patch to your series and

Re: [PATCH core] Switch the rubygems.org source to https://rubygems.org

2013-03-04 Thread David Lutterkort
On Fri, 2013-03-01 at 11:21 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Using HTTPS connection is now prefered way how to access > rubygems. Under MRI 2.0 having non-https URL will print > a huge ugly warning. ACK David

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

2013-03-01 Thread David Lutterkort
On Fri, 2013-03-01 at 14:40 +0100, Michal Fojtik wrote: > - ResourceMetada are now broken and need to be fixed. > (an informative warning included ;-) I added one more patch to your series and rerecorded as http://tracker.deltacloud.org/set/364 > - The filter_by and select_by methods moved to

Re: CIMI - Tests - modifying tests to use *Create

2013-02-28 Thread David Lutterkort
On Thu, 2013-02-28 at 16:20 -0500, rla...@redhat.com wrote: > Please review. Thanks! > ACK. Pushed David

Re: Deltacloud - Tests - removing reference to keys collection

2013-02-28 Thread David Lutterkort
On Thu, 2013-02-28 at 14:54 -0500, rla...@redhat.com wrote: > First patch adds the new test files > Second patch fixes copy/paste error ACK. Committed and pushed David

Bye, bye, Ruby 1.8.7

2013-02-28 Thread David Lutterkort
Hi all, Ruby 1.8.7 will become completely unsupported upstream in June[1]. We've been trying to keep Deltacloud running on it, but with 1.8.7's EOL looming, it's a rather pointless exercise. We are therefore planning to drop any guise of Ruby 1.8 support very, very soon; if that causes a problem

[jira] [Commented] (DTACLOUD-499) The 'ref' attributes are not (de)serialized properly when used in array

2013-02-26 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587988#comment-13587988 ] David Lutterkort commented on DTACLOUD-499: --- To produce an arra

[jira] [Assigned] (DTACLOUD-500) CIMI: GET /cimi/addresses, using application/xml errors out

2013-02-26 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lutterkort reassigned DTACLOUD-500: - Assignee: Michal Fojtik This looks like a Rabbit problem to me

[jira] [Resolved] (DTACLOUD-499) The 'ref' attributes are not (de)serialized properly when used in array

2013-02-26 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lutterkort resolved DTACLOUD-499. --- Resolution: Fixed > The 'ref' attributes are not (de)serialized

[jira] [Updated] (DTACLOUD-499) The 'ref' attributes are not (de)serialized properly when used in array

2013-02-26 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lutterkort updated DTACLOUD-499: -- Attachment: 0001-CIMI-schema-make-it-possible-to-build-an-array-of-re.patch Patch to

[jira] [Commented] (DTACLOUD-499) The 'ref' attributes are not (de)serialized properly when used in array

2013-02-26 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587722#comment-13587722 ] David Lutterkort commented on DTACLOUD-499: --- The problem is that

Re: design question about cimi system's subcollection implementations

2013-02-26 Thread David Lutterkort
Hi Dies, I am not 100% sure I understand what you are suggesting, but I think you are saying that the instances method in each driver should support an additional filter param 'system_id' .. is that correct ? As I understand it, the find method in CIMI::Model::SystemMachine needs to accept a syst

Re: [PATCH] CIMI - Tests - reenabling collections testing for addresses and forwardingGroupTemplates

2013-02-25 Thread David Lutterkort
On Mon, 2013-02-25 at 16:48 -0500, rla...@redhat.com wrote: > From: Ronelle Landy > > --- > tests/cimi/cep_test.rb |8 ++-- > 1 files changed, 2 insertions(+), 6 deletions(-) ACK & pushed with the exception that I had to disable addresses, as that blows up on my machine. Strangely, GET

Re: [PATCH 2/2] Tests - Deltacloud blackbox - fixing cleanup conditional statement

2013-02-25 Thread David Lutterkort
On Mon, 2013-02-25 at 17:42 -0500, rla...@redhat.com wrote: > From: Ronelle Landy > > --- > tests/deltacloud/buckets_test.rb |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) ACK & pushed

Re: [PATCH] CIMI Webapp: creating volume_configs; fix conflict in views/machine_templates/index.haml

2013-02-25 Thread David Lutterkort
On Wed, 2013-02-20 at 19:48 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/views/machine_templates/index.haml |8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) ACK and pushed (with a commit message that reflects the content of the patch a lit

Re: [PATCH 1/4] CIMI Webapp creating MachineTemplate

2013-02-25 Thread David Lutterkort
On Mon, 2013-02-25 at 12:29 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/lib/entities/machine_template.rb | 23 ++ > clients/cimi/views/machine_templates/index.haml | 38 > --- > clients/cimi/views/machine_templates/sho

[jira] [Commented] (DTACLOUD-497) image on /api/instance_states page does not display on Chrome and IE (Windows)

2013-02-22 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584932#comment-13584932 ] David Lutterkort commented on DTACLOUD-497: --- This might be cause

Re: [PATCH] GUI: made capitalization in titles and buttons consistent

2013-02-22 Thread David Lutterkort
On Sat, 2013-02-23 at 12:22 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper > > --- > server/views/addresses/show.html.haml | 2 +- > server/views/buckets/show.html.haml| 2 +- > server/views/firewalls/new.html.haml | 4 ++-- > server/views/images/show.h

Re: [PATCH] FGCP: add mapping for GET system and system_templates

2013-02-22 Thread David Lutterkort
Hi Dies, looks good, though I don't understand the networks method at all: On Fri, 2013-02-22 at 23:45 +1100, di...@fast.au.fujitsu.com wrote: > diff --git a/server/lib/deltacloud/drivers/fgcp/fgcp_driver_cimi_methods.rb > b/server/lib/deltacloud/drivers/fgcp/fgcp_driver_cimi_methods.rb > new f

Re: [PATCH] FGCP: added support for storage_volume creation from snapshot

2013-02-22 Thread David Lutterkort
On Fri, 2013-02-22 at 12:11 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper > > --- > server/lib/deltacloud/drivers/fgcp/fgcp_client.rb | 44 > +++ > server/lib/deltacloud/drivers/fgcp/fgcp_driver.rb | 38 +++- > server/views/storage_volumes/show.h

[jira] [Reopened] (DTACLOUD-477) Openstack provider: Realms id not correctly reported from GET /api/instance/Instance_id

2013-02-22 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lutterkort reopened DTACLOUD-477: --- The unit tests now fail, since they require rerecording. > Openst

Re: CIMI actions, validations and more...

2013-02-21 Thread David Lutterkort
On Mon, 2013-02-11 at 13:35 +0100, mfoj...@redhat.com wrote: > This patch-bomb is represents merged version of David patches that add > the 'ref' attribute type and my validation patches. ACK to the whole series. David

Re: [PATCH core 10/11] CIMI: Replaced :grab_content_type helper with :current_content_type

2013-02-21 Thread David Lutterkort
On Mon, 2013-02-11 at 13:35 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > In Sinatra helpers have direct access to the 'request' method, > so there is no need to pass any parameter to this helper. > > This patch will also report unsupported media type correctly > via Deltacloud exce

Re: [PATCH core 08/11] Core: Fixed JSON and XML serialization of realms

2013-02-21 Thread David Lutterkort
On Mon, 2013-02-11 at 13:35 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik ACK; one nit: > diff --git a/server/lib/deltacloud/models/realm.rb > b/server/lib/deltacloud/models/realm.rb > index 1c25ba2..7f1e2e9 100644 > --- a/server/lib/deltacloud/mod

Re: [PATCH core 06/11] CIMI: Initial inclusion of CIMI action models

2013-02-21 Thread David Lutterkort
On Mon, 2013-02-11 at 13:35 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > The way of how we currently create CIMI entities is not > really nice. We parse the raw JSON/XML and then we are > trying to create the CIMI entity. > > Besides the code looks ugly, there is no way to add vali

[jira] [Commented] (DTACLOUD-488) Openstack driver - re-map regions to providers rather than realms

2013-02-21 Thread David Lutterkort (JIRA)
[ https://issues.apache.org/jira/browse/DTACLOUD-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583654#comment-13583654 ] David Lutterkort commented on DTACLOUD-488: --- rlandy wrote: > > - I

Re: [PATCH core] Core: Run db:migrate rake task after mock:fixtures:reset

2013-02-21 Thread David Lutterkort
On Thu, 2013-02-21 at 15:45 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Since the database is erased, Deltacloud will exit(1) > when started using CIMI frontend. This patch will execute > the migration after mock dir cleanup. I don't understand why this is needed - the various moc

Re: [PATCH] CIMI: system and system_template support for mock driver, with unit tests. Just GET for now, no subcollections

2013-02-19 Thread David Lutterkort
On Tue, 2013-02-19 at 13:59 +1100, di...@fast.au.fujitsu.com wrote: > From: Dies Koper ACK, with a few comments and suggestions for changes before commit: > diff --git a/server/lib/cimi/collections/system_templates.rb > b/server/lib/cimi/collections/system_templates.rb > new file mode 100644 >

Re: [PATCH] rename vsp to networkPort

2013-02-19 Thread David Lutterkort
On Mon, 2013-02-18 at 17:05 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK & pushed. I assume there's some more work connected to this rename for the webapp. It's unfortunate that we do not have any unit tests for network_ports ... somebody should write them. David

Re: [PATCH 2/2] renaming vsp to network and removing CIMI client vsp view files

2013-02-19 Thread David Lutterkort
On Mon, 2013-02-18 at 15:27 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/app.rb|4 > clients/cimi/lib/entities.rb |3 --- > server/lib/cimi/models/network_port.rb | 34 > > 3 file

Re: [PATCH 1/2] changed routing_group to forwarding_group

2013-02-19 Thread David Lutterkort
On Mon, 2013-02-18 at 15:27 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK and pushed. David

Re: [PATCH] CIMI webapp: creating new volume configs

2013-02-19 Thread David Lutterkort
On Wed, 2013-02-13 at 13:08 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/lib/entities/volume_configuration.rb | 20 ++ > clients/cimi/views/machine_templates/index.haml| 12 > .../cimi/views/volume_configurations/index.haml|

Re: [PATCH] routes and view files for forwarding_groups and forwarding_group_templates

2013-02-19 Thread David Lutterkort
On Wed, 2013-02-13 at 13:08 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo This seems to be mostly the same as the 3 patches you sent previously (and that we neglected to commit); if there is anything that you'd like to commit on top of them, please rebase/resend the patch. David

Re: [PATCH] CIMI Webapp - Creating volume_images

2013-02-19 Thread David Lutterkort
On Wed, 2013-02-13 at 13:08 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/lib/entities/volume_image.rb | 21 + > clients/cimi/views/volume_images/index.haml | 26 ++ > 2 files changed, 47 insertions(+) When I

Re: [PATCH 3/3] DTACLOUD_404 Added view file for machine disks

2013-02-19 Thread David Lutterkort
On Tue, 2013-01-22 at 11:39 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK & pushed. One comment: > diff --git a/clients/cimi/lib/entities/machine.rb > b/clients/cimi/lib/entities/machine.rb > index 941f738..2708e4b 100644 > --- a/clients/cimi/lib/entities/machine.rb > +++ b/cl

Re: [PATCH 2/3] DTACLOUD-409 added forward_group view files and forward_group.rb to entities

2013-02-19 Thread David Lutterkort
On Tue, 2013-01-22 at 11:39 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo ACK & pushed David

Re: [PATCH 1/3] DTACLOUD-409: added forward_group_template view files and forward_group_template.rb to entities

2013-02-19 Thread David Lutterkort
On Tue, 2013-01-22 at 11:39 +0300, martha.c.ch...@gmail.com wrote: > From: NjeriChelimo > > --- > clients/cimi/app.rb|1 + > clients/cimi/lib/entities.rb |1 + > .../cimi/lib/entities/forwarding_group_template.rb | 30 > +++

Re: [PATCH core 7/7] CIMI: Print warning for pending migrations

2013-02-19 Thread David Lutterkort
On Tue, 2013-02-19 at 10:10 +0100, Michal Fojtik wrote: > > * do we really need a separate deltacloud-db-upgrade script rather > > than just the rake task ? I don't have an issue with requiring > > that people have rake on their prod systems (what's good enough > > for

Re: [PATCH core 7/7] CIMI: Print warning for pending migrations

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > We don't want to run any migrations automatically during > Deltacloud server boot time, to give users chance to backup > data, etc. > > This patch will provide a nice warning message if you start > Deltacloud

Re: [PATCH core 6/7] Core: Re-use deltacloud-db-migrate in the Rake task

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/Rakefile | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) ACK; should also be squashed into something (1/7 ?) David

Re: [PATCH core 5/7] Core: Fix rake mock:fixtures:reset tasks to cleanup correct dir

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/Rakefile | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) ACK(ish) .. I'd rather make running the initializers part of an intern

Re: [PATCH core 4/7] Core: Don't run migrations when server starts

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Users can now run migrations using: > > - bin/deltacloud-db-upgrade > - rake db:migrate > > Signed-off-by: Michal fojtik ACK. Should be squashed into 1/7 David

Re: [PATCH core 3/7] Core: Moved migrations to server/db/migrations

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > .../migrations/1_add_realm_to_machine_template.rb | 23 > ++ > .../migrations/1_add_realm_to_machine_template.rb | 23 > -- >

Re: [PATCH core 2/7] CIMI: Add support for 'realm' in MachineTemplate

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Clients can now specify the 'realm' attribute when > creating the new MachineTemplate entity. If they then use > this MachineTemplate to create a new Machine, the Machine > will be placed into that realm. > >

Re: [PATCH core 1/7] Core: Added support for migrations to database

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 16:27 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Currently everytime we add or remove attributes from > DB, users need to rerun the 'rake' task to recreate the > database. > > This patch will make possible to update the DB schema > without executing the rake

Re: [PATCH core 8/8] Mock: Cleanup in MockDriver code

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > - Removed obsoleted 'requires' (yaml, base64, etc) > - REALMS moved to 'realms' method > - @@METRICS_NAMES moved to Metric model > - Revamped 'filter_on' methods > - Next 'id' generation moved to separate metho

Re: [PATCH core 7/8] Tests: Be more verbose when checking state in Mock tests

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > The XML should reflect the state change of an Instance. > Instead of checking the status code returned we should also > verify the XML. > > Signed-off-by: Michal fojtik > --- > server/tests/deltacloud/collec

Re: [PATCH core 6/8] Mock: Cleanup in how we create mock 'metrics'

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Moved the code to the Metric model to keep MockDriver > clean. > > Signed-off-by: Michal fojtik > --- > server/lib/deltacloud/models/metric.rb | 45 > ++ > 1 file changed, 45

Re: [PATCH core 5/8] Mock: Require 'yaml' in client instead of driver

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > The YAML is really required in MockClient (I think this > require is not required here anyway ;-) > > This patch will also make .store() method return the stored > object, so in driver we don't need to create

Re: [PATCH core 4/8] Core: Added possibility to run filter_on with multiple attrs

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > So instead of writing: > > instances = filter_on instances, :id, opts > instances = filter_on instances, :realm_id, opts > instances = filter_on instances, :state, opts > > You can now use: > > instances = f

Re: [PATCH core 3/8] Core: Added possibility to define multiple features for collection

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > Instead of: > > feature :collection, :name > feature :collection, :second_name > > You can now use: > > feature :collection, :name, :second_name, ... > > Signed-off-by: Michal fojtik > --- > server/lib/de

Re: [PATCH core 2/8] Tests: Removed debugging 'puts' from openstack tests

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik ACK

Re: [PATCH core 1/8] Core: Fix rake mock:fixtures:reset tasks to cleanup correct dir

2013-02-18 Thread David Lutterkort
On Mon, 2013-02-18 at 14:41 +0100, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik ACK, though I prefer the patch I sent for this, since it relies on the initializers doing their thing rather than redoing it in the Rakefile (even if it's just one line now) D

  1   2   3   4   5   6   >