[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/deltaspike/pull/49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268766#comment-15268766
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user asfgit closed the pull request at:

https://github.com/apache/deltaspike/pull/49


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

[Gerhard Petracek]

hi @ all,

the comment in the discussion was:
we used to do it that way, but it isn't the case any longer in some areas.

regards,
gerhard



2016-05-03 15:12 GMT+02:00 manovotn :

> Github user manovotn commented on a diff in the pull request:
>
> https://github.com/apache/deltaspike/pull/49#discussion_r61877744
>
> --- Diff: deltaspike/parent/pom.xml ---
> @@ -49,7 +49,8 @@
>  
>  1.6
>  1.2.7
> -1.1.28.Final
> +
> +1.1.9.Final
> --- End diff --
>
> This is based on a Gerhard's comment. He claimed that the idea is to
> list the minimal supported version. Although I strongly dislike dislike
> this approach, I put it here.
> However if you look into Weld1 profile, you can see it is overriden by
> current version (1.1.33.Final). So this version declaration is naught but a
> mere information :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

[manovotn]

Github user manovotn commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61877744
  
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
 
 1.6
 1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --

This is based on a Gerhard's comment. He claimed that the idea is to list 
the minimal supported version. Although I strongly dislike dislike this 
approach, I put it here.
However if you look into Weld1 profile, you can see it is overriden by 
current version (1.1.33.Final). So this version declaration is naught but a 
mere information :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268672#comment-15268672
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user manovotn commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61877744
  
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
 
 1.6
 1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --

This is based on a Gerhard's comment. He claimed that the idea is to list 
the minimal supported version. Although I strongly dislike dislike this 
approach, I put it here.
However if you look into Weld1 profile, you can see it is overriden by 
current version (1.1.33.Final). So this version declaration is naught but a 
mere information :)


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1138) FutureableTest not compatible with weld v1.x

[John D. Ament (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268651#comment-15268651
 ] 

John D. Ament commented on DELTASPIKE-1138:
---

[~manovotn] please create a separate issue.  This one covered the fact that the 
tests failed outright (JVM stopped).  

> FutureableTest not compatible with weld v1.x
> 
>
> Key: DELTASPIKE-1138
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1138
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.6.1
>Reporter: Gerhard Petracek
>Assignee: Romain Manni-Bucau
> Fix For: 1.6.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

[johnament]

Github user johnament commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61874887
  
--- Diff: deltaspike/parent/code/pom.xml ---
@@ -41,7 +41,7 @@
 
1.0.2.Final
 3.1.2.2
 4.0
-12.1
+12.1   
--- End diff --

please clean up the whitespace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268643#comment-15268643
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


Github user johnament commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61874873
  
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
 
 1.6
 1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --

why downgrade?


> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

[johnament]

Github user johnament commented on a diff in the pull request:

https://github.com/apache/deltaspike/pull/49#discussion_r61874873
  
--- Diff: deltaspike/parent/pom.xml ---
@@ -49,7 +49,8 @@
 
 1.6
 1.2.7
-1.1.28.Final
+
+1.1.9.Final
--- End diff --

why downgrade?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (DELTASPIKE-1138) FutureableTest not compatible with weld v1.x

[Matej Novotny (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268604#comment-15268604
 ] 

Matej Novotny commented on DELTASPIKE-1138:
---

I do not have the rights to re-open this issue, though we are not yet done with 
this one. There is still a problem which affects at least two DS features - 
@Futureable and @Locked.
Both of them have an interceptor enabled in DS core jar file (via beans.xml). 
However this will not work with CDI 1.0/Weld 1.x! 
The reason is the eternal holy war for what exactly is a 'bean archive' :-). 
Weld will consider the interceptor enabled only for the core jar itself hence 
it will not kick in.

How to reproduce:
* Run DS on JBoss AS 7 (JDK 1.7 or lower) or EAP 6 (all JDKs)
** {{mvn clean verify -Pjbossas-build-managed-7 -Dweld.version=1.1.33.Final 
-Dtest=FutureableTest}}
* To make the test pass, you can add {{beans.xml}} containing the interceptor 
[here|https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/test/java/org/apache/deltaspike/test/core/impl/future/FutureableTest.java#L45]
 (same work for LockedTest)
** *The above trick is not a fix though!* Merely a workaround allowing Weld to 
enable the interceptor within test archive
** I think any user aiming to use these features with Weld 1.x would need to 
use this workaround in his/her deployments which is ugly

Notes:
* {{@Priority}} cannot be used here (for CDI 1.0)
* GlobalInterceptorExtension won't help either as it is working since CDI 1.1+
* This is not a problem for embedded container (e.g. running via {{-PWeld1}})
** This is probably because of different structure of embedded deployments

> FutureableTest not compatible with weld v1.x
> 
>
> Key: DELTASPIKE-1138
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1138
> Project: DeltaSpike
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.6.1
>Reporter: Gerhard Petracek
>Assignee: Romain Manni-Bucau
> Fix For: 1.6.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-1091) Weld core BOM update in next 2.3/3.x release

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268335#comment-15268335
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:


GitHub user manovotn opened a pull request:

https://github.com/apache/deltaspike/pull/49

DELTASPIKE-1091 add default values to Weld profiles.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manovotn/deltaspike weldProfiles

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/deltaspike/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit 1482edcdc9fa7f7727b1169b74a83766c0d74b58
Author: Matej Novotny 
Date:   2016-05-03T08:04:53Z

DELTASPIKE-1091 add default values to Weld profiles.




> Weld core BOM update in next 2.3/3.x release
> 
>
> Key: DELTASPIKE-1091
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Build
>Reporter: Matej Novotny
>Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] deltaspike pull request: DELTASPIKE-1091 add default values to Wel...

[manovotn]

GitHub user manovotn opened a pull request:

https://github.com/apache/deltaspike/pull/49

DELTASPIKE-1091 add default values to Weld profiles.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manovotn/deltaspike weldProfiles

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/deltaspike/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit 1482edcdc9fa7f7727b1169b74a83766c0d74b58
Author: Matej Novotny 
Date:   2016-05-03T08:04:53Z

DELTASPIKE-1091 add default values to Weld profiles.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---