Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread Mark Struberg
Txs! We also need to update the release docs. We don't need any profile during release anymore now. LieGrue, Strub > Am 29.05.2017 um 02:53 schrieb John D. Ament : > > We can look at it later, its not blocking for now. I created >

Re: [VOTE] Apache DeltaSpike 1.8.0 - 2nd take

2017-05-28 Thread Christian Kaltepoth
+1 Am 29.05.2017 02:53 schrieb "John D. Ament" : > +1 > > On Sun, May 28, 2017 at 6:42 AM Mark Struberg > wrote: > > > Hi! > > > > I just rerolled the release. > > release branch and tag again staged at my github account > >

Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread John D. Ament
We can look at it later, its not blocking for now. I created https://issues.apache.org/jira/browse/DELTASPIKE-1257 to track. On Sun, May 28, 2017 at 11:36 AM Mark Struberg wrote: > The error I got was something else. This happened even with the > distribution

Re: [VOTE] Apache DeltaSpike 1.8.0 - 2nd take

2017-05-28 Thread John D. Ament
+1 On Sun, May 28, 2017 at 6:42 AM Mark Struberg wrote: > Hi! > > I just rerolled the release. > release branch and tag again staged at my github account > https://github.com/struberg/deltaspike/tree/release_deltaspike_1.8.0 > > Staging repo is > >

[jira] [Created] (DELTASPIKE-1257) Research why BOM isn't working right in a release

2017-05-28 Thread John D. Ament (JIRA)
John D. Ament created DELTASPIKE-1257: - Summary: Research why BOM isn't working right in a release Key: DELTASPIKE-1257 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1257 Project:

[jira] [Updated] (DELTASPIKE-1257) Research why BOM isn't working right in a release

2017-05-28 Thread John D. Ament (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John D. Ament updated DELTASPIKE-1257: -- Fix Version/s: 1.8.1 > Research why BOM isn't working right in a release >

[jira] [Updated] (DELTASPIKE-1257) Research why BOM isn't working right in a release

2017-05-28 Thread John D. Ament (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John D. Ament updated DELTASPIKE-1257: -- Affects Version/s: 1.8.0 > Research why BOM isn't working right in a release >

Re: [VOTE] Apache DeltaSpike 1.8.0 - 2nd take

2017-05-28 Thread Jason Porter (lightguardjp)
+1 Get Outlook for iOS On Sun, May 28, 2017 at 4:42 AM -0600, "Mark Struberg" wrote: Hi! I just rerolled the release.

Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread Mark Struberg
The error I got was something else. This happened even with the distribution profile. Maven complained that the bom pom points to an illegal parent pom (warning) and kept complaining about 'unresolved snaphots left' asking me to specify the version for the various deltaspike modules. Maybe

Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread John D. Ament
I think that was the goal of the requestor's ask: - Not provide a bad bom - Only bring in our stuff DeltaSpike is very odd in the landscape, we don't directly declare dependencies. That's what makes a bom like this very useful and easy to manage, it doesn't bring in anything else. What would

Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread Romain Manni-Bucau
I'm kind of sharing Mark's feedback, each time I tried to use it (arquillian, spring, ...) it just had a very bad user experience after the first manually added dependency so not sure it does worth all the tricks the build would require or if we even really want to propose it to end users.

Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread Mark Struberg
Except that it broke Maven. In general I find this bom very questionable. Why would one use that? Usually boms get created as 'mashup' project to combine different separately released artifacts And there almost exclusively to pin down the versions of those various artifacts. So why would one

Re: [1/2] deltaspike git commit: further release fixes

2017-05-28 Thread John D. Ament
Mark, On Sun, May 28, 2017 at 6:37 AM wrote: > Repository: deltaspike > Updated Branches: > refs/heads/master 6721ca6ec -> a62a93fca > > > further release fixes > > > Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo > Commit:

Re: [2/2] deltaspike git commit: clean up superfluous stuff in our poms

2017-05-28 Thread John D. Ament
This is actually pretty import to keep, all of the dependencies in the dist pom. Without these with the explicit scope of compile, the remaining targets won't work correctly. On Sun, May 28, 2017 at 6:37 AM wrote: > clean up superfluous stuff in our poms > > yet another

[VOTE] Apache DeltaSpike 1.8.0 - 2nd take

2017-05-28 Thread Mark Struberg
Hi! I just rerolled the release. release branch and tag again staged at my github account https://github.com/struberg/deltaspike/tree/release_deltaspike_1.8.0 Staging repo is https://repository.apache.org/content/repositories/orgapachedeltaspike-1045/ Source release is

Re: [VOTE] [CANCEL] Release Apache DeltaSpike-1.8.0

2017-05-28 Thread Mark Struberg
Hi John! > I'd recommend just running a mvn deploy -Pdistribution from the 1.8.0 tag, > that should resolve this. Sadly not. Since the dist modules only get added conditionally they didn't even have been included in the version bump. So they are still on the 1.8.0-SNAPSHOT. I gonna clean up