[jira] [Commented] (DELTASPIKE-1411) Add New Config Keys for ProjectStage Detection

2020-06-02 Thread Mark Struberg (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124631#comment-17124631
 ] 

Mark Struberg commented on DELTASPIKE-1411:
---

Good idea, do you want to ship a PR?

> Add New Config Keys for ProjectStage Detection
> --
>
> Key: DELTASPIKE-1411
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1411
> Project: DeltaSpike
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Core
>Reporter: Syed Shah
>Priority: Trivial
>
> Currently, the `ProjectStageProducer` just has a hard-coded array of keys it 
> can check to identity the `ProjectStage`. Could this be altered so the list 
> can have additional keys to seek out the configuration?
> This is trivial, but would be nice for frameworks using CDI Extensions and 
> DeltaSpike as a foundation, so they add their own key name for setting the 
> `ProjectStage` for a more consistent configuration rather than a one off 
> `org.apache.deltaspike...` key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (DELTASPIKE-1411) Add New Config Keys for ProjectStage Detection

2020-06-02 Thread Syed Shah (Jira)
Syed Shah created DELTASPIKE-1411:
-

 Summary: Add New Config Keys for ProjectStage Detection
 Key: DELTASPIKE-1411
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1411
 Project: DeltaSpike
  Issue Type: Improvement
  Security Level: public (Regular issues)
  Components: Core
Reporter: Syed Shah


Currently, the `ProjectStageProducer` just has a hard-coded array of keys it 
can check to identity the `ProjectStage`. Could this be altered so the list can 
have additional keys to seek out the configuration?

This is trivial, but would be nice for frameworks using CDI Extensions and 
DeltaSpike as a foundation, so they add their own key name for setting the 
`ProjectStage` for a more consistent configuration rather than a one off 
`org.apache.deltaspike...` key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [deltaspike] SethiPandi edited a comment on pull request #108: Corrected Typo in EntityManagerFactoryProducer and Corrected Logger Strings

2020-06-02 Thread GitBox


SethiPandi edited a comment on pull request #108:
URL: https://github.com/apache/deltaspike/pull/108#issuecomment-637934568


   I was meant to make it a separate PR but ended up doing it here instead, 
sorry.
   Also, two classes have the `Logger` construction with `.toString()` instead 
of `getName()` which causes the logger to be named  
   `class 
org.apache.deltaspike.beanvalidation.impl.CDIAwareConstraintValidatorFactory` 
   instead of 
   
`org.apache.deltaspike.beanvalidation.impl.CDIAwareConstraintValidatorFactory`
   for example.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [deltaspike] SethiPandi commented on pull request #108: Corrected Typo in EntityManagerFactoryProducer and Corrected Logger Strings

2020-06-02 Thread GitBox


SethiPandi commented on pull request #108:
URL: https://github.com/apache/deltaspike/pull/108#issuecomment-637934568


   I was meant to make it a separate PR but ended up doing it here instead.
   Also, two classes have the `Logger` construction with `.toString()` instead 
of `getName()` which causes the logger to be named  
   `class 
org.apache.deltaspike.beanvalidation.impl.CDIAwareConstraintValidatorFactory` 
   instead of 
   
`org.apache.deltaspike.beanvalidation.impl.CDIAwareConstraintValidatorFactory`
   for example.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [deltaspike] Daniel-Dos commented on pull request #106: DELTASPIKE-1404 - add some links for example and articles.

2020-06-02 Thread GitBox


Daniel-Dos commented on pull request #106:
URL: https://github.com/apache/deltaspike/pull/106#issuecomment-637837660


   your welcome Mark : )



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (DELTASPIKE-1397) Detect the cycled variable references

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123947#comment-17123947
 ] 

ASF subversion and git services commented on DELTASPIKE-1397:
-

Commit da93fe7882bfaaa816daba7a71401a21823d4e92 in deltaspike's branch 
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=da93fe7 ]

DELTASPIKE-1397 log variable in case of recursive definition


> Detect the cycled variable references
> -
>
> Key: DELTASPIKE-1397
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1397
> Project: DeltaSpike
>  Issue Type: Wish
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.1
> Environment: JDK 1.8
>Reporter: Andrew Marinchuk
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Due to mistake in config file, we encountered the 
> java.lang.StackOverflowError.
> {code:title=properties}fs.docs.path=/opt/docsFolder
> fs.docs.path.IntegrationTest=/mnt/targetDocs
> fs.docs.path.Staging=${fs.docs.path.IntegrationTest}
> fs.docs.path.IntegrationTest=${fs.docs.path.IntegrationTest} <--- here is 
> invalid copy-pasted string
> fs.docs.path.Production=${fs.docs.path.IntegrationTest}{code}{code:title=stack
>  trace}
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(TypedResolverImpl.java:556)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getPropertyValue(TypedResolverImpl.java:590)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveStringValue(TypedResolverImpl.java:436)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(TypedResolverImpl.java:556)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getPropertyValue(TypedResolverImpl.java:590)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveStringValue(TypedResolverImpl.java:436)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  {code}
> It's very hard to find the configuration variable with a self-referencing 
> problem because StackOverflowError's message does not contain information 
> about variable with problem.
> Wrapping each TypedResolver.getValue()'s call into try-catch is not the best 
> practice in app code, but it's possible to detect the simplest 
> self-referencing issues in 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(String).
> The better (but much expensive) way is to track the reference chain during 
> resolving variables or catching the StackOverflowError in library's code 
> (it's not a good practice and will not help to find the core of reference 
> loop because try-catch should be done at the first TypedResolver.getValue()'s 
> call).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (DELTASPIKE-1397) Detect the cycled variable references

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1397.
---
Resolution: Fixed

txs for the report, hopefully fixed in a usable way.

> Detect the cycled variable references
> -
>
> Key: DELTASPIKE-1397
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1397
> Project: DeltaSpike
>  Issue Type: Wish
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.1
> Environment: JDK 1.8
>Reporter: Andrew Marinchuk
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Due to mistake in config file, we encountered the 
> java.lang.StackOverflowError.
> {code:title=properties}fs.docs.path=/opt/docsFolder
> fs.docs.path.IntegrationTest=/mnt/targetDocs
> fs.docs.path.Staging=${fs.docs.path.IntegrationTest}
> fs.docs.path.IntegrationTest=${fs.docs.path.IntegrationTest} <--- here is 
> invalid copy-pasted string
> fs.docs.path.Production=${fs.docs.path.IntegrationTest}{code}{code:title=stack
>  trace}
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(TypedResolverImpl.java:556)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getPropertyValue(TypedResolverImpl.java:590)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveStringValue(TypedResolverImpl.java:436)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(TypedResolverImpl.java:556)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getPropertyValue(TypedResolverImpl.java:590)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveStringValue(TypedResolverImpl.java:436)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  {code}
> It's very hard to find the configuration variable with a self-referencing 
> problem because StackOverflowError's message does not contain information 
> about variable with problem.
> Wrapping each TypedResolver.getValue()'s call into try-catch is not the best 
> practice in app code, but it's possible to detect the simplest 
> self-referencing issues in 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(String).
> The better (but much expensive) way is to track the reference chain during 
> resolving variables or catching the StackOverflowError in library's code 
> (it's not a good practice and will not help to find the core of reference 
> loop because try-catch should be done at the first TypedResolver.getValue()'s 
> call).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1358) Move shaded ASM classes from proxy-impl into a separate JAR

2020-06-02 Thread Christian Beikov (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123922#comment-17123922
 ] 

Christian Beikov commented on DELTASPIKE-1358:
--

Sure, keeping it up-to-date and doing the releases is fine for me.

> Move shaded ASM classes from proxy-impl into a separate JAR
> ---
>
> Key: DELTASPIKE-1358
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1358
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Proxy-Module
>Reporter: Christian Beikov
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> The intention behind this is that this would allow me to have a local Maven 
> module that shades a new version of ASM. Right now, I'd have to checkout 
> deltaspike, update the ASM version in the proxy module, and build that 
> separately. It would be great if switching ASM versions could be made easier 
> this way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DELTASPIKE-1397) Detect the cycled variable references

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated DELTASPIKE-1397:
--
Fix Version/s: 1.9.4

> Detect the cycled variable references
> -
>
> Key: DELTASPIKE-1397
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1397
> Project: DeltaSpike
>  Issue Type: Wish
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.1
> Environment: JDK 1.8
>Reporter: Andrew Marinchuk
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Due to mistake in config file, we encountered the 
> java.lang.StackOverflowError.
> {code:title=properties}fs.docs.path=/opt/docsFolder
> fs.docs.path.IntegrationTest=/mnt/targetDocs
> fs.docs.path.Staging=${fs.docs.path.IntegrationTest}
> fs.docs.path.IntegrationTest=${fs.docs.path.IntegrationTest} <--- here is 
> invalid copy-pasted string
> fs.docs.path.Production=${fs.docs.path.IntegrationTest}{code}{code:title=stack
>  trace}
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(TypedResolverImpl.java:556)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getPropertyValue(TypedResolverImpl.java:590)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveStringValue(TypedResolverImpl.java:436)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(TypedResolverImpl.java:556)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getPropertyValue(TypedResolverImpl.java:590)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveStringValue(TypedResolverImpl.java:436)
>  
> at 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.getValue(TypedResolverImpl.java:253)
>  {code}
> It's very hard to find the configuration variable with a self-referencing 
> problem because StackOverflowError's message does not contain information 
> about variable with problem.
> Wrapping each TypedResolver.getValue()'s call into try-catch is not the best 
> practice in app code, but it's possible to detect the simplest 
> self-referencing issues in 
> org.apache.deltaspike.core.impl.config.TypedResolverImpl.resolveVariables(String).
> The better (but much expensive) way is to track the reference chain during 
> resolving variables or catching the StackOverflowError in library's code 
> (it's not a good practice and will not help to find the core of reference 
> loop because try-catch should be done at the first TypedResolver.getValue()'s 
> call).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (DELTASPIKE-1358) Move shaded ASM classes from proxy-impl into a separate JAR

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1358.
---
Resolution: Fixed

> Move shaded ASM classes from proxy-impl into a separate JAR
> ---
>
> Key: DELTASPIKE-1358
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1358
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Proxy-Module
>Reporter: Christian Beikov
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> The intention behind this is that this would allow me to have a local Maven 
> module that shades a new version of ASM. Right now, I'd have to checkout 
> deltaspike, update the ASM version in the proxy module, and build that 
> separately. It would be great if switching ASM versions could be made easier 
> this way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1358) Move shaded ASM classes from proxy-impl into a separate JAR

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123884#comment-17123884
 ] 

ASF subversion and git services commented on DELTASPIKE-1358:
-

Commit b6fdf21c46a32c6f8a460f09728ab5ed6274ba95 in deltaspike's branch 
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=b6fdf21 ]

DELTASPIKE-1358 upgrade to ASM-8.0.1


> Move shaded ASM classes from proxy-impl into a separate JAR
> ---
>
> Key: DELTASPIKE-1358
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1358
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Proxy-Module
>Reporter: Christian Beikov
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> The intention behind this is that this would allow me to have a local Maven 
> module that shades a new version of ASM. Right now, I'd have to checkout 
> deltaspike, update the ASM version in the proxy module, and build that 
> separately. It would be great if switching ASM versions could be made easier 
> this way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1358) Move shaded ASM classes from proxy-impl into a separate JAR

2020-06-02 Thread Mark Struberg (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123881#comment-17123881
 ] 

Mark Struberg commented on DELTASPIKE-1358:
---

I gonna update to ASM-8.0.1 for now. And we should keep this on the latest 
version consequently for some time.
Is this sufficient?


> Move shaded ASM classes from proxy-impl into a separate JAR
> ---
>
> Key: DELTASPIKE-1358
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1358
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Proxy-Module
>Reporter: Christian Beikov
>Priority: Major
>
> The intention behind this is that this would allow me to have a local Maven 
> module that shades a new version of ASM. Right now, I'd have to checkout 
> deltaspike, update the ASM version in the proxy module, and build that 
> separately. It would be great if switching ASM versions could be made easier 
> this way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (DELTASPIKE-1358) Move shaded ASM classes from proxy-impl into a separate JAR

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reassigned DELTASPIKE-1358:
-

Assignee: Mark Struberg

> Move shaded ASM classes from proxy-impl into a separate JAR
> ---
>
> Key: DELTASPIKE-1358
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1358
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Proxy-Module
>Reporter: Christian Beikov
>Assignee: Mark Struberg
>Priority: Major
>
> The intention behind this is that this would allow me to have a local Maven 
> module that shades a new version of ASM. Right now, I'd have to checkout 
> deltaspike, update the ASM version in the proxy module, and build that 
> separately. It would be great if switching ASM versions could be made easier 
> this way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DELTASPIKE-1358) Move shaded ASM classes from proxy-impl into a separate JAR

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated DELTASPIKE-1358:
--
Fix Version/s: 1.9.4

> Move shaded ASM classes from proxy-impl into a separate JAR
> ---
>
> Key: DELTASPIKE-1358
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1358
> Project: DeltaSpike
>  Issue Type: Improvement
>  Components: Proxy-Module
>Reporter: Christian Beikov
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> The intention behind this is that this would allow me to have a local Maven 
> module that shades a new version of ASM. Right now, I'd have to checkout 
> deltaspike, update the ASM version in the proxy module, and build that 
> separately. It would be great if switching ASM versions could be made easier 
> this way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (DELTASPIKE-1404) News links to post and examples.

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1404.
---
Resolution: Fixed

txs Daniel, PR merged!

> News links to post and examples.
> 
>
> Key: DELTASPIKE-1404
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1404
> Project: DeltaSpike
>  Issue Type: Task
>  Security Level: public(Regular issues) 
>  Components: Documentation
>Affects Versions: 1.9.3
>Reporter: Daniel Dias
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.9.4
>
> Attachments: DELTASPIKE-1404.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I created some content referring to Deltaspike as a lecture and articles and 
> I would like to include it on the site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1404) News links to post and examples.

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123873#comment-17123873
 ] 

ASF subversion and git services commented on DELTASPIKE-1404:
-

Commit 4a7f385c99a82afd821603303aa53944fa020e2f in deltaspike's branch 
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=4a7f385 ]

Merge pull request #106 from Daniel-Dos/DELTASPIKE-1404

DELTASPIKE-1404 - add some links for example and articles.

> News links to post and examples.
> 
>
> Key: DELTASPIKE-1404
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1404
> Project: DeltaSpike
>  Issue Type: Task
>  Security Level: public(Regular issues) 
>  Components: Documentation
>Affects Versions: 1.9.3
>Reporter: Daniel Dias
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.9.4
>
> Attachments: DELTASPIKE-1404.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I created some content referring to Deltaspike as a lecture and articles and 
> I would like to include it on the site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (DELTASPIKE-1404) News links to post and examples.

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reassigned DELTASPIKE-1404:
-

Assignee: Mark Struberg

> News links to post and examples.
> 
>
> Key: DELTASPIKE-1404
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1404
> Project: DeltaSpike
>  Issue Type: Task
>  Security Level: public(Regular issues) 
>  Components: Documentation
>Affects Versions: 1.9.3
>Reporter: Daniel Dias
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.9.4
>
> Attachments: DELTASPIKE-1404.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I created some content referring to Deltaspike as a lecture and articles and 
> I would like to include it on the site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1404) News links to post and examples.

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123871#comment-17123871
 ] 

ASF subversion and git services commented on DELTASPIKE-1404:
-

Commit e46933fc118279d4898fb5454519a8717fd8c4a1 in deltaspike's branch 
refs/heads/master from Daniel Dias
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=e46933f ]

DELTASPIKE-1404 - add some links for example and articles.


> News links to post and examples.
> 
>
> Key: DELTASPIKE-1404
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1404
> Project: DeltaSpike
>  Issue Type: Task
>  Security Level: public(Regular issues) 
>  Components: Documentation
>Affects Versions: 1.9.3
>Reporter: Daniel Dias
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.9.4
>
> Attachments: DELTASPIKE-1404.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I created some content referring to Deltaspike as a lecture and articles and 
> I would like to include it on the site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1404) News links to post and examples.

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123872#comment-17123872
 ] 

ASF subversion and git services commented on DELTASPIKE-1404:
-

Commit 4a7f385c99a82afd821603303aa53944fa020e2f in deltaspike's branch 
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=4a7f385 ]

Merge pull request #106 from Daniel-Dos/DELTASPIKE-1404

DELTASPIKE-1404 - add some links for example and articles.

> News links to post and examples.
> 
>
> Key: DELTASPIKE-1404
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1404
> Project: DeltaSpike
>  Issue Type: Task
>  Security Level: public(Regular issues) 
>  Components: Documentation
>Affects Versions: 1.9.3
>Reporter: Daniel Dias
>Assignee: Mark Struberg
>Priority: Minor
> Fix For: 1.9.4
>
> Attachments: DELTASPIKE-1404.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> I created some content referring to Deltaspike as a lecture and articles and 
> I would like to include it on the site.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [deltaspike] struberg merged pull request #106: DELTASPIKE-1404 - add some links for example and articles.

2020-06-02 Thread GitBox


struberg merged pull request #106:
URL: https://github.com/apache/deltaspike/pull/106


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (DELTASPIKE-1406) Usage of "SHA-256" and "AES" is insecure

2020-06-02 Thread Mark Struberg (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123870#comment-17123870
 ] 

Mark Struberg commented on DELTASPIKE-1406:
---

Basically I like the idea, but we should also have a fallback to still be able 
to read SHA-256 encrypted data.

> Usage of "SHA-256" and "AES" is insecure
> 
>
> Key: DELTASPIKE-1406
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1406
> Project: DeltaSpike
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>Reporter: Md Mahir Asef Kabir
>Priority: Major
>
> *Vulnerability Description:* In 
> “deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/crypto/DefaultCipherService.java”,
>  the following algorithms were set to use later - 
> {code:java}
> private static final String HASH_ALGORITHM = "SHA-256";
> private static final String CIPHER_ALGORITHM = "AES";
> {code}
> Here, SHA-256 and AES are vulnerable.
> *Reason it’s vulnerable:* According to 
> [this|https://soylentnews.org/article.pl?sid=19/09/10/2351241], SHA256 can be 
> broken.
> ”AES” is also not secure. For further reference, please follow 
> [this|https://zachgrace.com/posts/attacking-ecb/]
> *Suggested Fix:* The secure algorithms to set would be -
> {code:java}
> private static final String HASH_ALGORITHM = "SHA-512";
> private static final String CIPHER_ALGORITHM = "AES/CFB/PKCS5Padding";
> {code}
> *Feedback:* Please select any of the options down below to help us get an 
> idea about how you felt about the suggestion - 
> # Liked it and will make the suggested changes
> # Liked it but happy with the existing version
> # Didn’t find the suggestion helpful



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime

2020-06-02 Thread Mark Struberg (Jira)


 [ 
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved DELTASPIKE-1402.
---
  Assignee: Mark Struberg
Resolution: Fixed

> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during 
> runtime
> 
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Assignee: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via 
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
>  does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes 
> in this file.
> The same is true for other 
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most 
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk 
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the 
> last-changed timestamp of the file and only checked every minute or so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime

2020-06-02 Thread Mark Struberg (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123867#comment-17123867
 ] 

Mark Struberg commented on DELTASPIKE-1402:
---

[~romain.manni-bucau] For disabling reload you can set {{deltaspike_reload=-1}} 
inside the property file. On almost every box the file metadata is heavily 
cached. So checking the lastModified is very cheap anyway. I've done quite a 
few perf tests on Linux, OSX and Win. All look fine.

> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during 
> runtime
> 
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via 
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
>  does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes 
> in this file.
> The same is true for other 
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most 
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk 
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the 
> last-changed timestamp of the file and only checked every minute or so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


need some additional eyes on a randomly failing partial-bean test in Wildfly

2020-06-02 Thread Mark Struberg
hi folks!

I've hit some random errors in the module partial-bean-impl.

Just let the following command run a few times

$> mvn clean install -Pwildfly-build-managed -f 
modules/partial-bean/impl/pom.xml


Caused by: java.lang.IllegalStateException: Could not find beans for 
Type=interface org.apache.deltaspike.test.core.api.partialbean.uc009.TestConfig 
and qualifiers:[]
at 
org.apache.deltaspike.core.api.provider.BeanProvider.getContextualReference(BeanProvider.java:154)
at 
org.apache.deltaspike.core.api.provider.BeanProvider.getContextualReference(BeanProvider.java:121)
at 
org.apache.deltaspike.core.api.provider.BeanProvider.getContextualReference(BeanProvider.java:100)
at 
org.apache.deltaspike.partialbean.impl.DeltaSpikePartialProducerLifecycle.create(DeltaSpikePartialProducerLifecycle.java:43)
at 
org.apache.deltaspike.core.util.bean.ImmutableBean.create(ImmutableBean.java:72)
at 
org.jboss.weld.context.unbound.DependentContextImpl.get(DependentContextImpl.java:70)

But not every time. Sometimes it also passes. 
This does not happen with Weld standalone, OWB and TomEE. Need to check other 
servers still.

Anyone up to lend a hand?

LieGrue,
strub

[jira] [Commented] (DELTASPIKE-1410) Support for CdiAwareExecutorService

2020-06-02 Thread Mark Struberg (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123701#comment-17123701
 ] 

Mark Struberg commented on DELTASPIKE-1410:
---

Hi!

passing Request Context objects to another thread is problematic.
The main problem is that any {{@RequestScoped}} object is guaranteed to be only 
accessed from a single thread at a time. But if you have concurrent threads, 
then this guarantee cannot be fulfilled.

Often you also do not want to propagate all RequestScoped Contextual Instances 
but only a few certain ones. Like the current User etc.

> Support for CdiAwareExecutorService
> ---
>
> Key: DELTASPIKE-1410
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1410
> Project: DeltaSpike
>  Issue Type: New Feature
>  Security Level: public(Regular issues) 
>  Components: Core
>Reporter: Syed Shah
>Priority: Trivial
>
> Not sure if this is appropriate for the DeltaSpike project, but it'd be 
> helpful if DeltaSpike provided a CdiAwareExecutorService that could 
> automatically propagate the current request context down to any runnables 
> passed down to spawned threads.
> Is this something that could be added?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123526#comment-17123526
 ] 

ASF subversion and git services commented on DELTASPIKE-1402:
-

Commit 5ffcaf3b8243586e9a479f7a7e554a34c7669844 in deltaspike's branch 
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=5ffcaf3 ]

DELTASPIKE-1402 wait a bit longer

sadly a few file systems have a bigger lastModified granularity.
So we better wait a bit longer.


> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during 
> runtime
> 
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via 
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
>  does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes 
> in this file.
> The same is true for other 
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most 
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk 
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the 
> last-changed timestamp of the file and only checked every minute or so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime

2020-06-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123428#comment-17123428
 ] 

ASF subversion and git services commented on DELTASPIKE-1402:
-

Commit 118b9d3e63970fb94038d6f9379f9c261b4e609b in deltaspike's branch 
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=118b9d3 ]

DELTASPIKE-1402 add a way to disable dynamic reloading

by using a deltaspike_reload smaller 0 you can disable dynamic reloading.


> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during 
> runtime
> 
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via 
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
>  does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes 
> in this file.
> The same is true for other 
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most 
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk 
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the 
> last-changed timestamp of the file and only checked every minute or so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)