Re: [Discuss] Data Module - Transactional Repositories

2014-02-17 Thread Thomas Hug
Ok with 3) you basically mean we don't rely on @Transactional, but rather on the TransactionStrategy? Sounds fine too. Would require some tricks to bridge from InvocationHandler to InvocationContext, and then again having the TXStrategy pick up the repository EM (haven't checked yet what that means

Re: [Discuss] Data Module - Transactional Repositories

2014-02-16 Thread Romain Manni-Bucau
Hello, 1) a producer + qualifier would be easier on entitymanager side so I'd propagate it to the repository. 2) em in transactionscoped should be useless since if you produce the em you are already in a scope so already cached by CDI itself, no? 3) we don't really need interceptors since we can i

Re: [Discuss] Data Module - Transactional Repositories

2014-02-16 Thread Thomas Hug
Yes would be great to get this sorted out soon. Looks like 2) is the preferred way to go, which would also mean some work on the JPA module. - Any thoughts on how the Data EntityManagerResolver fits in the picture there? - Also [1] seems rather nasty in this context. Is there a better way dealing

Re: [Discuss] Data Module - Transactional Repositories

2014-02-16 Thread Romain Manni-Bucau
Hi Thomas, would be great to get it in 0.6, any idea if it would be possible? I should be able to help once decided and if needed. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau

Re: [Discuss] Data Module - Transactional Repositories

2014-02-12 Thread Romain Manni-Bucau
While it works with JTA it is ok for me, I think it should be compatible with our @Transactional and EE 7 one. I think reusing @Transactional is important in declaration (on method) so maybe the way to go. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: ht

Re: [Discuss] Data Module - Transactional Repositories

2014-02-12 Thread Jean-Louis MONTEIRO
+1 for 2/ as well. That is right from an end user experience point of view. Also right to reuse and put in common some parts of JPA and Data module Closer to Java EE 7 @Transactional approach JLouis 2014-02-12 11:20 GMT+01:00 Thomas Hug : > Not sure where we stopped in the discussion but AFAIR

[Discuss] Data Module - Transactional Repositories

2014-02-12 Thread Thomas Hug
Not sure where we stopped in the discussion but AFAIR we had two approaches here: 1) An automatic internal tx handling if one is needed by the query, probably similar to what the JPA module does in the EnvironmentAwareTransactionStrategy. Could eventually be controlled by an attribute on @Reposito