bdemers commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-2062601466
@symphony-enrico Sorry again for the delay, I hadn't forgot about this, it's
a great addition to SCIMple!
--
This is an automated message from the Apache Git Service.
To
bdemers merged PR #541:
URL: https://github.com/apache/directory-scimple/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
symphony-enrico commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-2049279530
> I should have some time later this week to get this merged and a release
kicked off. (Well the merge part is easy, but I want to play around with it a
little and write
bdemers commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-2007505146
I should have some time later this week to get this merged and a release
kicked off.
(Well the merge part is easy, but I want to play around with it a little and
write up
symphony-enrico commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-2003448861
any chances to merge it (and release) if there are no blocking point? Thanks
a lot
--
This is an automated message from the Apache Git Service.
To respond to the
symphony-enrico commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1999224254
> Maybe this is something that should be abstracted out?
thank you, I understand. No, for now I dont have suggestions but I am just
discovering the framework...
bdemers commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1997604195
@symphony-enrico SCIMple's ETag support is an area that I think could be
improved. (and this Pull Request is very. appreciated in moving that forward!!)
SCIMple
symphony-enrico commented on code in PR #541:
URL: https://github.com/apache/directory-scimple/pull/541#discussion_r1524509240
##
scim-core/src/main/java/org/apache/directory/scim/core/repository/Repository.java:
##
@@ -69,14 +70,14 @@ public interface Repository {
*
*
symphony-enrico commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1996895797
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
symphony-enrico commented on code in PR #541:
URL: https://github.com/apache/directory-scimple/pull/541#discussion_r1524470637
##
scim-core/src/main/java/org/apache/directory/scim/core/repository/Repository.java:
##
@@ -69,14 +70,14 @@ public interface Repository {
*
*
bdemers commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1995338796
This looks great @symphony-enrico!
One last quick comment about the weak etag
--
This is an automated message from the Apache Git Service.
To respond to the message, please
bdemers commented on code in PR #541:
URL: https://github.com/apache/directory-scimple/pull/541#discussion_r1523752504
##
scim-core/src/main/java/org/apache/directory/scim/core/repository/Repository.java:
##
@@ -69,14 +70,14 @@ public interface Repository {
*
*
*
symphony-enrico commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1995055299
> @symphony-enrico I like it! I think the `ETag` object makes it clear what
it's intent is!
>
> Should the `List` be a `Set`? It probably doesn't matter much in
bdemers commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1994423009
@symphony-enrico I like it! I think the `ETag` object makes it clear what
it's intent is!
Should the `List` be a `Set`? It probably doesn't matter much in this
context,
symphony-enrico commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1993888550
> Maybe this is something that should be abstracted out?
In my repository implementation I process version in this way:
```java
/**
* Version
bdemers commented on PR #541:
URL:
https://github.com/apache/directory-scimple/pull/541#issuecomment-1991994026
Along with this we may want to tweak the text in the `Repository.update`
methods, some of the nuance that goes along with this? This value could
potentially be a comma separated
16 matches
Mail list logo
