Re: project & checkstyle update

2021-05-16 Thread Emmanuel Lécharny
Go ahead ! On 16/05/2021 17:45, Stefan Seelmann wrote: On 5/11/21 4:06 AM, Emmanuel Lécharny wrote: I will commit my changes in project-45 and checkstyle-configuration-2.0.1 if no one objects. I'd release the checkstyle-configuration-2.0.1 or to be more precise the buildtools project, ok?

Re: project & checkstyle update

2021-05-16 Thread Stefan Seelmann
On 5/11/21 4:06 AM, Emmanuel Lécharny wrote: > I will commit my changes in project-45 and > checkstyle-configuration-2.0.1 if no one objects. I'd release the checkstyle-configuration-2.0.1 or to be more precise the buildtools project, ok?

Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny
Many thanks, Stefan ! On 13/05/2021 09:42, Stefan Seelmann wrote: Committed and pushed, all issues are resolved, OSGi tests work again. On 5/13/21 9:20 AM, Emmanuel Lécharny wrote: OH, GREAT ! Please commit, I'll check for the missing deps. On 13/05/2021 08:46, Stefan Seelmann wrote: I

Re: project & checkstyle update

2021-05-13 Thread Stefan Seelmann
Committed and pushed, all issues are resolved, OSGi tests work again. On 5/13/21 9:20 AM, Emmanuel Lécharny wrote: > OH, GREAT ! > > Please commit, I'll check for the missing deps. > > > On 13/05/2021 08:46, Stefan Seelmann wrote: >> I got them to run, but some fail because of unresolved

Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny
On 13/05/2021 09:02, Stefan Seelmann wrote: apacheds-core-annotation and apacheds-server-annotation still have dependencies to junit4 (org.junit.runner package) This is probably something to remove... - To unsubscribe,

Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny
OH, GREAT ! Please commit, I'll check for the missing deps. On 13/05/2021 08:46, Stefan Seelmann wrote: I got them to run, but some fail because of unresolved requirements. Let me know if I should commit it and investigate further: diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml index

Re: project & checkstyle update

2021-05-13 Thread Stefan Seelmann
apacheds-core-annotation and apacheds-server-annotation still have dependencies to junit4 (org.junit.runner package) On 5/13/21 8:46 AM, Stefan Seelmann wrote: > I got them to run, but some fail because of unresolved requirements. Let > me know if I should commit it and investigate further: > >

Re: project & checkstyle update

2021-05-13 Thread Stefan Seelmann
I got them to run, but some fail because of unresolved requirements. Let me know if I should commit it and investigate further: diff --git a/osgi-integ/pom.xml b/osgi-integ/pom.xml index f993450965..527b31c51f 100644 --- a/osgi-integ/pom.xml +++ b/osgi-integ/pom.xml @@ -249,8 +249,8 @@

Re: project & checkstyle update

2021-05-13 Thread Emmanuel Lécharny
The weird thing is that there is only one difference between the working osgi-integ version and the not running one: org.junit.jupiter junit-jupiter-engine test replaced junit junit test If I roll back this change, I get the same

Re: project & checkstyle update

2021-05-12 Thread Emmanuel Lécharny
Ok, I know that the OSGi tests were running on commit 2ec1117fec41919a68d04ba3a51724562e3b46f8 ("Updating Jetty to 9.4.34.v20201102", made by Colm on Nov 6th) and stopped being run with commit 04212704be56cdcb750ca571081a5e55fa03bfb8 ("Started the migration to Junit 5", made by me on Dec,

Re: project & checkstyle update

2021-05-12 Thread Emmanuel Lécharny
Will analyse further tonite. FTR I have added a test class, which get executed, which means the tests are somehow visible. May be an issue with the RunWith(PaxExam.class) ? On 12/05/2021 06:47, Stefan Seelmann wrote: On 5/11/21 11:45 PM, Emmanuel Lécharny wrote: And after going back to the

Re: project & checkstyle update

2021-05-11 Thread Stefan Seelmann
On 5/11/21 11:45 PM, Emmanuel Lécharny wrote: > And after going back to the existing project (44) parent, I can't have > the osgi-integ test run at all : > > [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @ > apacheds-osgi-integ --- > [INFO] > [INFO]

Re: project & checkstyle update

2021-05-11 Thread Emmanuel Lécharny
And after going back to the existing project (44) parent, I can't have the osgi-integ test run at all : [INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @ apacheds-osgi-integ --- [INFO] [INFO] --- [INFO] T E S T S [INFO]

Re: project & checkstyle update

2021-05-11 Thread Emmanuel Lécharny
Ok, i have tried with ApacheDS too, and I have some issues with OSGi tests: [INFO] Running org.apache.directory.server.osgi.integ.ServerInterceptorsAuthNOsgiTest [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 s <<< FAILURE! - in

Re: project & checkstyle update

2021-05-10 Thread Stefan Seelmann
On 5/11/21 4:06 AM, Emmanuel Lécharny wrote: > before we cut a LDAP API and Studio release, I have done a few updates > in the 'checkstyle' and 'project' projects. There are a hell of maven > plugin version sthat have changed since the last release. > > I checked with LDAP API and beside an issue

project & checkstyle update

2021-05-10 Thread Emmanuel Lécharny
Hi, before we cut a LDAP API and Studio release, I have done a few updates in the 'checkstyle' and 'project' projects. There are a hell of maven plugin version sthat have changed since the last release. I checked with LDAP API and beside an issue with checkstyle ( a property was not