Re: [PR] eTag support with If-Match [directory-scimple]

2024-03-13 Thread via GitHub
symphony-enrico commented on PR #541: URL: https://github.com/apache/directory-scimple/pull/541#issuecomment-1993888550 > Maybe this is something that should be abstracted out? In my repository implementation I process version in this way: ```java /** * Version

Re: [PR] eTag support with If-Match [directory-scimple]

2024-03-13 Thread via GitHub
bdemers commented on PR #541: URL: https://github.com/apache/directory-scimple/pull/541#issuecomment-1994423009 @symphony-enrico I like it! I think the `ETag` object makes it clear what it's intent is! Should the `List` be a `Set`? It probably doesn't matter much in this context,

Re: [PR] eTag support with If-Match [directory-scimple]

2024-03-13 Thread via GitHub
symphony-enrico commented on PR #541: URL: https://github.com/apache/directory-scimple/pull/541#issuecomment-1995055299 > @symphony-enrico I like it! I think the `ETag` object makes it clear what it's intent is! > > Should the `List` be a `Set`? It probably doesn't matter much in

Re: [PR] eTag support with If-Match [directory-scimple]

2024-03-13 Thread via GitHub
bdemers commented on code in PR #541: URL: https://github.com/apache/directory-scimple/pull/541#discussion_r1523752504 ## scim-core/src/main/java/org/apache/directory/scim/core/repository/Repository.java: ## @@ -69,14 +70,14 @@ public interface Repository { * * *

Re: [PR] eTag support with If-Match [directory-scimple]

2024-03-13 Thread via GitHub
bdemers commented on PR #541: URL: https://github.com/apache/directory-scimple/pull/541#issuecomment-1995338796 This looks great @symphony-enrico! One last quick comment about the weak etag -- This is an automated message from the Apache Git Service. To respond to the message, please