HI Thomas and David,
We can remove one of the code branches if you guys feel strongly about it.
The reason we recommended to keep both is because both of them are working, and
we wanted to keep both of them for a while to get some feedback from other
people about which one they prefer. It
Hi Thomas,
I am asking for your help to identify a technical solution for moving forward.
Enabling the stats is a very important part of our Packet Framework
enhancements, as it is a dependency for a set of patches we plan to submit next.
1. What is the technical solution to avoid performance
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of eziegenb
> Sent: Tuesday, May 19, 2015 8:55 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] Mem: Fixes small memory leak due to missing
> free.
>
> A function in cmdline.c has a return that does not free
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rao, Ravi
> Sent: Tuesday, May 19, 2015 6:07 PM
> To: Czesnowicz, Przemyslaw; Thomas F Herbert; O'Driscoll, Tim; Butler,
> Siobhan A; dev at dpdk.org
> Subject: Re: [dpdk-dev] dev at DPDK Hackathon Proposal
>
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
>
> On Tue, May 19, 2015 at 05:45:05PM +0200, Thomas Monjalon wrote:
> > 2015-05-19 11:34, Neil Horman:
> > > On Tue, May 19, 2015 at 07:43:14AM -0700, Stephen Hemminger wrote:
> > > > > Composition of the TSC should reflect
Hello Michael,
I've updated the kernel and QEMU. Here are the packages I'm using:
--> CentOS 7 - 3.10.0-229.4.2.el7.x86_64
- qemu-kvm-1.5.3-86.el7_1.2.x86_64
- libvirt-1.2.8-16.el7_1.3.x86_64
- virt-manager-1.1.0-12.el7.noarch
- virt-what-1.13-5.el7.x86_64
-
Hi,
I am currently interested to tryout on the compute nodes for measuring the
performance on the data traffic. Can you please point to me any notes that I
can refer to get the ovs-dpdk on the nova in kilo..
Thanks & regards,
Ravi
-Original Message-
From: Czesnowicz, Przemyslaw
> This series contains compilation fixes.
>
> Olivier Matz (4):
> examples/bond: fix compilation with clang
> examples/netmap: fix compilation for x86_x32-native-linuxapp-gcc
> pmds: fix 32 bits compilation with debug enabled
> examples/mk: add dependencies for timer and vm_power_manager
> > This error is detected:
> > examples/ip_pipeline/cmdline.c:272:15: error: address of array
> > 'params->file_path' will always evaluate to 'true'
> > if (!params->file_path) {
> > ~^
> >
> > file_path is an array in a structure so it's
2015-05-19 11:34, Neil Horman:
> On Tue, May 19, 2015 at 07:43:14AM -0700, Stephen Hemminger wrote:
> > > Composition of the TSC should reflect contributions to the project, but be
> > > balanced so that no single party has an undue influence. It should also be
> > > kept to a manageable
From: eziegenb
A function in cmdline.c has a return that does not free buf properly.
Signed-off-by: Erik Ziegenbalg
---
lib/librte_cmdline/cmdline.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cmdline/cmdline.c
Thank you for your answer Bruce,
I think you refer to the example "l2fwd-ivshmem", Don't you?
I compiled and run it, it works.
I was reviewing the code and I found that the function rte_mempool_lookup
is not used in the guest.
In the host a structure containing pointers to the rings is allocated
Hi Ravi,
Kilo release of Openstack allows to use ovs-dpdk with vhostuser.
Nova includes vhost-user vif driver, and for neutron we have a mechanism driver
and agent in stackforge project :
https://github.com/stackforge/networking-ovs-dpdk
The neutron part is hosted on stackforge because of
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, May 19, 2015 11:37 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix build with clang 3.6
>
> This error is detected:
>
This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables it
as default in both Linux and BSD.
Also, to support port hotplug, rte_eal_pci_scan() and below missing
symbols should be exported to ethdev library.
- rte_eal_parse_devargs_str()
- rte_eal_pci_close_one()
-
The patch consolidates below functions, and implement these
in eal_common_pci_uio.c.
- pci_uio_map_secondary()
- pci_uio_map_resource()
- pci_uio_unmap()
- pci_uio_find_resource()
- pci_uio_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/Makefile
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_resource()
- pci_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 22
lib/librte_eal/common/eal_common_pci.c | 42
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_device()
- pci_unmap_device()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++
lib/librte_eal/common/eal_common_pci.c | 57 +
This patch consolidates below functions, and implements these in common
eal code.
- rte_eal_pci_probe_one_driver()
- rte_eal_pci_close_one_driver()
Because pci_map_device() is only implemented in linuxapp, the patch
implements it in bsdapp too. This implemented function will be merged to
This patch consolidates below structures, and defines them in common code.
- struct pci_map
- strucy mapped_pci_resouces
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 24
lib/librte_eal/common/include/rte_pci.h| 28
This patch adds a new function called pci_uio_map_resource_by_index().
The function hides how to map uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 107
This patch adds a new function called pci_uio_alloc_uio_resource().
The function hides how to prepare uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 70
This patch series adds port hotplug support to BSD.
Before applying, following patches should be applied.
- [PATCH v4 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c
- [PATCH v4 2/5] eal: Close file descriptor of uio configuration
- [PATCH v4 3/5] eal: Fix memory leaks and needless
Hi Bernard,
I've updated the series, because I've found the issue in BSD code.
Also, I have rebased the series for latest master branch.
Could you please read my below comments?
On 2015/05/19 14:54, Tetsuya Mukawa wrote:
> This patch set cleans up pci uio implementation. These clean up are
>
This patch fixes below.
- bsdapp
- Use map_id in pci_uio_map_resource().
- Fix interface of pci_map_resource().
- Move path variable of mapped_pci_resource structure to pci_map.
- linuxapp
- Remove redundant error message of linuxapp.
'pci_uio_map_resource()' is implemented in both linuxapp
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed,
This patch fixes following memory leaks.
- When open() is failed, uio_res and fds won't be freed in
pci_uio_map_resource().
- When pci_map_resource() is failed but path is allocated correctly,
path and fds won't be freed in pci_uio_map_recource().
- When pci_uio_unmap() is called, path should
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
This patch fixes coding style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24 +---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 12
2 files changed, 21
This patch set cleans up pci uio implementation. These clean up are
for consolidating pci uio implementation of linuxapp and bsdapp, and
moving consolidated functions in eal common.
Because of above, this patch set tries to implement linuxapp and bsdapp
almost same.
Actual consolidations will be
On Tue, 19 May 2015 12:54:35 -0700
eziegenb wrote:
> A function in cmdline.c has a return that does not free buf properly.
>
> Signed-off-by: eziegenb
> ---
> lib/librte_cmdline/cmdline.c |4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vincent JARDIN
> Sent: Tuesday, May 19, 2015 3:20 PM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] dev at DPDK Hackathon Proposal
>
> On 19/05/2015 05:59, O'Driscoll, Tim wrote:
> > a) Save the date.
> -Original Message-
> From: Thomas F Herbert [mailto:therbert at redhat.com]
> Sent: Tuesday, May 19, 2015 3:09 PM
> To: Rao, Ravi; O'Driscoll, Tim; Butler, Siobhan A; dev at dpdk.org
> Subject: Re: [dpdk-dev] dev at DPDK Hackathon Proposal
>
>
>
> On 5/19/15 9:43 AM, Rao, Ravi
Thomas, thank you!
- Helin
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, May 19, 2015 6:33 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
>
>
2015-05-19 12:24, Bruce Richardson:
> On Tue, May 19, 2015 at 12:14:59PM +0100, Mcnamara, John wrote:
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> >
> > Series Acked-by: John McNamara
> >
> > Note, due to 2 commits to i40e/base that were merged last night
To get device VMDQ info when only i40e VMDQ feature is enabled.
Signed-off-by: Jijiang Liu
---
lib/librte_pmd_i40e/i40e_ethdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
b/lib/librte_pmd_i40e/i40e_ethdev.c
index
Hi All,
Effort and emphasis has to be made to integrate DPDK into openstack
components like neutron and nova so that this becomes part of std openstack
release.
Currently some work was done and published as a patch to devstack's Juno but
there are no clear path to incorporate these patches
On Tue, May 19, 2015 at 05:45:05PM +0200, Thomas Monjalon wrote:
> 2015-05-19 11:34, Neil Horman:
> > On Tue, May 19, 2015 at 07:43:14AM -0700, Stephen Hemminger wrote:
> > > > Composition of the TSC should reflect contributions to the project, but
> > > > be
> > > > balanced so that no single
On Mon, May 18, 2015 at 10:32:37AM +0200, Mauricio V?squez wrote:
> Hi all,
>
> I'm trying to map a mempool into a guest using the IVSHMEM library but the
> mempool is not visible from the guest.
>
> The code I'm running is quite simple, on the host I run a primary DPDK
> process that creates
There wasn't any public response to this but we did discuss it with several
people separately who all thought it was a good idea. Therefore, we've decided
to go ahead with it. Siobhan is working on the plan now and should be in a
position to make a formal announcement in a few weeks.
In the
A function in cmdline.c has a return that does not free buf properly.
Signed-off-by: eziegenb
---
lib/librte_cmdline/cmdline.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c
index e61c4f2..747d3bb 100644
---
This error is detected:
examples/ip_pipeline/cmdline.c:272:15: error: address of array
'params->file_path' will always evaluate to 'true'
if (!params->file_path) {
~^
file_path is an array in a structure so it's unneeded to check it.
2015-05-18 16:43, Bruce Richardson:
> On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > Compile warnings on ICC and clang can be found, and treated as errors.
> > Disabling those warnings forcedly can fix them.
> >
> > v2 changes:
> > Added the fix for the compile error on clang.
>
On Mon, May 11, 2015 at 05:29:39PM +0100, Bruce Richardson wrote:
> Hi all,
>
> after a small amount of offline discussion with Marc Sune, here is an
> alternative proposal for a higher-level interface - aka pktdev - to allow a
> common Rx/Tx API across device types handling mbufs [for now,
On Tue, May 19, 2015 at 12:14:59PM +0100, Mcnamara, John wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Friday, May 15, 2015 4:57 PM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 00/19] Move PMDs to drivers
On Tue, May 19, 2015 at 07:43:14AM -0700, Stephen Hemminger wrote:
> >
> >
> >
> > Composition of the TSC should reflect contributions to the project, but be
> > balanced so that no single party has an undue influence. It should also be
> > kept to a manageable size(maybe 7?).
> >
> > The TSC
On Fri, Apr 17, 2015 at 08:35:33AM -0700, Stephen Hemminger wrote:
> Function always returned 0 and no one was checking anyway.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
> ---
> lib/librte_eal/common/eal_common_log.c | 3 +--
> lib/librte_eal/common/include/rte_log.h |
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> Sent: Wednesday, May 13, 2015 4:30 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] Coding standards
>
> When reviewing please remember: This document is designed to put in
> writing
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, May 15, 2015 4:57 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2 00/19] Move PMDs to drivers directory
Series Acked-by: John McNamara
Note, due to 2 commits to
On Mon, Apr 13, 2015 at 03:11:11PM -0700, Stephen Hemminger wrote:
> Do some cleanup of pci scan loop.
> * check errors first
> * don't initialize variables where not necessary
> * cuddle else (follow existing style)
> * chop off conditional after return
>
> Signed-off-by: Stephen
On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote:
> From: Stephen Hemminger
>
> Silence is normal. drivers should speak only when spoken to and not
> be chatty.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
> ---
> lib/librte_pmd_enic/enic_main.c | 2 --
>
On Tue, Mar 24, 2015 at 01:58:20PM +0800, xuelin.shi at freescale.com wrote:
> From: Xuelin Shi
>
> This module uses type conversion between struct and int.
> Also truncation and comparison is used with this int.
> It is not safe for different endian arch.
>
> Add ifdef for big endian struct to
On 5/19/15 10:18 AM, Butler, Siobhan A wrote:
>
>
>> -Original Message-
>> From: Thomas F Herbert [mailto:therbert at redhat.com]
>> Sent: Tuesday, May 19, 2015 3:09 PM
>> To: Rao, Ravi; O'Driscoll, Tim; Butler, Siobhan A; dev at dpdk.org
>> Subject: Re: [dpdk-dev] dev at DPDK Hackathon
On 2015/05/19 0:03, Helin Zhang wrote:
> Compile warnings on ICC and clang can be found, and treated as errors.
> Disabling those warnings forcedly can fix them.
>
> v2 changes:
> Added the fix for the compile error on clang.
>
> Helin Zhang (2):
> i40e: compile fix on ICC 13.0.0
> i40e:
On 5/19/15 9:43 AM, Rao, Ravi wrote:
> Hi All,
> Effort and emphasis has to be made to integrate DPDK into openstack
> components like neutron and nova so that this becomes part of std openstack
> release.
> Currently some work was done and published as a patch to devstack's Juno but
>
On Mon, May 18, 2015 at 6:39 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Mon, 18 May 2015 10:32:01 +0100
> Bruce Richardson wrote:
>
> > For the most part, this looks fine. However, I'm unsure about changing
> the log
> > level of the messages stating what the RX and TX
On 5/19/15 8:01 AM, Thomas Monjalon wrote:
> 2015-05-19 12:24, Bruce Richardson:
>> On Tue, May 19, 2015 at 12:14:59PM +0100, Mcnamara, John wrote:
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
>>>
>>> Series Acked-by: John McNamara
>>>
>>> Note, due to 2
On 5/19/15 8:59 AM, O'Driscoll, Tim wrote:
> There wasn't any public response to this but we did discuss it with several
> people separately who all thought it was a good idea. Therefore, we've
> decided to go ahead with it. Siobhan is working on the plan now and should be
> in a position to
On Tue, 19 May 2015 15:21:45 +0900
Tetsuya Mukawa wrote:
> This patch series adds port hotplug support to BSD.
> Before applying, following patches should be applied.
> - [PATCH v4 1/5] eal: Fix coding style of eal_pci.c and eal_pci_uio.c
> - [PATCH v4 2/5] eal: Close file descriptor of uio
On Tue, 19 May 2015 14:54:55 +0900
Tetsuya Mukawa wrote:
> When pci_uio_unmap_resource() is called, a file descriptor that is used
> for uio configuration should be closed.
>
> Signed-off-by: Tetsuya Mukawa
> ---
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +-
> 1 file changed, 5
Acked-by: Stephen Hemminger
On Mon, May 18, 2015 at 10:54 PM, Tetsuya Mukawa wrote:
> This patch fixes coding style of below files in linuxapp and bsdapp.
> - eal_pci.c
> - eal_pci_uio.c
>
> Signed-off-by: Tetsuya Mukawa
> ---
> lib/librte_eal/bsdapp/eal/eal_pci.c | 24
>
>
>
> Composition of the TSC should reflect contributions to the project, but be
> balanced so that no single party has an undue influence. It should also be
> kept to a manageable size(maybe 7?).
>
> The TSC should elect its own chair, who would have the deciding vote in
> the event that the
We need info messages about topology etc from other components.
On Tue, May 19, 2015 at 12:46 AM, David Marchand
wrote:
> On Mon, May 18, 2015 at 6:39 PM, Stephen Hemminger <
> stephen at networkplumber.org> wrote:
>
>> On Mon, 18 May 2015 10:32:01 +0100
>> Bruce Richardson wrote:
>>
>> > For
On 19/05/2015 07:18, Butler, Siobhan A wrote:
>> Also related to this, I would hope to participate in any discussion about OVS
>> >acceration and vhost/guest access acceleration.
We need to have this track with both:
- Qemu/kvm/libvirt session during the LinuxCon,
- virtio session during
On 19/05/2015 05:59, O'Driscoll, Tim wrote:
> a) Save the date. October 8th/9th, immediately after the European LinuxCon,
> in Dublin Ireland.
> b) Think about topics that you'd like to see covered. We'll solicit for
> inputs when the formal announcement is made, but it's good for people to
>
Hello
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vijayakumar
> Muthuvel Manickam
> Sent: Tuesday, May 19, 2015 7:33 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] kni: Add link status update
>
> Add an ioctl command in rte_kni module to enable
Below compile error can be found on clang 3.3, which is a warning
treated as error. Forcedly disabling the warning can fix it.
Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c:708:20: error: unused variable
'i40e_nvm_update_state_str' [-Werror,-Wunused-variable]
STATIC const char
Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.
Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
Compile warnings on ICC and clang can be found, and treated as errors.
Disabling those warnings forcedly can fix them.
v2 changes:
Added the fix for the compile error on clang.
v3 changes:
Reworded the commit titles.
Helin Zhang (2):
i40e: compile fix on ICC 13.0.0
i40e: compile fix on
Below compile error can be found on clang 3.3, which is a warning
treated as error. Forcedly disabling the warning can fix it.
Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c:708:20: error: unused variable
'i40e_nvm_update_state_str' [-Werror,-Wunused-variable]
STATIC const char
Below compile error can be found on ICC 13.0.0, which is a warning
treated as error. Forcedly disabling the warning can fix it.
Error log:
lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
type mixed with another type
hw->aq.asq_last_status = old_asq_status;
Compile warnings on ICC and clang can be found, and treated as errors.
Disabling those warnings forcedly can fix them.
v2 changes:
Added the fix for the compile error on clang.
Helin Zhang (2):
i40e: compile fix on ICC 13.0.0
i40e: compile fix on clang 3.3
lib/librte_pmd_i40e/Makefile | 3
72 matches
Mail list logo