[dpdk-dev] [PATCH] examples/kni: Fix segmentation fault at program exit

2015-08-05 Thread Zhang, Helin
> -Original Message- > From: Hyun Yoo [mailto:easetheworld at gmail.com] > Sent: Wednesday, August 5, 2015 2:58 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: [PATCH] examples/kni: Fix segmentation fault at program exit > > In kni_free_kni(), p[i] should be p[port_id] > >

[dpdk-dev] Reminder to Register for DPDK Summit August 17th

2015-08-05 Thread Butler, Siobhan A
Hi all, Just a little reminder that there is still time to register for DPDK Summit 2015 - San Francisco, August 17th. Go to www.dpdksummit.com to register for DPDK Summit and view upcoming events. Siobhan

[dpdk-dev] Changes to 5tuple IPv4 filters in dpdk v2.0

2015-08-05 Thread Vladimir Medvedkin
Hi Kam, Flow director can filter by src/dst prefix, but the src/dst prefix length is global for all rules. So, if you decide to specify /16 dst network, all rules will have /16 prefix length for dst address. Regards, Vladimir 2015-08-05 17:53 GMT+03:00 Kamraan Nasim : > Hi Vladimir, > > Thank

[dpdk-dev] [PATCH] eal/ppc: fix build

2015-08-05 Thread Chao Zhu
Acked-by: Chao Zhu On 2015/8/5 17:13, Thomas Monjalon wrote: > Byte ordering macros were used without including the needed header. > > Fixes: ce10b21bf624 ("eal/ppc: fix cpu cycle count for little endian") > > Signed-off-by: Thomas Monjalon > --- >

[dpdk-dev] [PATCH v3] ixgbe: remove vector pmd burst size restriction

2015-08-05 Thread Zoltan Kiss
On 05/08/15 07:28, Liang, Cunming wrote: > Hi Zoltan, > >> -Original Message- >> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org] >> Sent: Wednesday, August 05, 2015 12:26 AM >> To: Liang, Cunming; dev at dpdk.org >> Cc: Ananyev, Konstantin >> Subject: Re: [PATCH v3] ixgbe: remove

[dpdk-dev] [PATCH] bonding: 8023ad: fix incorrect typecast of socket

2015-08-05 Thread Sergey Balabanov
On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1) is being casted to unsigned char and then to signed int. The result is that socket_id has value of 255, not -1. This results to memory allocation failure. --- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH v2 3/3] doc: moved doxygen section to the doc guidelines

2015-08-05 Thread Bruce Richardson
On Fri, Jul 10, 2015 at 04:45:21PM +0100, John McNamara wrote: > Moved and refactored the Doxygen guidelines from the Coding Style doc > to the Documentation Guidelines doc. Replaced the existing Doxygen > references with links. > > Signed-off-by: John McNamara Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v2 2/3] doc: added guidelines on dpdk documentation

2015-08-05 Thread Bruce Richardson
On Fri, Jul 10, 2015 at 04:45:20PM +0100, John McNamara wrote: > Added guidelines on the purpose and structure of the DPDK > documentation, how to build it and guidelines for creating it. > > Signed-off-by: John McNamara Acked-by: Bruce Richardson with one minor error highlighted below. >

[dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create()

2015-08-05 Thread Thomas Monjalon
2015-08-05 13:36, Bernard Iremonger: > if the name parameter to rte_eth_bond_create() was NULL, > there was a segmentation fault because eth_dev was also NULL. You also add error handling of mac_addrs alloc and release_port(). It deserves to be said in this commit message.

[dpdk-dev] [PATCH v2 1/3] doc: set the default literal block format

2015-08-05 Thread Bruce Richardson
On Fri, Jul 10, 2015 at 04:45:19PM +0100, John McNamara wrote: > Set the default literal block format for Sphinx docs > to 'none' instead of the implicit default of 'python'. > > This means that default :: blocks won't have any > highlighting applied. Explicit highlighting via > the code-block::

[dpdk-dev] [PATCH v3 1/1] bonding: fix device initialisation error handling

2015-08-05 Thread Bernard Iremonger
If the name parameter to rte_eth_bond_create() was NULL, there was a segmentation fault because eth_dev was also NULL. Add error handling of mac_addrs memory allocation. Add call to rte_eth_dev_release_port() in error handling. Signed-off-by: Bernard Iremonger ---

[dpdk-dev] [PATCH] examples/kni: Fix segmentation fault at program exit

2015-08-05 Thread Hyun Yoo
In kni_free_kni(), p[i] should be p[port_id] Signed-off-by: Hyun Yoo gmail.com> --- examples/kni/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index 6f74d8e..6d434ad 100644 --- a/examples/kni/main.c +++

[dpdk-dev] [PATCH] eal/ppc: fix build

2015-08-05 Thread Thomas Monjalon
> > Byte ordering macros were used without including the needed header. > > > > Fixes: ce10b21bf624 ("eal/ppc: fix cpu cycle count for little endian") > > > > Signed-off-by: Thomas Monjalon > Acked-by: Chao Zhu Applied

[dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create()

2015-08-05 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, August 5, 2015 2:35 PM > To: Iremonger, Bernard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in > rte_eth_bond_create() > >

[dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create()

2015-08-05 Thread Bernard Iremonger
if the name parameter to rte_eth_bond_create() was NULL, there was a segmentation fault because eth_dev was also NULL. Signed-off-by: Bernard Iremonger --- drivers/net/bonding/rte_eth_bond_api.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] rte_config.h: No such file or directory in DPDK 2.1.0-rc3 and DPDK 2.0.0

2015-08-05 Thread Stefan Binna
Alright, thanks. > 2015-08-05 12:07, Stefan Binna: >> I can install both DPDK-versions without errors by help of following >> commands: > Good to know :) > >> But when I try to compile the Open vSwitch by help of following commands: > Please send this question to the Open vSwitch project.

[dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create()

2015-08-05 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, August 5, 2015 2:16 PM > To: Iremonger, Bernard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in > rte_eth_bond_create() > >

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-08-05 Thread Vincent JARDIN
> Use '--disable-hw-vlan-filter' in testpmd command line will allow it > continue to work. > You can have a try. Yes, but not using this flag should not imply to exit. > I am not sure which one is better when app configures one feature but fail to > negotiate it with host(which means has > no

[dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create()

2015-08-05 Thread Liu, Yong
Tested-by: Marvin Liu > -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, August 05, 2015 8:37 PM > To: dev at dpdk.org > Cc: Jastrzebski, MichalX K; Liu, Yong; Iremonger, Bernard > Subject: [PATCH v2 1/1] bonding: fix error handling in > rte_eth_bond_create() > > if the

[dpdk-dev] [PATCH 1/1] bonding: fix error handling in rte_eth_bond_create()

2015-08-05 Thread Iremonger, Bernard
Hi Thomas, > What is the root cause of the crash? > I guess it is rte_free(eth_dev->data->mac_addrs) because eth_dev is NULL. Yes, that is the roor cause. > > [...] > > -err: > > - rte_free(pci_dev); > > - rte_free(internals); > > +err4: > > rte_free(eth_dev->data->mac_addrs); > > -

[dpdk-dev] rte_config.h: No such file or directory in DPDK 2.1.0-rc3 and DPDK 2.0.0

2015-08-05 Thread Thomas Monjalon
2015-08-05 12:07, Stefan Binna: > I can install both DPDK-versions without errors by help of following > commands: Good to know :) > But when I try to compile the Open vSwitch by help of following commands: Please send this question to the Open vSwitch project.

[dpdk-dev] rte_config.h: No such file or directory in DPDK 2.1.0-rc3 and DPDK 2.0.0

2015-08-05 Thread Stefan Binna
Hi, I am seeking help regarding DPDK 2.1.0 -rc3 as well as DPDK 2.0.0 on Ubuntu 14.04 (Kernel 3.19.0-031900-generic) and openvswitchdpdk.l.1.1.0-27.gz. I can install both DPDK-versions without errors by help of following commands: export RTE_SDK=$(pwd) export

[dpdk-dev] [PATCH] test: fix test_tlb_tx_burst

2015-08-05 Thread Thomas Monjalon
2015-08-05 11:10, Michal Jastrzebski: > This patch fixes error in tlb_tx_burst function: > Distribution is not even. What was the error exactly? > A condition in TEST_ASSERT macro was changed, > as the previous one was random. I think "random" can be better described. > Also the time of

[dpdk-dev] [PATCH] eal/ppc: fix build

2015-08-05 Thread Thomas Monjalon
Byte ordering macros were used without including the needed header. Fixes: ce10b21bf624 ("eal/ppc: fix cpu cycle count for little endian") Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH] test: fix test_tlb_tx_burst

2015-08-05 Thread Michal Jastrzebski
This patch fixes error in tlb_tx_burst function: Distribution is not even. A condition in TEST_ASSERT macro was changed, as the previous one was random. Also the time of generating packets can now be decreased. Signed-off-by: Michal Jastrzebski --- app/test/test_link_bonding.c | 12

[dpdk-dev] Changes to 5tuple IPv4 filters in dpdk v2.0

2015-08-05 Thread Kamraan Nasim
Hi Vladimir, Thank you for the link. Seems to simply be an abstraction over the existing filters so it is safe for me to upgrade to v2.0 :) Since we are on the subject, are you aware of any filters on 82599 or Fortville that may provide subnet filtering(I can specify something like

[dpdk-dev] [PATCH v3] ixgbe: remove vector pmd burst size restriction

2015-08-05 Thread Ananyev, Konstantin
> -Original Message- > From: Liang, Cunming > Sent: Tuesday, August 04, 2015 12:47 PM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; zoltan.kiss at linaro.org; Liang, Cunming > Subject: [PATCH v3] ixgbe: remove vector pmd burst size restriction > > On receive side, the burst size now

[dpdk-dev] Using kni for tcp stream classification

2015-08-05 Thread EaseTheWorld Mr.
Hello. I'm using kni with a libpcap-based program. I will sort packets by tcp stream in kni so the program can concentrate on the business logic. My question is - Is kni guaranteed to keep the packet order? rte_kni_tx_burst(p1)->rte_kni_tx_burst(p2)->rte_kni_tx_burst(p3) then I want

[dpdk-dev] [dpdk_dev]bug report: create_proc_read_entry() is not supported from linux kernel 3.10.x

2015-08-05 Thread Chi, Xiaobo (Nokia - CN/Hangzhou)
Hi, Anyone has ever tested the rte_kni.ko in igb mode? If the following is confirmed as a bug, I would like to work out a patch. Thanks. For file ~/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/ igb_procfs.c, there are following code. As to what I know, from Linux kernel 3.10.x, the functions

[dpdk-dev] [PATCH v3] ixgbe: remove vector pmd burst size restriction

2015-08-05 Thread Liang, Cunming
Hi Zoltan, > -Original Message- > From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org] > Sent: Wednesday, August 05, 2015 12:26 AM > To: Liang, Cunming; dev at dpdk.org > Cc: Ananyev, Konstantin > Subject: Re: [PATCH v3] ixgbe: remove vector pmd burst size restriction > > > > On

[dpdk-dev] Could DPDK ring provide peek interface or any comments for this function?

2015-08-05 Thread Yan, Liming (Nokia - CN/Hangzhou)
> -Original Message- > From: ext Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, August 04, 2015 8:57 PM > To: Yan, Liming (Nokia - CN/Hangzhou); dev at dpdk.org > Subject: Re: [dpdk-dev] Could DPDK ring provide peek interface or any > comments for this function? > > Hi,

[dpdk-dev] DPDK bond the virtio NIC run error

2015-08-05 Thread Ouyang, Changchun
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hu, FangyinX > Sent: Wednesday, August 5, 2015 10:41 AM > To: dev at dpdk.org > Subject: [dpdk-dev] DPDK bond the virtio NIC run error > > HI, I use the qemu-kvm create a virtual machine and give a

[dpdk-dev] DPDK bond the virtio NIC run error

2015-08-05 Thread Hu, FangyinX
HI, I use the qemu-kvm create a virtual machine and give a virtio-net-pci mode NIC to the VM, then I run the bond_app example get an error. Here is the steps. 1. qemu-kvm -enable-kvm -had /home/images/fedora.qcow2 -m 2048 -smp 8 -cpu qemu64,+ssse3,+sse4.2 -device

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-08-05 Thread Ouyang, Changchun
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jardin at 6wind.com] > Sent: Tuesday, August 4, 2015 8:52 PM > To: Thomas Monjalon; Ouyang, Changchun > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan

[dpdk-dev] Changes to 5tuple IPv4 filters in dpdk v2.0

2015-08-05 Thread Vladimir Medvedkin
Hi Kam, 1) The reason is discussed in http://dpdk.org/ml/archives/dev/2014-September/005179.html 2) No, it's still not supported (on current NICs). At the moment ntuple is supported only by igb and ixgbe. If you look at drivers/net/ixgbe/ixgbe_ethdev.c you can see ntuple_filter_to_5tuple function

[dpdk-dev] "ifconfig" commands/status using the dpdk:igb_uio driver

2015-08-05 Thread Marc Sune
On 04/08/15 23:09, Navneet Rao wrote: > Hello Experts: > > > How can I configure my NIC setting(s) when loaded with the dpdk:igb_uio > driver? > E.g I need to keep the MAC address and the IP address of the NIC the "same as > before" after switching to a dpdk:igb_uio driver for the NIC.

[dpdk-dev] running dpdk application on aws c3 instance

2015-08-05 Thread Manish Yadav
my linux kernel version 2.6.38 and ixgbe version 3.2.9-k2. thanks, manish On Mon, Aug 3, 2015 at 11:15 PM, Manish Yadav wrote: > Hi, > > i am trying to bringup my dpdk application on aws c3.4x instance, my > application is based on dpdk 1.6. i have chosen this instance as this > supports