[dpdk-dev] [PATCH] scripts: check commit formatting

2016-03-30 Thread Yuanhan Liu
On Wed, Mar 30, 2016 at 03:27:40PM +0100, Bruce Richardson wrote: > On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote: > > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > > > The git messages have three parts: > > > 1/ the headline > > > 2/ the explanations > > > 3/

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Harish Patil
> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> +static void >> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev, >> + __rte_unused uint32_t index) >> +{ >> +struct qede_dev *qdev = eth_dev->data->dev_private; >> +struct ecore_dev *edev =

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Harish Patil
> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody wrote: > >> + >> +static void qede_print_adapter_info(struct qede_dev *qdev) >> +{ >> +struct ecore_dev *edev = >edev; >> +struct qed_dev_info *info = >dev_info.common; >> +char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; >> + >> +

[dpdk-dev] [PATCH] enic: expose RX missed packets counter

2016-03-30 Thread Thomas Monjalon
2016-03-30 11:07, John Daley: > Update the 'imissed' counter with the number of packets dropped > by the NIC. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar Applied, thanks

[dpdk-dev] [PATCH] examples/ip_pipeline: fix SSE4.2 optimization branch

2016-03-30 Thread Thomas Monjalon
The branch was disabled because of a typo in the SSE4.2 flag. Change also the x86_64 flag to use a DPDK one. Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 without SSE4.2") Signed-off-by: Thomas Monjalon Acked-by: Cristian Dumitrescu ---

[dpdk-dev] [PATCH] ixgbe: return err for too many interrupt queues

2016-03-30 Thread Thomas Monjalon
> > The lower 16 bits of EICR register are used for queue interrupts, dpdk > > framework > > take over the first bit for other interrupts like LSC, so there're only 15 > > bits left for > > queue interrupts mapping. > > This patch adds a check for the num of interrupt queues at dev_start. > > >

[dpdk-dev] [PATCH] ixgbe/base: fix VF multi-queue failure

2016-03-30 Thread Thomas Monjalon
2016-03-30 10:46, Wenzhuo Lu: > When starting testpmd with multiple queues on a ixgbe VF > port, it failed with this printing, "nb_rxq(4) is greater > than max_rx_queues(1)". > > The root cause is the VF doesn't get the right max rx queue > number from PF and it uses the default value 1. > VF max

[dpdk-dev] [PATCH] enic: state change from link-down to link-up not recognized

2016-03-30 Thread Thomas Monjalon
2016-03-25 17:45, John Daley: > When the enic was disabled, link notification was correctly disabled > in the NIC but the software indicator that it was disabled was not > updated (vdev->notify_pa not set to 0). When the link came back up, > enic did not re-enable notification in the NIC. > >

[dpdk-dev] [PATCH] enic: fix TX hang when number of packets > queue size

2016-03-30 Thread Thomas Monjalon
2016-03-25 17:43, John Daley: > If the nb_pkts parameter to rte_eth_tx_burst() was greater than > the TX descriptor count, a completion was not being requested > from the NIC, so descriptors would not be released back to the > host causing a lock-up. > > Introduce a limit of how many TX

[dpdk-dev] New Defects reported by Coverity Scan for DPDK Data Plane Development Kit

2016-03-30 Thread Mcnamara, John
Hi, The following is forwarded from latest Coverity scan on the DPDK head. As usual, I will send out semi-automated emails to the authors of the new defects. In the meantime you can then review the defects online at: http://scan.coverity.com/projects/dpdk-data-plane-development-kit You

[dpdk-dev] [PATCH 0/2] Fix multiple build errors for Amazon ENA driver

2016-03-30 Thread Thomas Monjalon
2016-03-29 14:43, Daniel Mrzyglod: > First patch cover multiple error for ICC. > a. mixed enum with other types > b. variable is used uninitialized > > Patches for FreeBSD: > a. Target was not setup > b. ETIME is not avaliable in FreeBSD > > Daniel Mrzyglod (2): > ena:

[dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning

2016-03-30 Thread Thomas Monjalon
2016-03-30 09:36, Stephen Hemminger: > On Wed, 30 Mar 2016 10:06:36 -0400 > Aaron Conole wrote: > > --- a/drivers/net/e1000/Makefile > > +++ b/drivers/net/e1000/Makefile > > @@ -54,6 +54,9 @@ else > > # > > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > > CFLAGS_BASE_DRIVER +=

[dpdk-dev] Question on examples/multi_process app

2016-03-30 Thread Harish Patil
>> >> >> >> >> >>Hi Harish, >> >>> >> > >>> >> >> -Original Message- >>> >> >> From: Richardson, Bruce >>> >> >> Sent: Wednesday, March 23, 2016 11:45 AM >>> >> >> To: Ananyev, Konstantin >>> >> >> Cc: Harish Patil; dev at dpdk.org >>> >> >> Subject: Re: [dpdk-dev] Question on

[dpdk-dev] [PATCH v2] hash: fix to support multi process

2016-03-30 Thread Pablo de Lara
Hash library used a function pointer to choose a different key compare function, depending on the key size. As a result, multiple processes could not use the same hash table, as the function addresses vary from one process to another. Instead, a jump table is used, so each process has its own

[dpdk-dev] [PATCH] mlx5: fix RETA table size

2016-03-30 Thread Yaacov Hazan
Change RETA table size to use 256 entries for better performance. Fixes: ebb30ec64a68 ("mlx5: increase RETA table size") Signed-off-by: Yaacov Hazan --- drivers/net/mlx5/mlx5_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_defs.h

[dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode

2016-03-30 Thread Thomas Monjalon
Anyone to review, please? 2016-03-25 17:44, John Daley: > From: Nelson Escobar > > Stopping then re-starting a bond interface containing slaves that > used polling for link detection caused the bond to think all slave > links were down and inactive. > > Move the start of the polling for link

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Thomas Monjalon
2016-03-30 14:15, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-03-30 13:57, Dumitrescu, Cristian: > > > I think the correct fix is: > > > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2) > > || defined(RTE_MACHINE_CPUFLAG_CRC32)) > > >

[dpdk-dev] [PATCH 4/4] autotest: fix func reentrancy

2016-03-30 Thread Olivier Matz
The previous code in func_reentrancy autotest was doing in parallel something close to: name = "common_name"; do several times { obj = allocate_an_object(name) // obj = ring, mempool, hash, lpm, ... if (obj == NULL && lookup(name) == NULL) return TEST_FAIL; } This

[dpdk-dev] [PATCH 3/4] hash: keep the list locked at creation

2016-03-30 Thread Olivier Matz
To avoid a race condition while creating a new hash object, the list has to be locked before the lookup, and released only once the new object is added in the list. Signed-off-by: Olivier Matz --- lib/librte_hash/rte_cuckoo_hash.c | 16 +++- 1 file changed, 11 insertions(+), 5

[dpdk-dev] [PATCH 2/4] hash: allocation of an existing object should fail

2016-03-30 Thread Olivier Matz
Change the API of rte_hash*_create() functions to return NULL and set rte_errno to EEXIST when the object name already exists. These functions were returning a pointer to the existing object in that case, but it is a problem as the caller did not know if the object had to be freed or not. Doing

[dpdk-dev] [PATCH 1/4] lpm: allocation of an existing object should fail

2016-03-30 Thread Olivier Matz
Change the API of rte_lpm*_create() functions to return NULL and set rte_errno to EEXIST when the object name already exists. These functions were returning a pointer to the existing object in that case, but it is a problem as the caller did not know if the object had to be freed or not. Doing

[dpdk-dev] [PATCH 0/4] fix lpm and hash creation

2016-03-30 Thread Olivier Matz
Seen while trying to fix the func_reentrancy autotest. The series addresses several issues: 1/ Hash and lpm return a pointer to an existing object if the user requests the creation with an already existing name. This look dangerous: when an object is returned, the user does not know if it

[dpdk-dev] [PATCH v2 0/2] Out of place operations for symmetric crypto

2016-03-30 Thread John Griffin
On 29/03/16 15:14, Fiona Trahe wrote: > From: Arek Kusztal > > This patch adds out of place operations for qat symmetric crypto PMD, > i.e. the result of the operation can be written to the destination buffer > instead of overwriting the source buffer as done in "in-place" operation. > > v2: >

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 30, 2016 4:50 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Singh, Jasvinder ; Zhang, > Roy Fan ; Hunt, David > Subject: Re: [dpdk-dev] [PATCH v2 2/4]

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Thomas Monjalon
2016-03-30 13:57, Dumitrescu, Cristian: > I think the correct fix is: > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2) || > defined(RTE_MACHINE_CPUFLAG_CRC32)) > > We'll test it and send a patch asap. I had prepared this patch. Please be inspired: examples/ip_pipeline: fix

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Thomas Monjalon
2016-03-30 13:24, Dumitrescu, Cristian: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > The compiler cannot use _mm_crc32_u64: > > > > examples/ip_pipeline/pipeline/hash_func.h:165:9: > > error: implicit declaration of function '_mm_crc32_u64' is invalid in C99 > >

[dpdk-dev] [PATCH] scripts: check commit formatting

2016-03-30 Thread Bruce Richardson
On Wed, Mar 30, 2016 at 10:44:14PM +0800, Yuanhan Liu wrote: > On Wed, Mar 30, 2016 at 03:27:40PM +0100, Bruce Richardson wrote: > > On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote: > > > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > > > > The git messages have

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2016 22:16:51 + Harish Patil wrote: > > > >On Tue, 29 Mar 2016 22:28:20 -0700 > >Rasesh Mody wrote: > > > >> + > >> +static void qede_print_adapter_info(struct qede_dev *qdev) > >> +{ > >> + struct ecore_dev *edev = >edev; > >> + struct qed_dev_info *info =

[dpdk-dev] [PATCH] scripts: check commit formatting

2016-03-30 Thread Bruce Richardson
On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote: > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > > The git messages have three parts: > > 1/ the headline > > 2/ the explanations > > 3/ the footer tags > > > > The headline helps to quickly browse an history or

[dpdk-dev] librte_pmd_ixgbe implementation of ixgbe_dev_rx_queue_count

2016-03-30 Thread Bruce Richardson
On Tue, Mar 29, 2016 at 09:54:18AM -0700, Stephen Hemminger wrote: > On Tue, 29 Mar 2016 10:31:19 +0100 > Bruce Richardson wrote: > > > On Mon, Mar 28, 2016 at 06:45:26PM -0700, Mohammad El-Shabani wrote: > > > Hi, > > > Looking into why it hurts performance, I see that ixgbe_dev_rx_queue_count

[dpdk-dev] [PATCH] Fix KNI compilation under Wind River Linux 6.0 recent RCPLs.

2016-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2016 12:13:35 -0600 Lee Roberts wrote: > skb_set_hash() has been backported to recent Wind River Linux 6.0 RCPLs. > As a result, the corresponding stanza in kcompat.h must be removed. > Similar patches have already been applied for RHEL, SLES and Ubuntu. > > Wind River Linux does

[dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning

2016-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2016 19:12:39 +0200 Thomas Monjalon wrote: > 2016-03-30 09:36, Stephen Hemminger: > > On Wed, 30 Mar 2016 10:06:36 -0400 > > Aaron Conole wrote: > > > --- a/drivers/net/e1000/Makefile > > > +++ b/drivers/net/e1000/Makefile > > > @@ -54,6 +54,9 @@ else > > > # > > >

[dpdk-dev] [PATCH 1/4] lpm: allocation of an existing object should fail

2016-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2016 17:30:24 +0200 Olivier Matz wrote: > diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c > index 4c44cd7..9877a30 100644 > --- a/lib/librte_lpm/rte_lpm6.c > +++ b/lib/librte_lpm/rte_lpm6.c > @@ -182,8 +182,11 @@ rte_lpm6_create(const char *name, int socket_id,

[dpdk-dev] [PATCH] vmxnet3: remove asserts that confuse coverity

2016-03-30 Thread Stephen Hemminger
These asserts are only for debugging and never fired during any testing, but they confuse coverity's null tracking. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 30, 2016 3:07 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Singh, Jasvinder ; Zhang, > Roy Fan ; Hunt, David > Subject: Re: [dpdk-dev] [PATCH v2 2/4]

[dpdk-dev] [PATCH] librte_ether: fix comments for filters

2016-03-30 Thread Thomas Monjalon
2016-03-29 11:04, Jingjing Wu: > This patch fixes comments for tunnel filters and flow director flows. > e.g. states fields which are in big endian. > > Fixes: 7b1312891b69 (ethdev: add IP in GRE tunnel) > Fixes: d69be32d4d78 (ethdev: structures to add or delete flow director) > Signed-off-by:

[dpdk-dev] [PATCH 7/7] l2fwd-crypto: extend crypto information

2016-03-30 Thread Pablo de Lara
Display extra crypto information (algorithms, keys/IV/AAD used, chain...), so user can know exactly what operations are being carried out. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 84 ++-- 1 file changed, 82 insertions(+), 2

[dpdk-dev] [PATCH 6/7] l2fwd-crypto: use key-value list of supported algorithms

2016-03-30 Thread Pablo de Lara
In order to ease the parsing and display of supported algorithms in the application, two new arrays are created, which contains the strings of the different cipher and authentication algorithms, These lists are used to parse the algorithms from the command line, and will be used to display crypto

[dpdk-dev] [PATCH 5/7] l2fwd-crypto: fix ambiguous input key size

2016-03-30 Thread Pablo de Lara
Some crypto algorithms support more than one key size (including cipher key, authentication key, IV and AAD), but the app was using always the minimum size. These changes allows the user to use an specific size, either from the string provided with cipher_key, auth_key, iv and ADD parameters, or

[dpdk-dev] [PATCH 4/7] l2fwd-crypto: fix length of random IV/AAD

2016-03-30 Thread Pablo de Lara
App was generating a random IV/AAD of only 4 bytes, instead of the actual length, since it was using sizeof(length). Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH 3/7] l2fwd-crypto: add missing string initialization

2016-03-30 Thread Pablo de Lara
When passing the preferred crypto device type in the command line parameters, the string (HW/SW/ANY) was not being saved, which is used for error information to the user. Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities") Signed-off-by: Pablo de Lara ---

[dpdk-dev] [PATCH 2/7] l2fwd-crypto: rename period parameter

2016-03-30 Thread Pablo de Lara
L2fwd-crypto app is based on L2fwd app and it inherits some of its parameters (such as portmask, queues per core...). The parameter period (period of time between statistic updates) is -T in L2fwd, but was -t in L2fwd-crypto, so for consistency, it is changed back to -T Fixes: 387259bd6c67

[dpdk-dev] [PATCH 1/7] l2fwd-crypto: add missing new line character in help

2016-03-30 Thread Pablo de Lara
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application) Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 5fd4ff1..0cb46c2 100644 ---

[dpdk-dev] [PATCH 0/7] L2fwd-crypto fixes/enhancements

2016-03-30 Thread Pablo de Lara
This patches fixes some small issues in L2fwd-crypto app and also improves the app, making it more flexible (accepting different key sizes) and readable (information display improvement). Pablo de Lara (7): l2fwd-crypto: add missing new line character in help l2fwd-crypto: rename period

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, March 30, 2016 2:24 PM > To: 'Thomas Monjalon' ; dev at dpdk.org > Cc: Singh, Jasvinder ; Zhang, Roy Fan > ; Hunt, David > Subject: RE: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for > x86_64 without

[dpdk-dev] [PATCH v2] drivers/crypto: Fix anonymous union initialization in crypto PMDs

2016-03-30 Thread Fiona Trahe
In SUSE11-SP3 i686 platform, with gcc 4.5.1, there are compile issues, e.g: null_crypto_pmd_ops.c:44:3: error: unknown field 'sym' specified in initializer cc1: warnings being treated as errors The member in anonymous union initialization should be inside '{}', otherwise it will report an

[dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD

2016-03-30 Thread Bruce Richardson
On Tue, Mar 29, 2016 at 08:52:38PM +, Rasesh Mody wrote: > Hi Bruce, > > > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > > Sent: Tuesday, March 22, 2016 4:30 AM > > > > On Tue, Mar 22, 2016 at 11:21:25AM +, Richardson, Bruce wrote: > > > I've had a quick scan over this

[dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2

2016-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 16, 2016 6:46 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for > x86_64 without SSE4.2 > > The compiler cannot use

[dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops

2016-03-30 Thread Thomas Monjalon
2016-03-28 16:51, Robert Sanford: > This patch series does the following: > > * enhances port ring writer test, to send two large, but not full > bursts; exposes ring writer buffer overflow > * fixes ring writer buffer overflow > * fixes full burst checks in ethdev, ring, and sched f_tx_bulk

[dpdk-dev] [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8

2016-03-30 Thread Thomas Monjalon
2016-03-25 09:48, David Marchand: > On Fri, Mar 25, 2016 at 9:11 AM, Chao Zhu > wrote: > > This patch fixes the max logic number and memory channel number settings > > on IBM POWER8 platform. > > 1. The max number of logic cores of a POWER8 processor is 96. Normally, > >there are two sockets

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-30 Thread Thomas Monjalon
2016-03-24 08:54, Panu Matilainen: > --- a/drivers/net/e1000/Makefile > +++ b/drivers/net/e1000/Makefile > @@ -54,6 +54,9 @@ else > # > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(shell test $(GCC_VERSION) -ge 60 &&

[dpdk-dev] [PATCH] Fix KNI compilation under Wind River Linux 6.0 recent RCPLs.

2016-03-30 Thread Lee Roberts
skb_set_hash() has been backported to recent Wind River Linux 6.0 RCPLs. As a result, the corresponding stanza in kcompat.h must be removed. Similar patches have already been applied for RHEL, SLES and Ubuntu. Wind River Linux does not provide convenient macros for kernel version identification.

[dpdk-dev] Question about cd10c42eb5bc ("mem: fix ivshmem freeing")

2016-03-30 Thread Burakov, Anatoly
Hi Mauricio, Good points. Would you be willing to prepare a patch to fix these issues? Thanks, Anatoly From: Mauricio V?squez [mailto:mauricio.vasquezber...@studenti.polito.it] Sent: Wednesday, March 30, 2016 10:13 AM To: Burakov, Anatoly Cc: dev at dpdk.org; Gonzalez Monroy, Sergio ;

[dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops

2016-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 30, 2016 12:00 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Robert Sanford > Subject: Re: [dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops > > 2016-03-28

[dpdk-dev] [PATCH 1/2 v2] lib/librte_lpm: Fix anonymous union initialization issue

2016-03-30 Thread Michael Qiu
In SUSE11-SP3 i686 platform, with gcc 4.5.1, there is a compile issue: rte_lpm.c: In function ?add_depth_small_v20?: rte_lpm.c:778:7: error: unknown field ?next_hop? specified in initializer cc1: warnings being treated as errors The root casue is gcc only

[dpdk-dev] [PATCH v13 0/8] ethdev: 100G and link speed API refactoring

2016-03-30 Thread Thomas Monjalon
2016-03-26 02:27, Marc Sune: > There are still too few tests and reviews, especially for > autonegotiation with Intel devices (patch #6). > I would not be surprised to see some bugs in this rework. > > The capabilities must be adapted per device. It can be > improved in a separate patch. > > It

[dpdk-dev] Question about cd10c42eb5bc ("mem: fix ivshmem freeing")

2016-03-30 Thread Mauricio Vásquez
Hi Anatoly, Thank you very much, I did not take into account that detail. I have two additional concerns about it: 1. I think it is possible to have a race condition. The memzone is marked as not freeable after it has been added to the ivshmem device, then it is possible to free the memzone

[dpdk-dev] [PATCH] enic: expose RX missed packets counter

2016-03-30 Thread John Daley
Update the 'imissed' counter with the number of packets dropped by the NIC. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley Reviewed-by: Nelson Escobar --- drivers/net/enic/enic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_main.c

[dpdk-dev] DPDK: receive single packet at a time

2016-03-30 Thread Mohan Prasad
Hi Bruce, Could not get it working by disabling the vector PMD, Do you have any example where it works? Thanks, Mohan On Tue, Mar 29, 2016 at 6:46 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Mar 29, 2016 at 06:31:58PM +0530, Mohan Prasad wrote: > > Hi, > > > > I have

[dpdk-dev] [PATCH] ixgbe/base: fix VF multi-queue failure

2016-03-30 Thread Wenzhuo Lu
When starting testpmd with multiple queues on a ixgbe VF port, it failed with this printing, "nb_rxq(4) is greater than max_rx_queues(1)". The root cause is the VF doesn't get the right max rx queue number from PF and it uses the default value 1. VF max rx queue number is set by PF through

[dpdk-dev] Question about cd10c42eb5bc ("mem: fix ivshmem freeing")

2016-03-30 Thread Mauricio Vásquez
Dear All, I was looking at that patch, I can understand its functionality but not its implementation.. Why to calculate idx?, Just doing "mz->ioremap_addr = mz->phys_addr" would not be sufficient? After all, the goal is to mark the memzone as used by ivshmem to forbid freeing it. Please

[dpdk-dev] Must kni be associated with a dpdk port?

2016-03-30 Thread ALeX Wang
Hi, I want to use 'rte_kni_alloc()' to create a kernel iface and use it to test application rx. From the api and example in 'examples/kni/main.c', i saw the 'conf' argument is assigned with pci info of a dpdk port. Want to ask if this is compulsory... Must kni always be used together with a

[dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning

2016-03-30 Thread Aaron Conole
The register read/write mphy functions have misleading whitespace around the `locked` check. This cleanup merely preserves the existing functionality and suppresses future gcc versions' "misleading indentation" warning. Suggested-by: Panu Matilainen Signed-off-by: Aaron Conole --- v2: * Changed

[dpdk-dev] [PATCH v13 5/8] ethdev: add speed capabilities

2016-03-30 Thread Marc
On 29 March 2016 at 15:31, Alejandro Lucero wrote: > For nfp.c, speed_capa should be ETH_LINK_SPEED_40G instead of > ETH_LINK_SPEED_50G. > By the way, the change in patch 4 sets the right link speed using the new > constants. > > Regards > Noted for v14, thanks Marc > > On Sat, Mar 26, 2016

[dpdk-dev] e1000: randomly loosing link change events triggered by the peer

2016-03-30 Thread Marc
On 29 March 2016 at 03:19, Lu, Wenzhuo wrote: > Hi Marc, > > > > *From:* marc.sune at gmail.com [mailto:marc.sune at gmail.com] *On Behalf Of * > Marc > *Sent:* Monday, March 28, 2016 7:03 PM > *To:* Lu, Wenzhuo > *Cc:* dev at dpdk.org > *Subject:* Re: e1000: randomly loosing link change events

[dpdk-dev] [PATCH v13 6/8] ethdev: redesign link speed config

2016-03-30 Thread Marc
On 29 March 2016 at 08:18, Xing, Beilei wrote: > > > > -Original Message- > > From: Marc Sune [mailto:marcdevel at gmail.com] > > Sent: Saturday, March 26, 2016 9:27 AM > > To: Thomas Monjalon ; Xu, Qian Q > > ; Xing, Beilei ; > dev at dpdk.org; > > Ananyev, Konstantin ; Lu, Wenzhuo > >

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +void qede_config_rx_mode(struct rte_eth_dev *eth_dev) > +{ > + struct qede_dev *qdev = eth_dev->data->dev_private; > + struct ecore_dev *edev = >edev; > + /* TODO: - QED_FILTER_TYPE_UCAST */ > + enum

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > +static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool action) > +{ > + struct ecore_dev *edev = >edev; > + struct qed_update_vport_params params; > + int rc; > + > + /* Proceed only if action actually needs to

[dpdk-dev] [PATCH] scripts: check commit formatting

2016-03-30 Thread Yuanhan Liu
On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > The git messages have three parts: > 1/ the headline > 2/ the explanations > 3/ the footer tags > > The headline helps to quickly browse an history or catch instantly the > purpose of a commit. Making it short with some consistent

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > +static void > +qede_alloc_etherdev(struct qede_dev *qdev, struct qed_dev_eth_info *info) > +{ > + rte_memcpy(>dev_info, info, sizeof(*info)); Why bother with rte_memcpy here? why not just assignment or memcpy()? > + qdev->num_tc

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +static void > +qede_dev_info_get(struct rte_eth_dev *eth_dev, > + struct rte_eth_dev_info *dev_info) > +{ > + struct qede_dev *qdev = eth_dev->data->dev_private; > + struct ecore_dev *edev = >edev; > + > +

[dpdk-dev] [PATCH v4 05/10] qede: Add core driver

2016-03-30 Thread Stephen Hemminger
On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +static void qede_print_adapter_info(struct qede_dev *qdev) > +{ > + struct ecore_dev *edev = >edev; > + struct qed_dev_info *info = >dev_info.common; > + char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; > + > + RTE_LOG(INFO,

[dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning

2016-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2016 10:06:36 -0400 Aaron Conole wrote: > The register read/write mphy functions have misleading whitespace around > the `locked` check. This cleanup merely preserves the existing functionality > and suppresses future gcc versions' "misleading indentation" warning. > >

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-30 Thread Aaron Conole
Thomas Monjalon writes: > 2016-03-24 08:54, Panu Matilainen: >> --- a/drivers/net/e1000/Makefile >> +++ b/drivers/net/e1000/Makefile >> @@ -54,6 +54,9 @@ else >> # >> CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter >> CFLAGS_BASE_DRIVER += -Wno-unused-variable >> +ifeq

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-03-30 Thread Xie, Huawei
On 3/18/2016 5:15 PM, Patrik Andersson wrote: > Protect against DPDK crash when allocation of listen fd >= 1023. > For events on fd:s >1023, the current implementation will trigger > an abort due to access outside of allocated bit mask. > > Corrections would include: > > * Match fdset_add()

[dpdk-dev] Issue with binding NIC of type 82545EM to dpdk

2016-03-30 Thread Al Patel
Hi Lu, I do see the module there, but seems it is built against incorrect kernel version and thus it is not loading: # insmod ./dpdk/kmod/igb_uio.ko insmod: ERROR: could not insert module ./dpdk/kmod/igb_uio.ko: Invalid module format dmesg: [54394.611703] igb_uio: version magic

[dpdk-dev] Question about cd10c42eb5bc ("mem: fix ivshmem freeing")

2016-03-30 Thread Burakov, Anatoly
Hi Mauricio, You?re not missing anything. It would be done this way, if the memzone parameter wasn?t const. But it is const, so we have to find the memzone in config to edit it. Thanks, Anatoly From: Mauricio V?squez [mailto:mauricio.vasquezber...@studenti.polito.it] Sent: Wednesday, March

[dpdk-dev] Issue with binding NIC of type 82545EM to dpdk

2016-03-30 Thread Lu, Wenzhuo
Hi Al, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Al Patel > Sent: Wednesday, March 30, 2016 1:14 AM > To: Yigit, Ferruh > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Issue with binding NIC of type 82545EM to dpdk > > Ferruh, > > On my fedora23, I

[dpdk-dev] [PATCH] scripts: check commit formatting

2016-03-30 Thread Thomas Monjalon
The git messages have three parts: 1/ the headline 2/ the explanations 3/ the footer tags The headline helps to quickly browse an history or catch instantly the purpose of a commit. Making it short with some consistent wording allows to easily parse it or match some patterns. The explanations