(e.g. 64B), it actually slows a bit down. That is expected because this
patch introduces some extra works, and it outweighs the benefit from
saving few bytes copy.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost.c | 2 +
lib/librte_vhost/vhost.h | 21 ++
lib/librte_vhost/vhost_us
, we need use another var to note
the last avail ring idx we have consumed.
Therefore, last_avail_idx is introduced.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost.h | 2 +-
lib/librte_vhost/virtio_net.c | 19 +++
2 files changed, 12 insertions(+), 9 deletions(-)
diff
So that we can convert a guest physical address to host physical
address, which will be used in later Tx zero copy implementation.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost.h | 30 +++
lib/librte_vhost/vhost_user.c | 86 +++
2
ch removes orig_region_map and
redefines virtio_memory_region, to include all necessary info.
With that, we can simplify the guest/host address convert a bit.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost.h | 49 ++--
lib/librte_vhost/vhost_us
+% performance boost for packet
size 1400B.
For VM2VM iperf test case, it's even better: about 70% boost.
---
Yuanhan Liu (6):
vhost: simplify memory regions handling
vhost: get guest/host physical address mappings
vhost: introduce last avail idx for Tx
vhost: add Tx zero copy
vhost: add a flag
On Fri, Aug 19, 2016 at 08:54:00AM +0530, Jerin Jacob wrote:
> On Thu, Aug 18, 2016 at 02:52:31PM +0800, Yuanhan Liu wrote:
> > On Tue, Jul 05, 2016 at 06:19:24PM +0530, Jerin Jacob wrote:
> > > Split out SSE instruction based virtio simple Rx
> > > implem
the issue when Jerin's patchset is applied. Thus, I think
it's still needed.
Fixes: fc3d66212fed ("virtio: add vector Rx")
Cc: Jerin Jacob
Signed-off-by: Yuanhan Liu
---
drivers/net/virtio/virtio_rxtx_simple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
On Thu, Aug 18, 2016 at 10:19:15AM +, Tan, Jianfeng wrote:
> > > +VLAN strip option is removed, because different NICs have different
> > behaviors
> > > +when disabling VLAN strip. Such feature, which heavily depends on
> > hardware,
> > > +should be removed from this example to deduce
On Sat, Aug 20, 2016 at 06:11:36AM -0400, Jiayu Hu wrote:
> When examples/vhost runs in client mode, only one QEMU can be connected.
> This is because that examples/vhost just supports one socket file. This
> patch is to add multiple sockets support for examples/vhost.
>
> Signed-off-by: Jiayu Hu
On Sat, Aug 20, 2016 at 06:10:33AM -0400, Jiayu Hu wrote:
> In examples/vhost, "dev-basename" is a program option, which is to set
> the vhost-net socket used by vhost-user, or the character device used
> by vhost-cuse. Since vhost-cuse should be dropped, and "dev-basename"
> is not a suitable
On Thu, Aug 18, 2016 at 11:27:06AM -0700, Rich Lane wrote:
> On Mon, Aug 15, 2016 at 7:37 PM, Yuanhan Liu
> wrote:
>
> On Mon, Aug 15, 2016 at 01:00:24PM -0700, Rich Lane wrote:
> > Concurrent enqueue is an important performance optimization when the
> number
On Mon, Aug 22, 2016 at 03:46:11PM +0200, Thomas Monjalon wrote:
> 2016-08-18 16:48, Yuanhan Liu:
> > remove vhost-cuse code, including the eventfd_link kernel module that
> > is for vhost-cuse only.
>
> Please, remove also the deprecation notice. Thanks
Yes, David a
On Thu, Aug 18, 2016 at 02:33:06AM -0400, Zhihong Wang wrote:
> This patch implements the vhost logic from scratch into a single function
> designed for high performance and better maintainability.
>
> Signed-off-by: Zhihong Wang
> ---
> lib/librte_vhost/vhost_rxtx.c | 212
>
On Thu, Aug 18, 2016 at 02:33:07AM -0400, Zhihong Wang wrote:
> This patch removes obsolete functions.
Splitting patches doesn't work in this way: this should be in the first
patch. Otherwise, build breaks in the first patch, as some functions are
defined but not used.
--yliu
No need to use a pointer to store/retrieve features.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_user.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index ef4a0c1..eee99e9 100644
Invoke get_device() at the beginning of vhost_user_msg_handler, so that
we could check the return value once. Which could save tons of duplicate
get-and-check device.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_user.c | 160 +-
1 file changed
Some functions are with prefix "user_", while others with "vhost_".
Making them all starting with "vhost_user_" to unify the function names.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_user.c | 60 +--
1 file
those common handles to corresponding vhost
user handler.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/vhost_user.c | 115 --
1 file changed, 31 insertions(+), 84 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
implementation only so far: it's just a rename
from vhost_rxtx.c
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/Makefile |6 +-
lib/librte_vhost/{vhost-net-user.c => socket.c}| 209 +---
lib/librte_vhost/vhost.c |
We now have one vhost implementation; no sub source dir is needed.
Rmove it by move them to upper dir.
Signed-off-by: Yuanhan Liu
---
lib/librte_vhost/Makefile | 6 +++---
lib/librte_vhost/{vhost_user => }/fd_man.c | 0
lib/librte_vhost/{vhost_u
is removed.
Signed-off-by: Yuanhan Liu
---
config/common_base| 6 +-
lib/librte_vhost/Makefile | 13 +-
lib/librte_vhost/eventfd_link/Makefile| 41 ---
lib/librte_vhost/eventfd_link/eventfd_link.c | 277
lib/librte_vhost
way (see patch 3 for details).
---
Yuanhan Liu (7):
vhost: remove vhost-cuse
vhost: remove sub source dir
vhost: refactor source code structure
vhost: fold common message handlers
vhost: unify function names
vhost: get device once
vhost: simplify features set/get
config
On Thu, Aug 18, 2016 at 10:27:55AM +0200, Maxime Coquelin wrote:
>
>
> On 08/16/2016 06:14 PM, Jiayu Hu wrote:
> >When examples/vhost runs in client mode, only one QEMU can be connected.
> >This is because that examples/vhost just supports one socket file. This
> >patch is to add multiple
On Thu, Aug 18, 2016 at 10:22:38AM +0200, Maxime Coquelin wrote:
> Hi Jiayu,
>
> On 08/16/2016 06:14 PM, Jiayu Hu wrote:
> >In examples/vhost, "dev-basename" is a program option, which is to set
> >the vhost-net socket used by vhost-user, or the character device used
> >by vhost-cuse. Since
On Wed, Aug 17, 2016 at 03:54:21PM +0530, Pankaj Chauhan wrote:
> My use case is that my machine/board which is not sitting as end node of
> network but somewhere in between like an router. So the traffic looks
> something like this:
>
> Physical port 1 -> Enter VM(s) through virtio -> exit from
On Tue, Aug 16, 2016 at 12:14:39PM -0400, Jiayu Hu wrote:
> +/*
> + * This function is used to unregister drivers.
> + */
> +static void
> +unregister_drivers(int socket_num)
> +{
Redundant comment. The function name already explains it well.
> /* Register vhost user driver to handle
On Tue, Jul 05, 2016 at 06:19:24PM +0530, Jerin Jacob wrote:
> Split out SSE instruction based virtio simple Rx
> implementation to a separate file
>
> Signed-off-by: Jerin Jacob
Hi,
I was about to apply this set. I then did some build test and found a
weird issue: it breaks the build with
On Wed, Aug 17, 2016 at 11:17:46AM +0200, Maxime Coquelin wrote:
> >>>This is something I've thought about while writing the code, the reason I
> >>>keep it as one function body is that:
> >>>
> >>> 1. This function is very performance sensitive, and we need full control
> >>> of
> >>>code
On Wed, Aug 17, 2016 at 01:45:26AM +, Wang, Zhihong wrote:
>
>
> > -Original Message-
> > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> > Sent: Tuesday, August 16, 2016 10:00 PM
> > To: Wang, Zhihong ; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] optimize
On Tue, Aug 09, 2016 at 04:42:33PM +0530, Pankaj Chauhan wrote:
>
> Hi,
>
> I am working on an NXP platform where we intend to use user space vhost
> switch (examples/vhost) as backend for VIRTIO devices. But there are two
> limitations in current vhost-switch (examples/vhost)that are
On Mon, Aug 15, 2016 at 01:00:24PM -0700, Rich Lane wrote:
> Concurrent enqueue is an important performance optimization when the number
> of cores used for switching is different than the number of vhost queues.
> I've observed a 20% performance improvement compared to a strategy that
> binds
On Tue, Jul 12, 2016 at 04:32:12PM +0200, Maxime Coquelin wrote:
> Indirect descriptors are usually supported by virtio-net devices,
> allowing to dispatch a large number of large requests.
>
> When the virtio device sends a packet using indirect descriptors,
> only one slot is used in the ring,
ices
> for DPDK.
>
> The maintainer for the initial release will be Yuanhan Liu
> . It is hoped that other community members
> will
> volunteer as maintainers for other Stable Releases.
>
> The initial targeted release for LTS is proposed to be 16.11 based on the
> results o
Claim v16.07 as a stable release: only bug fix patches are allowed.
And volunteer to be the maintainer.
Signed-off-by: Yuanhan Liu
---
MAINTAINERS | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d099131..1a5b047 100644
--- a/MAINTAINERS
ed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d099131..6536c6b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -373,7 +373,7 @@ F: drivers/net/vmxnet3/
> F: doc/guides/nics/vmxnet3.rst
>
> Vhost PMD
> -M: Tetsuya Mukawa
On Mon, Jul 25, 2016 at 04:09:58PM +0200, Maxime Coquelin wrote:
> nr_desc is not an index but the number of descriptors,
> so can be equal to the virtqueue size.
>
> Fixes: a436f53ebfeb ("vhost: avoid dead loop chain")
>
> Cc: Yuanhan Liu
> Signed-off-by: Maxime
gned-off-by: Thomas Monjalon
Acked-by: Yuanhan Liu
--yliu
On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote:
> 2016-07-22 09:46, Yuanhan Liu:
> > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> > > The following tools may be installed system-wise.
> >
> > Yes, indeed. Following is an exa
te the strings in docs and source code, which could lead to
> failure to start this device as per the docs.
>
> This patch updates related strings in the docs and source code.
>
> Fixes: cb6696d22023 ("drivers: update registration macro usage")
>
> Reported-by: Tiwei B
On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> The following tools may be installed system-wise.
Yes, indeed. Following is an example from dpdk package shipped in
ubutun 16.04:
dpdk: /etc/dpdk/dpdk.conf
dpdk: /etc/dpdk/interfaces
dpdk: /etc/init.d/dpdk
dpdk:
On Thu, Jul 21, 2016 at 04:43:25PM +0300, Ilya Maximets wrote:
>
>
> On 21.07.2016 16:35, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote:
> >> If something abnormal happened to QEMU, 'connect()' can block calling
> >> thread
dpdk_vhost_user_construct
> #4 netdev_open (name=0xa664b0 "vhost1")
> [...]
> #11 main
>
> Fix that by setting non-blocking mode for client sockets for connection.
>
> Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
>
> Signed-o
t;
> Version 3:
> * fixed leak of file descriptors by adding of
> 'close(reconn->fd)' to 'vhost_user_remove_reconnect()'
>
> Version 2:
> * style fixes.
Acked-by: Yuanhan Liu
--yliu
On Thu, Jul 21, 2016 at 03:58:11PM +0300, Ilya Maximets wrote:
> On 21.07.2016 15:58, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote:
> >> On 21.07.2016 15:35, Yuanhan Liu wrote:
> >>> On Thu, Jul 21, 2016 at 03:13:1
On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote:
> On 21.07.2016 15:35, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
> >>>>
> >>>> What do you think of it?
> >>>
> >>> I
On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote:
> >>
> >> What do you think of it?
> >
> > I found that we can't check connection status without select/poll
> > on it. 'getsockopt()' will return 0 with no errors if connection
> > is not still established just like if it was.
> >
On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote:
> > Hmm, how about this fixup:
> > --
> > diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c
> > b/lib/librte_vhost/vhost_user/vhost-net-user.c
> >
On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote:
> On 21.07.2016 12:37, Yuanhan Liu wrote:
> > On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
> >> If something abnormal happened to QEMU, 'connect()' can block calling
> >> thread (e.g.
On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote:
> If something abnormal happened to QEMU, 'connect()' can block calling
> thread (e.g. main thread of OVS) forever or for a really long time.
> This can break whole application or block the reconnection thread.
>
> Example with OVS:
>
"VIRTIO_" prefix and
> API comments.
>
> Fixes: f24f8f9fee8a ("net/virtio: allow virtual address to fill vring
> descriptors")
>
> Signed-off-by: Olivier Matz
Thanks for the fix!
Acked-by: Yuanhan Liu
--yliu
, vsocket->connfd, path);
We should try not to break a log message into several lines, which
hurts "git grep". Here, it could be:
RTE_LOG(INFO, VHOST_CONFIG,
"free connfd = %d for device '%s'\n",
vsocket->connfd, path);
Besides the two minor nits,
Acked-by: Yuanhan Liu
--yliu
ot;)
>
> Reported-by: Qian Xu
> Signed-off-by: Jianfeng Tan
> ---
> v3: reword commit log.
Yes, much better. One minor nit: you forgot to carry the Tested-by from
Qian.
Acked-by: Yuanhan Liu
Thanks.
--yliu
On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote:
> Currently while calling of 'rte_vhost_driver_unregister()' connection
> to QEMU will not be closed. This leads to inability to register driver
> again and reconnect to same virtual machine.
>
> This scenario is reproducible with
On Wed, Jul 20, 2016 at 01:50:34PM +0800, Tan, Jianfeng wrote:
>
>
> On 7/20/2016 12:38 PM, Yuanhan Liu wrote:
> >On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote:
> >>We find significant perfermance drop introduced by below commit,
> >>when vhost ex
On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote:
> We find significant perfermance drop introduced by below commit,
> when vhost example is started with --mergeable 0 and inside vm,
> kernel virtio-net driver is used to do ip based forwarding.
>
> The root cause is that below commit
On Wed, Jul 20, 2016 at 10:44:13AM +0800, Tan, Jianfeng wrote:
> Hi Yuanhan,
>
> On 7/20/2016 9:44 AM, Yuanhan Liu wrote:
> >On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote:
> >>We find significant perfermance drop introduced by below commit,
> >
On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote:
> We find significant perfermance drop introduced by below commit,
> when vhost example is started with --mergeable 0 and inside vm,
> kernel virtio-net driver is used to do ip based forwarding.
>
> The root cause is that below commit
On Tue, Jul 19, 2016 at 01:57:11PM +, Mcnamara, John wrote:
> > - Note: the "reconnect" feature requires **QEMU v2.7** (or above).
> > + .. Note::
> > + * The "reconnect" feature requires **QEMU v2.7** (or above).
> > +
> > + * The vhost supported features must be exactly the same
On Tue, Jul 19, 2016 at 07:31:35AM +0200, Maxime Coquelin wrote:
> >And to Thomas, I don't find a good reason to have this in 16.07. Let's
> >delay the apply to v16.11.
> Yes, that's why I mentioned it didn't fixed any problem on my side.
>
> So I propose we skip this patch, I'll resend one
Add a git tree line for the virtio/vhost section, to make an explicit
statement that the developers are suggested to make patches based on
that tree.
Signed-off-by: Yuanhan Liu
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9c76352..433ddd8
undefined might happen.
Signed-off-by: Yuanhan Liu
---
I just put the part "people should not do this" into the doc, and I'm
not quite sure I need put the "why" part there or not.
---
doc/guides/prog_guide/vhost_lib.rst | 7 ++-
1 file changed, 6 insertions(+), 1 del
The rxq/txq for the queue_release callback could be NULL, say when
rte_eth_dev_configure() fails that the queue is not setup at all.
Do a simple NULL check would fix the crash issue.
Fixes: 01ad44fd374f ("net/virtio: split Rx/Tx queue")
Reported-by: Olivier Matz
Signed-off-by: Y
On Mon, Jul 18, 2016 at 06:06:53PM +0200, Olivier Matz wrote:
> Hi,
>
> On 16.07-rc3, when I start testpmd with a virtio driver in a VM,
> requesting options that are not implemented (rx checksum), it crashes:
>
...
> Sorry, I have not a lot of time to investigate further, hope you can
> find
On Fri, Jul 15, 2016 at 11:14:52AM +0200, Thomas Monjalon wrote:
> 2016-07-15 16:42, Yuanhan Liu:
> > You see that no body cares it :)
> >
> > So I will make a patch to mark vhost-cuse as deprecated shortly.
> > Thomas, works to you?
>
> Perfect. Thanks Yuanha
result to a much cleaner code base, allowing us
to do all kinds of extending easier.
So here to mark vhost-cuse as deprecated in this release and will be
removed in the next release (v16.11).
Signed-off-by: Yuanhan Liu
---
doc/guides/rel_notes/deprecation.rst | 4
1 file changed, 4 insertions
On Fri, Jul 15, 2016 at 02:15:03PM +0300, Ilya Maximets wrote:
> Version 3:
> * Patch splitted in two.
> * Applied workaround from Rich Lane and added comment about
> performance issue with some compilers and 'unlikely' macro.
Thanks a lot for the patches.
Acked
You see that no body cares it :)
So I will make a patch to mark vhost-cuse as deprecated shortly.
Thomas, works to you?
--yliu
On Mon, Jul 11, 2016 at 11:59:55AM +0800, Yuanhan Liu wrote:
> It's something echoed around in my mind for a long while, and here I'm
> gonna make it
On Fri, Jul 15, 2016 at 10:23:12AM +0300, Ilya Maximets wrote:
> On 15.07.2016 09:17, Yuanhan Liu wrote:
> > On Thu, Jul 14, 2016 at 11:18:39AM +0300, Ilya Maximets wrote:
> >> In current implementation vhost will crash with segmentation fault
> >> if malicious or bugg
On Thu, Jul 14, 2016 at 11:18:39AM +0300, Ilya Maximets wrote:
> In current implementation vhost will crash with segmentation fault
> if malicious or buggy virtio application breaks addresses of descriptors.
>
> Before commit 0823c1cb0a73 this crash was reproducible even with
> normal DPDK
lause does
> > not guard... [-Werror=misleading-indentation]
> > if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
> > ^~
> >
> > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> >
> > Cc: Jianfeng Tan
> > Signed-off-by: Maxime Coquelin
> > Acked-by: Yuanhan Liu
> >
> Reviewed-by: Jan Viktorin
On Wed, Jul 13, 2016 at 08:54:08AM -0700, Rich Lane wrote:
> On Wednesday, July 13, 2016, Yuanhan Liu
> wrote:
>
> On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote:
> > This scenario fixed somehow, I agree. But this patch still needed to
> prote
On Wed, Jul 13, 2016 at 04:51:02AM -0700, Jeff Shaw wrote:
> The correct mailing list dev at dpdk.org, not dev at dpkg.org.
Nice catch!
Reviewed-by: Yuanhan Liu
--yliu
On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote:
> On 12.07.2016 08:53, Ilya Maximets wrote:
> > On 12.07.2016 05:43, Yuanhan Liu wrote:
> >> On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote:
> >>> On 11.07.2016 14:05, Yuanhan Liu wrote:
>
anfeng Tan
> Signed-off-by: Maxime Coquelin
Acked-by: Yuanhan Liu
Thanks for the fix.
--yliu
On Wed, Jul 06, 2016 at 09:08:12PM +0800, Yuanhan Liu wrote:
> On Wed, Jul 06, 2016 at 02:24:57PM +0200, Christian Ehrhardt wrote:
> > Hi,
> > while checking for dpdk 16.07 what backports are accepted in the meantime
> > so I
> > can drop them I found this particular d
d we should have had it in last
release.
Acked-by: Yuanhan Liu
--yliu
VM with vhost_user on host
> doc: add vhost_user live migration image
Reviewed-by: Yuanhan Liu
And thanks for the doc!
--yliu
>
> doc/guides/howto/img/lm_vhost_user.svg| 644
> ++
> doc/guides/howto/index.rst
On Mon, Jul 11, 2016 at 02:47:56PM +0300, Ilya Maximets wrote:
> On 11.07.2016 14:05, Yuanhan Liu wrote:
> > On Mon, Jul 11, 2016 at 12:50:24PM +0300, Ilya Maximets wrote:
> >> On 11.07.2016 11:38, Yuanhan Liu wrote:
> >>> On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yu
On Mon, Jul 11, 2016 at 01:35:46PM +0200, David Marchand wrote:
> Hello all,
>
> On Mon, Jul 11, 2016 at 7:56 AM, Thomas Monjalon
> wrote:
> > 2016-07-11 13:33, Yuanhan Liu:
> >> I'm not quite sure I understood it well: are you asking us to resend
> >>
On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote:
> On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote:
> >
> > Another point is that crash constantly happens on queue_id=3 (second RX
> > queue) in
> > my scenario. It is newly allocated virtqueue
On Mon, Jul 11, 2016 at 07:56:16AM +0200, Thomas Monjalon wrote:
> 2016-07-11 13:33, Yuanhan Liu:
> > On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote:
> > > 2016-04-20 14:43, David Marchand:
> > > > test application and kni still want to know e1000
On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote:
> 2016-04-20 14:43, David Marchand:
> > test application and kni still want to know e1000 pci devices.
> > So let's create headers in the driver that will be used by them.
>
> There is also an usage of ixgbe ID for the broken bypass
It's something echoed around in my mind for a long while, and here I'm
gonna make it public: a proposal to remove vhost-cuse.
Vhost-cuse was invented before vhost-user exist. The both are actually
doing the same thing: a vhost-net implementation in user space. But they
are not exactly the same
On Thu, Jul 07, 2016 at 02:49:08PM +0100, Ferruh Yigit wrote:
> This is for target i686-native-linuxapp-gcc and gcc6,
>
> Compilation error is:
> == Build drivers/net/virtio
> CC virtio_rxtx_simple.o
> In file included from
> .../build/include/rte_mempool.h:77:0,
> from
>
On Mon, Jul 04, 2016 at 11:00:13AM +0800, Yuanhan Liu wrote:
> On Fri, Jul 01, 2016 at 08:50:31AM +, Jianfeng Tan wrote:
> > When the specified cores and memory lie on different numa socket with
> > physical NIC, vhost fails to set up rx queue, and exits without any
> > hi
On Mon, Jul 04, 2016 at 10:24:41AM +0800, Yuanhan Liu wrote:
> On Fri, Jul 01, 2016 at 09:31:12AM -0700, Rich Lane wrote:
> > Fixes a bug where rte_eth_vhost_get_queue_event would not return enabled
> > queues
> > after a guest application restart.
> >
> > Fixes:
On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote:
>
> Another point is that crash constantly happens on queue_id=3 (second RX
> queue) in
> my scenario. It is newly allocated virtqueue while reconfiguration from rxq=1
> to
> rxq=2.
That's a valuable message: what's your DPDK HEAD
On Wed, Jul 06, 2016 at 02:24:57PM +0200, Christian Ehrhardt wrote:
> Hi,
> while checking for dpdk 16.07 what backports are accepted in the meantime so I
> can drop them I found this particular discussion has been silently forgotten
> by
> all of us.
Not really. As later I found that my patch
On Wed, Jul 06, 2016 at 02:19:12PM +0300, Ilya Maximets wrote:
> On 01.07.2016 10:35, Yuanhan Liu wrote:
> > Hi,
> >
> > Sorry for the long delay.
> >
> > On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote:
> >> In current implementation
On Tue, Jul 05, 2016 at 06:43:57PM +0530, Jerin Jacob wrote:
> On Tue, Jul 05, 2016 at 07:32:46PM +0800, Yuanhan Liu wrote:
> > On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote:
> > > On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
> > > > 2016-06-30 17:46
On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote:
> On 6/30/2016 6:28 PM, Thomas Monjalon wrote:
> > 2016-06-30 17:46, Jerin Jacob:
> >> Signed-off-by: Jerin Jacob
> >> Acked-by: Olivier Matz
> >
> > Applied, thanks
> >
>
> Hi Jerin,
>
> This commit cause a compilation error on
On Mon, Jul 04, 2016 at 06:20:42PM +0530, Jerin Jacob wrote:
> > > The former case will have issue as "hw" been used in "if" with
> > > vtpci_with_feature.
> >
> > Oh, my bad. I overlooked it. Sorry for that!
> >
> > > OR
> > >
> > > if you meant just floating "struct virtio_hw *hw" without
>
On Mon, Jul 04, 2016 at 05:45:57PM +0530, Jerin Jacob wrote:
> On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote:
> > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote:
> > > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote:
> > > > On M
On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote:
> On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote:
> > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote:
> > > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote:
> > > > On F
On Mon, Jul 04, 2016 at 02:25:55PM +0530, Jerin Jacob wrote:
> On Mon, Jul 04, 2016 at 03:53:22PM +0800, Yuanhan Liu wrote:
> > On Fri, Jul 01, 2016 at 04:46:38PM +0530, Jerin Jacob wrote:
> > > Added neon based Rx vector implementation.
> > > Selection of the new hand
On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote:
> On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote:
> > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote:
> > > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,
> &
On Fri, Jul 01, 2016 at 04:46:38PM +0530, Jerin Jacob wrote:
> Added neon based Rx vector implementation.
> Selection of the new handler based neon availability at runtime.
> Updated the release notes and MAINTAINERS file.
>
> Signed-off-by: Jerin Jacob
> ---
> MAINTAINERS
On Fri, Jul 01, 2016 at 04:46:37PM +0530, Jerin Jacob wrote:
> * Introduced cpuflag based run-time detection to
> select the SSE based simple Rx handler
> * Split out SSE instruction based virtio simple Rx
> implementation to a separate file
As your commit log says, it does two things, therefore,
On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote:
> @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,
> {
> uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX;
>
> -#ifdef RTE_MACHINE_CPUFLAG_SSSE3
> - struct virtio_hw *hw =
On Fri, Jul 01, 2016 at 08:50:31AM +, Jianfeng Tan wrote:
> When the specified cores and memory lie on different numa socket with
> physical NIC, vhost fails to set up rx queue, and exits without any
> hints. This could leads to confusion of users.
>
> This patch fixes it by adding some error
201 - 300 of 1146 matches
Mail list logo
