Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2023-07-06 Thread Thomas Monjalon
04/07/2023 00:31, Stephen Hemminger: > On Thu, 18 Aug 2022 15:18:36 +0500 > Usman Tanveer wrote: > > > Hi, > > > > Can you please have a look and update the status? > > Looks OK to me. > > Acked-by: Stephen Hemminger better title: examples/ethtool: remove stop before start Applied, thanks.

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2023-07-03 Thread Stephen Hemminger
On Thu, 18 Aug 2022 15:18:36 +0500 Usman Tanveer wrote: > Hi, > > Can you please have a look and update the status? Looks OK to me. Acked-by: Stephen Hemminger

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-08-18 Thread Usman Tanveer
Hi, Can you please have a look and update the status? On Wed, Jul 6, 2022 at 2:49 PM Usman Tanveer wrote: > > It has been there since the file was added (2015). I'm not able to > find any purpose for this. > > Although, it's misleading the messages it shows upon calling > rte_ethtool_net_open()

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-07-06 Thread Usman Tanveer
It has been there since the file was added (2015). I'm not able to find any purpose for this. Although, it's misleading the messages it shows upon calling rte_ethtool_net_open() as mentioned above. And when this function is called even when the port is already UP, it should print a message "device

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-06-26 Thread Thomas Monjalon
27/05/2022 08:42, Usman Tanveer: > There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() > due to which user gets misleading message upon first open/start call. > It says that the > device is already stopped, which should not be the case. This patch > removes rte_eth_dev_stop() from rte_e

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-06-03 Thread Usman Tanveer
Hi, I've submitted a patch on 27th May, 2022. One of the tests is failing and I think it is not related to the patch. Following test is failing: - ci/github-robot: build Can you please rerun the tests so that the patch can be submitted. Regards, -Usman On Fri, May 27, 2022 at 11:42 AM Usman Tan

[PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-05-26 Thread Usman Tanveer
There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() due to which user gets misleading message upon first open/start call. It says that the device is already stopped, which should not be the case. This patch removes rte_eth_dev_stop() from rte_ethtool_net_open(). Signed-off-by: Usman Ta