Re: [dpdk-dev] [PATCH] eal: fix build with conflicting libc variable memory_order

2020-10-15 Thread David Marchand
On Thu, Oct 15, 2020 at 1:16 AM Thomas Monjalon wrote: > > 14/10/2020 08:19, Eli Britstein: > > The cited commit introduced functions with 'int memory_order' argument. > > The C11 standard section 7.17.1.4 defines 'memory_order' as the > > "enumerated type whose enumerators identify memory orderin

Re: [dpdk-dev] [PATCH] eal: fix build with conflicting libc variable memory_order

2020-10-14 Thread Thomas Monjalon
14/10/2020 08:19, Eli Britstein: > The cited commit introduced functions with 'int memory_order' argument. > The C11 standard section 7.17.1.4 defines 'memory_order' as the > "enumerated type whose enumerators identify memory ordering constraints". > Applications that use the standard enum (include

Re: [dpdk-dev] [PATCH] eal: fix build with conflicting libc variable memory_order

2020-10-14 Thread Asaf Penso
>-Original Message- >From: dev On Behalf Of Eli Britstein >Sent: Wednesday, October 14, 2020 9:19 AM >To: dev@dpdk.org >Cc: Eli Britstein >Subject: [dpdk-dev] [PATCH] eal: fix build with conflicting libc variable >memory_order > >The cited commit int

[dpdk-dev] [PATCH] eal: fix build with conflicting libc variable memory_order

2020-10-14 Thread Eli Britstein
The cited commit introduced functions with 'int memory_order' argument. The C11 standard section 7.17.1.4 defines 'memory_order' as the "enumerated type whose enumerators identify memory ordering constraints". Applications that use the standard enum (includes stdatomic.h), will fail compilation wit

Re: [dpdk-dev] [PATCH] eal: fix build on armv7

2020-04-24 Thread David Marchand
On Thu, Apr 23, 2020 at 4:25 PM David Marchand wrote: > > Caught by OBS on armv7: > > In file included from .../lib/librte_eal/include/rte_string_fns.h:21, > from .../lib/librte_kvargs/rte_kvargs.c:9: > .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', > ';

Re: [dpdk-dev] [PATCH] eal: fix build on armv7

2020-04-23 Thread Thomas Monjalon
23/04/2020 16:24, David Marchand: > Caught by OBS on armv7: > > In file included from .../lib/librte_eal/include/rte_string_fns.h:21, > from .../lib/librte_kvargs/rte_kvargs.c:9: > .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', > ';', 'asm' or '__attribu

[dpdk-dev] [PATCH] eal: fix build on armv7

2020-04-23 Thread David Marchand
Caught by OBS on armv7: In file included from .../lib/librte_eal/include/rte_string_fns.h:21, from .../lib/librte_kvargs/rte_kvargs.c:9: .../lib/librte_eal/include/rte_common.h:67:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__rte_aligned' 67 | typedef u

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-15 Thread Ilya Maximets
; Ilya Maximets >> ; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on >> armv8 >> >> In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. >> But 'rte_atomic.h' is a generic header that included to the e

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Thomas Monjalon
14/01/2019 17:50, Honnappa Nagarahalli: > > > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > But 'rte_atomic.h' is a generic header that included to the external apps > > like > > OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8 >

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Honnappa Nagarahalli
> > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the external apps like > OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya Maximets > Sent: Monday, January 14, 2019 4:15 PM > To: dev@dpdk.org; Thomas Monjalon > Cc: Pavan Nikhilesh ; Ilya Maximets > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix b

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Thomas Monjalon
14/01/2019 17:14, Ilya Maximets: > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the > external apps like OVS while building with DPDK. As a result, > clang build of OVS fails on ARMv8 if DPDK built using gcc: > > in

[dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

2019-01-14 Thread Ilya Maximets
In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. But 'rte_atomic.h' is a generic header that included to the external apps like OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8 if DPDK built using gcc: include/generic/rte_atomic.h:215:9: error:

Re: [dpdk-dev] [PATCH] eal: fix build issue

2018-11-06 Thread Thomas Monjalon
06/11/2018 14:31, Jerin Jacob: > From: Thomas Monjalon > > 06/11/2018 12:45, Jerin Jacob: > > > Some toolchain has fls() definition in string.h as argument type int, > > > which is conflicting uint32_t argument type. > > > > > > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > > >

Re: [dpdk-dev] [PATCH] eal: fix build issue

2018-11-06 Thread Jerin Jacob
-Original Message- > Date: Tue, 06 Nov 2018 13:29:19 +0100 > From: Thomas Monjalon > To: Jerin Jacob > Cc: "dev@dpdk.org" , "Jacob, Jerin" > , "sta...@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH] eal: fix build issue > > >

Re: [dpdk-dev] [PATCH] eal: fix build issue

2018-11-06 Thread Thomas Monjalon
06/11/2018 12:45, Jerin Jacob: > Some toolchain has fls() definition in string.h as argument type int, > which is conflicting uint32_t argument type. > > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > error: conflicting types for ‘fls’ > static inline int fls(uint32_t x) >

[dpdk-dev] [PATCH] eal: fix build issue

2018-11-06 Thread Jerin Jacob
Some toolchain has fls() definition in string.h as argument type int, which is conflicting uint32_t argument type. /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: error: conflicting types for ‘fls’ static inline int fls(uint32_t x) ^~~ /opt/marvell-tools-201/aarc

Re: [dpdk-dev] [PATCH] eal: fix build with gcc 4.7

2018-07-18 Thread Thomas Monjalon
16/07/2018 22:52, Gaëtan Rivet: > Hi Pablo, > > On Mon, Jul 16, 2018 at 07:26:27AM +0100, Pablo de Lara wrote: > > Fixed possible out-of-bounds issue: > > > > lib/librte_eal/common/eal_common_devargs.c: > > In function ‘rte_devargs_layers_parse’: > > lib/librte_eal/common/eal_common_devargs.c

Re: [dpdk-dev] [PATCH] eal: fix build with gcc 4.7

2018-07-16 Thread Gaëtan Rivet
Hi Pablo, On Mon, Jul 16, 2018 at 07:26:27AM +0100, Pablo de Lara wrote: > Fixed possible out-of-bounds issue: > > lib/librte_eal/common/eal_common_devargs.c: > In function ‘rte_devargs_layers_parse’: > lib/librte_eal/common/eal_common_devargs.c:121:7: > error: array subscript is abov

[dpdk-dev] [PATCH] eal: fix build with gcc 4.7

2018-07-16 Thread Pablo de Lara
Fixed possible out-of-bounds issue: lib/librte_eal/common/eal_common_devargs.c: In function ‘rte_devargs_layers_parse’: lib/librte_eal/common/eal_common_devargs.c:121:7: error: array subscript is above array bounds Bugzilla ID: 71 Fixes: 338327d731e6 ("devargs: add function to par

Re: [dpdk-dev] [PATCH] eal: fix build with glibc < 2.12

2017-10-26 Thread Thomas Monjalon
26/10/2017 16:05, Gonzalez Monroy, Sergio: > On 25/10/2017 09:36, Ferruh Yigit wrote: > > build error: > >CC rte_cycles.o > >cc1: warnings being treated as errors > >...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c: In function > >‘rdmsr’: > >...dpdk/lib/librte_eal/common/arc

Re: [dpdk-dev] [PATCH] eal: fix build with glibc < 2.12

2017-10-26 Thread Gonzalez Monroy, Sergio
On 25/10/2017 09:36, Ferruh Yigit wrote: build error: CC rte_cycles.o cc1: warnings being treated as errors ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c: In function ‘rdmsr’: ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c:67:2: error: implicit declaration of function

[dpdk-dev] [PATCH] eal: fix build with glibc < 2.12

2017-10-25 Thread Ferruh Yigit
build error: CC rte_cycles.o cc1: warnings being treated as errors ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c: In function ‘rdmsr’: ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c:67:2: error: implicit declaration of function ‘pread’ ...dpdk/lib/librte_eal/common/arch/x86

[dpdk-dev] [PATCH] eal: fix build with Xen dom0 enabled

2015-12-06 Thread Thomas Monjalon
2015-12-03 05:25, Thomas Monjalon: > There is a new function in the EAL API for internal use. > It has neither a proper prefix nor a .map export: > libethdev.so: undefined reference to `is_xen_dom0_supported' > > Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime") > > Signed-off-by: Th

[dpdk-dev] [PATCH] eal: fix build with Xen dom0 enabled

2015-12-03 Thread Thomas Monjalon
There is a new function in the EAL API for internal use. It has neither a proper prefix nor a .map export: libethdev.so: undefined reference to `is_xen_dom0_supported' Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime") Signed-off-by: Thomas Monjalon --- drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [PATCH] eal: fix build

2015-07-30 Thread Thomas Monjalon
2015-07-29 17:08, Thomas Monjalon: > 2015-07-29 15:00, Zhang, Helin: > > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c: > > In function ???rte_eal_pci_probe_one_driver???: > > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c:188:4: > > error: i

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 15:09, Zhang, Helin: > From: Gonzalez Monroy, Sergio > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and > > bsd") > > > > The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set, > > was moved to eal_common_pci.c, but pci_config_space_set w

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
omas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Wednesday, July 29, 2015 1:20 AM > > To: Zhang, Helin > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > > > 2015-07-29 06:48, Helin Zhang: > > > It fixes the bui

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 9:06 AM > To: Zhang, Helin > Cc: Gonzalez Monroy, Sergio; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > 2015-07-29 15:09

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Gonzalez Monroy, Sergio
Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Wednesday, July 29, 2015 1:20 AM >> To: Zhang, Helin >> Cc: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] eal: fix build >> >> 2015-07-29 06:48, Helin Zhang: >>> It fixes the build error

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 8:09 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > 2015-07-29 15:00, Zhang, Helin: > > Hi

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Wednesday, July 29, 2015 8:06 AM > To: Zhang, Helin > Cc: dev at dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > > On 29/07/2015 16:00, Zhang, Helin wrote: > > Hi

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Zhang, Helin
rte_pci_device *dev) ^ cc1: all warnings being treated as errors Regards, Helin > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 1:20 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PAT

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 06:48, Helin Zhang: > It fixes the build error of implicit declaration of function. What is the error? Please show the build log and describe the case when it happens (compiler, version).

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Helin Zhang
It fixes the build error of implicit declaration of function. Signed-off-by: Helin Zhang --- lib/librte_eal/common/include/rte_pci.h | 11 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte

[dpdk-dev] [PATCH] eal: Fix build issue of hotplug with icc

2015-02-28 Thread Thomas Monjalon
> > This patch fixes following errors with icc. > > > > error #188: enumerated type mixed with another type > > return -1; > > > Confirmed that this fixes the issue with ICC 13.1.1. > > Acked-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH] eal: Fix build issue of hotplug with icc

2015-02-27 Thread Mcnamara, John
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, February 27, 2015 5:21 AM > To: dev at dpdk.org > Cc: Mcnamara, John; Tetsuya Mukawa > Subject: [PATCH] eal: Fix build issue of hotplug with icc > > This patch fixes following errors with icc. > > e

[dpdk-dev] [PATCH] eal: Fix build issue of hotplug with icc

2015-02-27 Thread Tetsuya Mukawa
This patch fixes following errors with icc. error #188: enumerated type mixed with another type return -1; Reported-by: Mcnamara, John Signed-off-by: Tetsuya Mukawa --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte

[dpdk-dev] [PATCH] eal: fix build for bsd

2014-07-02 Thread Thomas Monjalon
al Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Wednesday, July 02, 2014 5:22 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] eal: fix build for bsd > > > > When adding link bonding to EAL initializat

[dpdk-dev] [PATCH] eal: fix build for bsd

2014-07-02 Thread Thomas Monjalon
When adding link bonding to EAL initialization (a155d430119), an include was missing for BSD. Signed-off-by: Thomas Monjalon --- lib/librte_eal/bsdapp/eal/eal.c | 1 + 1 file changed, 1 insertion(+) Please, a quick test and acknowledgement of this fix would be helpful. diff --git a/lib/librt

[dpdk-dev] [PATCH] eal: fix build for bsd

2014-07-02 Thread Zhan, Zhaochen
Thanks, Zhaochen > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, July 02, 2014 5:22 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix build for bsd > > When adding link bonding to EAL initia