[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-06 Thread Xu, Qian Q
rkin Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload OK, I will check it tomorrow. Another comment is that "Legacy vhost + virtio-pmd" is not the common use case. Firstly, in this case, virtio-pmd has no TCP/IP stack, TSO is not very meaningful;

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-05 Thread Xu, Qian Q
dpdk.org; Michael S. Tsirkin Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload 2015-11-05 08:49, Xu, Qian Q: > Test Case 1: test_dpdk vhost+ virtio-pmd tso [...] > Test Case 2: test_dpdk vhost+legacy virtio iperf tso [...] > Yes please, I'd like to see a te

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-05 Thread Thomas Monjalon
2015-11-05 08:49, Xu, Qian Q: > Test Case 1: test_dpdk vhost+ virtio-pmd tso [...] > Test Case 2: test_dpdk vhost+legacy virtio iperf tso [...] > Yes please, I'd like to see a test report showing this virtio running with > Linux vhost and without vhost. > We must check that the checksum is

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-05 Thread Xu, Qian Q
ss. Thanks Qian -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Wednesday, November 04, 2015 9:18 PM To: Liu, Jijiang Cc: dev at dpdk.org; Michael S. Tsirkin Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload 2015

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Jijiang Liu
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_rxtx.c | 61 ++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Jijiang Liu
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_rxtx.c | 61 ++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Thomas Monjalon
2015-11-04 12:52, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Please could you check that your virtio implementation works with a vanilla > > Linux with or without vhost? > > Thanks [...] > Xu Qian can send the test report out. Yes please, I'd like to see a

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Liu, Jijiang
age- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Liu, Jijiang > Sent: Wednesday, November 4, 2015 9:08 PM > To: Thomas Monjalon > Cc: dev at dpdk.org; Michael S. Tsirkin > Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX > offload > > &

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Liu, Jijiang
> -Original Message- > From: Liu, Jijiang > Sent: Wednesday, November 4, 2015 8:52 PM > To: 'Thomas Monjalon' > Cc: dev at dpdk.org; Michael S. Tsirkin > Subject: RE: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX > offload > > Hi Thomas, >

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Liu, Jijiang
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, November 4, 2015 7:18 PM > To: Liu, Jijiang > Cc: dev at dpdk.org; Michael S. Tsirkin > Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Liu, Jijiang
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, November 4, 2015 7:18 PM > To: Liu, Jijiang > Cc: dev at dpdk.org; Michael S. Tsirkin > Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost The following

[dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload

2015-11-04 Thread Thomas Monjalon
2015-11-04 18:54, Jijiang Liu: > + /* if vhost TX checksum offload is required */ > + if (m->ol_flags & PKT_TX_IP_CKSUM) { > + hdr->csum_start = m->l2_len; > + hdr->csum_offset = offsetof(struct ipv4_hdr, hdr_checksum); > + } else if (m->ol_flags &