[dpdk-dev] [PATCH 3/4] vhost: log vring changes

2015-12-09 Thread Xie, Huawei
On 12/2/2015 10:09 PM, Victor Kaplansky wrote: > On Wed, Dec 02, 2015 at 11:43:12AM +0800, Yuanhan Liu wrote: >> Invoking vhost_log_write() to mark corresponding page as dirty while >> updating used vring. > Looks good, thanks! > > I didn't find where you log the dirty pages in result of data >

[dpdk-dev] [PATCH 2/4] vhost: introduce vhost_log_write

2015-12-09 Thread Xie, Huawei
On 12/2/2015 9:53 PM, Victor Kaplansky wrote: > On Wed, Dec 02, 2015 at 11:43:11AM +0800, Yuanhan Liu wrote: >> Introduce vhost_log_write() helper function to log the dirty pages we >> touched. Page size is harded code to 4096 (VHOST_LOG_PAGE), and each >> log is presented by 1 bit. >> >>

[dpdk-dev] [PATCH 0/4 for 2.3] vhost-user live migration support

2015-12-09 Thread Xie, Huawei
On 12/2/2015 11:40 AM, Yuanhan Liu wrote: > This patch set adds the initial vhost-user live migration support. > > The major task behind that is to log pages we touched during > live migration. So, this patch is basically about adding vhost > log support, and using it. > > Patchset > > -

[dpdk-dev] [PATCH 2/4] vhost: introduce vhost_log_write

2015-12-09 Thread Yuanhan Liu
On Wed, Dec 09, 2015 at 03:33:16AM +, Xie, Huawei wrote: ... > >> +static inline void __attribute__((always_inline)) > >> +vhost_log_write(struct virtio_net *dev, struct vhost_virtqueue *vq, > >> + uint64_t offset, uint64_t len) > >> +{ > >> + uint64_t addr = vq->log_guest_addr; > >>

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-09 Thread Chao Zhu
Jerin, Both stdio.h and stddef.h works on POWER. To make it work on ARM, I'll use stddef.h and submit another patch. Thanks! On 2015/12/8 17:10, Jerin Jacob wrote: > On Tue, Dec 08, 2015 at 04:28:52PM +0800, Chao Zhu wrote: >> This patch fixes the compile errors caused by lacking of "size_t"

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-09 Thread Chao Zhu
This patch fixes the compile errors caused by lacking of "size_t" definition in rte_hash.h. The compile error exists on IBM POWER and ARM (see jerin.jacob at caviumnetworks.com's message). The errors are like: In file included from /tmp/dpdk/app/test/test_hash_scaling.c:35:0:

[dpdk-dev] Coverity runs

2015-12-09 Thread Vithal Mohare
Hi, Recently upgraded to DPDK version 2.1 and we run coverity periodically. Coverity throwing quite a few warnings and most of them sounds serious issues too. Wondering if coverity is run on released versions of dpdk or any plans to do so in future, if not being done so far. Thanks, -Vithal

[dpdk-dev] Coverity runs

2015-12-09 Thread Vithal Mohare
Sorry for my ignorance, going through archives found coverity related discussions. So, coverity is being run, but rel version 2.1 still has warnings left, may be marked as 'ignore'. Thanks, -Vithal -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Vithal Mohare

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-09 Thread Jerin Jacob
On Wed, Dec 09, 2015 at 12:11:47PM +0800, Chao Zhu wrote: > This patch fixes the compile errors caused by lacking of "size_t" definition > in rte_hash.h. The > compile error exists on IBM POWER and ARM (see jerin.jacob at > caviumnetworks.com's message). remove relative references from git log,

[dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow

2015-12-09 Thread Jijiang Liu
The struct 'rte_eth_tunnel_flow' is only used by struct 'rte_eth_fdir_flow' now, but its name is generic, and I plan to extend new fileds like below to support generic configuration for tunneling packet. struct rte_eth_tunnel_flow { enum rte_eth_fdir_tunnel_type tunnel_type; /**< Tunnel

[dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow

2015-12-09 Thread Lu, Wenzhuo
Hi, Acked-by: Wenzhuo Lu

[dpdk-dev] ivshmem mmap to specific address

2015-12-09 Thread Eli Britstein
Hello, In librte_eal, in eal_ivshmem.c, in function map_all_segments, there is mapping of segments from the metadata to the same virtual address as written in the metadata. Is there a method to guarantee that this mapping won't fail, even for different processes, that might have large code

[dpdk-dev] [PATCH v4 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-09 Thread Panu Matilainen
On 12/08/2015 05:33 PM, Kamil Rytarowski wrote: > Currently rte_eal_check_module() detects Linux kernel modules via reading > /proc/modules. Built-in ones aren't listed there and therefore they are not > being found by the script. > > Add support for checking built-in modules with parsing the

[dpdk-dev] [PATCH] mk: fix install with minimal shell

2015-12-09 Thread Thomas Monjalon
Some shells like dash do not support the syntax {}: {mk,scripts}: No such file or directory Reported-by: Thiago Martins Reported-by: Piotr Bartosiewicz Signed-off-by: Thomas Monjalon --- mk/rte.sdkinstall.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] doc: add fm10k driver

2015-12-09 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" This documentation covers introdutions and limitations on Intel FM1 series products. Signed-off-by: Chen Jing D(Mark) --- doc/guides/nics/fm10k.rst | 54 + doc/guides/nics/index.rst |1 + 2

[dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue

2015-12-09 Thread Azarewicz, PiotrX T
> -Original Message- > From: Mcnamara, John > Sent: Tuesday, December 8, 2015 6:00 PM > To: Mcnamara, John ; Azarewicz, PiotrX T > ; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy > issue > > > -Original Message- > > From: dev

[dpdk-dev] [PATCH 2/4] vhost: introduce vhost_log_write

2015-12-09 Thread Yuanhan Liu
On Wed, Dec 09, 2015 at 05:44:11AM +, Xie, Huawei wrote: > On 12/9/2015 11:41 AM, Yuanhan Liu wrote: > > On Wed, Dec 09, 2015 at 03:33:16AM +, Xie, Huawei wrote: > > ... > +static inline void __attribute__((always_inline)) > +vhost_log_write(struct virtio_net *dev, struct

[dpdk-dev] [PATCH] ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Michael Qiu
From: root strict-aliasing Signed-off-by: Michael Qiu --- .../ip_pipeline/pipeline/pipeline_routing_be.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/examples/ip_pipeline/pipeline/pipeline_routing_be.c

[dpdk-dev] [PATCH] ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Qiu, Michael
Sorry please ignore this :) Thanks, Michael -Original Message- From: Qiu, Michael Sent: Wednesday, December 9, 2015 4:40 PM To: dev at dpdk.org Cc: Singh, Jasvinder; Dumitrescu, Cristian; root; Qiu, Michael Subject: [PATCH] ip_pipeline: Fix compile issue with strict-aliasing From: root

[dpdk-dev] [PATCH] examples/ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Michael Qiu
Compile ip_pipeline in CentOS 6.5 with kernel 2.6.32-431 GCC 4.4.7, will lead below error: pipeline_routing_be.c: In function ?pipeline_routing_msg_req_arp_add_handler?: pipeline_routing_be.c:1817: error: dereferencing pointer ?({anonymous})? does break

[dpdk-dev] [PATCH] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Xie, Huawei
On 12/8/2015 7:24 PM, De Lara Guarch, Pablo wrote: > Fixes following error on gcc 4.4.7: > > make: Entering directory `/tmp/dpdk-tmp/examples/vhost' > CC main.o > cc1: warnings being treated as errors > /tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?: >

[dpdk-dev] [PATCH] examples/ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Singh, Jasvinder
> -Original Message- > From: Qiu, Michael > Sent: Wednesday, December 9, 2015 8:44 AM > To: dev at dpdk.org > Cc: Singh, Jasvinder; Dumitrescu, Cristian; Qiu, Michael > Subject: [PATCH] examples/ip_pipeline: Fix compile issue with strict-aliasing > > Compile ip_pipeline in CentOS 6.5

[dpdk-dev] [PATCH v2 1/1] example/ip_pipeline: fix memcpy issue

2015-12-09 Thread Piotr Azarewicz
The source and destination both are the arrays of cmdline_parse_ctx_t. So the goal is to copy elements size of cmdline_parse_ctx_t not cmdline_parse_ctx_t*. Coverity issue: 120412 Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding dynamically") Fixes: ea0908c4ab89

[dpdk-dev] [PATCH v2] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Pablo de Lara
From: "De Lara Guarch, Pablo" Fixes following error on gcc 4.4.7: make: Entering directory `/tmp/dpdk-tmp/examples/vhost' CC main.o cc1: warnings being treated as errors /tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?:

[dpdk-dev] [PATCH v2] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Bruce Richardson
On Wed, Dec 09, 2015 at 09:39:59AM +, Pablo de Lara wrote: > From: "De Lara Guarch, Pablo" > > Fixes following error on gcc 4.4.7: > > make: Entering directory `/tmp/dpdk-tmp/examples/vhost' > CC main.o > cc1: warnings being treated as errors > /tmp/dpdk-tmp/examples/vhost/main.c: In

[dpdk-dev] ivshmem mmap to specific address

2015-12-09 Thread Burakov, Anatoly
Hi Eli > Is there a method to guarantee that this mapping won't fail, even for > different processes, that might have large code or constructors running even > before main? I'm afraid there is none. That's the nature of the beast. The best you can do is map stuff into a different address range

[dpdk-dev] dev Digest, Vol 68, Issue 68

2015-12-09 Thread Betts, Ian
Date: Fri, 27 Nov 2015 15:09:24 +0200 From: Panu Matilainen To: "Doherty, Declan" , Thomas Monjalon Cc: "dev at dpdk.org" Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state Message-ID: <56585604.9030909 at redhat.com> Content-Type: text/plain;

[dpdk-dev] [PATCH v2] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Xie, Huawei
On 12/9/2015 5:40 PM, De Lara Guarch, Pablo wrote: > From: "De Lara Guarch, Pablo" > > Fixes following error on gcc 4.4.7: > > make: Entering directory `/tmp/dpdk-tmp/examples/vhost' > CC main.o > cc1: warnings being treated as errors > /tmp/dpdk-tmp/examples/vhost/main.c: In function

[dpdk-dev] [PATCH v2 1/1] example/ip_pipeline: fix memcpy issue

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Wednesday, December 9, 2015 9:34 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/1] example/ip_pipeline: fix memcpy issue > > The source and destination both are the arrays of

[dpdk-dev] [PATCH v2] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread De Lara Guarch, Pablo
Hi Huawei, > -Original Message- > From: Xie, Huawei > Sent: Wednesday, December 09, 2015 10:45 AM > To: De Lara Guarch, Pablo; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: Re: [PATCH v2] examples/vhost: fix strict aliasing error on gcc 4.4.7 > > On 12/9/2015 5:40 PM,

[dpdk-dev] Coverity runs

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vithal Mohare > Sent: Wednesday, December 9, 2015 4:38 AM > To: Vithal Mohare; dev at dpdk.org > Subject: Re: [dpdk-dev] Coverity runs > > Sorry for my ignorance, going through archives found coverity related >

[dpdk-dev] [PATCH] ip_pipeline: fix build errors on different linux kernels

2015-12-09 Thread Jasvinder Singh
This patch fixes build errors on linux kernels such as SuSE 11-SP2/3(64 bits), etc. Error Log: error: implicit declaration of function 'WIFEXITED' error: implicit declaration of function 'WEXITSTATUS' Fixes: ed0b2d020159 ("examples/ip_pipeline: add more ports") Signed-off-by:

[dpdk-dev] [PATCH v3] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Pablo de Lara
From: "De Lara Guarch, Pablo" Fixes following error on gcc 4.4.7: make: Entering directory `/tmp/dpdk-tmp/examples/vhost' CC main.o cc1: warnings being treated as errors /tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?:

[dpdk-dev] [PATCH v2] mk: fix external shared library dependencies of libraries

2015-12-09 Thread Panu Matilainen
On 12/08/2015 06:28 PM, Sergio Gonzalez Monroy wrote: > On 08/12/2015 11:47, Panu Matilainen wrote: >> Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but >> for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion >> while at it. >> >> Requiring applications to know

[dpdk-dev] [PATCH v4] Fixes following error on gcc 4.4.7:

2015-12-09 Thread Pablo de Lara
make: Entering directory `/tmp/dpdk-tmp/examples/vhost' CC main.o cc1: warnings being treated as errors /tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?: /tmp/dpdk-tmp/x86_64-native-linuxapp-gcc/include/rte_ring.h:740: error: dereferencing pointer ?mbuf.486? does break

[dpdk-dev] Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

2015-12-09 Thread Piotr Bartosiewicz
W dniu 08.12.2015 o 20:07, Martinx - ? pisze: > On 8 December 2015 at 17:03, Thomas Monjalon > mailto:thomas.monjalon at 6wind.com>> wrote: > > 2015-12-08 18:01, Piotr Bartosiewicz: > > > > > cp: cannot stat > > > >

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Bernard Iremonger
correct sample console commands Fixes: d0dff9ba445e ("doc: sample application user guide" Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") Signed-off-by: Bernard Iremonger --- doc/guides/sample_app_ug/vhost.rst | 40

[dpdk-dev] [PATCH v5 1/2] tools: Add support for handling built-in kernel modules

2015-12-09 Thread Kamil Rytarowski
Currently dpdk_nic_bind.py detects Linux kernel modules via reading /proc/modules. Built-in ones aren't listed there and therefore they are not being found by the script. Add support for checking built-in modules with parsing the sysfs files. This commit obsoletes the /proc/modules parsing

[dpdk-dev] [PATCH v5 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-09 Thread Kamil Rytarowski
Currently rte_eal_check_module() detects Linux kernel modules via reading /proc/modules. Built-in ones aren't listed there and therefore they are not being found by the script. Add support for checking built-in modules with parsing the sysfs files This commit obsoletes the /proc/modules parsing

[dpdk-dev] [PATCH v4 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-09 Thread Kamil Rytarowski
W dniu 09.12.2015 o 08:30, Panu Matilainen pisze: > On 12/08/2015 05:33 PM, Kamil Rytarowski wrote: >> Currently rte_eal_check_module() detects Linux kernel modules via >> reading >> /proc/modules. Built-in ones aren't listed there and therefore they >> are not >> being found by the script. >>

[dpdk-dev] [PATCH v4] Fixes following error on gcc 4.4.7:

2015-12-09 Thread Xie, Huawei
On 12/9/2015 8:20 PM, De Lara Guarch, Pablo wrote: > make: Entering directory `/tmp/dpdk-tmp/examples/vhost' > CC main.o [...] > - rte_ring_sc_dequeue(vpool->ring, (void **)); > + rte_ring_sc_dequeue(vpool->ring, (void *)mbuf); Here we are expecting the address of , not mbuf, which is

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Xie, Huawei
On 12/9/2015 8:36 PM, Iremonger, Bernard wrote: > correct sample console commands > > Fixes: d0dff9ba445e ("doc: sample application user guide" > Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") > Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") > Signed-off-by: Bernard Iremonger

[dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue with 128-byte cache line targets

2015-12-09 Thread Ananyev, Konstantin
Hi Jerin, > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, December 08, 2015 5:49 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; Richardson, Bruce; > olivier.matz at 6wind.com; Dumitrescu, Cristian > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v4] Fixes following error on gcc 4.4.7:

2015-12-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Xie, Huawei > Sent: Wednesday, December 09, 2015 1:29 PM > To: De Lara Guarch, Pablo; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: Re: [PATCH v4] Fixes following error on gcc 4.4.7: > > On 12/9/2015 8:20 PM, De Lara Guarch, Pablo wrote: >

[dpdk-dev] fix mbuf->port for eth_af_packet

2015-12-09 Thread Krauz, Pavel
ves/dev/attachments/20151209/9c636d80/attachment.txt>

[dpdk-dev] [PATCH v4] Fixes following error on gcc 4.4.7:

2015-12-09 Thread Xie, Huawei
On 12/9/2015 10:01 PM, De Lara Guarch, Pablo wrote: > >> -Original Message- >> From: Xie, Huawei >> Sent: Wednesday, December 09, 2015 1:29 PM >> To: De Lara Guarch, Pablo; dev at dpdk.org >> Cc: yuanhan.liu at linux.intel.com >> Subject: Re: [PATCH v4] Fixes following error on gcc 4.4.7:

[dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script

2015-12-09 Thread Neil Horman
On Tue, Dec 08, 2015 at 05:03:26PM +, Robie Basak wrote: > On Wed, Dec 02, 2015 at 06:44:19AM -0500, Neil Horman wrote: > > Theres nothing "complex" about the simple fact that a project builds lots of > > libraries. Its extreemely common. Any graphic window manager has exactly > > the > >

[dpdk-dev] [PATCH] doc: add fm10k driver

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: Chen, Jing D > Sent: Wednesday, December 9, 2015 8:25 AM > To: dev at dpdk.org > Cc: Mcnamara, John; Chen, Jing D > Subject: [PATCH] doc: add fm10k driver > > From: "Chen Jing D(Mark)" > > This documentation covers introdutions and limitations on Intel >

[dpdk-dev] fix mbuf->port for eth_af_packet

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Krauz, Pavel > Sent: Wednesday, December 9, 2015 2:10 PM > To: dev at dpdk.org > Subject: [dpdk-dev] fix mbuf->port for eth_af_packet > > Hello, > Here goes patch for DPDK 2.2.0.rc3 that fixes reported port

[dpdk-dev] [PATCH v5] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Pablo de Lara
From: "De Lara Guarch, Pablo" Fixes following error on gcc 4.4.7: make: Entering directory `/tmp/dpdk-tmp/examples/vhost' CC main.o cc1: warnings being treated as errors /tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?:

[dpdk-dev] [PATCH v5] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Xie, Huawei
On 12/9/2015 10:27 PM, De Lara Guarch, Pablo wrote: > From: "De Lara Guarch, Pablo" > > Fixes following error on gcc 4.4.7: > > make: Entering directory `/tmp/dpdk-tmp/examples/vhost' > CC main.o > cc1: warnings being treated as errors > /tmp/dpdk-tmp/examples/vhost/main.c: In function

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Wiles, Keith
I am having a problem with ?make install T=? command as I was using it before. I would normally build a x86_64-native-linuxapp-gcc, clang and icc or a different config all together. Currently the ?make install T=? gives a warning message at the end of the build plus creates the

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Wednesday, December 9, 2015 12:36 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application > guide > > correct sample console commands > >

[dpdk-dev] Buildroot support for DPDK 2.2.0-rc3

2015-12-09 Thread Santosh Shukla
Its encouraging. Could you pl. post buildroot how-to patch to dpdk-dev mailing list, after your work gets accepted in buildroot. Thanks On Wed, Dec 9, 2015 at 8:10 PM, Jan Viktorin wrote: > Hello, > > I've posted a new patch set with DPDK support into the Buildroot project: > >

[dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue with 128-byte cache line targets

2015-12-09 Thread Jerin Jacob
On Wed, Dec 09, 2015 at 01:44:44PM +, Ananyev, Konstantin wrote: Hi Konstantin, > > Hi Jerin, > > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Tuesday, December 08, 2015 5:49 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com;

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bernard Iremonger > Sent: Wednesday, December 9, 2015 12:36 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application > guide > > correct sample console commands > >

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Thomas Monjalon
2015-12-09 14:39, Wiles, Keith: > I am having a problem with ?make install T=? command as I was using it > before. I would normally build a x86_64-native-linuxapp-gcc, clang and icc or > a different config all together. Currently the ?make install T=? gives a > warning message at the end of the

[dpdk-dev] fix mbuf->port for eth_af_packet

2015-12-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Krauz, Pavel > Sent: Wednesday, December 9, 2015 2:47 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] fix mbuf->port for eth_af_packet > > Hello, > Here goes the patch again in the correct format. > Thanks &

[dpdk-dev] Buildroot support for DPDK 2.2.0-rc3

2015-12-09 Thread Jan Viktorin
On Wed, 9 Dec 2015 20:17:44 +0530 Santosh Shukla wrote: > Its encouraging. > > Could you pl. post buildroot how-to patch to dpdk-dev mailing list, after > your work gets accepted in buildroot. Yes. What exactly do you mean by "how-to patch"? > > Thanks > > On Wed, Dec 9, 2015 at 8:10 PM,

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Thomas Monjalon
2015-12-09 14:50, Mcnamara, John: > Also, as a general note, not just to this document/patch. > > I don't think the "user at target:~$" prefixes used in some DPDK > Doc commandlines is useful. > > It prevents a straight copy and paste for testing, it makes the > literal block lines longer than

[dpdk-dev] Buildroot support for DPDK 2.2.0-rc3

2015-12-09 Thread Santosh Shukla
On Wed, Dec 9, 2015 at 8:34 PM, Jan Viktorin wrote: > > On Wed, 9 Dec 2015 20:17:44 +0530 > Santosh Shukla wrote: > > > Its encouraging. > > > > Could you pl. post buildroot how-to patch to dpdk-dev mailing list, after > > your work gets accepted in buildroot. > > Yes. What exactly do you mean

[dpdk-dev] fix mbuf->port for eth_af_packet

2015-12-09 Thread Thomas Monjalon
2015-12-09 15:03, Mcnamara, John: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Krauz, Pavel > > Hello, > > Here goes the patch again in the correct format. > > Thanks & b.r. > > Pavel > > Hi Pavel, > > There wasn't a patch submitted that I can see. Maybe send a few test emails > to

[dpdk-dev] [PATCH 1/1] arm: set CONFIG_RTE_ARCH_STRICT_ALIGN=y for armv7 target

2015-12-09 Thread Jan Viktorin
This patch reduces number of warnings from 53 to 40. It removes the usual false positives utilizing unaligned_uint*_t data types. Signed-off-by: Jan Viktorin --- As far as I know, only a 64-bit unaligned access can be a problem for ARMv7. I found only one such occurence: 118 struct rte_mbuf *

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Wiles, Keith
On 12/9/15, 8:59 AM, "Thomas Monjalon" wrote: >2015-12-09 14:39, Wiles, Keith: >> I am having a problem with ?make install T=? command as I was using it >> before. I would normally build a x86_64-native-linuxapp-gcc, clang and icc >> or a different config all together. Currently the ?make

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Iremonger, Bernard
Hi John, > Hi Bernard, > > Thanks for that. One comment (in several places): > > > > .. code-block:: console > > > > -user at target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir > /mnt/huge -- -p 0x1 --dev-basename usvhost > > +user at target:~$

[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Iremonger, Bernard
Hi John, > 2015-12-09 14:50, Mcnamara, John: > > Also, as a general note, not just to this document/patch. > > > > I don't think the "user at target:~$" prefixes used in some DPDK Doc > > commandlines is useful. > > > > It prevents a straight copy and paste for testing, it makes the > > literal

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Thomas Monjalon
2015-12-09 15:32, Wiles, Keith: > On 12/9/15, 8:59 AM, "Thomas Monjalon" wrote: > > >2015-12-09 14:39, Wiles, Keith: > >> I am having a problem with ?make install T=? command as I was using it > >> before. I would normally build a x86_64-native-linuxapp-gcc, clang and icc > >> or a different

[dpdk-dev] [PATCH] doc: add patch submit cheatsheet

2015-12-09 Thread Harry van Haaren
This patch adds the patch submission cheatsheet to the contributers guide. Both HTML and PDF docs show the cheatsheet on its own page. Right clicking the SVG image in the HTML doc allows for viewing the image on its own, useful for printing in high quality. The exact appearance of of the

[dpdk-dev] [PATCH v5 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-09 Thread Stephen Hemminger
On Wed, 9 Dec 2015 14:19:58 +0100 Kamil Rytarowski wrote: > + /* Check if there is sysfs mounted */ > + if (stat("/sys/module", ) != 0) { > + RTE_LOG(DEBUG, EAL, "sysfs is not mounted! error %i (%s)\n", > + errno, strerror(errno)); > return

[dpdk-dev] [PATCH v5 2/2] eal/linux: Add support for handling built-in kernel modules

2015-12-09 Thread Kamil Rytarowski
W dniu 09.12.2015 o 17:38, Stephen Hemminger pisze: > On Wed, 9 Dec 2015 14:19:58 +0100 > Kamil Rytarowski wrote: > >> +/* Check if there is sysfs mounted */ >> +if (stat("/sys/module", ) != 0) { >> +RTE_LOG(DEBUG, EAL, "sysfs is not mounted! error %i (%s)\n", >> +

[dpdk-dev] [PATCH] doc: add patch submit cheatsheet

2015-12-09 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > It would be better with a colon: > Fixes: line Ok, will send a v2 with that fix. > > git send-email -N --to > Why -N? -N sets the Number of patches to send, when not sending .patch files but sending the latest commits of

[dpdk-dev] [PATCH] doc: add patch submit cheatsheet

2015-12-09 Thread Thomas Monjalon
2015-12-09 16:47, Van Haaren, Harry: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > It would be better with a colon: > > Fixes: line > > Ok, will send a v2 with that fix. > > > > git send-email -N --to > > Why -N? > > -N sets the Number of patches to send, when not

[dpdk-dev] [PATCH] doc: add patch submit cheatsheet

2015-12-09 Thread Bruce Richardson
On Wed, Dec 09, 2015 at 04:47:42PM +, Van Haaren, Harry wrote: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > It would be better with a colon: > > Fixes: line > > Ok, will send a v2 with that fix. > > > > git send-email -N --to > > Why -N? > > -N sets the Number of

[dpdk-dev] [PATCH v2 1/1] doc: correct Vhost Sample Application guide

2015-12-09 Thread Bernard Iremonger
correct sample console commands changes in v2: remove "user at target:~$" prefixes in command lines. use continuation character to stay within 80 character limit. wrap sample python code. Fixes: d0dff9ba445e ("doc: sample application user guide" Fixes: 9bc23cb8209c ("doc: add vhost-user to

[dpdk-dev] [PATCH v2] doc: add patch submit cheatsheet

2015-12-09 Thread Harry van Haaren
This patch adds the patch submission cheatsheet to the contributers guide. Both HTML and PDF docs show the cheatsheet on its own page. Right clicking the SVG image in the HTML doc allows for viewing the image on its own, useful for printing in high quality. The exact appearance of of the

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Wiles, Keith
On 12/9/15, 10:19 AM, "Thomas Monjalon" wrote: >2015-12-09 15:32, Wiles, Keith: >> On 12/9/15, 8:59 AM, "Thomas Monjalon" wrote: >> >> >2015-12-09 14:39, Wiles, Keith: >> >> I am having a problem with ?make install T=? command as I was using it >> >> before. I would normally build a

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Wiles, Keith
On 12/9/15, 11:31 AM, "dev on behalf of Wiles, Keith" wrote: >On 12/9/15, 10:19 AM, "Thomas Monjalon" wrote: BTW, I am not overly concerned about the build system per say I just wish I had put my $0.02 worth in before the change. We can leave as it is now. The test-build.sh script build does

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Thomas Monjalon
2015-12-09 17:44, Wiles, Keith: > On 12/9/15, 11:31 AM, "dev on behalf of Wiles, Keith" dpdk.org on behalf of keith.wiles at intel.com> wrote: > > >On 12/9/15, 10:19 AM, "Thomas Monjalon" wrote: > > BTW, I am not overly concerned about the build system per say I just wish I > had put my $0.02

[dpdk-dev] building LIBRTE_PMD_XENVIRT in 32bit triggers some errors

2015-12-09 Thread Martinx - ジェームズ
On 4 December 2015 at 21:56, Martinx - ? wrote: > > On 2 December 2015 at 12:05, Christian Ehrhardt > wrote: > > Hi, > > just FYI - building LIBRTE_PMD_XENVIRT in 32bit triggers some errors. > > > > I don't know if that part of the tree is actively maintained - It is > > default off, in the

[dpdk-dev] [PATCH] vfio: support iommu group zero

2015-12-09 Thread Stephen Hemminger
The current implementation of VFIO will not with the new no-IOMMU mode in 4.4 kernel. The original code assumed that IOMMU group zero would never be used. Group numbers are assigned starting at zero, and up until now the group numbers came from the hardware which is likely to use group 0 for

[dpdk-dev] Building with 'make install T=' and 'make config T='

2015-12-09 Thread Thomas Monjalon
2015-12-09 17:31, Wiles, Keith: > On 12/9/15, 10:19 AM, "Thomas Monjalon" wrote: > >Between "make config" and "make" you can modify the configuration. > >In the next release, "make config" will be wrapped by a "configure" script > >which will allow to configure your target in one line. > >So we

[dpdk-dev] [PATCH 6/6] virtio: arm/arm64: memory mapped IO support in pmd driver

2015-12-09 Thread Stephen Hemminger
On Thu, 10 Dec 2015 00:29:30 +0530 Santosh Shukla wrote: > On Tue, Dec 8, 2015 at 6:23 PM, Santosh Shukla wrote: > > > > > > On Mon, Dec 7, 2015 at 10:38 PM, Stephen Hemminger > > wrote: > >> > >> On Fri, 4 Dec 2015 23:05:19 +0530 > >> Santosh Shukla wrote: > >> > >> > > >> > +#ifdef

[dpdk-dev] [PATCH 6/6] virtio: arm/arm64: memory mapped IO support in pmd driver

2015-12-09 Thread Stephen Hemminger
On Thu, 10 Dec 2015 00:49:08 +0530 Santosh Shukla wrote: > On Thu, Dec 10, 2015 at 12:34 AM, Stephen Hemminger > wrote: > > On Thu, 10 Dec 2015 00:29:30 +0530 > > Santosh Shukla wrote: > > > >> On Tue, Dec 8, 2015 at 6:23 PM, Santosh Shukla > >> wrote: > >> > > >> > > >> > On Mon, Dec 7,

[dpdk-dev] [PATCH 5/6] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init()

2015-12-09 Thread Jan Viktorin
On Fri, 4 Dec 2015 23:05:18 +0530 Santosh Shukla wrote: > iopl() syscall not supported in linux-arm/arm64 so always return 0 value. > > Signed-off-by: Santosh Shukla > --- Acked-by: Jan Viktorin

[dpdk-dev] [PATCH] vhost: don't stall if guest is slow

2015-12-09 Thread Thomas Monjalon
2015-12-08 11:12, Yuanhan Liu: > On Tue, Dec 08, 2015 at 03:30:43AM +0100, Thomas Monjalon wrote: > > 2015-12-08 10:23, Yuanhan Liu: > > > On Mon, Dec 07, 2015 at 04:50:21PM -0800, Stephen Hemminger wrote: > > > > When guest is booting (or any othertime guest is busy) it is possible > > > > for

[dpdk-dev] building LIBRTE_PMD_XENVIRT in 32bit triggers some errors

2015-12-09 Thread Thomas Monjalon
2015-12-09 15:54, Martinx - ?: > Sorry to insist on this subject but, the time for releasing DPDK 2.2 > is near and DPDK build with Xen 32-bit is broken. > > If DPDK doesn't fix this, there will be no way to enable XenVirt > support for next Ubuntu LTS 16.04, which is a shame... > > I'm

[dpdk-dev] [PATCH] mk: fix install with minimal shell

2015-12-09 Thread Thomas Monjalon
2015-12-09 09:03, Thomas Monjalon: > Some shells like dash do not support the syntax {}: > {mk,scripts}: No such file or directory > > Reported-by: Thiago Martins > Reported-by: Piotr Bartosiewicz > Signed-off-by: Thomas Monjalon Applied

[dpdk-dev] [PATCH] virtio: fix wrong queue index for VIRTIO_PCI_QUEUE_SEL

2015-12-09 Thread Thomas Monjalon
2015-12-08 11:05, Yuanhan Liu: > We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx, > but not vq->queue_id. > > vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(), > which always starts from 0 no matter which queue it is. However, > for virtio, even number is for RX queue,

[dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER

2015-12-09 Thread Thomas Monjalon
2015-12-09 10:10, Jerin Jacob: > On Wed, Dec 09, 2015 at 12:11:47PM +0800, Chao Zhu wrote: > > This patch fixes the compile errors caused by lacking of "size_t" > > definition in rte_hash.h. The > > compile error exists on IBM POWER and ARM (see jerin.jacob at > > caviumnetworks.com's message).

[dpdk-dev] [PATCH] bnx2x: check sc->state to prevent double init

2015-12-09 Thread Thomas Monjalon
2015-12-08 09:48, Chas Williams: > If the link is up, then the driver cannot be stopped and started > successfully. Instead of checking the link status, use the driver's > state. > > Signed-off-by: Chas Williams <3chas3 at gmail.com> Applied, thanks

[dpdk-dev] [PATCH 2/3] vmxnet3: don't clear vf_table on restart

2015-12-09 Thread Yong Wang
On 12/3/15, 5:05 PM, "Stephen Hemminger" wrote: >From: "Charles (Chas) Williams" > >From: Charles (Chas) Williams > >During an MTU change, the adapter is restarted. If hardware VLAN offload >is in use, this existing filter table would also be cleared. Instead, >setup the shadow table once

[dpdk-dev] [PATCH 2/2] ethtool: fix dead code

2015-12-09 Thread Thomas Monjalon
2015-12-08 16:58, Remy Horton: > Beat me to it.. :) > > On 08/12/2015 16:51, Stephen Hemminger wrote: > > Remove dead code, and print better return for other errors. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Remy Horton Series applied, thanks

[dpdk-dev] [PATCH 3/3] vmxnet3: fix vlan_offload_set

2015-12-09 Thread Yong Wang
On 12/3/15, 5:05 PM, "Stephen Hemminger" wrote: >From: Nachiketa Prachanda > >vmxnet3_dev_vlan_offload_set(dev, mask) was incorrectly treating the >mask parameter as the bitmask for vlan_strip and vlan_filter, whereas >the mask indicates only what has changed - the values for >vlan_stripping

[dpdk-dev] [PATCH] examples/ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Thomas Monjalon
> > Compile ip_pipeline in CentOS 6.5 with kernel 2.6.32-431 GCC 4.4.7, will > > lead > > below error: > > > > pipeline_routing_be.c: In function > > ?pipeline_routing_msg_req_arp_add_handler?: > > pipeline_routing_be.c:1817: error: dereferencing pointer ?({anonymous})? > >

[dpdk-dev] [PATCH v2 1/1] example/ip_pipeline: fix memcpy issue

2015-12-09 Thread Thomas Monjalon
> > The source and destination both are the arrays of cmdline_parse_ctx_t. > > So the goal is to copy elements size of cmdline_parse_ctx_t not > > cmdline_parse_ctx_t*. > > > > Coverity issue: 120412 > > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding > > dynamically") > >

[dpdk-dev] [PATCH] ip_pipeline: fix build errors on different linux kernels

2015-12-09 Thread Thomas Monjalon
2015-12-09 11:12, Jasvinder Singh: > This patch fixes build errors on linux kernels such as > SuSE 11-SP2/3(64 bits), etc. > > Error Log: > error: implicit declaration of function 'WIFEXITED' > error: implicit declaration of function 'WEXITSTATUS' > > Fixes: ed0b2d020159

[dpdk-dev] [PATCH v5] examples/vhost: fix strict aliasing error on gcc 4.4.7

2015-12-09 Thread Thomas Monjalon
2015-12-09 14:33, Xie, Huawei: > On 12/9/2015 10:27 PM, De Lara Guarch, Pablo wrote: > > From: "De Lara Guarch, Pablo" > > > > Fixes following error on gcc 4.4.7: > > > > make: Entering directory `/tmp/dpdk-tmp/examples/vhost' > > CC main.o > > cc1: warnings being treated as errors > >

[dpdk-dev] [PATCH] vfio: support iommu group zero

2015-12-09 Thread Thomas Monjalon
2015-12-09 09:55, Stephen Hemminger: > The current implementation of VFIO will not with the new no-IOMMU mode > in 4.4 kernel. The original code assumed that IOMMU group zero would > never be used. Group numbers are assigned starting at zero, and up > until now the group numbers came from the

[dpdk-dev] [PATCH] vfio: support iommu group zero

2015-12-09 Thread Stephen Hemminger
On Wed, 09 Dec 2015 22:12:33 +0100 Thomas Monjalon wrote: > So I guess you have tested the VFIO no-iommu patch. > Is it working well with DPDK with only this patch for group zero? > Have you talked to Alex Williamson? I did test it enough to bring up a link but I needed this patch. The patch

[dpdk-dev] [PATCH] vfio: support iommu group zero

2015-12-09 Thread Stephen Hemminger
On Wed, 09 Dec 2015 22:12:33 +0100 Thomas Monjalon wrote: > 2015-12-09 09:55, Stephen Hemminger: > > The current implementation of VFIO will not with the new no-IOMMU mode > > in 4.4 kernel. The original code assumed that IOMMU group zero would > > never be used. Group numbers are assigned

  1   2   >