[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On 9 May 2016 at 20:11, Jerin Jacob wrote: > On Mon, May 09, 2016 at 07:02:36PM +0800, Jianbo Liu wrote: >> On 9 May 2016 at 17:06, Jerin Jacob >> wrote: >> > On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote: >> >> This patch introduces dpaa2 machine target to address difference

[dpdk-dev] [PATCH 2/6] vhost: add vhost-user client mode

On Mon, May 09, 2016 at 01:33:08PM -0700, Yuanhan Liu wrote: > On Mon, May 09, 2016 at 06:33:45AM -0400, Victor Kaplansky wrote: > > Adding a flag for a future extension seems fine to me. > > Could we manage without adding a flag? > > For example, could we always try a client mode for a while at

[dpdk-dev] [PATCH] armv7a: disable qede pmd

The qede PMD driver is failing when building for ARMv7: drivers/net/qede/base/ecore_dev.c: In function ?ecore_hw_init_pf?: drivers/net/qede/base/ecore_dev.c:1150:6: error: variable ?prs_reg? set but not used [-Werror=unused-but-set-variable] u32 prs_reg; ^ [...]

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On 10 May 2016 at 00:17, Jerin Jacob wrote: > On Mon, May 09, 2016 at 11:22:15PM +0800, Jianbo Liu wrote: >> On 9 May 2016 at 20:11, Jerin Jacob >> wrote: >> > On Mon, May 09, 2016 at 07:02:36PM +0800, Jianbo Liu wrote: >> >> On 9 May 2016 at 17:06, Jerin Jacob >> >> wrote: >> >> > On Mon,

[dpdk-dev] [PATCH v2] i40evf: fix return value if command fails

Previously, if message is sent successfully, but no response is received, function "i40evf_execute_vf_cmd" will return without error. The root cause is value "err" is overwritten. This patch fixes it. Fixes: ae19955e7c86 ("i40evf: support reporting PF reset") Signed-off-by: Jingjing Wu --- v2

[dpdk-dev] [PATCH 0/6] vhost: add vhost-user client mode and reconnect ability

Do we need patch qemu for the reconnect case? Thanks Qian -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yuanhan Liu Sent: Saturday, May 07, 2016 2:40 PM To: dev at dpdk.org Cc: Xie, Huawei; Yuanhan Liu Subject: [dpdk-dev] [PATCH 0/6] vhost: add vhost-user

[dpdk-dev] [PATCH] mk: Introduce NXP dpaa2 architecture based on armv8-a

On Tue, May 10, 2016 at 10:10:07AM +0800, Jianbo Liu wrote: > On 10 May 2016 at 00:17, Jerin Jacob > wrote: > > On Mon, May 09, 2016 at 11:22:15PM +0800, Jianbo Liu wrote: > >> On 9 May 2016 at 20:11, Jerin Jacob > >> wrote: > >> > On Mon, May 09, 2016 at 07:02:36PM +0800, Jianbo Liu wrote: >

[dpdk-dev] [PATCHv2 1/2] mk:disabling CONFIG_RTE_EAL_IGB_UIO for armv8a

The compilation with upstream kernel is broken with this config as enabled. Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-armv8a-linuxapp-gcc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc

[dpdk-dev] [PATCHv2 2/2] mk: Introduce NXP dpaa2 architecture based on armv8-a

This patch introduces dpaa2 machine target to address difference in cpu parameter, number of core to 8 and no numa support w.r.t default armv8-a machine Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 42 ++ mk/machine/dpaa2/rte.vars.mk

[dpdk-dev] [PATCHv2 1/2] mk:disabling CONFIG_RTE_EAL_IGB_UIO for armv8a

On Tue, May 10, 2016 at 05:25:33PM +0530, Hemant Agrawal wrote: > The compilation with upstream kernel is broken with this config as enabled. > few nits: - 'mk:..' subject header looks incorrect, you can start with config/armv8a: disable igb_uio - Also pl. reword the description- perhaps

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On 5/10/2016 2:08 AM, Yuanhan Liu wrote: > On Mon, May 09, 2016 at 04:47:02PM +, Xie, Huawei wrote: >> On 5/7/2016 2:36 PM, Yuanhan Liu wrote: >>> +static void * >>> +vhost_user_client_reconnect(void *arg) >>> +{ >>> + struct reconnect_info *reconn = arg; >>> + int ret; >>> + >>> +

[dpdk-dev] [PATCH 02/20] thunderx/nicvf: add pmd skeleton

On Mon, May 09, 2016 at 10:41:22AM -0700, Stephen Hemminger wrote: > On Sat, 7 May 2016 20:46:20 +0530 > Jerin Jacob wrote: > > > + > > +static inline struct nicvf* > > +nicvf_pmd_priv(struct rte_eth_dev *eth_dev) > > +{ > > + return (struct nicvf *)eth_dev->data->dev_private; > > +} > > Cast

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On Tue, May 10, 2016 at 07:24:10AM +, Xie, Huawei wrote: > On 5/10/2016 2:08 AM, Yuanhan Liu wrote: > > On Mon, May 09, 2016 at 04:47:02PM +, Xie, Huawei wrote: > >> On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > >>> +static void * > >>> +vhost_user_client_reconnect(void *arg) > >>> +{ > >>> +

[dpdk-dev] DPDK Community Call - 16.04 Retrospective - Wednesday May 11th

Hi all Just a reminder about the 16.04 Retrospective Call tomorrow. All the call-in details are provided in Tim's email below Chat then! Mike -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of O'Driscoll, Tim Sent: Friday, April 29, 2016 3:09 PM To: dev at

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On 5/10/2016 3:56 PM, Michael S. Tsirkin wrote: > On Tue, May 10, 2016 at 07:24:10AM +, Xie, Huawei wrote: >> On 5/10/2016 2:08 AM, Yuanhan Liu wrote: >>> On Mon, May 09, 2016 at 04:47:02PM +, Xie, Huawei wrote: On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > +static void * >

[dpdk-dev] [PATCH] mbuf: add helpers to prefetch mbuf

Hi, On 05/10/2016 12:02 AM, Wiles, Keith wrote: >> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >> index 529debb..e3ee0b3 100644 >> --- a/lib/librte_mbuf/rte_mbuf.h >> +++ b/lib/librte_mbuf/rte_mbuf.h >> @@ -842,6 +842,44 @@ struct rte_mbuf { >> uint16_t timesync; >>

[dpdk-dev] rte_malloc

Hi, On 09/05/2016 18:32, Mahdi Moradmand Badie wrote: > Hello All, > > I had a problem regarding use the rte_malloc. > I want to know if I want to use rte_malloc instead of malloc just mak > change like this > struct lcore_params *p = malloc >

[dpdk-dev] [PATCH v1 1/1] enic: fix local ol_flags variable

Expand local ol_flags field to 64-bits. The offload flags field (ol_flags) in rte_mbuf structure is 64-bits, so local copy of it must be 64-bits too. Moreover bit comparison between 16-bits variable and 64-bits value make no sense. CID 13218 : Operands don't affect result

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > When DPDK app crashes (or quits, or gets killed), and when QEMU supports > reconnecting (patches have been sent, not merged yet), a restart of DPDK > app would get stale vring base from QEMU. That would break the kernel > virtio net completely, making it

[dpdk-dev] [PATCH] arm64: change rte_memcpy to inline function

Other APP may call rte_memcpy by function pointer, so change it to an inline function. Signed-off-by: Jianbo Liu --- lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [RFC] mbuf: remove unused rx error flags

Following the discussions from: http://dpdk.org/ml/archives/dev/2015-July/021721.html http://dpdk.org/ml/archives/dev/2016-April/038143.html The value of these flags is 0, making them useless. Today, no example application checks them on RX, and only few drivers sets them, and silently give wrong

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On Tue, May 10, 2016 at 08:07:00AM +, Xie, Huawei wrote: > On 5/10/2016 3:56 PM, Michael S. Tsirkin wrote: > > On Tue, May 10, 2016 at 07:24:10AM +, Xie, Huawei wrote: > >> On 5/10/2016 2:08 AM, Yuanhan Liu wrote: > >>> On Mon, May 09, 2016 at 04:47:02PM +, Xie, Huawei wrote: > On

[dpdk-dev] [PATCH v3] eal: make hugetlb initialization more robust

Hi Jianfeng, On 09/05/2016 11:48, Jianfeng Tan wrote: > /* find physical addresses and sockets for each hugepage */ > @@ -1172,8 +1255,9 @@ rte_eal_hugepage_init(void) > hp_offset += new_pages_count[i]; > #else > /* remap all hugepages */ > -

[dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer keys

On 09/05/2016 14:59, David Harton (dharton) wrote: [..] >> } >> >> - > > Not sure how the community feels about white-space only changes. > Just mentioning in case some folks get excited about it. One here and a few > below. I doubt it'll be showstopper. In any case hoping to get a v3 out

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On 5/10/2016 4:42 PM, Michael S. Tsirkin wrote: > On Tue, May 10, 2016 at 08:07:00AM +, Xie, Huawei wrote: >> On 5/10/2016 3:56 PM, Michael S. Tsirkin wrote: >>> On Tue, May 10, 2016 at 07:24:10AM +, Xie, Huawei wrote: On 5/10/2016 2:08 AM, Yuanhan Liu wrote: > On Mon, May 09,

[dpdk-dev] [PATCH] sched: fix useless call

Fix issue reported by Coverity. Coverity ID 13338 A function call that seems to have an intended effect has no actual effect on the logic of the program. In rte_sched_port_free: A function is called that is only useful for its return value, and this value is ignored. Fixes: de3cfa2c9823

[dpdk-dev] Ring PMD: why are stats counters atomic?

Hello, Per-queue stats counters are defined as rte_atomic64_t, in the tx/rx functions, they are atomically increased if the rings have the multiple consumers/producer flag enabled. According to the design principles, the application should not invoke those functions on the same queue on

[dpdk-dev] [PATCH v3] eal: make hugetlb initialization more robust

Hi Sergio, > -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Tuesday, May 10, 2016 4:55 PM > To: Tan, Jianfeng; dev at dpdk.org > Cc: david.marchand at 6wind.com; nhorman at tuxdriver.com > Subject: Re: [PATCH v3] eal: make hugetlb initialization more robust > > > Hi

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

On Tue, May 10, 2016 at 09:00:45AM +, Xie, Huawei wrote: > On 5/10/2016 4:42 PM, Michael S. Tsirkin wrote: > > On Tue, May 10, 2016 at 08:07:00AM +, Xie, Huawei wrote: > >> On 5/10/2016 3:56 PM, Michael S. Tsirkin wrote: > >>> On Tue, May 10, 2016 at 07:24:10AM +, Xie, Huawei wrote: >

[dpdk-dev] [PATCH 9/9] doc: update ipsec sample guide

Hi, Thanks for the updated docs and clear examples. Some minor comments below. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Friday, May 6, 2016 5:32 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 9/9] doc: update

[dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology

From: Arkadiusz Kusztal Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/qat/Makefile | 1 + drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +--- 2 files

[dpdk-dev] Ring PMD: why are stats counters atomic?

On Tue, May 10, 2016 at 11:13:08AM +0200, Mauricio V?squez wrote: > Hello, > > Per-queue stats counters are defined as rte_atomic64_t, in the tx/rx > functions, they are atomically increased if the rings have the multiple > consumers/producer flag enabled. > > According to the design principles,

[dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation

>-Original Message- >From: Dumitrescu, Cristian >Sent: Thursday, April 28, 2016 1:16 PM >To: Jastrzebski, MichalX K ; Zhang, Roy Fan >; Singh, Jasvinder >Cc: dev at dpdk.org; Mrozowicz, SlawomirX >Subject: RE: [PATCH v3] examples/qos_sched: fix bad bit shift operation > > > >>

[dpdk-dev] [PATCHv2 0/5] add packet capture framework

This patchset include below changes 1)Changes to librte_ether. 2)New library librte_pdump added for packet capture framework. 3)New app/pdump tool added for packet capturing. 4)Test pmd changes done to initialize packet capture framework. 5)Documentation update. 1)librte_pdump == To

[dpdk-dev] [PATCHv2 1/5] librte_ether: protect add/remove of rxtx callbacks with spinlocks

* added spinlocks around add/remove logic of rxtx callbacks to avoid corruption of callback lists in multithreaded context. * added new public api rte_eth_add_first_rx_callback to add given callback as head of list. * converted rte_eth_dev_get_port_by_name to public API. * add new fields to

[dpdk-dev] [PATCHv2 4/5] app/test-pmd: add pdump initialization uninitialization

call rte_pdump_init and rte_pdump_uninit for packet capturing initialization and uninitialization. Signed-off-by: Reshma Pattan --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 26a174c..e131363 100644 ---

[dpdk-dev] [PATCHv2 2/5] lib/librte_pdump: add new library for packet capturing support

Added new library for packet capturing support. Added public api rte_pdump_init, applications should call this as part of their application setup to have packet capturing framework ready. Added public api rte_pdump_uninit to un initialize the packet capturing framework. Added public apis

[dpdk-dev] [PATCHv2 3/5] app/pdump: add pdump tool for packet capturing

New tool added for packet capturing on dpdk. This tool supports command line options. This tool runs as secondary process by default. Command line supports various parameters to capture the packets. User should pass on a)port and queue (or) b)pci address and queue (or) c)device name and queue to

[dpdk-dev] [PATCHv2 5/5] doc: update doc for packet capture framework

added programmers guide for librte_pdump. added sample application guide for app/pdump application. updated release note for packet capture framework changes. Signed-off-by: Reshma Pattan --- MAINTAINERS | 3 + doc/guides/prog_guide/index.rst | 1 +

[dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation

> -Original Message- > From: Mrozowicz, SlawomirX > Sent: Tuesday, May 10, 2016 10:40 AM > To: Dumitrescu, Cristian ; Jastrzebski, > MichalX K ; Zhang, Roy Fan > ; Singh, Jasvinder > Cc: dev at dpdk.org > Subject: RE: [PATCH v3] examples/qos_sched: fix bad bit shift operation > > >

[dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology

Acked-by: Deepak Kumar JAIN -Original Message- From: Kusztal, ArkadiuszX Sent: Tuesday, May 10, 2016 10:24 AM To: dev at dpdk.org Cc: Trahe, Fiona ; Griffin, John ; Jain, Deepak K ; Kusztal, ArkadiuszX Subject: [PATCH] qat: change optimization flag for Intel QuickAssist Technology

[dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0

With gcc >= 6.0, qede base driver fails to build with: drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common': cc1: error: left shift of negative value [-Werror=shift-negative-value] Since the base drivers are untouchable, work around by disabling the warning. Signed-off-by: Panu

[dpdk-dev] [PATCHv2 0/5] add packet capture framework

On 10/05/2016 10:39, Reshma Pattan wrote: [..] > Reshma Pattan (5): >librte_ether: protect add/remove of rxtx callbacks with spinlocks >lib/librte_pdump: add new library for packet capturing support >app/pdump: add pdump tool for packet capturing >app/test-pmd: add pdump

[dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get

On 07/05/2016 01:14, Rasesh Mody wrote: [..] >>> Enhance the stats_get() routine to display drop counters under imissed >>> counter. >>> Added extended stats get support to provide additional info. >>> Encorporated review comment to rename some of the stats. [..] > We shall split this patch into

[dpdk-dev] [PATCH v1] igu_uio: fix IOMMU domain issue

Problem: The following operations will cause the igb_uio based DPDK operation failed. --Any device assignment through the kvm_assign_device interface, this can be the pci-assign method in QEMU --VFIO group attachment operation(attach to the container) this can happens in vfio-pci assignment in

[dpdk-dev] [PATCH] qede: fix icc build error

fix errors: icc: command line warning #10006: ignoring unknown option '-Wno-unused-value' icc: command line warning #10006: ignoring unknown option '-Wno-format-nonliteral' icc: command line warning #10006: ignoring unknown option '-Wno-shift-negative-value' qede/base/ecore_dev.c(1643): error

[dpdk-dev] [PATCH 15/15] vfio: change VFIO init to be extendable

Hi Jan, > We can now just OR the vfio_enabled sequentially and so adding new VFIO > subsystems (vfio_platform) is possible. > > Signed-off-by: Jan Viktorin > --- > lib/librte_eal/linuxapp/eal/eal.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git

[dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of pci_vfio_map_resource

Hi Jan, > /* > - * at this point, we know at least one port on this device is bound to > VFIO, > - * so we can proceed to try and set this particular port up > - */ > - > - /* check if the group is viable */ > - ret = ioctl(vfio_group_fd, VFIO_GROUP_GET_STATUS, >

[dpdk-dev] [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c

Hi Jan, > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c > @@ -39,10 +39,282 @@ > #include > #include > #include > +#include > > #include "eal_filesystem.h" > #include "eal_vfio.h" I believe the eal_private.h should be local include (in

[dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation

Fix issue reported by Coverity. Coverity ID 30690: Bad bit shift operation large_shift: In expression 1ULL << i, left shifting by more than 63 bits has undefined behavior. The shift amount, i, is as much as 127. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Slawomir Mrozowicz

[dpdk-dev] [PATCH 00/15] Make VFIO support independent on PCI

On Fri, Apr 29, 2016 at 7:14 PM, Jan Viktorin wrote: > > Hello, > > here follows several patchs extracting the general VFIO code out of the > PCI + VFIO code base. Usually, it's just move and rename of functions. > The most complicated ones are: > > * eal/linux: extract setup logic out of

[dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in macswap loop

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, May 03, 2016 11:20 AM > To: Ivan Boule > Cc: Jerin Jacob; dev at dpdk.org; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add packet data prefetch in >

[dpdk-dev] [PATCH 0/2] l2fwd improvements

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > Sent: Tuesday, April 19, 2016 10:35 AM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Richardson, Bruce > ; De Lara Guarch, Pablo > ; Jerin Jacob > > Subject: [dpdk-dev] [PATCH 0/2]

[dpdk-dev] [PATCH 00/15] Make VFIO support independent on PCI

Hello Santosh, On Tue, 10 May 2016 17:48:23 +0530 Santosh Shukla wrote: > On Fri, Apr 29, 2016 at 7:14 PM, Jan Viktorin > wrote: > > > > Hello, > > > > here follows several patchs extracting the general VFIO code out of the > > PCI + VFIO code base. Usually, it's just move and rename of

[dpdk-dev] [PATCH 15/15] vfio: change VFIO init to be extendable

Hello Anatoly, On Tue, 10 May 2016 11:50:23 + "Burakov, Anatoly" wrote: > Hi Jan, > > > We can now just OR the vfio_enabled sequentially and so adding new VFIO > > subsystems (vfio_platform) is possible. > > > > Signed-off-by: Jan Viktorin > > --- > > lib/librte_eal/linuxapp/eal/eal.c |

[dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of pci_vfio_map_resource

On Tue, 10 May 2016 11:53:21 + "Burakov, Anatoly" wrote: > Hi Jan, > > > > /* > > -* at this point, we know at least one port on this device is bound to > > VFIO, > > -* so we can proceed to try and set this particular port up > > -*/ > > - > > - /* check if the group is

[dpdk-dev] [PATCH 10/15] vfio: extract setup logic out of pci_vfio_map_resource

On Tue, 10 May 2016 14:58:26 +0200 Jan Viktorin wrote: > On Tue, 10 May 2016 11:53:21 + > "Burakov, Anatoly" wrote: > > > Hi Jan, > > > > > > > /* > > > - * at this point, we know at least one port on this device is bound to > > > VFIO, > > > - * so we can proceed to try and set

[dpdk-dev] [PATCH v2] examples/vm_power_manager: buffer not null terminated

CID30691: If the buffer is treated as a null terminated string in later operations, a buffer overflow or over-read may occur. In add_vm: The string buffer may not have a null terminator if the source string's length is equal to the buffer size Fixes: e8ae9b662506 ("examples/vm_power: channel

[dpdk-dev] [PATCH v3 2/4] ixgbe: implement vector PMD for arm architecture

On Fri, May 06, 2016 at 11:55:46AM +0530, Jianbo Liu wrote: > use ARM NEON intrinsic to implement ixgbe vPMD > > Signed-off-by: Jianbo Liu > --- > drivers/net/ixgbe/Makefile | 4 + > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 561 > > 2 files

[dpdk-dev] [PATCH] vmxnet3: VLAN tag on end packet, not first

On Tue, Apr 12, 2016 at 04:08:04PM -0700, John Guzik wrote: > Signed-off-by: John Guzik > Fixes: 9fd5e98b > > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > Applied to dpdk-next-net/rel_16_07, with corrected fixes line,

[dpdk-dev] [PATCH] vhost: fix buffer not null terminated

Fix issue reported by Coverity. Coverity ID 124556 If the buffer is treated as a null terminated string in later operations, a buffer overflow or over-read may occur. In vhost_set_ifname: The string buffer may not have a null terminator if the source string's length is equal to the buffer size

[dpdk-dev] rte_malloc

Thanks Sergio, Yes sure, I attached files, it seems so easy but doesn't work. Thanks, On 10 May 2016 at 04:12, Sergio Gonzalez Monroy < sergio.gonzalez.monroy at intel.com> wrote: > Hi, > > On 09/05/2016 18:32, Mahdi Moradmand Badie wrote: > >> Hello All, >> >> I had a problem regarding use the

[dpdk-dev] rte_malloc

Thanks Sergio, Yes sure, I attached files, it seems so easy but doesn't work. Thanks, On 10 May 2016 at 04:12, Sergio Gonzalez Monroy < sergio.gonzalez.monroy at intel.com> wrote: > Hi, > > On 09/05/2016 18:32, Mahdi Moradmand Badie wrote: > >> Hello All, >> >> I had a problem regarding use the

[dpdk-dev] rte_malloc

Forgot to ask, What's the command line you are using to run the app? Sergio On 10/05/2016 16:17, Mahdi Moradmand Badie wrote: > Thanks Sergio, > Yes sure, > I attached files, it seems so easy but doesn't work. > Thanks, > > On 10 May 2016 at 04:12, Sergio Gonzalez Monroy >

[dpdk-dev] [PATCH 05/15] i40e/base: fixup Geneve VNI for HW use

On Thu, May 05, 2016 at 04:53:34PM +0800, Helin Zhang wrote: > The hardware doesn't layout the Geneve VNI quite the same > as the VxLAN VNI, so it needs to adjust it before sending > through the AQ commands as the workaround. > > Signed-off-by: Helin Zhang Please expand out acronyms like VNI in

[dpdk-dev] rte_malloc

#!/bin/sh ./build/app/Mahdi_test -c 0x55 --master-lcore 0 On 10 May 2016 at 11:31, Sergio Gonzalez Monroy < sergio.gonzalez.monroy at intel.com> wrote: > Forgot to ask, > > What's the command line you are using to run the app? > > Sergio > > > On 10/05/2016 16:17, Mahdi Moradmand Badie wrote: >

[dpdk-dev] [PATCH v1] igu_uio: fix IOMMU domain issue

On Tue, 10 May 2016 19:21:41 +0800 Zhe Tao wrote: > Problem: > The following operations will cause the igb_uio based DPDK > operation failed. > --Any device assignment through the kvm_assign_device interface, > this can be the pci-assign method in QEMU > --VFIO group attachment operation(attach

[dpdk-dev] rte_malloc

Have you tried to run the unit tests? (Run 'app/test' application, then 'malloc_autotest') Sergio On 10/05/2016 16:55, Mahdi Moradmand Badie wrote: > #!/bin/sh > ./build/app/Mahdi_test -c 0x55 --master-lcore 0 > > On 10 May 2016 at 11:31, Sergio Gonzalez Monroy >

[dpdk-dev] rte_malloc

No, I don't have any idea? :) On 10 May 2016 at 12:12, Sergio Gonzalez Monroy < sergio.gonzalez.monroy at intel.com> wrote: > Have you tried to run the unit tests? (Run 'app/test' application, then > 'malloc_autotest') > > Sergio > > > On 10/05/2016 16:55, Mahdi Moradmand Badie wrote: > >

[dpdk-dev] [PATCH 10/16] vhost: export vid as the only interface to applications

On Mon, May 2, 2016 at 3:25 PM, Yuanhan Liu wrote: > With all the previous prepare works, we are just one step away from > the final ABI refactoring. That is, to change current API to let them > stick to vid instead of the old virtio_net dev. > This patch removes the only assignment to

[dpdk-dev] [RFC] mbuf: new flag when vlan is stripped

The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in PMDs not advertising the same flags in similar conditions. Following discussion in http://dpdk.org/ml/archives/dev/2016-April/037837.html, introduce 2 new flags PKT_RX_VLAN_STRIPPED and PKT_RX_QINQ_STRIPPED that are better

[dpdk-dev] [PATCH 10/16] vhost: export vid as the only interface to applications

On Tue, May 10, 2016 at 09:17:23AM -0700, Rich Lane wrote: > On Mon, May 2, 2016 at 3:25 PM, Yuanhan Liu > wrote: > > With all the previous prepare works, we are just one step away from > the final ABI refactoring. That is, to change current API to let them > stick to vid instead of

[dpdk-dev] [PATCH] sched: fix useless call

On 5/10/2016 11:11 AM, Daniel Mrzyglod wrote: > Fix issue reported by Coverity. > Coverity ID 13338 > > A function call that seems to have an intended effect has no actual effect > on the logic of the program. > > In rte_sched_port_free: A function is called that is only useful for its > return

[dpdk-dev] [PATCH 10/16] vhost: export vid as the only interface to applications

On Tue, May 10, 2016 at 9:39 AM, Yuanhan Liu wrote: > > Rich, would you help try by adding following line there and > do a test? It would be great if this patch has your Tested-by :) > > internal->vid = vid; > The problem is new_device has already returned before that point because

[dpdk-dev] [PATCH] vhost: add support for dynamic vhost PMD creation

On 5/9/2016 10:31 PM, Yuanhan Liu wrote: > On Thu, May 05, 2016 at 07:11:09PM +0100, Ferruh Yigit wrote: >> Add rte_eth_from_vhost() API to create vhost PMD dynamically from >> applications. > > This sounds a good idea to me. It could be better if you name a good > usage of it though. > >> >>

[dpdk-dev] [PATCH 3/6] vhost: add reconnect ability

> On Tue, May 10, 2016 at 09:00:45AM +, Xie, Huawei wrote: > > On 5/10/2016 4:42 PM, Michael S. Tsirkin wrote: > > > On Tue, May 10, 2016 at 08:07:00AM +, Xie, Huawei wrote: > > >> On 5/10/2016 3:56 PM, Michael S. Tsirkin wrote: > > >>> On Tue, May 10, 2016 at 07:24:10AM +, Xie, Huawei

[dpdk-dev] [PATCH] sched: fix useless call

> -Original Message- > From: Mrzyglod, DanielX T > Sent: Tuesday, May 10, 2016 11:11 AM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] sched: fix useless call > > Fix issue reported by Coverity. > Coverity ID 13338 > > A function call that

[dpdk-dev] [PATCH 10/16] vhost: export vid as the only interface to applications

On Tue, May 10, 2016 at 10:13:18AM -0700, Rich Lane wrote: > On Tue, May 10, 2016 at 9:39 AM, Yuanhan Liu > wrote: > > Rich, would you help try by adding following line there and > do a test? It would be great if this patch has your Tested-by :) > > ? ? internal->vid = vid; > > ? >

[dpdk-dev] [PATCH v3] examples/qos_sched: fix bad bit shift operation

> -Original Message- > From: Mrozowicz, SlawomirX > Sent: Tuesday, May 10, 2016 1:21 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Singh, Jasvinder ; > Mrozowicz, SlawomirX > Subject: [PATCH v3] examples/qos_sched: fix bad bit shift operation > > Fix issue reported by Coverity.

[dpdk-dev] [PATCH 0/6] vhost: add vhost-user client mode and reconnect ability

On Tue, May 10, 2016 at 03:23:15AM +, Xu, Qian Q wrote: > Do we need patch qemu for the reconnect case? Yes, we need some support from QEMU: currently QEMU will not be able to detect disconnection and hence will not establish the connection when DPDK vhost restarts. Following patchset from

[dpdk-dev] [PATCH v3] examples/qos_meter: fix unchecked return value

> -Original Message- > From: Mrozowicz, SlawomirX > Sent: Monday, May 9, 2016 9:38 AM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Singh, Jasvinder ; > Mrozowicz, SlawomirX > Subject: [PATCH v3] examples/qos_meter: fix unchecked return value > > Fix issue reported by Coverity. >

[dpdk-dev] [PATCH v2 00/11] Include resources in tests

Hello, another round. The code now looks better. Brief introduction: This patch set introduces a mechanism to include a resource (in general a blob) into the test binary. This allows to make tests less dependent on the target testing environment. The first use case is testing of PCI bus scan by

[dpdk-dev] [PATCH v2 01/11] app/test: introduce resources for tests

Certain internal mechanisms of DPDK access different file system structures (e.g. /sys/bus/pci/devices). It is difficult to test those cases automatically by a unit test when such path is not hard-coded and there is no simple way how to distribute fake ones with the current testing environment.

[dpdk-dev] [PATCH v2 02/11] mk: define objcopy-specific target and arch

The program objcopy uses non-standard conventions to name the target and arch. Define the values for supported architectures. FIXME: tile and ppc_64 are not present. Signed-off-by: Jan Viktorin --- mk/arch/arm/rte.vars.mk | 5 + mk/arch/arm64/rte.vars.mk | 5 +

[dpdk-dev] [PATCH v2 03/11] app/test: support resources externally linked

To include resources from other source that the C source code we can take advantage of the objcopy behaviour, i.e. packing of an arbitrary file as an object file that is linked to the target program. A linked object file is always accessible as a pair extern const char beg_; extern const char

[dpdk-dev] [PATCH v2 04/11] app/test: add functions to create files from resources

A resource can be written into the target filesystem by calling resource_fwrite or resource_fwrite_file. Such file can be created before a test is started and removed after the test finishes. Signed-off-by: Jan Viktorin --- app/test/resource.c | 35 +++

[dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers

The test unregisters all real drivers before starting into an array. This inflexiable as we can use a linked list for this purpose. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/app/test/test_pci.c

[dpdk-dev] [PATCH v2 05/11] app/test: support resources archived by tar

When a more complex resource (a file hierarchy) is needed, packing every single file as a single resource would be very ineffective. For that purpose, it is possible to pack the files into a tar archive, extract it before test from the resource and finally clean up all the created files. This

[dpdk-dev] [PATCH v2 07/11] app/test: extract test_pci_setup and test_pci_cleanup

Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 47 ++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index cf82373..9d53ba5 100644 --- a/app/test/test_pci.c +++ b/app/test/test_pci.c @@

[dpdk-dev] [PATCH v2 08/11] app/test: convert current pci_test into a single test case

The current test_pci is just a single test case that tests the blacklisting of devices. Rename it to test_pci_blacklist and call it from the test_pci. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 85 + 1 file changed, 47

[dpdk-dev] [PATCH v2 11/11] app/test: do not dump PCI devices in blacklist test

Dumping of devices in a unittest is useless. Instead, test whether the test has been set up well - i.e. there are no devices. Signed-off-by: Jan Viktorin --- app/test/test_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c

[dpdk-dev] [PATCH v2 10/11] app/test: scan PCI bus using a fake sysfs

Scan the PCI bus by providing a fake sysfs with a PCI device. The fake sysfs is a packed file hierarchy linked into the test. Signed-off-by: Jan Viktorin --- app/test/Makefile | 1 + app/test/test_pci.c| 58

[dpdk-dev] [PATCH] vhost: fix buffer not null terminated

On Tue, May 10, 2016 at 06:11:18PM +0200, Daniel Mrzyglod wrote: > Fix issue reported by Coverity. > Coverity ID 124556 > > If the buffer is treated as a null terminated string in later operations, > a buffer overflow or over-read may occur. > > In vhost_set_ifname: The string buffer may not

[dpdk-dev] [PATCH 10/16] vhost: export vid as the only interface to applications

2016-05-10 10:29, Yuanhan Liu: > On Tue, May 10, 2016 at 10:13:18AM -0700, Rich Lane wrote: > > ps. Could you push git branches somewhere for these larger vhost patch > > series? > > That would make it a lot easier to test than getting patches individually > > from > > patchwork. > > Yes,

[dpdk-dev] [PATCH] qede: fix icc build error

Hi Ferruh, >fix errors: >icc: command line warning #10006: ignoring unknown option >'-Wno-unused-value' >icc: command line warning #10006: ignoring unknown option >'-Wno-format-nonliteral' >icc: command line warning #10006: ignoring unknown option >'-Wno-shift-negative-value'

[dpdk-dev] [PATCH v2] enic: fix 'imissed' to count drops due to no RX buffers

The enic rx_no_bufs counter is a hardware counter of packets dropped on the interface due to no host buffers being available. Use this counter to update the r_stats->imissed counter. Also, include the rx_drop enic counter in the r_stats->ierrors count. Rx_drop plus rx_errors are the total number

[dpdk-dev] [PATCH 0/3] [RFC] vhost: micro vhost optimization

I see a significant performance improvement with these patches, around 5% at 64 bytes. The one patch that didn't give any performance boost for me was "vhost: arrange virtio_net fields for better cache sharing". Tested-by: Rich Lane On Mon, May 2, 2016 at 5:46 PM, Yuanhan Liu wrote: > Here

[dpdk-dev] [PATCH 0/3] [RFC] vhost: micro vhost optimization

On Tue, May 10, 2016 at 02:49:43PM -0700, Rich Lane wrote: > I see a significant performance improvement with these patches, around 5% at > 64 > bytes. Thanks for testing. > > The one patch that didn't give any performance boost for me was "vhost: > arrange > virtio_net fields for better

[dpdk-dev] [PATCH 0/2] check-git-log fix and enhancement

Patch 1 fix a false positive warning; patch 2 helps to spot bad content clearly. --- Yuanhan Liu (2): scripts: fix false positive warning scripts: high light bad patterns scripts/check-git-log.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- 1.9.0

[dpdk-dev] [PATCH 1/2] scripts: fix false positive warning

It reports an false positive warning when the commit subject includes the word "ctx", as it matches following regexp: -e 'rx\|tx\|RX\|TX' Fixes: edbeb7d962e9 ("scripts: check commit formatting") Signed-off-by: Yuanhan Liu --- scripts/check-git-log.sh | 4 ++-- 1 file changed, 2

  1   2   >