[dpdk-dev] [PATCH v6 0/4] support reset of VF link

2016-07-11 Thread Lu, Wenzhuo
> > Unfortunately I found one issue: if PF is down, and then the VF on the guest > is > down as well (ip link down) and then goes back up before the PF, then calling > rte_eth_dev_reset will return 0 (success), even though the PF is still down > and it > should fail. This is with ixgbe. Any

[dpdk-dev] [PATCH] vhost: reset queue state in destroy_device

2016-07-11 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 10:24:41AM +0800, Yuanhan Liu wrote: > On Fri, Jul 01, 2016 at 09:31:12AM -0700, Rich Lane wrote: > > Fixes a bug where rte_eth_vhost_get_queue_event would not return enabled > > queues > > after a guest application restart. > > > > Fixes: ee584e9710b9 ("vhost: add driver

[dpdk-dev] [PATCH] examples/vhost: fix failure without hints

2016-07-11 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 11:00:13AM +0800, Yuanhan Liu wrote: > On Fri, Jul 01, 2016 at 08:50:31AM +, Jianfeng Tan wrote: > > When the specified cores and memory lie on different numa socket with > > physical NIC, vhost fails to set up rx queue, and exits without any > > hints. This could leads

[dpdk-dev] [PATCH] net/virtio: fix gcc6 i686 compiler error

2016-07-11 Thread Yuanhan Liu
On Thu, Jul 07, 2016 at 02:49:08PM +0100, Ferruh Yigit wrote: > This is for target i686-native-linuxapp-gcc and gcc6, > > Compilation error is: > == Build drivers/net/virtio > CC virtio_rxtx_simple.o > In file included from > .../build/include/rte_mempool.h:77:0, > from >

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-11 Thread Liang, Cunming
Hi Adrien, Thanks so much for the explanation. > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Friday, July 08, 2016 9:26 PM > To: Liang, Cunming > Cc: dev at dpdk.org; Thomas Monjalon ; Zhang, > Helin ; Wu, Jingjing ; > Rasesh > Mody ; Ajit

[dpdk-dev] [RFC] remove vhost-cuse

2016-07-11 Thread Yuanhan Liu
It's something echoed around in my mind for a long while, and here I'm gonna make it public: a proposal to remove vhost-cuse. Vhost-cuse was invented before vhost-user exist. The both are actually doing the same thing: a vhost-net implementation in user space. But they are not exactly the same

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Jingjing Wu
move PCI device ids from rte_pci_dev_ids.h to driver. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 21 ++-- drivers/net/i40e/i40e_ethdev_vf.c | 9 ++-- lib/librte_eal/common/include/rte_pci_dev_ids.h | 71 - 3 files

[dpdk-dev] [dpdk-dev, 1/3] rte_interrupts: add rte_eal_intr_exit to shut down IRQ thread

2016-07-11 Thread Liang, Cunming
Hi Thomas, Base on the previous conversation, at least it requires v2 to reword some comments. > > >> 2. I propose to add addition comments on rte_epoll_wait() API > > >> description. For any signal, it causes an error return, user needs > > >> to handle. > > > Agreed. In addition, one

[dpdk-dev] Ignoring number of bytes read in eal

2016-07-11 Thread David Marchand
Hello, On Tue, Jun 28, 2016 at 10:40 AM, Kobylinski, MichalX wrote: > CID 13212 - Ignoring number of bytes read: > The number of bytes copied into the buffer can be smaller than the requested > number and the buffer can potentially be accessed out of range. > In rte_mem_virt2phy: Value returned

[dpdk-dev] [PATCH] doc: announce driver name changes

2016-07-11 Thread Christian Ehrhardt
Hi, I'm all in for consistent naming and this "only" is the deprecation notice ahead of time which is great. Looking ahead I wanted to ask for opinions if more than just me would consider it useful to keep aliases on the old names when the rename happens. That way any sort of old config would

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-07-11 Thread Yuanhan Liu
On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote: > 2016-04-20 14:43, David Marchand: > > test application and kni still want to know e1000 pci devices. > > So let's create headers in the driver that will be used by them. > > There is also an usage of ixgbe ID for the broken bypass

[dpdk-dev] [PATCH v2 1/2] doc: add bifurcated driver guide on ixgbe nic

2016-07-11 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, July 8, 2016 5:14 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; Mcnamara, John; Liu, Yong; Zhang, Helin; Iremonger, > Bernard > Subject: Re: [dpdk-dev] [PATCH v2 1/2] doc: add bifurcated

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-07-11 Thread Thomas Monjalon
2016-07-11 13:33, Yuanhan Liu: > On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote: > > 2016-04-20 14:43, David Marchand: > > > test application and kni still want to know e1000 pci devices. > > > So let's create headers in the driver that will be used by them. > > > > There is also

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-07-11 Thread Yuanhan Liu
On Mon, Jul 11, 2016 at 07:56:16AM +0200, Thomas Monjalon wrote: > 2016-07-11 13:33, Yuanhan Liu: > > On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote: > > > 2016-04-20 14:43, David Marchand: > > > > test application and kni still want to know e1000 pci devices. > > > > So let's

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Zhang, Helin
Hi Jingjing I'd suggest to add a new header file in each PMD to define what we defined in rte_pci_dev_ids.h. There was a patch set submitted several months ago, like that. Regards, Helin > -Original Message- > From: Wu, Jingjing > Sent: Monday, July 11, 2016 12:01 PM > To:

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Wenzhuo Lu
In testpmd code, device id is used directly to check if bypass is supported. But APP should not know the details of HW, the NIC specific info should not be exposed here. This patch adds a new rte API to check if bypass is supported. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Thomas Monjalon
Hi Helin, 2016-07-11 06:19, Zhang, Helin: > Hi Jingjing > > I'd suggest to add a new header file in each PMD to define what we defined in > rte_pci_dev_ids.h. Why? > There was a patch set submitted several months ago, like that. Which one?

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Zhang, Helin
Hi Thomas It should be the one from David as I read that before. I am not sure if all PMD has its own header files for device IDs, but I did see there was. Even in recent kernel drivers (e.g. i40e), there is a new header file for device ID list. I think it could be clearer, though no correct or

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Thomas Monjalon
2016-07-11 14:21, Wenzhuo Lu: > In testpmd code, device id is used directly to check if bypass > is supported. But APP should not know the details of HW, the NIC > specific info should not be exposed here. Right > This patch adds a new rte API to check if bypass is supported. Hmmm. It's true it

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Wu, Jingjing
Hi, helin What I did is exactly same as what David's patch set did in i40e. I agree with his change. About the new header file, there is already i40e_devids.h in base code which defines the device IDs and vendor ID. This patch just combines them to be a pci device id in struct pci_id_i40e_map

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Wu, Jingjing
Hi, Wenzhuo I don't think you need to create a new API: rte_eth_dev_bypass_supported. If bypass in not supported, the Ops for bypass feature will not be implemented in driver, or driver need to return NOT supported. So I think what you need do is just remove the NIC specific things from testpmd,

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Lu, Wenzhuo
> -Original Message- > From: Wu, Jingjing > Sent: Monday, July 11, 2016 3:51 PM > To: Lu, Wenzhuo; dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup > > Hi, Wenzhuo > > I don't think you need to create

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Lu, Wenzhuo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, July 11, 2016 3:11 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [PATCH] lib/librte_ether: bypass code cleanup > > 2016-07-11 14:21, Wenzhuo Lu: > > In testpmd code, device id is

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Ananyev, Konstantin
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, July 11, 2016 8:11 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup > > 2016-07-11 14:21, Wenzhuo

[dpdk-dev] [PATCH v2] app/testpmd: bypass code cleanup

2016-07-11 Thread Wenzhuo Lu
In testpmd code, device id is used directly to check if bypass is supported. But APP should not know the details of HW, the NIC specific info should not be exposed here. As every bypass API does know if it's supported, no need to check that at first. So, this patch removes the

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Zhang, Helin
> -Original Message- > From: Wu, Jingjing > Sent: Monday, July 11, 2016 3:29 PM > To: Zhang, Helin ; Thomas Monjalon > > Cc: dev at dpdk.org > Subject: RE: [PATCH] i40e: move PCI device ids to driver > > Hi, helin > > What I did is exactly same as what David's patch set did in i40e. I

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-11 Thread Yuanhan Liu
On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote: > On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote: > > > > Another point is that crash constantly happens on queue_id=3 (second RX > > queue) in > > my scenario. It is newly allocated virtqueue while reconfiguration from

[dpdk-dev] Ignoring number of bytes read in eal

2016-07-11 Thread Sergio Gonzalez Monroy
On 11/07/2016 05:48, David Marchand wrote: > Hello, > > On Tue, Jun 28, 2016 at 10:40 AM, Kobylinski, MichalX > wrote: >> CID 13212 - Ignoring number of bytes read: >> The number of bytes copied into the buffer can be smaller than the requested >> number and the buffer can potentially be

[dpdk-dev] [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le

2016-07-11 Thread Chao Zhu
Gowrishankar, Nice patches! Do you have some function test result? I need some time to verify the patches. -Original Message- From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] Sent: 2016?7?10? 15:51 To: dev at dpdk.org Cc: Chao Zhu ; Bruce Richardson ; Konstantin Ananyev ;

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Thomas Monjalon
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > for bypass is a good idea at all. > > I was thinking to totally remove it. > > Why to remove it? > As I know there are people who use that

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-07-11 Thread Ilya Maximets
On 11.07.2016 11:38, Yuanhan Liu wrote: > On Sun, Jul 10, 2016 at 09:17:31PM +0800, Yuanhan Liu wrote: >> On Fri, Jul 08, 2016 at 02:48:56PM +0300, Ilya Maximets wrote: >>> >>> Another point is that crash constantly happens on queue_id=3 (second RX >>> queue) in >>> my scenario. It is newly

[dpdk-dev] [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le

2016-07-11 Thread gowrishankar
Hi Chao, On Monday 11 July 2016 02:25 PM, Chao Zhu wrote: > Gowrishankar, > > Nice patches! Do you have some function test result? I need some time to > verify the patches. Please find below lpm and acl units tests (Test OK at the end of each tests). # ./app/test < EAL/PMD logs> APP: HPET is

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Ananyev, Konstantin
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > > for bypass is a good idea at all. > > > I was thinking to totally remove it. > > > > Why to remove it? > > As I know there are people who

[dpdk-dev] [PATCH] net/enic: decrement Tx mbuf reference count before recycling

2016-07-11 Thread Olivier Matz
Hi John, On 07/09/2016 12:22 AM, John Daley wrote: > In the Tx cleanup function, the reference count in mbufs to be > returned to the pool should to be decremented before they are > returned. Decrementing is not done by rte_mempool_put_bulk() > so it must be done separately using

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-11 Thread Adrien Mazarguil
On Mon, Jul 11, 2016 at 03:18:19AM +, Liang, Cunming wrote: [...] > > > >When several actions are combined in a flow rule, they should all have > > > >different types (e.g. dropping a packet twice is not possible). However > > > >considering the VOID type is an exception to this rule, the

[dpdk-dev] specific driver API - was bypass code cleanup

2016-07-11 Thread Thomas Monjalon
2016-07-11 09:56, Ananyev, Konstantin: > > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > > > for bypass is a good idea at all. > > > > I was thinking to totally remove it. > > > > > >

[dpdk-dev] [PATCH 0/4] fix mempool creation with Xen Dom0

2016-07-11 Thread Olivier Matz
Since the recent mempool rework [1], Xen Dom0 is broken. This series aims at fixing it. I think it should be integrated in 16.07. As I don't have a full testing platform, any help in validating this patchset would be appreciated. [1] http://www.dpdk.org/ml/archives/dev/2016-May/039229.html

[dpdk-dev] [PATCH 1/4] eal: fix typo in Xen Dom0 specific code

2016-07-11 Thread Olivier Matz
Fix the compilation with CONFIG_RTE_LIBRTE_XEN_DOM0=y, by correcting the typo in variable names. Fixes: 8dab48370129 ("xen: return machine address without knowing memseg id") Signed-off-by: Olivier Matz --- lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 4 ++-- 1 file changed, 2 insertions(+),

[dpdk-dev] [PATCH 2/4] mbuf: set errno on pool creation error

2016-07-11 Thread Olivier Matz
In rte_pktmbuf_pool_create(), the rte_errno variable was not always set on failure. Fixes: 152ca517900b ("mbuf: use default mempool handler from config") Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 3/4] eal: fix retrieval of phys address with Xen Dom0

2016-07-11 Thread Olivier Matz
When using Xen Dom0, it looks that /proc/self/pagemap returns 0. This breaks the creation of mbufs pool. We can workaround this in rte_mem_virt2phy() by browsing the dpdk memory segments. This only works for dpdk memory, but it's enough to fix the mempool creation. Fixes: c042ba20674a ("mempool:

[dpdk-dev] [PATCH 4/4] mempool: fix creation with Xen Dom0

2016-07-11 Thread Olivier Matz
Restore the use of 2M hugepages when using Xen Dom0 that was dropped during mempool rework. Fixes: c042ba20674a ("mempool: rework support of Xen dom0") Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] I211, Double VLAN tags and VLAN Stripping not working

2016-07-11 Thread Padam Jeet Singh
Hello, I am using the development branch of DPDK and am trying out double tagging using the DPDK PMD E1000 driver.

[dpdk-dev] specific driver API - was bypass code cleanup

2016-07-11 Thread Ananyev, Konstantin
> > > > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > > > > for bypass is a good idea at all. > > > > > I was thinking to totally remove it. > > > > > > > > Why to remove it? > > > > As I know there are people who use that functionality. > > > > > > > > > Maybe we

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-11 Thread Jerin Jacob
On Tue, Jul 05, 2016 at 08:16:46PM +0200, Adrien Mazarguil wrote: Hi Adrien, Overall this proposal looks very good. I could easily map to the classification hardware engines I am familiar with. > Priorities > ~~ > > A priority can be assigned to a matching pattern. > > The default

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

2016-07-11 Thread Chandran, Sugesh
Hi Adrien, Thank you for your response, Please see my comments inline. Regards _Sugesh > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Friday, July 8, 2016 2:03 PM > To: Chandran, Sugesh > Cc: dev at dpdk.org; Thomas Monjalon ; > Zhang,

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-11 Thread Ananyev, Konstantin
Hi , > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Juhamatti Kuusisaari > Sent: Monday, July 11, 2016 11:21 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct > location > > Fix the location of the rte_ring

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-11 Thread Kuusisaari, Juhamatti
Hi, > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Juhamatti > > Kuusisaari > > Sent: Monday, July 11, 2016 11:21 AM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct > > location > > > > Fix the

[dpdk-dev] [PATCH v2] librte_pmd_bond: fix exported symbol versioning

2016-07-11 Thread Christian Ehrhardt
*update in v2* - add missing changes in rte_eth_bond_8023ad.h The older versions of rte_eth_bond_8023ad_conf_get and rte_eth_bond_8023ad_setup were available in the old way since 2.0 - at least according to the map file. But versioning in the code was set to 16.04. That breaks compatibility

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-11 Thread Olivier Matz
Hi, On 07/11/2016 01:22 PM, Kuusisaari, Juhamatti wrote: > > Hi, > >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Juhamatti >>> Kuusisaari >>> Sent: Monday, July 11, 2016 11:21 AM >>> To: dev at dpdk.org >>> Subject: [dpdk-dev] [PATCH] lib: move

[dpdk-dev] [PATCH v6 0/4] support reset of VF link

2016-07-11 Thread Luca Boccassi
On Mon, 2016-07-11 at 01:32 +, Lu, Wenzhuo wrote: > > > > Unfortunately I found one issue: if PF is down, and then the VF on the > > guest is > > down as well (ip link down) and then goes back up before the PF, then > > calling > > rte_eth_dev_reset will return 0 (success), even though the

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-07-11 Thread Yuanhan Liu
On Mon, Jul 11, 2016 at 01:35:46PM +0200, David Marchand wrote: > Hello all, > > On Mon, Jul 11, 2016 at 7:56 AM, Thomas Monjalon > wrote: > > 2016-07-11 13:33, Yuanhan Liu: > >> I'm not quite sure I understood it well: are you asking us to resend > >> what David has already send, say me for

[dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location

2016-07-11 Thread Ananyev, Konstantin
> Hi, > > > > -Original Message- > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Juhamatti > > > Kuusisaari > > > Sent: Monday, July 11, 2016 11:21 AM > > > To: dev at dpdk.org > > > Subject: [dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct > > > location > > >

[dpdk-dev] [PATCH v4] mk: filter duplicate configuration entries

2016-07-11 Thread Thomas Monjalon
2016-07-06 11:13, Christian Ehrhardt: > *updates in v4* > - replace awk usage with sed > - re-add the old loop to be able to get rid of awk > - add more explanation to the header of the makefile section > > *updates in v3* > - replace tac with sed '1!G;h;$!d' to avoid build time dependency > >

[dpdk-dev] [PATCH v2] librte_pmd_bond: fix exported symbol versioning

2016-07-11 Thread Thomas Monjalon
2016-07-11 13:27, Christian Ehrhardt: > *update in v2* > - add missing changes in rte_eth_bond_8023ad.h > > The older versions of rte_eth_bond_8023ad_conf_get and > rte_eth_bond_8023ad_setup were available in the old way since 2.0 - at > least according to the map file. > > But versioning in the

[dpdk-dev] [PATCH v1 00/15] rte_driver/device infrastructure

2016-07-11 Thread Shreyansh jain
Hi Jan, On Saturday 09 July 2016 12:39 AM, Jan Viktorin wrote: > Hello, > > based on the discussions with Shreyansh, I propose a patchset with > the important EAL changes. It is incomplete and I suppose to extend > and change certain things in the foreseeable future. > > Important notes: > > *

[dpdk-dev] [PATCH v2] app/testpmd: bypass code cleanup

2016-07-11 Thread Thomas Monjalon
2016-07-11 16:29, Wenzhuo Lu: > In testpmd code, device id is used directly to check if bypass > is supported. But APP should not know the details of HW, the NIC > specific info should not be exposed here. > As every bypass API does know if it's supported, no need to check > that at first. So,

[dpdk-dev] [PATCH v1 01/15] eal: extract vdev infra

2016-07-11 Thread Shreyansh jain
Hi Jan, Some comments. On Saturday 09 July 2016 12:39 AM, Jan Viktorin wrote: > Move all PMD_VDEV-specific code into a separate module and header > file to not polute the generic code anymore. There is now a list > of virtual devices available. > > The rte_vdev_driver integrates the original

[dpdk-dev] [PATCH] app/testpmd: add timer based fwd Rx queue flushing

2016-07-11 Thread Thomas Monjalon
> > Testpmd can stuck inside do while loop of the flush_fwd_rx_queues() > > function. As non-zero packets are returned always by rte_eth_rx_burst() > > function when compiled with no optimizations and if input line rate is > > high. "do while" loop must exit at one stage to proceed further to > >

[dpdk-dev] QoS config variables

2016-07-11 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of sreenaath > vasudevan > Sent: Saturday, July 9, 2016 12:23 AM > To: dev at dpdk.org > Subject: [dpdk-dev] QoS config variables > > Hi > Can someone throw some light on the following DPDK QoS config variables?

[dpdk-dev] [PATCH] app/testpmd: refactor of RSS fwd config

2016-07-11 Thread Thomas Monjalon
2016-07-05 10:20, Ilya Maximets: > Since > commit f2bb7ae1d204 ("app/testpmd: handle all Rx queues in RSS setup") > behavior of rss_fwd_config_setup() changed and description of this > function is wrong now. > > Also, there is a type mismatch in a loop. > > Signed-off-by: Ilya Maximets

[dpdk-dev] [PATCH v1 01/15] eal: extract vdev infra

2016-07-11 Thread Jan Viktorin
On Mon, 11 Jul 2016 18:59:48 +0530 Shreyansh jain wrote: > Hi Jan, > > Some comments. > > On Saturday 09 July 2016 12:39 AM, Jan Viktorin wrote: > > Move all PMD_VDEV-specific code into a separate module and header > > file to not polute the generic code anymore. There is now a list > > of

[dpdk-dev] [PATCH v2] app/test: fix hexdump length of cipher/plaintexts

2016-07-11 Thread Thomas Monjalon
2016-07-10 17:16, Deepak Kumar Jain: > From: Pablo de Lara > > Plaintexts and ciphertexts are dumped when debugging is enabled, > using TEST_HEXDUMP. For Snow3G and KASUMI, their lengths are in bits, > but TEST_HEXDUMP uses bytes, so lenghts are passed in bytes now. > > Fixes: 47df73a1a62f

[dpdk-dev] Redirect all packets to a specific VM pool

2016-07-11 Thread Mauricio Vásquez
Hello, To be more specific, what I am trying to do it to setup an environment where I have a physical NIC that has some Virtual Functions configured, then all the incoming traffic to the NIC should be forwarded to a specific Virtual Function. I was able to modify the "VMDQ and DCB Forwarding

[dpdk-dev] [PATCH v1 1/1] examples/bond: fix unchecked return value

2016-07-11 Thread Thomas Monjalon
2016-06-30 10:13, Declan Doherty: > On 29/06/16 10:23, ptazarex at ecsmtp.igk.intel.com wrote: > > The example is calling rte_eal_wait_lcore without checking return value. > > Now it is fixed by checking the value and print proper message. > > > > Coverity issue: 37789 > > Coverity issue: 37790 >

[dpdk-dev] [PATCH] examples/tep_term: fix out-of-bounds access

2016-07-11 Thread Thomas Monjalon
2016-07-05 14:15, Beilei Xing: > Coverity reported lots of out-of-bounds in function > vxlan_link, these issues should happen when index > port_id evaluates to 2, cause size of arrays is > 2 in structure. > Fix this issue by modifying judgement condition, make > sure port_id is less than 2. > >

[dpdk-dev] [PATCH v2] examples/l3fwd: update usage and documentation

2016-07-11 Thread Thomas Monjalon
> > Update l3fwd example usage and documentation with missing options. > > > > Signed-off-by: Beilei Xing > > Acked-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH v4 00/10] kill global pci device id list (almost)

2016-07-11 Thread David Marchand
With the introduction of pmdinfo by Neil, we have almost everything in place to get rid of the pci devices in eal. We still have some ties with some pmds for functionalities like kni/ethtool or ixgbe bypass api, so the plan has switched to touch all pmds but those igb and ixgbe drivers. Since we

[dpdk-dev] [PATCH v4 01/10] eal: remove PCI device ids header from doxygen

2016-07-11 Thread David Marchand
This file is going to disappear, remove the doxygen parts that reference various drivers and remove it from the doxygen index. Signed-off-by: David Marchand --- doc/api/doxy-api-index.md | 1 - lib/librte_eal/common/include/rte_pci_dev_ids.h | 40 -

[dpdk-dev] [PATCH v4 02/10] net/e1000: move em PCI device ids to the driver

2016-07-11 Thread David Marchand
Reused defines from the driver and added a Intel vendor id macro for use by igb later. Used RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff. igb/igbvf is left as is, waiting for kni/ethtool cleanup. Signed-off-by: David Marchand --- Changes since v3: - dropped all but em pci device ids

[dpdk-dev] [PATCH v4 03/10] net/i40e: move PCI device ids to the driver

2016-07-11 Thread David Marchand
Reused defines from the driver. Used RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand --- Changes since v3 - added new pci ids from HEAD --- drivers/net/i40e/i40e_ethdev.c | 25 +++-- drivers/net/i40e/i40e_ethdev_vf.c | 9

[dpdk-dev] [PATCH v4 05/10] net/virtio: move PCI device ids to the driver

2016-07-11 Thread David Marchand
Reused defines from the driver. Used RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand Acked-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 7 ++- lib/librte_eal/common/include/rte_pci_dev_ids.h | 16 2 files

[dpdk-dev] [PATCH v4 06/10] net/vmxnet3: move PCI device ids to the driver

2016-07-11 Thread David Marchand
Moved vmware device ids macro since the driver had no such information. Used RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand --- drivers/net/vmxnet3/vmxnet3_ethdev.c| 9 - lib/librte_eal/common/include/rte_pci_dev_ids.h | 16

[dpdk-dev] [PATCH v4 08/10] net/bnx2x: move PCI device ids to the driver

2016-07-11 Thread David Marchand
Reused defines from the driver and moved broadcom vendor id macro. Used RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand --- drivers/net/bnx2x/bnx2x.c | 3 +- drivers/net/bnx2x/bnx2x_ethdev.c| 21 --

[dpdk-dev] [PATCH v4 09/10] net/bnxt: move PCI device ids to the driver

2016-07-11 Thread David Marchand
Moved defines since the driver had no such information. Used RTE_PCI_DEVICE in place of RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand --- drivers/net/bnxt/bnxt_ethdev.c | 27 +--- lib/librte_eal/common/include/rte_pci_dev_ids.h | 34

[dpdk-dev] [PATCH v4 10/10] net/ena: remove unneeded PCI macro

2016-07-11 Thread David Marchand
I suppose this is a remnant of rte_pci_dev_ids.h, just remove this. Signed-off-by: David Marchand --- drivers/net/ena/ena_ethdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index f1b5e64..ac0803d 100644

[dpdk-dev] [PATCH v2 0/2] examples/ipsec_secgw: add configuration file support

2016-07-11 Thread Fan Zhang
This patchset adds the configuration file supported to ipsec_secgw sample application. Two sample configuration files, ep0.cfg and ep1.cfg are also added to show how to configure two systems back-to-back that would forward traffic through an IPsec tunnel v2 changes: - fix configuration file

[dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: add configuration file support

2016-07-11 Thread Fan Zhang
This patch adds the configuration file support to ipsec_secgw sample application. Instead of hard-coded rules, the users can specify their own SP, SA, and routing rules in the configuration file. An command line option "-f" is added to pass the configuration file location to the application.

[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add sample configuration files

2016-07-11 Thread Fan Zhang
This patch adds two sample configuration files to ipsec-secgw sample application. The sample configuration files shows how to set-up systems back-to-back that would forward traffic through an IPsec tunnel. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/ep0.cfg | 119

[dpdk-dev] [PATCH] examples/l2fwd-crypto: out-of-bounds read

2016-07-11 Thread Thomas Monjalon
> > Overrunning array crypto_statistics of 32 64-byte elements > > at element index 63 using index cdevid. > > Fixed by extend crypto_statistics array. > > > > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") > > Coverity ID 120145 > > > > Signed-off-by: Slawomir Mrozowicz >

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect stats array length

2016-07-11 Thread Thomas Monjalon
2016-06-28 09:28, Declan Doherty: > On 27/06/16 14:37, Pablo de Lara wrote: > > crypto_statistics array was not big enough for storing > > all the possible crypto device statistics, as its size was > > RTE_MAX_ETHPORTS, but should be RTE_CRYPTO_MAX_DEVS, leading > > this to a potential

[dpdk-dev] [PATCH 1/2] doc: live migration of VM with vhost_user on host

2016-07-11 Thread Bernard Iremonger
This patch describes the procedure to be be followed to perform Live Migration of a VM with Virtio PMD running on a host which is running the vhost_user sample application (vhost-switch). It includes sample host and VM scripts used in the procedure. Signed-off-by: Bernard Iremonger ---

[dpdk-dev] [PATCH 0/2] doc: live migration procedure with vhost_user

2016-07-11 Thread Bernard Iremonger
This patchset describes the procedure to Live migrate a VM with Virtio PMD's with the vhost_user sample application (vhost-switch) running on the host. Bernard Iremonger (2): doc: live migration of VM with vhost_user on host doc: add vhost_user live migration image

[dpdk-dev] [PATCH] examples/l2fwd-crypto: flush crypto dev buffers

2016-07-11 Thread Thomas Monjalon
2016-07-06 10:38, Pablo de Lara: > Crypto operations are enqueued in the crypto devices > when the crypto device buffers are full (MAX_PKT_BURST), > in order to be more efficient. > > The problem is that operations might be stuck in those buffers, > if they never get full, and therefore, those

[dpdk-dev] [PATCH] examples/vm_power_manager: remove dependency on internal header file

2016-07-11 Thread Thomas Monjalon
2016-07-04 16:57, Marvin Liu: > Macro CHANNEL_CMDS_MAX_CPUS stand for the maximum number of cores > controlled by virtual channels. This macro only be used in the example, > so remove it from library to example header file. > > Signed-off-by: Marvin Liu Applied, thanks

[dpdk-dev] [PATCH v6 0/4] support reset of VF link

2016-07-11 Thread Luca Boccassi
On Mon, 2016-07-11 at 13:02 +0100, Luca Boccassi wrote: > On Mon, 2016-07-11 at 01:32 +, Lu, Wenzhuo wrote: > > > > > > Unfortunately I found one issue: if PF is down, and then the VF on the > > > guest is > > > down as well (ip link down) and then goes back up before the PF, then > > >

[dpdk-dev] [PATCH 0/4] fix mempool creation with Xen Dom0

2016-07-11 Thread Olivier Matz
On 07/11/2016 12:20 PM, Olivier Matz wrote: > Since the recent mempool rework [1], Xen Dom0 is broken. > This series aims at fixing it. I think it should be integrated > in 16.07. > > As I don't have a full testing platform, any help in validating > this patchset would be appreciated. > > [1]

[dpdk-dev] [PATCH] i40e: move PCI device ids to driver

2016-07-11 Thread Thomas Monjalon
2016-07-11 12:01, Jingjing Wu: > move PCI device ids from rte_pci_dev_ids.h to driver. > > Signed-off-by: Jingjing Wu Thanks David has sent a v4 for almost every drivers, including i40e: http://dpdk.org/ml/archives/dev/2016-July/043798.html

[dpdk-dev] [PATCH 0/4] fix mempool creation with Xen Dom0

2016-07-11 Thread Thomas Monjalon
2016-07-11 12:20, Olivier Matz: > Since the recent mempool rework [1], Xen Dom0 is broken. > This series aims at fixing it. I think it should be integrated > in 16.07. > > As I don't have a full testing platform, any help in validating > this patchset would be appreciated. > > [1]

[dpdk-dev] No RX frames on Intel 82599 VF

2016-07-11 Thread Garik E
Hello, I have two Intel servers S2600WTTR and S2600WT2 both with 82599 10G Ethernet Controllers I run the same DPDK application on both servers. The application works with one interface bound to physical or virtual PCI function depending on configuration The S2600WTTR server receives incoming

[dpdk-dev] pktgen wr_cksum error

2016-07-11 Thread Wiles, Keith
the line is using C99 option of ?for (int i = 0; i < X; i++) need to move the declare of the int i out to the function instead of in the for loop. I have fixed his already, but will make a special patch to update this problem when i can. > On Jul 11, 2016, at 9:09 AM, Posadas, Emerson >

[dpdk-dev] [PATCH 0/8] Misc enhancements in testpmd

2016-07-11 Thread Olivier Matz
This patchset introduces several enhancements or minor fixes in testpmd. It is targetted for v16.11, and applies on top of software ptype patchset [1]. These patches will be useful to test another patchset (coming soon !) that brings support for offload in virtio pmd. [1]

[dpdk-dev] [PATCH 1/8] mbuf: add function to dump ol flag list

2016-07-11 Thread Olivier Matz
The functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name() can dump one flag, or set of flag that are part of the same mask (ex: PKT_TX_UDP_CKSUM, part of PKT_TX_L4_MASK). But they are not designed to dump the list of flags contained in mbuf->ol_flags. This commit introduce new

[dpdk-dev] [PATCH 2/8] app/testpmd: use new function to dump offload flags

2016-07-11 Thread Olivier Matz
Use the functions introduced in the previous commit to dump the offload flags. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 27 +++ app/test-pmd/rxonly.c | 15 ++- 2 files changed, 5 insertions(+), 37 deletions(-) diff --git

[dpdk-dev] [PATCH 3/8] app/testpmd: dump rx flags in csum engine

2016-07-11 Thread Olivier Matz
Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 7cc51df..a484b18 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@

[dpdk-dev] [PATCH 4/8] app/testpmd: add option to enable lro

2016-07-11 Thread Olivier Matz
Introduce a new argument '--enable-lro' to ask testpmd to enable the LRO feature on enabled ports, like it's done for '--enable-rx-cksum' for instance. Signed-off-by: Olivier Matz --- app/test-pmd/parameters.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/parameters.c

[dpdk-dev] [PATCH 7/8] app/testpmd: don't use tso if packet is too small

2016-07-11 Thread Olivier Matz
Asking for TSO (TCP Segmentation Offload) on packets that are already smaller than (headers + MSS) does not work, for instance on ixgbe. Fix the csumonly engine to only set the TSO flag when a segmentation offload is really required, i.e. when packet is large enough. Signed-off-by: Olivier Matz

[dpdk-dev] [PATCH 6/8] app/testpmd: display rx port in csum engine

2016-07-11 Thread Olivier Matz
This information is useful when debugging, especially with bidirectional traffic. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index ee98724..35edf1d 100644 ---

[dpdk-dev] [PATCH 5/8] app/testpmd: do not change ip addrs in csum engine

2016-07-11 Thread Olivier Matz
The csum forward engine was updated to change the IP addresses in the packet data in commit 51f694dd40f5 ("app/testpmd: rework checksum forward engine") This was done to ensure that the checksum is correctly reprocessed when using hardware checksum offload. But the functions

[dpdk-dev] [PATCH 8/8] app/testpmd: hide segsize when unrelevant in csum engine

2016-07-11 Thread Olivier Matz
When TSO is not asked, hide the segment size. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 9938150..4b36d74 100644 --- a/app/test-pmd/csumonly.c +++

[dpdk-dev] [PATCH] net/enic: decrement Tx mbuf reference count before recycling

2016-07-11 Thread John Daley (johndale)
> -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, July 11, 2016 3:04 AM > To: John Daley (johndale) ; dev at dpdk.org > Cc: bruce.richardson at intel.com > Subject: Re: [dpdk-dev] [PATCH] net/enic: decrement Tx mbuf reference > count before

  1   2   >