[dpdk-dev] [PATCH v2] examples/vhost: fix perf regression

We find significant perfermance drop introduced by below commit, when vhost example is started with --mergeable 0 and inside vm, kernel virtio-net driver is used to do ip based forwarding. The root cause is that below commit adds support for VIRTIO_NET_F_GUEST_TSO4 and VIRTIO_NET_F_GUEST_TSO6,

[dpdk-dev] [PATCH v2] examples/vhost: fix perf regression

Self-Nack this patch because the commit log needs change further. > -Original Message- > From: Tan, Jianfeng > Sent: Thursday, July 21, 2016 8:24 AM > To: dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com; Wang, Zhihong; Xu, Qian Q; Tan, Jianfeng > Subject: [PATCH v2] examples/vhost:

[dpdk-dev] [PATCH v3] examples/vhost: fix perf regression

We find significant perfermance drop introduced by below commit, when vhost example is started with --mergeable 0 and inside vm, kernel virtio-net driver is used to do ip based forwarding. The commit, 859b480d5afd ("vhost: add guest offload setting"), adds support for VIRTIO_NET_F_GUEST_TSO4 and

[dpdk-dev] [PATCH v3] examples/vhost: fix perf regression

On Thu, Jul 21, 2016 at 12:42:45AM +, Jianfeng Tan wrote: > We find significant perfermance drop introduced by below commit, > when vhost example is started with --mergeable 0 and inside vm, > kernel virtio-net driver is used to do ip based forwarding. > > The commit, 859b480d5afd ("vhost:

[dpdk-dev] [PATCH v3] examples/vhost: fix perf regression

Add the tested-by:) Tested-by: Qian Xu - Test Commit: 608487f3fc96704271c624d0f3fe9d7fb2187aea - OS/Kernel: Fedora 21/4.1.13 - GCC: gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) - CPU: Intel(R) Xeon(R) CPU E5-2695 v4 @ 2.10 - NIC: Intel(R) Ethernet Controller X710 for 10GbE SFP+ - Total 2 cases, 2

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Wednesday, July 20, 2016 6:41 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Thomas Monjalon; Zhang, Helin; Wu, Jingjing; Rasesh Mody; > Ajit Khaparde; Rahul Lakkireddy; Jan Medala; John

[dpdk-dev] [PATCH 1/2] example/l2fwd-crypto: add support for cryptodev_start

The usual device sequence is configure, queue setup and start. Crypto device should be started before use. Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/l2fwd-crypto/main.c

[dpdk-dev] [PATCH 2/2] example/ipsec-secgw: add support for cryptodev_start

The usual device sequence is configure, queue setup and start. Crypto device should be started before use. Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- examples/ipsec-secgw/ipsec-secgw.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c

[dpdk-dev] [PATCH] eal: fix parsing of argument of option --lcores

The '-' in lcores set overrides cpu set of following lcore set in the argument of EAL option --lcores. Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") Signed-off-by: Wei Dai --- lib/librte_eal/common/eal_common_options.c | 12 1 file changed, 12 insertions(+)

[dpdk-dev] [PATCH 00/12] net/virtio: add offload support

This patchset, targetted for 16.11, introduces the support of rx and tx offload in virtio pmd. To achieve this, some new mbuf flags must be introduced, as discussed in [1]. It applies on top of: - 16.07-rc3 - software packet type [2] - testpmd enhancements [3] - virtio packet corruption fix [4]

[dpdk-dev] [PATCH 01/12] virtio: move device initialization in a function

Move all code related to device initialization in a new function virtio_init_device(). This commit brings no functional change, it prepares the next commits that will add the offload support. For that, it will be needed to reinitialize the device from ethdev->configure(), using this new function.

[dpdk-dev] [PATCH 02/12] virtio: setup and start cq in configure callback

Move the configuration of control queue in the configure callback. This is needed by next commit, which introduces the reinitialization of the device in the configure callback to change the feature flags. Therefore, the control queue will have to be restarted at the same place. As

[dpdk-dev] [PATCH 03/12] virtio: reinitialize the device in configure callback

Add the ability to reset the virtio device in the configure callback if the features flag changed since previous reset. This will be possible with the introduction of offload support in next commits. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 26

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

This function can be used to calculate the checksum of data embedded in mbuf, that can be composed of several segments. This function will be used by the virtio pmd in next commits to calculate the checksum in software in case the protocol is not recognized. Signed-off-by: Olivier Matz ---

[dpdk-dev] [PATCH 05/12] mbuf: add new Rx checksum mbuf flags

Following discussions in [1] and [2], introduce a new bit to describe the Rx checksum status in mbuf. Before this patch, only one flag was available: PKT_RX_L4_CKSUM_BAD: L4 cksum of RX pkt. is not OK. And same for L3: PKT_RX_IP_CKSUM_BAD: IP cksum of RX pkt. is not OK. This had 2 issues: -

[dpdk-dev] [PATCH 06/12] app/testpmd: fix checksum stats in csum engine

--- app/test-pmd/csumonly.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 4b36d74..34a2591 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -680,8 +680,10 @@ pkt_burst_checksum_forward(struct

[dpdk-dev] [PATCH 07/12] mbuf: new flag for LRO

When receiving coalesced packets in virtio, the original size of the segments is provided. This is a useful information because it allows to resegment with the same size. Add a RX new flag in mbuf, that can be set when packets are coalesced by a hardware or virtual driver when the m->tso_segsz

[dpdk-dev] [PATCH 08/12] app/testpmd: display lro segment size

In csumonly engine, display the value of LRO segment if the LRO flag is set. Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 34a2591..3455a7e 100644 ---

[dpdk-dev] [PATCH 11/12] virtio: add Lro support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 ++- drivers/net/virtio/virtio_ethdev.h | 9 - drivers/net/virtio/virtio_rxtx.c | 21 + 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH 12/12] virtio: add Tso support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 6 ++ drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 129 - 3 files changed, 134 insertions(+), 3 deletions(-) diff --git

[dpdk-dev] [PATCH 09/12] virtio: add Rx checksum offload support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 14 drivers/net/virtio/virtio_ethdev.h | 2 +- drivers/net/virtio/virtio_rxtx.c | 66 ++ drivers/net/virtio/virtqueue.h | 1 + 4 files changed, 75 insertions(+), 8

[dpdk-dev] [PATCH 10/12] virtio: add Tx checksum offload support

Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 7 + drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_rxtx.c | 57 +- 3 files changed, 45 insertions(+), 20 deletions(-) diff --git

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

Hi Adrien, The proposal looks very good. It satisfies most of the features supported by Chelsio NICs. We are looking for suggestions on exposing more additional features supported by Chelsio NICs via this API. Chelsio NICs have two regions in which filters can be placed - Maskfull and Maskless

[dpdk-dev] [PATCH] vhost: fix driver unregister for client mode

On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote: > Currently while calling of 'rte_vhost_driver_unregister()' connection > to QEMU will not be closed. This leads to inability to register driver > again and reconnect to same virtual machine. > > This scenario is reproducible with

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

If something abnormal happened to QEMU, 'connect()' can block calling thread (e.g. main thread of OVS) forever or for a really long time. This can break whole application or block the reconnection thread. Example with OVS: ovs_rcu(urcu2)|WARN|blocked 512000 ms waiting for main to quiesce

[dpdk-dev] [PATCH] mk: fix static link with glibc < 2.17

> Tested-by: Yongjie Gu Applied

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

Sometimes app just wants to update the RSS hash function and no RSS key update is needed, but fm10k pmd will return EINVAL for this case. If the rss_key is NULL, we don't need to check the rss_key_len. Fixes: 57033cdf8fdc ("fm10k: add PF RSS") Reported-by: Xueqin Lin Signed-off-by: Xiao Wang

[dpdk-dev] [PATCH] virtio: fix packet corruption

On Tue, Jul 19, 2016 at 02:31:59PM +0200, Olivier Matz wrote: > The support of virtio-user changed the way the mbuf dma address is > retrieved, using a physical address in case of virtio-pci and a virtual > address in case of virtio-user. > > This change introduced some possible memory corruption

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

> > The sed syntax of '0,/regexp/' is GNU specific and fails with > > non GNU sed in FreeBSD. > > > > To solve the issue we can use awk instead to remove duplicates. > > > > The awk script basically keeps the last config value, while > > maintaining order and comments from original config file. >

[dpdk-dev] [PATCH v2] vhost: fix driver unregister for client mode

Currently while calling of 'rte_vhost_driver_unregister()' connection to QEMU will not be closed. This leads to inability to register driver again and reconnect to same virtual machine. This scenario is reproducible with OVS. While executing of the following command vhost port will be re-created

[dpdk-dev] [PATCH] vhost: fix driver unregister for client mode

Thanks. Fixed. Best regards, Ilya Maximets. On 21.07.2016 11:24, Yuanhan Liu wrote: > On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote: >> Currently while calling of 'rte_vhost_driver_unregister()' connection >> to QEMU will not be closed. This leads to inability to register driver

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

Hi, > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 144b2de..01f4a72 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev, > >

[dpdk-dev] [PATCH] app/test: increase memory allocated for greedy autotests

On 07/19/2016 07:21 PM, Thomas Monjalon wrote: > The autotest lists, requirements and distribution needs a big rework > to reduce the amount of cores and memory required. > The root cause is not addressed yet. > > This patch just increase some memory allocation for some greedy tests > which

[dpdk-dev] [PATCH] app/test: disable filtering with stripped binary

On 07/19/2016 06:53 PM, Thomas Monjalon wrote: > The unavailable tests are filtered out by autotest by looking for > the symbols in the binary: > > PCI autotest: Skipped [Not Available] [00m 00s] > Malloc autotest: Success [00m 00s] >

[dpdk-dev] [PATCH] doc: update 16.07 release notes and nic guide for enic

Signed-off-by: John Daley --- doc/guides/nics/enic.rst | 9 +++-- doc/guides/nics/overview.rst | 2 +- doc/guides/rel_notes/release_16_07.rst | 23 +++ 3 files changed, 27 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/enic.rst

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote: > If something abnormal happened to QEMU, 'connect()' can block calling > thread (e.g. main thread of OVS) forever or for a really long time. > This can break whole application or block the reconnection thread. > > Example with OVS: >

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

Hi Mark, > -Original Message- > From: Chen, Jing D > Sent: Thursday, July 21, 2016 4:48 PM > To: Wang, Xiao W ; dev at dpdk.org > Cc: Lin, Xueqin > Subject: RE: [PATCH] net/fm10k: fix RSS hash config > > Hi, > > > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > >

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 12:37, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote: >> If something abnormal happened to QEMU, 'connect()' can block calling >> thread (e.g. main thread of OVS) forever or for a really long time. >> This can break whole application or block the

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote: > On 21.07.2016 12:37, Yuanhan Liu wrote: > > On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote: > >> If something abnormal happened to QEMU, 'connect()' can block calling > >> thread (e.g. main thread of OVS) forever or

[dpdk-dev] [PATCH] timer: fix break list when timer_cb reset running timer

Hi Robert, Thank you for reviewing. In the following case, the skip list is broken. - Timer A and timer B are configured on the same lcore, in the same pending list. - The expire time of timer A is earlier than that of timer B. - rte_timer_manage() is called on the lcore after the expire time of

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 13:13, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote: >> On 21.07.2016 12:37, Yuanhan Liu wrote: >>> On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote: If something abnormal happened to QEMU, 'connect()' can block calling

[dpdk-dev] [PATCH v4 0/2] examples/ipsec_secgw: add configuration file support

This patchset adds the configuration file supported to ipsec_secgw sample application. Two sample configuration files, ep0.cfg and ep1.cfg are also added to show how to configure two systems back-to-back that would forward traffic through an IPsec tunnel v4 change: - rebase the patchset on top

[dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: add configuration file support

This patch adds the configuration file support to ipsec_secgw sample application. Instead of hard-coded rules, the users can specify their own SP, SA, and routing rules in the configuration file. An command line option "-f" is added to pass the configuration file location to the application.

[dpdk-dev] [PATCH v4 2/2] examples/ipsec-secgw: add sample configuration files

This patch adds two sample configuration files to ipsec-secgw sample application. The sample configuration files shows how to set-up systems back-to-back that would forward traffic through an IPsec tunnel. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/ep0.cfg | 160

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

Hi Olivier, > > This function can be used to calculate the checksum of data embedded in mbuf, > that can be composed of several segments. > > This function will be used by the virtio pmd in next commits to calculate the > checksum in software in case the protocol is not recognized. > >

[dpdk-dev] [dpdk-users] RSS Hash not working for XL710/X710 NICs for some RX mbuf sizes

Hi Beilei, On Wed, Jul 20, 2016 at 3:59 AM, Xing, Beilei wrote: > Hi Ceara, > >> -Original Message- >> From: Take Ceara [mailto:dumitru.ceara at gmail.com] >> Sent: Tuesday, July 19, 2016 10:59 PM >> To: Xing, Beilei >> Cc: Zhang, Helin ; Wu, Jingjing >> ; dev at dpdk.org >> Subject:

[dpdk-dev] [PATCH] net/i40e: fix out-of-bounds writes during vector Rx

From: Sergey Dyasly Rx loop inside _recv_raw_pkts_vec() ignores nb_pkts argument and always tries to receive RTE_I40E_VPMD_RX_BURST (32) packets. This is a violation of rte_eth_rx_burst() API and can lead to memory corruption (out-of-bounds writes to struct rte_mbuf

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

Hi Adrien, Please find my comments below Regards _Sugesh > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Wednesday, July 20, 2016 6:11 PM > To: Chandran, Sugesh > Cc: dev at dpdk.org; Thomas Monjalon ; > Zhang, Helin ; Wu, Jingjing > ;

[dpdk-dev] [PATCH] doc: deprecate vhost-cuse

> Subject: [dpdk-dev] [PATCH] doc: deprecate vhost-cuse > > Vhost-cuse was invented before vhost-user exist. The both are actually > doing the same thing: a vhost-net implementation in user space. But they > are not exactly the same thing. > > Firstly, vhost-cuse is harder for use; no one seems

[dpdk-dev] [PATCH v2] vhost: fix connect hang in client mode

If something abnormal happened to QEMU, 'connect()' can block calling thread (e.g. main thread of OVS) forever or for a really long time. This can break whole application or block the reconnection thread. Example with OVS: ovs_rcu(urcu2)|WARN|blocked 512000 ms waiting for main to quiesce

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 13:37, Ilya Maximets wrote: > > > On 21.07.2016 13:13, Yuanhan Liu wrote: >> On Thu, Jul 21, 2016 at 12:45:32PM +0300, Ilya Maximets wrote: >>> On 21.07.2016 12:37, Yuanhan Liu wrote: On Thu, Jul 21, 2016 at 11:21:15AM +0300, Ilya Maximets wrote: > If something abnormal

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote: > > Hmm, how about this fixup: > > -- > > diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c > > b/lib/librte_vhost/vhost_user/vhost-net-user.c > >

[dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var

test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So removing ptr var. Now freeing mp_stack var. Signed-off-by: Santosh Shukla --- app/test/test_mempool.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_mempool.c

[dpdk-dev] [PATCH v5] eal: out-of-bounds write

Hi Thomas, As I understand Sergio suggested to come back to the solution similar to v1. Could you comment or better take decision which solution should be applied, please. Best Regards, S?awomir >-Original Message- >From: Gonzalez Monroy, Sergio >Sent: Monday, June 20, 2016 1:29 PM

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 14:40, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote: >>> Hmm, how about this fixup: >>> -- >>> diff --git a/lib/librte_vhost/vhost_user/vhost-net-user.c >>>

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 15:10, Ilya Maximets wrote: > On 21.07.2016 14:40, Yuanhan Liu wrote: >> On Thu, Jul 21, 2016 at 02:14:59PM +0300, Ilya Maximets wrote: Hmm, how about this fixup: -- diff --git

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: > >> > >> What do you think of it? > > > > I found that we can't check connection status without select/poll > > on it. 'getsockopt()' will return 0 with no errors if connection > > is not still established just like if it was. > >

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 15:35, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: What do you think of it? >>> >>> I found that we can't check connection status without select/poll >>> on it. 'getsockopt()' will return 0 with no errors if connection >>> is not

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote: > On 21.07.2016 15:35, Yuanhan Liu wrote: > > On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: > > What do you think of it? > >>> > >>> I found that we can't check connection status without select/poll > >>> on

[dpdk-dev] [PATCH v5] eal: out-of-bounds write

2016-07-21 12:01, Mrozowicz, SlawomirX: > Hi Thomas, > > As I understand Sergio suggested to come back to the solution similar to v1. > Could you comment or better take decision which solution should be applied, > please. > > Best Regards, > S?awomir > > > >-Original Message- >

[dpdk-dev] [PATCH v3] vhost: fix driver unregister for client mode

Currently while calling of 'rte_vhost_driver_unregister()' connection to QEMU will not be closed. This leads to inability to register driver again and reconnect to same virtual machine. This scenario is reproducible with OVS. While executing of the following command vhost port will be re-created

[dpdk-dev] [PATCH v2] vhost: fix driver unregister for client mode

I've fixed leak of file descriptors in 'vhost_user_remove_reconnect()' and sent v3. On 21.07.2016 11:31, Ilya Maximets wrote: > Currently while calling of 'rte_vhost_driver_unregister()' connection > to QEMU will not be closed. This leads to inability to register driver > again and reconnect to

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On 21.07.2016 15:58, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote: >> On 21.07.2016 15:35, Yuanhan Liu wrote: >>> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: >> >> What do you think of it? > > I found that we can't check

[dpdk-dev] [PATCH V2] doc: fix vhost setup in tep-termination app guide

- Fix vhost setup flags - Add minor edits to improve readability and consistency --- v2: - revert file mode changes made erroneously in v1 Signed-off-by: Mark Kavanagh --- doc/guides/sample_app_ug/tep_termination.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) mode change

[dpdk-dev] [PATCH] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 03:58:11PM +0300, Ilya Maximets wrote: > On 21.07.2016 15:58, Yuanhan Liu wrote: > > On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote: > >> On 21.07.2016 15:35, Yuanhan Liu wrote: > >>> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: > >> >

[dpdk-dev] [PATCH V2] doc: fix vhost setup in tep-termination app guide

- Fix vhost setup flags - Add minor edits to improve readability and consistency --- v2: - revert file mode changes made erroneously in v1 Signed-off-by: Mark Kavanagh --- doc/guides/sample_app_ug/tep_termination.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[dpdk-dev] [PATCH V2] doc: fix vhost setup in tep-termination app guide

Please disregard - correct version of patch to follow. Cheers, Mark >-Original Message- >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mark Kavanagh >Sent: Thursday, July 21, 2016 2:04 PM >To: dev at dpdk.org >Subject: [dpdk-dev] [PATCH V2] doc: fix vhost setup in

[dpdk-dev] [PATCH v3] vhost: fix driver unregister for client mode

On Thu, Jul 21, 2016 at 03:55:36PM +0300, Ilya Maximets wrote: > Currently while calling of 'rte_vhost_driver_unregister()' connection > to QEMU will not be closed. This leads to inability to register driver > again and reconnect to same virtual machine. > > This scenario is reproducible with

[dpdk-dev] [PATCH v3] vhost: fix connect hang in client mode

If something abnormal happened to QEMU, 'connect()' can block calling thread (e.g. main thread of OVS) forever or for a really long time. This can break whole application or block the reconnection thread. Example with OVS: ovs_rcu(urcu2)|WARN|blocked 512000 ms waiting for main to quiesce

[dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var

Hi Santosh, On 07/21/2016 01:49 PM, Santosh Shukla wrote: > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. > So > removing ptr var. Now freeing mp_stack var. > > Signed-off-by: Santosh Shukla > --- > app/test/test_mempool.c |3 +-- > 1 file changed, 1

[dpdk-dev] [PATCH v3] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote: > If something abnormal happened to QEMU, 'connect()' can block calling > thread (e.g. main thread of OVS) forever or for a really long time. > This can break whole application or block the reconnection thread. > > Example with OVS: >

[dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var

2016-07-21 15:28, Olivier Matz: > Hi Santosh, > > On 07/21/2016 01:49 PM, Santosh Shukla wrote: > > test_mempool func not using pointer variable 'mp_ext' and incorrectly > > freed. So > > removing ptr var. Now freeing mp_stack var. > > > > Signed-off-by: Santosh Shukla > > --- > >

[dpdk-dev] [PATCH v2] mempool: adjust name string size in related data types

Hi Zoltan, On 07/20/2016 07:16 PM, Zoltan Kiss wrote: > A recent patch brought up an issue about the size of the 'name' fields: > > 85cf0079 mem: avoid memzone/mempool/ring name truncation > > These relations should be observed: > > 1. Each ring creates a memzone with a prefixed name: >

[dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size

Hi Jerin, On 07/18/2016 07:55 AM, Jerin Jacob wrote: > rte_ring_create expects the size of the ring to > be a power of 2. REFCNT_RING_SIZE value is not > power of 2 in-case if RTE_MAX_LCORE == 96. > Fix it by aligning the size to next power of 2 value. > > Fixes: af75078f ("first public

[dpdk-dev] [PATCH v3] vhost: fix connect hang in client mode

On 21.07.2016 16:35, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote: >> If something abnormal happened to QEMU, 'connect()' can block calling >> thread (e.g. main thread of OVS) forever or for a really long time. >> This can break whole application or block

[dpdk-dev] [PATCH] memzone: allow full length name

Hi, On 07/20/2016 07:16 PM, Zoltan Kiss wrote: > (strlen(name) == sizeof(mz->name) - 1) is a valid case, change the > condition to reflect that. > Move it earlier to avoid lookup with invalid name. > Change errno to ENAMETOOLONG. > > Fixes: 85cf0079 ("mem: avoid memzone/mempool/ring name

[dpdk-dev] [PATCH v2] mempool: adjust name string size in related data types

On 21/07/16 14:40, Olivier Matz wrote: > Hi Zoltan, > > > On 07/20/2016 07:16 PM, Zoltan Kiss wrote: >> A recent patch brought up an issue about the size of the 'name' fields: >> >> 85cf0079 mem: avoid memzone/mempool/ring name truncation >> >> These relations should be observed: >> >> 1. Each

[dpdk-dev] [PATCH v3] vhost: fix connect hang in client mode

On Thu, Jul 21, 2016 at 04:43:25PM +0300, Ilya Maximets wrote: > > > On 21.07.2016 16:35, Yuanhan Liu wrote: > > On Thu, Jul 21, 2016 at 04:19:35PM +0300, Ilya Maximets wrote: > >> If something abnormal happened to QEMU, 'connect()' can block calling > >> thread (e.g. main thread of OVS) forever

[dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count

On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote: > > > On Jul 20, 2016, at 3:16 PM, Neil Horman wrote: > > > > On Wed, Jul 20, 2016 at 07:47:32PM +, Wiles, Keith wrote: > >> > >>> On Jul 20, 2016, at 12:48 PM, Neil Horman wrote: > >>> > >>> On Wed, Jul 20, 2016 at 07:40:49PM

[dpdk-dev] [PATCH] ethdev: ensure consistent port id assignment

Hi Amin, > -Original Message- > From: Tootoonchian, Amin > Sent: Wednesday, July 20, 2016 5:08 PM > To: Kerlin, MarcinX > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com > Subject: RE: [PATCH] ethdev: ensure consistent port id assignment > > Hi Marcin, > > Comments inline: > > >

[dpdk-dev] [PATCH 0/3] net/thunderx: add 81xx SoC support

CN81xx is four core version of ThunderX SoC. Added the support by adding new HW capability flag to select the difference in runtime. Jerin Jacob (3): net/thunderx: remove generic passx references from the driver net/thunderx: introduce cqe_rx2 HW capability flag net/thunderx: add 81xx SoC

[dpdk-dev] [PATCH 1/3] net/thunderx: remove generic passx references from the driver

thunderx pmd driver needs to support multiple SoC variants in ThunderX family. Remove generic pass references from driver as each SoC can have same pass number. Signed-off-by: Jerin Jacob --- drivers/net/thunderx/base/nicvf_hw.c | 2 +- drivers/net/thunderx/base/nicvf_hw.h | 12 +---

[dpdk-dev] [PATCH 2/3] net/thunderx: introduce cqe_rx2 HW capability flag

Certain thunderx SoC pass has additional optional word in Rx descriptor to hold tunneling extension info. Based on this capability, the location where packet pointer address stored in Rx descriptor will vary. Signed-off-by: Jerin Jacob --- drivers/net/thunderx/base/nicvf_hw.h | 5 +++--

[dpdk-dev] [PATCH 3/3] net/thunderx: add 81xx SoC support

81xx NIC subsystem differs in new PCI subsystem_device_id and NICVF_CAP_CQE_RX2 capability. Signed-off-by: Jerin Jacob --- doc/guides/nics/thunderx.rst | 1 + drivers/net/thunderx/base/nicvf_hw.c | 3 +++ drivers/net/thunderx/base/nicvf_hw.h | 1 + drivers/net/thunderx/nicvf_ethdev.c |

[dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count

> On Jul 21, 2016, at 8:54 AM, Neil Horman wrote: > > On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote: >> >>> On Jul 20, 2016, at 3:16 PM, Neil Horman wrote: >>> >>> On Wed, Jul 20, 2016 at 07:47:32PM +, Wiles, Keith wrote: > On Jul 20, 2016, at 12:48 PM, Neil

[dpdk-dev] [PATCH] eal: fix parsing of argument of option --lcores

Hi, 2016-07-21 14:03, Wei Dai: > The '-' in lcores set overrides cpu set of following > lcore set in the argument of EAL option --lcores. > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > Signed-off-by: Wei Dai Thanks for the catch! > ---

[dpdk-dev] [PATCH] EAL:fix memory barrier implementation on IBM POWER

2016-07-15 10:30, Chao Zhu: > On weak memory order architecture like POWER, rte_smp_wmb/rte_smp_rmb > need to use CPU instructions, not compiler barrier. This patch fixes > this. Also, to improve performance on PPC64, use light weight sync > instruction instead of sync instruction. > >

[dpdk-dev] [PATCH v2] mempool: adjust name string size in related data types

On 07/21/2016 03:47 PM, Zoltan Kiss wrote: > > > On 21/07/16 14:40, Olivier Matz wrote: >> Hi Zoltan, >> >> >> On 07/20/2016 07:16 PM, Zoltan Kiss wrote: >>> A recent patch brought up an issue about the size of the 'name' fields: >>> >>> 85cf0079 mem: avoid memzone/mempool/ring name truncation

[dpdk-dev] [PATCH] eal: fix check number of bytes from read function

Hi, 2016-07-20 16:24, Michal Jastrzebski: > - if (read(fd, , sizeof(uint64_t)) < 0) { > + > + retval = read(fd, , sizeof(uint64_t)); > + if (retval < 0) { > RTE_LOG(ERR, EAL, "%s(): cannot read /proc/self/pagemap: %s\n", > __func__,

[dpdk-dev] [PATCH] eal: fix check number of bytes from read function

On 20/07/2016 15:24, Michal Jastrzebski wrote: > In rte_mem_virt2phy: Value returned from a function and indicating the > number of bytes was ignored. This could cause a wrong pfn (page frame > number) mask read from pagemap file. > When read returns less than the number of sizeof(uint64_t) bytes,

[dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count

On Thu, Jul 21, 2016 at 02:09:19PM +, Wiles, Keith wrote: > > > On Jul 21, 2016, at 8:54 AM, Neil Horman wrote: > > > > On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote: > >> > >>> On Jul 20, 2016, at 3:16 PM, Neil Horman wrote: > >>> > >>> On Wed, Jul 20, 2016 at 07:47:32PM

[dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure

This is an ABI deprecation notice for DPDK 16.11 in librte_ether about changes in rte_eth_dev and rte_eth_desc_lim structures. As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different

[dpdk-dev] [PATCH] validate_abi: build faster by augmenting make with job count

> On Jul 21, 2016, at 10:06 AM, Neil Horman wrote: > > On Thu, Jul 21, 2016 at 02:09:19PM +, Wiles, Keith wrote: >> >>> On Jul 21, 2016, at 8:54 AM, Neil Horman wrote: >>> >>> On Wed, Jul 20, 2016 at 10:32:28PM +, Wiles, Keith wrote: > On Jul 20, 2016, at 3:16 PM, Neil

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] > Sent: Thursday, July 21, 2016 3:51 AM > Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a > checksum > >... > > + Added a new function ``rte_pktmbuf_cksum()`` to process the

[dpdk-dev] [PATCH] doc: announce KNI ethtool removal

2016-07-21 16:41, Igor Ryzhov: > On Thu, Jul 21, 2016 at 4:33 PM, Ferruh Yigit > wrote: > > On 7/20/2016 5:07 PM, Thomas Monjalon wrote: > > > The out-of-tree kernel code must be avoided. > > > Moreover there is no good reason to keep this legacy feature > > > which is only partially supported. >

[dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a checksum

Dear Don, On 07/21/2016 06:26 PM, Don Provan wrote: >> -Original Message- >> From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com] >> Sent: Thursday, July 21, 2016 3:51 AM >> Subject: Re: [dpdk-dev] [PATCH 04/12] mbuf: add function to calculate a >> checksum >> >> ... >>> +

[dpdk-dev] [RFC] Generic flow director/filtering/classification API

Hi Rahul, Please see below. On Thu, Jul 21, 2016 at 01:43:37PM +0530, Rahul Lakkireddy wrote: > Hi Adrien, > > The proposal looks very good. It satisfies most of the features > supported by Chelsio NICs. We are looking for suggestions on exposing > more additional features supported by

[dpdk-dev] [RFC 00/21] pcap pmd improvements

No new feature added, code refactored. This patch targetted for 16.11 release. Ferruh Yigit (21): net/pcap: create own configuration parameter net/pcap: use macros for param string net/pcap: reorganize private structs net/pcap: add checks for max queue number net/pcap: update function

[dpdk-dev] [RFC 01/21] net/pcap: create own configuration parameter

pcap pmd is using ring pmd configuration parameters to set max number of queues. This creates an unnecessary dependency and confusion. Create a new config parameter for pcap PMD: CONFIG_RTE_PMD_PCAP_MAX_QUEUES Default value of config is same as ring parameter default. pcap pmd doesn't need to

[dpdk-dev] [RFC 02/21] net/pcap: use macros for param string

Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 6343c0e..877e4c2 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++

  1   2   >