> -Original Message-
> From: Kerlin, MarcinX
> Sent: Monday, October 10, 2016 1:08 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo; Jastrzebski, MichalX K; Kerlin, MarcinX
> Subject: [PATCH 1/1] fix the number of operations in libcrypto test
>
> This patch reduce the number of
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Monday, October 10, 2016 5:27 PM
> To: Kerlin, MarcinX; dev at dpdk.org
> Cc: Jastrzebski, MichalX K
> Subject: Re: [dpdk-dev] [PATCH 1/1] fix the number of operations in
All init/uninit function names in the virtual devices have been renamed,
so they finish with probe or remove, so to keep consistency,
same thing should be done in this PMD.
Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
Signed-off-by: Pablo de Lara
---
All init/uninit function names in the virtual devices have been renamed,
so they finish with probe or remove, so to keep consistency,
same thing should be done in this PMD.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Signed-off-by: Pablo de Lara
---
Hi Adrien Mazarguil,
There is a struct rte_flow_action_rss in rte_flow.txt, the member
rss_conf is a pointer type, is there any convenience in using pointer?
Why not using struct rte_eth_rss_conf rss_conf type, as rte_flow_item_ipv4/
rte_flow_item_ipv6 struct member?
Thank you.
struct
On Mon, Oct 10, 2016 at 10:49:22AM +, Kavanagh, Mark B wrote:
> >
> >On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote:
> >> /*
> >> * dev_ops for virtio, bare necessities for basic operation
> >> */
> >> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
> >>
On Wed, Sep 28, 2016 at 04:25:11PM +0800, Jason Wang wrote:
> Add modern device id and rename VIRTIO_PCI_DEVICEID_MIN to
> VIRTIO_PCI_LEGACY_DEVICEID_NET. While at it, remove unused macros too.
>
> Signed-off-by: Jason Wang
Series applied to dpdk-next-virtio.
Thanks.
--yliu
On Fri, Oct 07, 2016 at 07:24:44AM +0300, Michael S. Tsirkin wrote:
> On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote:
> > Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support.
> >
> > Signed-off-by: Jason Wang
> > ---
> > Changes from v1:
> > - remove unnecessary NEED_MAPPING
On Mon, Oct 10, 2016 at 10:42:58PM +0200, Thomas Monjalon wrote:
> > Support New Device Types in Vhost-User: Support will be added to vhost-user
> > for new device types including vhost-scsi and vhost-blk.
>
> Great!
> Is it only related to networking or should we expect some storage-related
>
On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote:
>
>
> On 10/10/2016 04:42 PM, Yuanhan Liu wrote:
> >On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime Coquelin wrote:
> >At that time, a packet always use 2 descs. Since indirect desc is
> >enabled (by default) now, the
On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
>> Hi Thomas,
>>
>>> -Original Message-
>>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>>> Sent: Friday, October 07, 2016 7:22 PM
>>> To: Shreyansh Jain
On 10/11/2016 08:04 AM, Yuanhan Liu wrote:
> On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote:
>>
>>
>> On 10/10/2016 04:42 PM, Yuanhan Liu wrote:
>>> On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime Coquelin wrote:
>>> At that time, a packet always use 2 descs. Since indirect
On Tue, Oct 11, 2016 at 08:39:54AM +0200, Maxime Coquelin wrote:
>
>
> On 10/11/2016 08:04 AM, Yuanhan Liu wrote:
> >On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote:
> >>
> >>
> >>On 10/10/2016 04:42 PM, Yuanhan Liu wrote:
> >>>On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime
On Mon, Oct 10, 2016 at 07:39:59AM +0300, Michael S. Tsirkin wrote:
> > > > > > 1. why is this memset expensive?
> > > > >
> > > > > I don't have the exact answer, but just some rough thoughts:
> > > > >
> > > > > It's an external clib function: there is a call stack and the
> > > > > IP register
2016-10-11 12:06, Shreyansh Jain:
> On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> > On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
> >> Hi Thomas,
> >>
> >>> -Original Message-
> >>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> >>> Sent: Friday,
Hi Ferruh, Thomas,
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, October 05, 2016 9:29 AM
>
> 2016-09-30 18:40, Mody, Rasesh:
> > > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] Thank you for the
> > > update, base driver patch update now reduced from
>
If offloading features are not negotiated, parsing the virtio header
is not needed.
Micro-benchmark with testpmd shows that the gain is +4% with indirect
descriptors, +1% when using direct descriptors.
Signed-off-by: Maxime Coquelin
---
Changes since v1:
=
- Rebased
- Fix
2016-10-10 15:39, John Ousterhout:
> Before this patch, application-specific loggers could not be
> installed before rte_eal_init completed (the initialization process
> called rte_openlog_stream, overwriting any previously installed
> logger). This made it impossible for an application to capture
>-Original Message-
>From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
>Sent: Tuesday, October 11, 2016 5:01 AM
>To: Kavanagh, Mark B
>Cc: Dey ; stephen at networkplumber.org; dev at dpdk.org
>Subject: Re: [PATCH v7] net/virtio: add set_mtu in virtio
>
>On Mon, Oct 10, 2016 at
Hi Wei,
On Tue, Oct 11, 2016 at 01:47:53AM +, Zhao1, Wei wrote:
> Hi Adrien Mazarguil,
> There is a struct rte_flow_action_rss in rte_flow.txt, the member
> rss_conf is a pointer type, is there any convenience in using pointer?
> Why not using struct rte_eth_rss_conf rss_conf type,
That is looks really good and should save a lot of time for maintainer
taking already validated patches. How hard is connection between patchwork,
mailing list tags and testing system? Is that all inside patchwork or you
wrote it specially for dpdk? I would really like to have the same thing
for
Hi Vladislav,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladyslav Buslov
> Sent: Monday, October 10, 2016 6:06 PM
> To: Wu, Jingjing ; Yigit, Ferruh intel.com>; Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: add
2016-10-07 12:23, Kerlin, MarcinX:
> Hi Thomas,
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Sent: Thursday, October 06, 2016 4:53 PM
> > To: Kerlin, MarcinX
> > Cc: dev at dpdk.org; De Lara Guarch, Pablo > intel.com>
> > Subject: Re:
On 10/10/16 12:36, Thomas Monjalon wrote:
> Hi,
>
> I would like to raise a naming issue in crypto.
>
> In the crypto side of DPDK, we have a library (similar to ethdev)
> for crypto API and device interface:
> http://dpdk.org/browse/dpdk/tree/lib/librte_cryptodev
> There are also some
On Tue, Oct 11, 2016 at 09:45:27AM +0200, Maxime Coquelin wrote:
> @@ -684,12 +699,12 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct
> vring_desc *descs,
> struct rte_mempool *mbuf_pool)
> {
> struct vring_desc *desc;
> - uint64_t desc_addr;
> + uint64_t
Hi Thomas,
On 10/10/2016 04:52 PM, Thomas Monjalon wrote:
> 2016-10-03 10:38, Olivier Matz:
>> The file rte_mbuf.h starts to be quite big, and next commits
>> will introduce more functions related to packet types. Let's
>> move them in a new file.
>>
>> Signed-off-by: Olivier Matz
>> ---
>>
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>
> Thanks Tim for the interesting inputs.
> Some of them may require a dedicated thread to continue the discussion
> based on some preliminary specifications or drafts.
Agreed. To avoid me acting as a middle man, I'm going to ask the
2016-10-11 09:53, Declan Doherty:
> On 10/10/16 12:36, Thomas Monjalon wrote:
> > Hi,
> >
> > I would like to raise a naming issue in crypto.
> >
> > In the crypto side of DPDK, we have a library (similar to ethdev)
> > for crypto API and device interface:
> >
Hi John,
On 9/29/2016 9:56 PM, John Daley wrote:
> 1300 series Cisco adapter firmware version 2.0(13) for UCS
> C-series servers and 3.1(2) for blade servers supports more
> filtering capabilities. The feature can be enabled via Cisco
> CIMC or USCM with the 'advanced filters' radio button. When
Hi Konstantin,
> -Original Message-
> From: Ananyev, Konstantin [mailto:konstantin.ananyev at intel.com]
> Sent: Tuesday, October 11, 2016 11:51 AM
> To: Vladyslav Buslov; Wu, Jingjing; Yigit, Ferruh; Zhang, Helin
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: add
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Tuesday, October 11, 2016 2:22 AM
> To: John Daley (johndale) ;
> bruce.richardson at intel.com
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300
> series
Hi Keith,
On 10/4/2016 3:45 PM, Keith Wiles wrote:
> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
> on the local host. The PMD allows for DPDK and the host to
> communicate using a raw device interface on the host and in
> the DPDK application. The device created is a Tap
Hi Olivier,
Secondary process support's got overlooked during this refactoring, thanks
for the patch. However can you describe the issue you're addressing as part
of the commit log?
I think problems started when txq got mistakenly converted to
primary_txq_ctrl in 21c8bb4928c9 ("net/mlx5: split
>-Original Message-
>From: Jastrzebski, MichalX K
>Sent: Wednesday, September 14, 2016 10:48 AM
>To: Akhil Goyal ; Azarewicz, PiotrX T
>; Doherty, Declan
>; dev at dpdk.org
>Cc: Kerlin, MarcinX ; Mrozowicz, SlawomirX
>; Kobylinski, MichalX
>; Kulasek, TomaszX
>; Mrzyglod, DanielX T
>
This patch fix that created pool for crypto mbufs may be too big in some
environments.
To avoid the issue, mbuf pool is reverted to its previous size.
Moreover, here is added additional small pool with one large mbuf, what
is needed in large data test scenarios.
Fixes: ffbe3be0d4b5 ("app/test:
Hi Thomas,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, October 10, 2016 9:43 PM
> To: O'Driscoll, Tim
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] 17.02 Roadmap
>
> Thanks Tim for the interesting inputs.
> Some of
2016-10-04 16:45 GMT+02:00, Keith Wiles :
> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
> on the local host. The PMD allows for DPDK and the host to
> communicate using a raw device interface on the host and in
> the DPDK application. The device created is a Tap device with
> a
Hi,
Firstly, apologize for so late review. It's been forgotten :(
BTW, please feel free to ping me in future if I made no response
in one or two weeks!
I haven't reviewed it carefully yet (something I will do tomorrow).
Before that, few quick questions.
Firstly, would you write down some test
On 10/4/2016 3:45 PM, Keith Wiles wrote:
> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
> on the local host. The PMD allows for DPDK and the host to
> communicate using a raw device interface on the host and in
> the DPDK application. The device created is a Tap device with
> a
Hi Yuanhan,
On 10/11/2016 01:35 PM, Yuanhan Liu wrote:
> Hi,
>
> Firstly, apologize for so late review. It's been forgotten :(
>
> BTW, please feel free to ping me in future if I made no response
> in one or two weeks!
>
> I haven't reviewed it carefully yet (something I will do tomorrow).
>
On 10/4/2016 3:45 PM, Keith Wiles wrote:
> +/*
> + * Open a TAP interface device.
> + */
> +static int
> +rte_pmd_tap_devinit(const char *name, const char *params)
> +{
> + int ret = 0;
> + struct rte_kvargs *kvlist;
> + struct tap_info tap_info;
> +
> + /* Setup default values */
Hi Olivier,
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Move all code related to device initialization in a new function
> virtio_init_device().
>
> This commit brings no functional change, it prepares the next commits
> that will add the offload support. For that, it will be needed to
>
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Move the configuration of control queue in the configure callback.
> This is needed by next commit, which introduces the reinitialization
> of the device in the configure callback to change the feature flags.
> Therefore, the control queue will have
Tested-by: Qian Xu
- Apply patch to dpdk-next-virtio: Pass
- Compile: Pass
- OS: Ubuntu16.04 4.4.0-34-generic
- GCC: 5.4.0
Test Case - Pass, over 20% performance gain for big packet(1024B), and it's
designed to improve big packet performance.
- Test case: Without NIC, Vhost dequeuer, virtio
> > You sure can - use the 'retag' command [1]:
> >
> > ? ? ./manage.py retag
> >
> > I should probably have included that in the upgrade notes...
> >
> > Stephen
> >
> > [1]
> > https://github.com/getpatchwork/patchwork/blob/stable/1.1/patchwork/management/commands/>
> > retag.py
>
> That
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Add the ability to reset the virtio device in the configure callback
> if the features flag changed since previous reset. This will be possible
> with the introduction of offload support in next commits.
>
> Signed-off-by: Olivier Matz
> ---
>
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> This function can be used to calculate the checksum of data embedded in
> mbuf, that can be composed of several segments.
>
> This function will be used by the virtio pmd in next commits to calculate
> the checksum in software in case the protocol is
Hi Maxime,
On 10/11/2016 03:25 PM, Maxime Coquelin wrote:
>> /**
>> + * Compute the raw (non complemented) checksum of a packet.
>> + *
>> + * @param m
>> + * The pointer to the mbuf.
>> + * @param off
>> + * The offset in bytes to start the checksum.
>> + * @param len
>> + * The length in
On Tue, Oct 11, 2016 at 12:06:27PM +0530, Shreyansh Jain wrote:
> On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> > On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
> > > Hi Thomas,
> > >
> > > > -Original Message-
> > > > From: Thomas Monjalon
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Following discussions in [1] and [2], introduce a new bit to
> describe the Rx checksum status in mbuf.
>
> Before this patch, only one flag was available:
> PKT_RX_L4_CKSUM_BAD: L4 cksum of RX pkt. is not OK.
>
> And same for L3:
>
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> ---
> app/test-pmd/csumonly.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index d5eb260..8c88ee8 100644
> --- a/app/test-pmd/csumonly.c
> +++
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> When receiving coalesced packets in virtio, the original size of the
> segments is provided. This is a useful information because it allows to
> resegment with the same size.
>
> Add a RX new flag in mbuf, that can be set when packets are coalesced
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> In csumonly engine, display the value of LRO segment if the
> LRO flag is set.
>
> Signed-off-by: Olivier Matz
> ---
> app/test-pmd/csumonly.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
It's possible to have the same numbers for bus, device id and function,
therefore we need to differentiate on domain.
This enables DPDK with multiple VFs on ThunderX 2-socket hardware.
Signed-off-by: Maciej Czekaj
Signed-off-by: Kamil Rytarowski
Signed-off-by: Zyta Szpak
Signed-off-by:
W dniu 10.10.2016 o 15:27, Ferruh Yigit pisze:
> On 10/10/2016 2:01 PM, Kamil Rytarowski wrote:
>>
>> W dniu 10.10.2016 o 12:19, Ferruh Yigit pisze:
>>> Hi Kamil,
>>>
>>> On 9/30/2016 1:05 PM, Kamil Rytarowski wrote:
It's possible to have the same numbers for bus, device id and function,
On Wed, 2016-10-05 at 22:36 -0700, Rasesh Mody wrote:
> Fix the max number of PF rx/tx queues. Set the value based
> on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128.
>
> Fixes: 540a211 ("bnx2x: driver core")
>
> Signed-off-by: Rasesh Mody
> ---
> drivers/net/bnx2x/bnx2x.c |4
2016-10-11 09:38, Neil Horman:
> This also begs the question in my mind, is it really worth changing the macro?
> I really don't think it is. The registration macros are pretty descriptive as
> they stand, and have already changed 3 or 4 times in the last 6 months, which
> suggests to me that any
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Signed-off-by: Olivier Matz
> ---
> drivers/net/virtio/virtio_ethdev.c | 14
> drivers/net/virtio/virtio_ethdev.h | 2 +-
> drivers/net/virtio/virtio_rxtx.c | 69
> ++
>
From: Nikhil Jagtap [mailto:nikhil.jag...@gmail.com]
Sent: Wednesday, October 5, 2016 8:10 AM
To: Dumitrescu, Cristian
Cc: dev at dpdk.org; users at dpdk.org
Subject: Re: qos: traffic shaping at queue level
Hi Cristian,
Thanks for the info. A few more comments/questions inline.
On 3 October
On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Signed-off-by: Olivier Matz
> ---
> drivers/net/virtio/virtio_ethdev.c | 7 ++-
> drivers/net/virtio/virtio_ethdev.h | 9 -
> drivers/net/virtio/virtio_rxtx.c | 21 +
> 3 files changed, 27 insertions(+), 10
>
>On Wed, 2016-10-05 at 22:36 -0700, Rasesh Mody wrote:
>> Fix the max number of PF rx/tx queues. Set the value based
>> on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128.
>>
>> Fixes: 540a211 ("bnx2x: driver core")
>>
>> Signed-off-by: Rasesh Mody
>> ---
>>
On 10/11/2016 04:04 PM, Maxime Coquelin wrote:
>> +/* Optionally fill offload information in structure */
>> +static int
>> +virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr)
>> +{
>> +struct rte_net_hdr_lens hdr_lens;
>> +uint32_t hdrlen, ptype;
>> +int l4_supported
On 10/11/2016 04:29 PM, Olivier MATZ wrote:
>
>
> On 10/11/2016 04:04 PM, Maxime Coquelin wrote:
>>> +/* Optionally fill offload information in structure */
>>> +static int
>>> +virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr)
>>> +{
>>> +struct rte_net_hdr_lens hdr_lens;
mlx5_rx_queue_setup() was setting the Rx function by itself instead of
using priv_select_rx_function() written for that purpose.
Fixes: cdab90cb5c8d ("net/mlx5: add Tx/Rx burst function selection wrapper")
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed,
On 10/11/2016 04:36 PM, Maxime Coquelin wrote:
>
>
> On 10/11/2016 04:29 PM, Olivier MATZ wrote:
>>
>>
>> On 10/11/2016 04:04 PM, Maxime Coquelin wrote:
+/* Optionally fill offload information in structure */
+static int
+virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr
On Tue, Oct 11, 2016 at 03:57:29PM +0200, Thomas Monjalon wrote:
> 2016-10-11 09:38, Neil Horman:
> > This also begs the question in my mind, is it really worth changing the
> > macro?
> > I really don't think it is. The registration macros are pretty descriptive
> > as
> > they stand, and have
On Tue, Oct 11, 2016 at 04:44:50PM +0200, Nelio Laranjeiro wrote:
> mlx5_rx_queue_setup() was setting the Rx function by itself instead of
> using priv_select_rx_function() written for that purpose.
>
> Fixes: cdab90cb5c8d ("net/mlx5: add Tx/Rx burst function selection wrapper")
>
>
Hi Bernard,
On 10/7/2016 11:45 AM, Bernard Iremonger wrote:
> add test for set vf vlan anti spoof
> add test for set vf mac anti spoof
> add test for set vf vlan stripq
> add test for set vf vlan insert
> add test for set tx loopback
> add test for set all queues drop enable bit
> add test for
2016-10-11 16:09, Ferruh Yigit:
> This will cause a compilation error for shared libraries. Because PMDs
> not linked against application when compiled as shared library but used
> as plugins.
>
> Since it has been decided to have NIC specific APIs, we need to re-work
> that approach to fix
2016-10-11 11:01, Olivier MATZ:
> Hi Thomas,
>
> On 10/10/2016 04:52 PM, Thomas Monjalon wrote:
> > 2016-10-03 10:38, Olivier Matz:
> >> The file rte_mbuf.h starts to be quite big, and next commits
> >> will introduce more functions related to packet types. Let's
> >> move them in a new file.
>
Hi Thomas,
> Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new
> API's
>
> 2016-10-11 16:09, Ferruh Yigit:
> > This will cause a compilation error for shared libraries. Because PMDs
> > not linked against application when compiled as shared library but
> > used as plugins.
2016-10-03 10:38, Olivier Matz:
> This patchset introduces a software packet type parser. This
> feature is targeted for v16.11.
>
> The goal here is to provide a reference implementation for packet type
> parsing. This function will be used by testpmd to compare its result
> with the value given
On Tue, Oct 11, 2016 at 1:08 AM, Thomas Monjalon
wrote:
>
> 2016-10-10 15:39, John Ousterhout:
> > ...
> >
> > Note: I see from the code that Linux and BSD set different default
streams:
> > Linux uses stdout, while BSD uses stderr. This patch retains the
distinction,
> > though I'm not sure why
2016-10-11 15:51, Iremonger, Bernard:
> Hi Thomas,
>
>
>
> > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new
> > API's
> >
> > 2016-10-11 16:09, Ferruh Yigit:
> > > This will cause a compilation error for shared libraries. Because PMDs
> > > not linked against
Hi Thomas,
> > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for
> > > new API's
> > >
> > > 2016-10-11 16:09, Ferruh Yigit:
> > > > This will cause a compilation error for shared libraries. Because
> > > > PMDs not linked against application when compiled as shared
> > > >
On Tue, Oct 11, 2016 at 3:49 PM, Kamil Rytarowski
wrote:
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 382c959..01d5fb0 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -225,7 +225,7 @@
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Friday, October 07, 2016 9:05 AM
> To: dev at dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH v5 0/8] Misc enhancements in testpmd
>
> This patchset introduces several enhancements or minor fixes
> in
2016-10-11 09:30, John Ousterhout:
> On Tue, Oct 11, 2016 at 1:08 AM, Thomas Monjalon 6wind.com>
> wrote:
> >
> > 2016-10-10 15:39, John Ousterhout:
> > > ...
> > >
> > > Note: I see from the code that Linux and BSD set different default
> streams:
> > > Linux uses stdout, while BSD uses stderr.
2016-10-07 18:05, Olivier Matz:
> The functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name()
> can dump one flag, or set of flag that are part of the same mask (ex:
> PKT_TX_UDP_CKSUM, part of PKT_TX_L4_MASK). But they are not designed to
> dump the list of flags contained in
Regards,
Keith
> On Oct 11, 2016, at 6:30 AM, Micha? Miros?aw wrote:
>
> 2016-10-04 16:45 GMT+02:00, Keith Wiles :
>> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
>> on the local host. The PMD allows for DPDK and the host to
>> communicate using a raw device interface on the
Regards,
Keith
> On Oct 11, 2016, at 7:28 AM, Yigit, Ferruh wrote:
>
> On 10/4/2016 3:45 PM, Keith Wiles wrote:
>> +/*
>> + * Open a TAP interface device.
>> + */
>> +static int
>> +rte_pmd_tap_devinit(const char *name, const char *params)
>> +{
>> +int ret = 0;
>> +struct rte_kvargs
Regards,
Keith
> On Oct 11, 2016, at 6:49 AM, Yigit, Ferruh wrote:
>
> On 10/4/2016 3:45 PM, Keith Wiles wrote:
>> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
>> on the local host. The PMD allows for DPDK and the host to
>> communicate using a raw device interface on the
All of your suggestions look reasonable and fairly straightforward; I'll
work on a new patch that includes them.
Given that rte_eal_log_init is a no-op (and won't even be invoked), would
it be better to remove that function completely, and even delete the file
containing it (eal_log.c), or is it
This patch adds support to get Link notification asynchronously.
The HW sends Async notifications on default completion ring. The
PMD processes these notifications and logs a message appropriately.
Signed-off-by: Ajit Khaparde
--
v2: Remove unused function rte_bnxt_atomic_read_link_status which
The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
on the local host. The PMD allows for DPDK and the host to
communicate using a raw device interface on the host and in
the DPDK application. The device created is a Tap device with
a L2 packet header.
v5 - merge in changes from list
> -Original Message-
> From: John Ousterhout [mailto:ouster at cs.stanford.edu]
> Sent: Tuesday, October 11, 2016 9:30 AM
> To: Thomas Monjalon
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] log: respect rte_openlog_stream calls
> before rte_eal_init
>
> On Tue, Oct 11, 2016
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, October 10, 2016 1:43 PM
> To: O'Driscoll, Tim
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] 17.02 Roadmap
>
> Thanks Tim for the interesting inputs.
> Some of them may
Correctly hint the cache line size. Remove unused macros associated
with the cache line size.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
Acked-by: Harish Patil
---
drivers/net/bnx2x/bnx2x.h | 5 +
1 file changed, 1 insertion(+), 4
ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined. Remove them
along with enumeration constants dependent on their inclusion.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.c | 28
This 2.5s delay doesn't seem to serve any purpose other than a being a
pause after logging the device configuration.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_rxtx.c | 13 +++--
drivers/net/bnx2x/bnx2x_rxtx.h | 6 --
2 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c
Don't use bnx2x_fill_accept_flags() to fill the RX mask in the VF
since the PF only handles a subset of the existing flags. now,
bnx2x_fill_accept_flags() can be static.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.c
Replace BNX2X_TLV_APPEND() with the clearer and safer bnx2x_add_tlv().
bnx2x_add_tlv() was previously prototyped at some point but can be static.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_vfpf.c | 80
The pf2vf mailbox can only be used by one thread at a time.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.h| 12 +++--
drivers/net/bnx2x/bnx2x_ethdev.c | 2 +
drivers/net/bnx2x/bnx2x_vfpf.c | 113
Refactor bnx2x_do_req4pf() to be easier to read and return errors when
the transaction fails -- Previously, it could succeed when the control
channel was down.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_vfpf.c | 110
bnx2x_loop_obtain_resources() returns a struct. This routine either
succeeds or fails -- We don't need a struct for that.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_vfpf.c | 51
The register read/writes should just be static inline instead of
alternately defined as routines or macros depending on the status of
debugging.
Fix bnx2x_reg_read32() returning 0 during debug unaligned reads.
Fixes: b5bf7719221d ("bnx2x: driver support routines")
Signed-off-by: Chas Williams
DPDK version:16.07
OS: Ubuntu 15:04
dual-port Intel X710 10GbE PCI-Express NICs
I have installed the modules, ran the tool to bind them to the NICs,
running gdb over skeleton/basicfwd example shows that rte_eal_init
completes, but it fails at the even number of ports check since
rte_eth_dev_count
I had enabled 1G hugepages and verified that they are recognised in
eal_hugepage_init
On Tue, Oct 11, 2016 at 5:19 PM, Aniraj Kesavan
wrote:
>
> DPDK version:16.07
> OS: Ubuntu 15:04
> dual-port Intel X710 10GbE PCI-Express NICs
>
> I have installed the modules, ran the tool to bind them to the
Don's argument for stderr over stdout makes sense to me. Does anyone else
disagree?
-John-
On Tue, Oct 11, 2016 at 3:16 PM, Don Provan wrote:
> > -Original Message-
> > From: John Ousterhout [mailto:ouster at cs.stanford.edu]
> > Sent: Tuesday, October 11, 2016 9:30 AM
> > To: Thomas
100 matches
Mail list logo
