[dpdk-dev] [PATCH v3 01/23] eal: introduce one device scan

2018-06-25 Thread Qi Zhang
When hot plug a new device, it is not necessary to scan everything on the bus since the devname and devargs are already there. So new rte_bus ops "scan_one" is introduced, bus driver can implement this function to simplify the hotplug process. Signed-off-by: Qi Zhang --- lib/librte_eal/common/ea

[dpdk-dev] [PATCH v3 00/22] enable hotplug on multi-process

2018-06-25 Thread Qi Zhang
v3: - enable mp init callback register to help non-eal module to initialize mp channel during rte_eal_init - fix when attach share device from secondary. 1) dead lock due to sync IPC be invoked in rte_malloc in primary process when handle secondary request to attach device, the soluti

[dpdk-dev] [PATCH v3 03/23] ethdev: add function to release port in local process

2018-06-25 Thread Qi Zhang
Add driver API rte_eth_release_port_private to support the requirement that an ethdev only be released on secondary process, so only local state be set to unused , share data will not be reset so primary process can still use it. Signed-off-by: Qi Zhang --- lib/librte_ethdev/rte_ethdev.c

[dpdk-dev] [PATCH v3 02/23] bus/vdev: enable one device scan

2018-06-25 Thread Qi Zhang
The patch implemented the ops scan_one for vdev bus, it gives two benifits 1. Improve scan efficiency when a device is attached as hotplug, since no need to pupulate a new device by iterating all devargs in devargs_list. 2. It also avoid sync IPC invoke (which happens in vdev->scan on secondary pro

[dpdk-dev] [PATCH v3 04/23] eal: enable multi process init callback

2018-06-25 Thread Qi Zhang
Introduce new API rte_eal_register_mp_init that help to register a callback function which will be invoked right after multi-process channel be established (rte_mp_channel_init). Typically the API will be used by other module that want it's mp channel action callbacks can be registered during rte_e

[dpdk-dev] [PATCH v3 05/23] ethdev: enable hotplug on multi-process

2018-06-25 Thread Qi Zhang
We are going to introduce the solution to handle different hotplug cases in multi-process situation, it include below scenario: 1. Attach a share device from primary 2. Detach a share device from primary 3. Attach a share device from secondary 4. Detach a share device from secondary 5. Attach a pr

[dpdk-dev] [PATCH v3 06/23] ethdev: introduce device lock

2018-06-25 Thread Qi Zhang
Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let application lock or unlock on specific ethdev, a locked device can't be detached, this help applicaiton to prevent unexpected device detaching, especially in multi-process envrionment. Aslo introduce the new API rte_eth_dev_lock_with_cal

[dpdk-dev] [PATCH v3 09/23] net/ixgbe: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 1 file c

[dpdk-dev] [PATCH v3 07/23] ethdev: support attach or detach share device from secondary

2018-06-25 Thread Qi Zhang
This patch cover the multi-process hotplug case when a share device attach/detach request be issued from secondary process, the implementation references malloc_mp.c. device attach on secondary: a) seconary send asycn request to primary and wait on a condition which will be released by matched

[dpdk-dev] [PATCH v3 08/23] net/i40e: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 2 ++ drivers/net/i40e/i

[dpdk-dev] [PATCH v3 10/23] net/e1000: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/e1000/em_ethdev.c | 9 + 1 file changed,

[dpdk-dev] [PATCH v3 11/23] net/igb: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/e1000/igb_ethdev.c | 9 + 1 file changed

[dpdk-dev] [PATCH v3 13/23] net/af_packet: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/af_packet/rte_eth_af_packet.c | 11 +++

[dpdk-dev] [PATCH v3 15/23] net/failsafe: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/failsafe/failsafe.c | 16 1 fil

[dpdk-dev] [PATCH v3 12/23] net/fm10k: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 9 + 1 file chang

[dpdk-dev] [PATCH v3 14/23] net/bonding: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++ 1 f

[dpdk-dev] [PATCH v3 16/23] net/kni: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/kni/rte_eth_kni.c | 11 +++ 1 file chang

[dpdk-dev] [PATCH v3 17/23] net/null: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/null/rte_eth_null.c | 16 +++- 1 fil

[dpdk-dev] [PATCH v3 22/23] net/vhost: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file c

[dpdk-dev] [PATCH v3 18/23] net/octeontx: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/octeontx/octeontx_ethdev.c | 16

[dpdk-dev] [PATCH v3 20/23] net/softnic: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/softnic/rte_eth_softnic.c | 19 -

[dpdk-dev] [PATCH v3 19/23] net/pcap: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_eth_pcap.c | 15 ++- 1 file

[dpdk-dev] [PATCH v3 21/23] net/tap: enable port detach on secondary process

2018-06-25 Thread Qi Zhang
Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/tap/rte_eth_tap.c | 17 +++-- 1 file

Re: [dpdk-dev] [PATCH v2 4/7] vhost: translate iovas at vectors fill time

2018-06-25 Thread Maxime Coquelin
On 06/25/2018 04:21 AM, Tiwei Bie wrote: On Sat, Jun 23, 2018 at 09:11:24AM +0200, Maxime Coquelin wrote: This patch aims at simplifying the desc to mbuf and mbuf to desc copy functions. It performs the iova to hva translations at vectors fill time. Doing this, in case desc buffer isn't cont

[dpdk-dev] [PATCH v3 23/23] examples/multi_process: add hotplug sample

2018-06-25 Thread Qi Zhang
The sample code demonstrate device (ethdev only) management at multi-process envrionment. User can attach/detach a device on primary process and see it is synced on secondary process automatically, also user can lock a device to prevent it be detached or unlock it to go back to default behaviour.

[dpdk-dev] [PATCH] net/i40e: fix Tx check descriptor status APIs error

2018-06-25 Thread Wei Zhao
This is a issue involve RS bit set rule in ixgbe. Let us take function i40e_xmit_pkts_vec () as an example, in this function RS bit will be set for descriptor with index txq->tx_next_rs, and also descriptor free function i40e_tx_free_bufs() also check RS bit for descriptor with index txq->tx_next_r

[dpdk-dev] [PATCH v2 1/8] vhost: announce VIRTIO_F_IN_ORDER support

2018-06-25 Thread Marvin Liu
If devices always use descriptors in the same order in which they have been made available. These devices can offer the VIRTIO_F_IN_ORDER feature. If negotiated, this knowledge allows devices to notify the use of a batch of buffers to virtio driver by only writing used ring index. Vhost user devic

[dpdk-dev] [PATCH v2 2/8] net/virtio: add VIRTIO_F_IN_ORDER definition

2018-06-25 Thread Marvin Liu
If VIRTIO_F_IN_ORDER has been negotiated, driver will use descriptors in ring order: starting from offset 0 in the table, and wrapping around at the end of the table. Also introduce use_inorder_[rt]x flag for selection of IN_ORDER [RT]x handlers. Signed-off-by: Marvin Liu diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 0/8] support VIRTIO_F_IN_ORDER feature

2018-06-25 Thread Marvin Liu
In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced. When this feature has been negotiated, virtio driver will use descriptors in ring order: starting from offset 0 in the table, and wrapping around at the end of the table. Vhost devices will always use descriptors in the same o

[dpdk-dev] [PATCH v2 6/8] net/virtio: support IN_ORDER Rx and Tx

2018-06-25 Thread Marvin Liu
IN_ORDER Rx function can support merge-able feature. Descriptors allocation and free will be done in bulk. Virtio dequeue logic: dequeue_burst_rx(burst mbufs) for (each mbuf b) { if (b need merge) { merge remained mbufs add merged mbuf to

[dpdk-dev] [PATCH v2 4/8] net/virtio: free IN_ORDER descriptors before device start

2018-06-25 Thread Marvin Liu
Add new function for freeing IN_ORDER descriptors. As descriptors will be allocated and freed sequentially when IN_ORDER feature was negotiated. There will be no need to utilize chain for freed descriptors management, only index update is enough. Signed-off-by: Marvin Liu diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 5/8] net/virtio: extract common part for IN_ORDER functions

2018-06-25 Thread Marvin Liu
IN_ORDER virtio-user Tx function support Tx checksum offloading and TSO which also support on normal Tx function. So extracts common part into separated function. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 0bca29855..e9b1b496e

[dpdk-dev] [PATCH v2 7/8] net/virtio: add IN_ORDER Rx/Tx into selection

2018-06-25 Thread Marvin Liu
After IN_ORDER Rx/Tx paths added, need to update Rx/Tx path selection logic. Rx path select logic: If IN_ORDER is disabled will select normal Rx path. If IN_ORDER is enabled, Rx offload and merge-able are disabled will select simple Rx path. Otherwise will select IN_ORDER Rx path. Tx path select

[dpdk-dev] [PATCH v2 3/8] net/virtio-user: add mrg_rxbuf and in_order vdev parameters

2018-06-25 Thread Marvin Liu
Add parameters for configuring VIRTIO_NET_F_MRG_RXBUF and VIRTIO_F_IN_ORDER feature bits. If feature is disabled, also update corresponding unsupported feature bit. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_us

[dpdk-dev] [PATCH v2 8/8] net/virtio: annouce VIRTIO_F_IN_ORDER support

2018-06-25 Thread Marvin Liu
Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 8ab1267b0..69da18d9c 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -36,6 +36,7 @@ 1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE | \

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Tx check descriptor status APIs error

2018-06-25 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, June 25, 2018 2:49 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix Tx check descriptor status APIs error > > Hi,qi > > > -Original Message- > > From: Zhang, Qi

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Tx check descriptor status APIs error

2018-06-25 Thread Zhao1, Wei
Hi, qi > -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 25, 2018 3:47 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix Tx check descriptor status APIs error > > > > > -Original Message- > > From: Zhao1, Wei

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Tx check descriptor status APIs error

2018-06-25 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, June 25, 2018 3:53 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix Tx check descriptor status APIs error > > Hi, qi > > > -Original Message- > > From: Zhang, Qi

Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues

2018-06-25 Thread Michał Krawczyk
Hi Daria, >From what you reported on bugzilla, it looks like this patch won't fix the issue. Have you tried to execute the application with the changes I suggested in the earlier email thread? Thanks, Michal czw., 21.06.2018, 17:34 użytkownik Daria Kolistratova napisał: > > When he number of

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Tx check descriptor status APIs error

2018-06-25 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 25, 2018 3:56 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix Tx check descriptor status APIs error > > > > > -Original Message- > > From: Zhao1, Wei > > S

[dpdk-dev] [Bug 65] Tx VLAN offload not working on DPDK 17.11 LTS

2018-06-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=65 Bug ID: 65 Summary: Tx VLAN offload not working on DPDK 17.11 LTS Product: DPDK Version: 17.11 Hardware: All OS: Linux Status: CONFIRMED Severity: major P

Re: [dpdk-dev] patch for dpdk-devbind.py support ipv6

2018-06-25 Thread Burakov, Anatoly
On 21-Jun-18 3:51 PM, Yaron Illouz wrote: Hi dpdk-devbind.py support only ipv4 interface, when run with -s parameter which is status, it display all ipv6 interface as non Active It set interface as Active according to "ip -o route" output Here is a change that can support ipv6 @@ -269,6 +269,

Re: [dpdk-dev] [PATCH v3 08/23] net/i40e: enable port detach on secondary process

2018-06-25 Thread Andrew Rybchenko
On 06/25/2018 10:17 AM, Qi Zhang wrote: Previously, detach port on secondary process will mess primary process and cause same device can't be attached again, by take advantage of rte_eth_release_port_private, we can support this with minor change. Signed-off-by: Qi Zhang --- drivers/net/i40e/

Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops

2018-06-25 Thread Daly, Lee
> > > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > >> Sent: Tuesday, May 15, 2018 11:32 AM > >> To: De Lara Guarch, Pablo > >> Cc: Trahe, Fiona ; dev@dpdk.org; > >> pathr...@caviumnetworks.com; Sunila Sahu > >> ; Ashish Gupta > >> > >> Sub

Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops

2018-06-25 Thread Verma, Shally
HI Lee >-Original Message- >From: Daly, Lee [mailto:lee.d...@intel.com] >Sent: 25 June 2018 15:35 >To: Verma, Shally >Cc: Trahe, Fiona ; dev@dpdk.org; >pathr...@caviumnetworks.com; Sahu, Sunila ; >Gupta, Ashish ; De Lara Guarch, Pablo > >Subject: RE: [dpdk-dev] [PATCH v1 2/6] compress/z

Re: [dpdk-dev] [PATCH v2 4/7] vhost: translate iovas at vectors fill time

2018-06-25 Thread Tiwei Bie
On Mon, Jun 25, 2018 at 09:19:34AM +0200, Maxime Coquelin wrote: > On 06/25/2018 04:21 AM, Tiwei Bie wrote: > > On Sat, Jun 23, 2018 at 09:11:24AM +0200, Maxime Coquelin wrote: [...] > > > @@ -293,7 +314,8 @@ fill_vec_buf(struct virtio_net *dev, struct > > > vhost_virtqueue *vq, > > > static inl

Re: [dpdk-dev] [RFC v3 0/7] vhost2: new librte_vhost2 proposal

2018-06-25 Thread Tiwei Bie
On Thu, Jun 07, 2018 at 05:12:20PM +0200, Dariusz Stojaczyk wrote: > rte_vhost is not vhost-user spec compliant. Some Vhost drivers have > been already confirmed not to work with rte_vhost. virtio-user-scsi-pci > in QEMU 2.12 doesn't fully initialize its management queues at SeaBIOS > stage. This i

Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues

2018-06-25 Thread Kolistratova, Daria
Hi Michal, Yes, it won't fix the issue, but will return error instead of fail. I tried to execute with changes from the earlier email thread and it works. Should I resend patch with these changes? Best regards, Kolistratova Daria -Original Message- From: Michał Krawczyk [mailto:m...@

Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues

2018-06-25 Thread Michał Krawczyk
Daria, Yes, please. I will ack the patch once it will be resent. Thanks, Michal 2018-06-25 13:05 GMT+02:00 Kolistratova, Daria : > Hi Michal, > > Yes, it won't fix the issue, but will return error instead of fail. I tried > to execute with changes from the earlier email thread and it works. Sho

Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one

2018-06-25 Thread Shahaf Shuler
Monday, June 25, 2018 9:41 AM , Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the > standard one > > On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote: > > The generic tunnel TSO was depended in the regular one capabilities to > > be enabled. > > >

Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one

2018-06-25 Thread Nélio Laranjeiro
On Mon, Jun 25, 2018 at 11:23:22AM +, Shahaf Shuler wrote: > Monday, June 25, 2018 9:41 AM , Nélio Laranjeiro: > > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the > > standard one > > > > On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote: > > > The generic tunne

Re: [dpdk-dev] [RFC v3 0/7] vhost2: new librte_vhost2 proposal

2018-06-25 Thread Stojaczyk, DariuszX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Monday, June 25, 2018 1:02 PM > > > Hi Dariusz, > Hi Tiwei, > Thank you for putting efforts in making the DPDK > vhost more generic! > > From my understanding, your proposal is that: > > 1

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: fix use of unsupported RSS offloads

2018-06-25 Thread Remy Horton
On 22/06/2018 14:36, Remy Horton wrote: [..] Signed-off-by: Remy Horton --- examples/ipsec-secgw/ipsec-secgw.c | 5 + 1 file changed, 5 insertions(+) Self-Nack. Another pending patch already fixes this.

Re: [dpdk-dev] [DPDK] examples/ipsec-secgw: fix use of unsupported RSS offloads

2018-06-25 Thread Remy Horton
On 22/06/2018 16:46, Ferruh Yigit wrote: [..] Is following covering this patch: https://patches.dpdk.org/patch/41313/ Looks like it. Didn't spot it earlier.. ..Remy

Re: [dpdk-dev] [PATCH v4] net/bonding: add add/remove mac addrs

2018-06-25 Thread Doherty, Declan
On 20/06/2018 9:37 AM, Alex Kiselev wrote: add functions to add/remove MAC addresses Signed-off-by: Alex Kiselev --- ... Acked-by: Declan Doherty

[dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-25 Thread Olivier Matz
The Tx descriptor status api was not behaving as expected. This API is used to inspect the content of the descriptors in the Tx ring to determine the length of the Tx queue. Since the software advances the tail pointer and the hardware advances the head pointer, the Tx queue is located before txq-

Re: [dpdk-dev] [RFC] net/ixgbe: fix Tx descriptor status api

2018-06-25 Thread Olivier Matz
Removing wrong mails from the To and Cc. Sorry. On Mon, Jun 25, 2018 at 04:20:57PM +0200, Olivier Matz wrote: > The Tx descriptor status api was not behaving as expected. This API is > used to inspect the content of the descriptors in the Tx ring to > determine the length of the Tx queue. > > Sin

Re: [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname()

2018-06-25 Thread Olivier Matz
On Mon, Jun 18, 2018 at 11:00:55AM +0100, Burakov, Anatoly wrote: > On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote: > > The doc says this function returns negative errno > > on error, but it currently returns either -1 or > > positive errno. > > > > It was incorrectly assumed that pthread_setname_n

Re: [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create()

2018-06-25 Thread Olivier Matz
On Mon, Jun 18, 2018 at 11:01:40AM +0100, Burakov, Anatoly wrote: > On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote: > > This function returned positive error numbers instead > > of negative ones as desbribed in the doc. What's worse, > > multiple of its callers only check for (rc < 0) to detect > >

Re: [dpdk-dev] [PATCH 1/2] log: remove useless intermediate buffer

2018-06-25 Thread Olivier Matz
On Thu, May 31, 2018 at 10:03:27AM +0200, David Marchand wrote: > Rather than copy the log message, we can use a precision in the format > string given to syslog. > > Fixes: af75078fece3 ("first public release") > Signed-off-by: David Marchand Reviewed-by: Olivier Matz

Re: [dpdk-dev] [PATCH 2/2] cmdline: remove useless intermediate buffer

2018-06-25 Thread Olivier Matz
On Thu, May 31, 2018 at 10:03:28AM +0200, David Marchand wrote: > Rather than copy the string, we can use a precision in the format string > given to printf. > > Signed-off-by: David Marchand Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk

2018-06-25 Thread Olivier Matz
Hi Thomas, On Tue, Jan 23, 2018 at 05:30:57PM +0100, Olivier Matz wrote: > Hi Thomas, > > On Fri, Dec 15, 2017 at 12:00:01PM +0100, Thomas Monjalon wrote: > > 15/12/2017 11:45, Olivier MATZ: > > > On Fri, Dec 15, 2017 at 11:32:12AM +0100, Thomas Monjalon wrote: > > > > 15/12/2017 11:25, Olivier M

Re: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops functions

2018-06-25 Thread Olivier Matz
On Mon, Jun 11, 2018 at 07:49:37PM +0530, santosh wrote: > > On Monday 11 June 2018 07:37 PM, Jerin Jacob wrote: > > -Original Message- > >> Date: Tue, 5 Jun 2018 11:54:11 +0530 > >> From: Hemant Agrawal > >> To: dev@dpdk.org > >> CC: olivier.m...@6wind.com, santosh.shu...@caviumnetworks

Re: [dpdk-dev] [PATCH v4] net/bonding: add add/remove mac addrs

2018-06-25 Thread Chas Williams
On Wed, Jun 20, 2018 at 4:37 AM Alex Kiselev wrote: > add functions to add/remove MAC addresses > Signed-off-by: Alex Kiselev > Acked-by: Chas Williams > --- > drivers/net/bonding/rte_eth_bond_api.c | 12 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 131 >

Re: [dpdk-dev] [PATCH v2] rte_ring: clarify preemptible nature of ring algorithm

2018-06-25 Thread Olivier Matz
Hi Honnappa, On Thu, May 31, 2018 at 04:53:01AM +, Honnappa Nagarahalli wrote: > > -Original Message- > > From: Burakov, Anatoly > > Sent: Wednesday, May 30, 2018 2:48 AM > > To: Honnappa Nagarahalli ; > > olivier.m...@6wind.com > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] net: rename u16 to fix shadowed declaration warning

2018-06-25 Thread Olivier Matz
On Mon, Jun 04, 2018 at 02:40:00PM -0500, Gage Eads wrote: > This patch renames u16 to u16_buf. u16 as a variable name causes a shadowed > declaration warning if, for example, the application also typedefs u16 > (e.g. by including a header containing "typedef unsigned short u16") and > the applicat

[dpdk-dev] [RFC 1/9] usertools: add DPDK config lib python library

2018-06-25 Thread Anatoly Burakov
This is a placeholder for Python library abstracting away many of mundane details DPDK configuration scripts have to deal with. We need __init__.py file to make the subdirectory a package so that Python scripts in usertools/ can find their dependencies. Signed-off-by: Anatoly Burakov --- usertoo

[dpdk-dev] [RFC 2/9] usertools/lib: add platform info library

2018-06-25 Thread Anatoly Burakov
Add a library that will parse system information: * NUMA nodes * Cores and threads * Mapping from NUMA node and core to thread id's * Hyperthreading support status * RAM size * Default hugepage size as reported by kernel This can be used by scripts. Signed-off-by: Anatoly Burakov --- usertools

[dpdk-dev] [RFC 4/9] usertools/lib: support FreeBSD for platform info

2018-06-25 Thread Anatoly Burakov
This enables FreeBSD support for PlatformInfo part of the DPDKConfigLib script, thereby enabling FreeBSD support for the cpu_layout script. Signed-off-by: Anatoly Burakov --- usertools/DPDKConfigLib/PlatformInfo.py | 81 - 1 file changed, 78 insertions(+), 3 deletions(-)

[dpdk-dev] [RFC 9/9] usertools/lib: add GRUB utility library for hugepage config

2018-06-25 Thread Anatoly Burakov
This library is highly experimental and can kill kittens, but its main purpose is to automatically set up GRUB command-line to allocate a given number of hugepages at boot time. It works in a similar way HugeUtil library does, but instead of committing changes to fstab or runtime configuration, it

[dpdk-dev] [RFC 8/9] usertools: add hugepage info script

2018-06-25 Thread Anatoly Burakov
Add a simple hugepage info script for demonstration purposes. It lists the following information: - Currently configured persistent hugetlbfs mountpoints (fstab) - Currently mounted hugetlbfs mountpoints - Total number of hugepages for each size - Per-NUMA node number of hugepages for each size S

[dpdk-dev] [RFC 5/9] usertools/lib: add device information library

2018-06-25 Thread Anatoly Burakov
This library is mostly copy-paste of devbind script, but with few additional bells and whistles, such as the ability to enumerate and create/destroy VF devices. Signed-off-by: Anatoly Burakov --- usertools/DPDKConfigLib/DevInfo.py | 414 + usertools/DPDKConfigLib/DevU

[dpdk-dev] [RFC 7/9] usertools/lib: add hugepage information library

2018-06-25 Thread Anatoly Burakov
Add a library for getting hugepage information on Linux system. Supported functionality: - List active hugetlbfs mountpoints - Change hugetlbfs mountpoints - Supports both transient and persistent (fstab) mountpoints - Display/change number of allocated hugepages - Supports both total and per

[dpdk-dev] [RFC 3/9] usertools/cpu_layout: rewrite to use DPDKConfigLib

2018-06-25 Thread Anatoly Burakov
Rewrite cpu layout script to use data provided by DPDKConfigLib script. This demonstrates an example of how external tools can get the same information from DPDKConfigLib. Signed-off-by: Anatoly Burakov --- usertools/cpu_layout.py | 53 ++--- 1 file changed, 1

[dpdk-dev] [RFC 6/9] usertools/devbind: switch to using DPDKConfigLib

2018-06-25 Thread Anatoly Burakov
Make devbind use DPDKConfigLib library instead of having its own logic for binding/unbinding/enumerating devices and getting device information. All semantics and output are kept the same, only the internals changed. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 518 ++-

[dpdk-dev] [RFC 0/9] Modularize and enhance DPDK Python scripts

2018-06-25 Thread Anatoly Burakov
This patchset attempts to create a library out of Python scripts that come with DPDK, with a goal of enabling external tools to get the same information about the system DPDK has, and perhaps configure DPDK. Potential applications include: * Better setup.sh script (it's long overdue, and you know

Re: [dpdk-dev] [PATCH v13 1/6] mk: fix makefile based cross build errors

2018-06-25 Thread Ali Alnubani
Tested-by: Ali Alnubani > -Original Message- > From: dev On Behalf Of Gavin Hu > Sent: Monday, June 25, 2018 5:49 AM > To: dev@dpdk.org > Cc: n...@arm.com; gavin...@arm.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v13 1/6] mk: fix makefile based cross build errors > > From: gavin h

Re: [dpdk-dev] [PATCH v13 3/6] build: fix the meson build warning

2018-06-25 Thread Ali Alnubani
Tested-by: Ali Alnubani > -Original Message- > From: dev On Behalf Of Gavin Hu > Sent: Monday, June 25, 2018 5:49 AM > To: dev@dpdk.org > Cc: n...@arm.com; gavin...@arm.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v13 3/6] build: fix the meson build warning > > This is to fix the u

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-06-25 Thread Burakov, Anatoly
On 22-Jun-18 5:37 PM, Kumar, Ravi1 wrote: Hi, As the memory subsystem in DPDK 18.05 is reworked, it has introduced a problem for AMD EPYC 2P platforms. The issue is that DPDK 18.05 only works with up to 4 NUMAs. For AMD EPYC 2P platforms, DPDK now only works with P0 (NUMA 0-3) and does not wor

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-06-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Saturday, June 23, 2018 7:26 PM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; > dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish > Subject: RE: [PATCH v3

Re: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size functions

2018-06-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Friday, June 22, 2018 6:02 PM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Doherty, Declan > ; ravi1.ku...@amd.com; Jacob, Jerin > ; Zhang, Roy Fan > ; Trahe, Fiona ; > t...@semihalf.com; jianjay.z...@hua

Re: [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

2018-06-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, June 19, 2018 2:20 PM > To: Tomasz Duszynski ; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; akhil.go...@nxp.com; > ravi1.ku...@amd.com; jerin.ja...@caviumnetworks.com; Zhang, Roy Fan > ; jianjay.z...@huawei.com; dev@dpdk.org;

Re: [dpdk-dev] [PATCH 6/6] cryptodev: replace mbuf scatter gather flag

2018-06-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Monday, June 18, 2018 7:30 AM > To: De Lara Guarch, Pablo ; Doherty, Declan > ; akhil.go...@nxp.com; ravi1.ku...@amd.com; > jerin.ja...@caviumnetworks.com; Zhang, Roy Fan ; > Trahe, Fiona ; t.

[dpdk-dev] [Bug 66] Secondary process must have exact same whitelist "-w" list

2018-06-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=66 Bug ID: 66 Summary: Secondary process must have exact same whitelist "-w" list Product: DPDK Version: 18.05 Hardware: x86 OS: Linux Status: CONFIRMED

[dpdk-dev] [PATCH v2 00/15] Cryptodev API changes for 18.08

2018-06-25 Thread Pablo de Lara
API changes in the cryptodev library, announced in the previous release, 18.05. Changes in v2: - Instead of removing max_nb_sessions in info structure, a new value `0` is allowed, to indicate that the PMD does not have any limitation on the number of sessions to be managed - Modified crypto

[dpdk-dev] [PATCH v2 01/15] cryptodev: replace bus specific struct with generic dev

2018-06-25 Thread Pablo de Lara
Structure rte_cryptodev_info has currently PCI device information ("struct rte_pci_device") in it. This information is not generic to all devices, so this gets replaced with the generic "rte_device" structure, compatible with all crypto devices. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal

[dpdk-dev] [PATCH v2 03/15] app/crypto-perf: limit number of sessions

2018-06-25 Thread Pablo de Lara
Instead of creating a fixed number of sessions, calculate the necessary number based on number of devices and queue pairs used. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/main.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/app/te

[dpdk-dev] [PATCH v2 04/15] test/crypto: limit number of sessions

2018-06-25 Thread Pablo de Lara
Instead of using the maximum number of sessions allowed by the PMDs (which will change to unlimited most of the PMDs), limit the number to a small sufficient amount. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 27 +-- 1 file changed, 21 insertions(+), 6

[dpdk-dev] [PATCH v2 02/15] cryptodev: remove max number of sessions per queue

2018-06-25 Thread Pablo de Lara
The cryptodev info structure currently contains the maximum number of sessions that can be used in a queue pair. This is only set in DPAA_SEC PMD, and since it is calculated based on the maximum number of sessions (which is not used anymore), this field can be removed. Signed-off-by: Pablo de Lara

[dpdk-dev] [PATCH v2 06/15] examples/ipsec-secgw: check for max supported sessions

2018-06-25 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- examples/ipsec-secgw/ipsec-secgw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index a5da8b280..2582dcb6e 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-se

[dpdk-dev] [PATCH v2 05/15] examples/l2fwd-crypto: limit number of sessions

2018-06-25 Thread Pablo de Lara
Calculate the number of sessions required for the application, knowing that there is only one session required per device. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/examples/l2fwd-crypto/

[dpdk-dev] [PATCH v2 07/15] crypto/mvsam: parse max number of sessions

2018-06-25 Thread Pablo de Lara
The maximum number of sessions device argument will be removed, as most PMDs do not have a limitation on this number. Therefore, the MVSAM PMD needs to parse this value internally. Signed-off-by: Pablo de Lara --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 132 1

[dpdk-dev] [PATCH v2 09/15] cryptodev: remove max number of sessions parameter

2018-06-25 Thread Pablo de Lara
Most crypto PMDs do not have a limitation of the number of the sessions that can be handled internally. The value that was set before was not actually used at all, since the sessions are created at the application level. Therefore, this value is not parsed from the initial crypto parameters anymore

[dpdk-dev] [PATCH v2 08/15] cryptodev: define value for unlimited sessions

2018-06-25 Thread Pablo de Lara
Currently, the info structure contains the maximum number of sessions that a device can manage. This field was useful when the session mempool was created inside each device, but now it is created at the application level. Most PMDs do not have a limitation on the sessions managed, but a few do, t

[dpdk-dev] [PATCH v2 10/15] doc: remove unneeded deprecation notice

2018-06-25 Thread Pablo de Lara
In release 18.05, a deprecation notice to remove the `sym` structure in the cryptodev info structure was sent. However, only one of the fields inside the structure will be removed, so the notice is not actually correct. In any case, it needs to be removed. Signed-off-by: Pablo de Lara --- doc/gu

[dpdk-dev] [PATCH v2 12/15] cryptodev: remove old get session size functions

2018-06-25 Thread Pablo de Lara
Removed rte_cryptodev_get_header_session_size and rte_cryptodev_get_private_session_size functions, as they have been substituted with functions specific for symmetric operations, with _sym_ word after "rte_cryptodev_". Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH v2 11/15] cryptodev: remove queue start/stop functions

2018-06-25 Thread Pablo de Lara
Removed cryptodev queue start/stop functions, as they were marked deprecated in 18.05, since they were not implemented by any driver. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 4 --- doc/guides/rel_notes/release_18_08.rst |

[dpdk-dev] [PATCH v2 13/15] cryptodev: replace mbuf scatter gather flag

2018-06-25 Thread Pablo de Lara
The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not, plus if in-place and/or out-of-place is supported. Therefore, five new flags will replace this flag: - RTE_CRYPTODEV_FF_IN_PLACE_SGL - RTE_CRYPTODEV_

[dpdk-dev] [PATCH v2 14/15] cryptodev: remove attach/detach session API

2018-06-25 Thread Pablo de Lara
As announced in the previous release, The API to attach/dettach a session to a queue pair is removed, as it was only used in DPAA, and it is not actually needed. Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 8 doc/guides/rel_notes/release_18_08.rst

[dpdk-dev] [PATCH v2 15/15] cryptodev: rename PMD symmetric session API

2018-06-25 Thread Pablo de Lara
The PMD specific API to configure, clear and obtain session private size is renamed, including the word _sym_ to clarify that it is API for symmetric sessions, so there will not be any conflicts for asymmetric and other type of sessions in the future. Signed-off-by: Pablo de Lara --- drivers/cry

  1   2   >