On Fri, Jul 08, 2016 at 01:11:30PM +0200, Jan Medala wrote:
> Avoid submitting doorbell when:
> * no packets have been submitted to TX
> * no free resources have been submitted while RX
>
> Sending doorbell without actual work to be performed by device
> violates ENA specification and can lead to
On Thu, Jul 07, 2016 at 06:10:21PM -0700, Nelson Escobar wrote:
> enic_disable() removed the MAC address when a port was shut down but
> enic_enable() didn't add the MAC address back when the port was
> started again. Move where we set the MAC address for the adapter from
> enic_setup_finish() to
On Fri, Jul 08, 2016 at 11:36:58AM +0100, Remy Horton wrote:
>
> On 07/07/2016 23:50, Rasesh Mody wrote:
> >This patch adds support for extended statistics for BNX2X PMD.
> >
> >Signed-off-by: Rasesh Mody
>
> Acked-by: Remy Horton
Applied to dpdk-next-net/rel_16_07
/Bruce
On Fri, Jul 08, 2016 at 11:36:54AM +0100, Remy Horton wrote:
>
> On 07/07/2016 23:50, Rasesh Mody wrote:
> >This patch adds support for extended statistics for QEDE PMD.
> >
> >Signed-off-by: Rasesh Mody
>
> Acked-by: Remy Horton
Applied to dpdk-next-net/rel_16_07
/Bruce
On Fri, Jul 08, 2016 at 03:29:02PM +0200, Adrien Mazarguil wrote:
> On Fri, Jul 08, 2016 at 02:43:26PM +0200, Nelio Laranjeiro wrote:
> > Fixed issue could occur when a Mbuf starvation happens in a middle of
> > reception of a segmented packet, in such situation, the PMD has to release
> > all
On Fri, Jul 08, 2016 at 09:09:32AM +0200, Adrien Mazarguil wrote:
> On Thu, Jul 07, 2016 at 06:34:45PM +0200, Maxime Leroy wrote:
> > In mlx5 rx function, the packet_type and ol_flags mbuf fields are not
> > properly initialized when no rx offload feature is enabled (checksum, l2
> > tun checksum,
On Thu, Jul 07, 2016 at 02:19:02PM +0200, Olivier Matz wrote:
> Update desc_to_olflags_v() to set PKT_RX_IP_CKSUM_BAD and
> PKT_RX_L4_CKSUM_BAD in the ol_fags of the mbuf.
>
> The Rx vector function can now be used with hw_ip_checksum
> enabled.
>
> Tested with:
>
> cd dpdk.org/
> make
There were a couple of issues which prevented pmdinfo.py from running on
FreeBSD, both of which are fixed by this patch.
* The path to python is not /usr/bin/python as on Linux, so use
/usr/bin/env to find it on both OS's.
* The path to the pci ids DB is in a different location on FreeBSD,
so
error on compilation caused by missing include for libgen.h.
HOSTCC pmdinfogen.o
/usr/home/bruce/dpdk/buildtools/pmdinfogen/pmdinfogen.c:402:4: error: implicit
declaration of function 'basename' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
This patchset fixes pmdinfogen and pmdinfo.py so that they can work on
FreeBSD. It's been tested with static binaries compiled using clang and gcc
on FreeBSD, as well as gcc-generated dynamic libraries. For some reason
clang wasn't able to build dynamic libraries for DPDK on FreeBSD so that is
Signed-off-by: Jan Viktorin
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 6f1a28a..ab08a16 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++
Signed-off-by: Jan Viktorin
---
app/test/virtual_pmd.c | 4 ++--
drivers/net/fm10k/fm10k_ethdev.c| 6 +++---
drivers/net/virtio/virtio_pci.c | 2 +-
lib/librte_cryptodev/rte_cryptodev.c| 2 +-
lib/librte_eal/common/eal_common_pci.c | 14 +++---
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/eal_common_dev.c | 13 +
lib/librte_eal/common/include/rte_dev.h | 31 +++
2 files changed, 44 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_dev.c
To register both vdev and pci drivers into the list of all rte_driver,
we have to call rte_eal_driver_register explicitly.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/eal_common_pci.c | 2 ++
lib/librte_eal/common/eal_common_vdev.c | 2 ++
2 files changed, 4 insertions(+)
diff --git
Signed-off-by: Jan Viktorin
---
app/test/test_pci.c | 10 +++---
app/test/virtual_pmd.c | 2 +-
drivers/crypto/qat/rte_qat_cryptodev.c | 4 +++-
drivers/net/bnx2x/bnx2x_ethdev.c| 8 ++--
drivers/net/cxgbe/cxgbe_ethdev.c| 4 +++-
There is no need to have a custom memory resource representation for
each infrastructure (PCI, ...) as it would always have the same members.
Signed-off-by: Jan Viktorin
---
drivers/net/szedata2/rte_eth_szedata2.c | 4 ++--
lib/librte_eal/common/include/rte_dev.h | 9 +
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/include/rte_common.h | 16
1 file changed, 16 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_common.h
b/lib/librte_eal/common/include/rte_common.h
index 332f2a4..a9b6792 100644
---
There is no need to determine a PMD type any more. The PMD_VDEV devices
has its own list of drivers. And all PMD_PDEV are PCI devices using
a different way of registering themselfs.
Signed-off-by: Jan Viktorin
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 1 -
All PMD_VDEV drivers can now use rte_vdev_driver instead of the
rte_driver (which is embedded in the rte_vdev_driver).
Signed-off-by: Jan Viktorin
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 16 +---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 16 +---
There is no way how to call an init on a PMD_PDEV driver as those
drivers are all PCI drivers and they do not register any rte_driver
with EAL. We can drop the loop over PMD_PDEV drivers entirely.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/eal_common_dev.c | 8
1 file
All devices in the rte_eal_vdev_init/uninit are always virtual devices.
Signed-off-by: Jan Viktorin
---
lib/librte_eal/common/eal_common_vdev.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_vdev.c
b/lib/librte_eal/common/eal_common_vdev.c
index
Hello,
based on the discussions with Shreyansh, I propose a patchset with
the important EAL changes. It is incomplete and I suppose to extend
and change certain things in the foreseeable future.
Important notes:
* pmd_type is removed
* introduced rte_vdev_driver inheriting rte_driver
*
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, July 06, 2016 8:25 AM
> To: John Daley (johndale) ; Nelson Escobar
> (neescoba)
> Cc: dev at dpdk.org
> Subject: [PATCH] net/enic: remove useless assert macro
>
> The macro ENIC_ASSERT
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, June 30, 2016 7:25 PM
> To: Mcnamara, John
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] doc: autogenerate nic overview table
> from ini files
>
> 2016-06-30 19:03, John
2016-07-06 15:05, Pablo de Lara:
> New cryptodev type for the new KASUMI PMD was added
> in the cryptodev type enum, but not at the end of it,
> causing an ABI breakage.
>
> Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
>
> Signed-off-by: Pablo de Lara
> Reported-by:
When running check-git-log.sh on a clean tree it was complaining
of a wrong empty headline because '^[^:]*$' was matching.
It is fixed by matching at least one character with +.
Signed-off-by: Thomas Monjalon
---
scripts/check-git-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Cunming, what is the status of this patchset, please?
2016-03-23 11:24, Liang, Cunming:
> Hi Mattew,
>
> Thank you for your time.
>
> On 3/22/2016 3:39 PM, Matthew Hall wrote:
> > On Mon, Mar 21, 2016 at 03:58:44PM +0800, Liang, Cunming wrote:
> >> the default termination handler
> > I am not
Ping, this patch is stalled.
2016-05-11 18:24, Ferruh Yigit:
> On 5/11/2016 8:35 AM, Alejandro Lucero wrote:
> > On Tue, May 10, 2016 at 4:59 PM, Stephen Hemminger <
> > stephen at networkplumber.org> wrote:
> >
> >> On Tue, 10 May 2016 19:21:41 +0800
> >> Zhe Tao wrote:
> >>
> >>> Problem:
>
> Recently reported, the introduction of pmd information exports led to a
> breakage of cryptodev unit tests because the test infrastructure relies on the
> cryptodev names being available in macros. This patch fixes the pmd naming to
> use the macro names. Note that the macro names were already
Hi Adrien,
On 7/6/2016 2:16 AM, Adrien Mazarguil wrote:
> Hi All,
>
> First, forgive me for this large message, I know our mailboxes already
> suffer quite a bit from the amount of traffic on this ML.
>
> This is not exactly yet another thread about how flow director should be
> extended, rather
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> Sent: Friday, July 8, 2016 2:42 PM
> To: Thomas Monjalon
> Cc: De Lara Guarch, Pablo ; dev at
> dpdk.org;
> Richardson, Bruce ; Stephen Hemminger
> ; Panu Matilainen
> Subject: Re: [dpdk-dev]
2016-07-04 14:24, Remy Horton:
> On 04/07/2016 12:36, Zyta Szpak wrote:
> > From: Zyta Szpak
> >
> > This change deals with hard-coded register width.
> > The app was allocating too little space for 64-bit registers
> > which resulted in memory corruption. This commit resolves
> > this by getting
2016-07-08 16:42, Thomas Monjalon:
> These are some patches that I think needed for RC2.
Applied
> There are other patches needed as discussed on the mailing-list which
> are not part of this series:
> - overwritten driver name (reported by Pablo)
> - pmdinfo.py on FreeBSD (reported by
Recently reported, the introduction of pmd information exports led to a
breakage of cryptodev unit tests because the test infrastructure relies on the
cryptodev names being available in macros. This patch fixes the pmd naming to
use the macro names. Note that the macro names were already
On Fri, Jul 08, 2016 at 03:45:50PM +0100, Ferruh Yigit wrote:
> On 7/8/2016 3:35 PM, Adrien Mazarguil wrote:
> > On Fri, Jul 08, 2016 at 02:15:37PM +, Wiles, Keith wrote:
> >>
> >>> On Jul 8, 2016, at 4:56 AM, Yigit, Ferruh
> >>> wrote:
> >>>
> >>> On 7/8/2016 9:05 AM, Adrien Mazarguil
On Fri, 2016-07-08 at 00:14 +, Lu, Wenzhuo wrote:
> > > > > > > > > > Hello Wenzhuo,
> > > > > > > > > >
> > > > > > > > > > I'm testing this patchset, but I am sporadically running
> > > > > > > > > > into an issue where the VFs reset fails after the PF flaps.
> > > > > > > > > >
> > > > > >
On Wed, Jul 06, 2016 at 04:21:59PM -0700, Nelson Escobar wrote:
> The enic PMD was using the same variables in the enic structure to
> track two different things. Initially rq_count, wq_count, cq_count,
> and intr_count were set to the values obtained from the VIC adapters
> as the maximum
On Wed, Jul 06, 2016 at 11:53:13AM +, Mcnamara, John wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ian Stokes
> > Sent: Wednesday, July 6, 2016 11:30 AM
> > To: dev at dpdk.org
> > Cc: Stokes, Ian
> > Subject: [dpdk-dev] [PATCH v2] doc:
When fetching xstats values the driver specific parameters are
placed after the generic ones, but when fetching xstats names
the driver specific parameter names came first. This patch fixes
the resulting id mismatch between names and values.
Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics
The author of this feature is Neil Horman.
Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
---
MAINTAINERS | 4
1 file changed, 4 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a59191e..f996c2e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -68,6 +68,10 @@ F:
Sphynx reports this error:
doc/guides/prog_guide/dev_kit_build_system.rst:337: WARNING:
Pygments lexer name u'C' is not known
Fixes: 737ddf3fb ("doc: add prog guide section documenting pmdinfo script")
Reported-by: Bernard Iremonger
Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
---
Remove include of rte_pci.h in the generic header rte_dev.h.
Fixes: cb6696d22023 ("drivers: update registration macro usage")
Suggested-by: David Marchand
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/common/include/rte_dev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The name of the tool is pmdinfogen.
Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Signed-off-by: Thomas Monjalon
---
buildtools/pmdinfogen/pmdinfogen.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/buildtools/pmdinfogen/pmdinfogen.c
When compiled with a standard clang, pmdinfogen can raise a warning:
buildtools/pmdinfogen/pmdinfogen.c:365:1: warning:
control reaches end of non-void function
Actually there can be more warnings with stricter compilers.
In order to catch them early and fix most of them, the DPDK
When building with "make V=1" it is expected to see the output of each
compiler command in order to debug them.
Unfortunately the pmdinfogen related commands were always quiet.
It is fixed by defining the commands in some Makefile variables.
They are printed if the verbose mode is enabled.
The
The tool pmdinfogen was called from RTE_OUTPUT/app/ which does not exist
if building a driver outside of the SDK build.
When building DPDK, RTE_SDK_BIN is RTE_OUTPUT. When building an external
driver, RTE_SDK_BIN must point to the installed DPDK directory containing
includes, libs, etc.
That's
The recipe rte.hostapp.mk does not build in hostapp/ anymore.
Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
---
doc/guides/freebsd_gsg/build_dpdk.rst | 2 +-
doc/guides/linux_gsg/build_dpdk.rst | 2 +-
When compiling the drivers, some code is generated with pmdinfogen.
A fresh parallel build can fail if a driver is compiled before pmdinfogen:
build/buildtools/dpdk-pmdinfogen: Permission denied
There was a dependency declared in drivers/Makefile but it cannot work
because this file is
Compilation fails because of some typos.
Fixes: cb6696d22023 ("drivers: update registration macro usage")
Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
Tested-by: Adrien Mazarguil
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +-
drivers/net/mlx4/mlx4.c| 2 +-
These are some patches that I think needed for RC2.
There are other patches needed as discussed on the mailing-list which
are not part of this series:
- overwritten driver name (reported by Pablo)
- pmdinfo.py on FreeBSD (reported by Bruce)
Note: RC2 is planned to be out at the end of this
On Fri, Jul 08, 2016 at 02:15:37PM +, Wiles, Keith wrote:
>
> > On Jul 8, 2016, at 4:56 AM, Yigit, Ferruh wrote:
> >
> > On 7/8/2016 9:05 AM, Adrien Mazarguil wrote:
> >> On Thu, Jul 07, 2016 at 06:33:17PM +, Wiles, Keith wrote:
> >>>
> On Jul 7, 2016, at 10:49 AM, Adrien
On Tue, Jul 05, 2016 at 02:10:02PM +0800, Beilei Xing wrote:
> Fix some open coverity defects.
>
> V2 changes:
> Rework commit log.
> Refactor patchset.
>
> Beilei Xing (3):
> i40e: fix log error
> i40e: fix dereference before null check
> i40e: fix out-of-bounds access
>
>
Some drivers define the supported PCI IDs, others define them
in the common file rte_pci_dev_ids.h.
This situation brings some confusion in the layering design.
In order to clean up things, I've suggested a plan to remove
rte_pci_dev_ids.h:
On Wed, Jul 06, 2016 at 03:00:17AM +0100, Xing, Beilei wrote:
>
>
> > -Original Message-
> > From: Richardson, Bruce
> > Sent: Tuesday, July 5, 2016 9:26 PM
> > To: Xing, Beilei
> > Cc: Wu, Jingjing ; Jastrzebski, MichalX K
> > ; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2
Hi
Can someone throw some light on the following DPDK QoS config variables?
A) In struct *rte_sched_subport_params* AND *rte_sched_pipe_params*
1) tb_rate - Is the provisioned rate at which the TB can be filled while
enqueuing OR the TB rate slice allotted to this subport ?
2) tb_size
3)
2016-07-08 09:56, Neil Horman:
> On Fri, Jul 08, 2016 at 10:49:25AM +0200, David Marchand wrote:
> > Hello Thomas, Neil,
> >
> > (will be back in a couple of days, thanks Thomas for pointing this thread)
> >
> >
> > On Thu, Jul 7, 2016 at 6:25 PM, Thomas Monjalon
> > wrote:
> > > 2016-07-07
On 7/8/2016 3:35 PM, Adrien Mazarguil wrote:
> On Fri, Jul 08, 2016 at 02:15:37PM +, Wiles, Keith wrote:
>>
>>> On Jul 8, 2016, at 4:56 AM, Yigit, Ferruh wrote:
>>>
>>> On 7/8/2016 9:05 AM, Adrien Mazarguil wrote:
On Thu, Jul 07, 2016 at 06:33:17PM +, Wiles, Keith wrote:
>
>>
2016-04-20 14:43, David Marchand:
> test application and kni still want to know e1000 pci devices.
> So let's create headers in the driver that will be used by them.
There is also an usage of ixgbe ID for the broken bypass API.
Sharing those PCI ids outside of the drivers was really a wrong
On Fri, Jul 08, 2016 at 02:43:26PM +0200, Nelio Laranjeiro wrote:
> Fixed issue could occur when a Mbuf starvation happens in a middle of
> reception of a segmented packet, in such situation, the PMD has to release
> all segments of such packet. The end condition was wrong causing it to
> free a
Hi Cunming,
I agree with Bruce, I'll start snipping non relevant parts considering the
size of this message. Please see below.
On Fri, Jul 08, 2016 at 07:11:28PM +0800, Liang, Cunming wrote:
[...]
> >Meta item types
> >~~~
> >
> >These do not match packet data but affect how the
One instance of a filter add failure was not incrementing the
the fail counter.
Fixes: 4c2c7bf41f5a ("net/enic: fix negative array index write")
Signed-off-by: John Daley
---
drivers/net/enic/enic_clsf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/enic/enic_clsf.c
In the Tx cleanup function, the reference count in mbufs to be
returned to the pool should to be decremented before they are
returned. Decrementing is not done by rte_mempool_put_bulk()
so it must be done separately using __rte_pktmbuf_prefree_seg().
If decrementing does not result in a 0
On 7/8/2016 2:23 PM, Bruce Richardson wrote:
> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
>> On 6/30/2016 4:04 PM, Jan Medala wrote:
>>> Signed-off-by: Alexander Matushevsky
>>> Signed-off-by: Jakub Palider
>>> Signed-off-by: Jan Medala
>>
>> The compilation error to fix is
Hi Sugesh,
On Thu, Jul 07, 2016 at 11:15:07PM +, Chandran, Sugesh wrote:
> Hi Adrien,
>
> Thank you for proposing this. It would be really useful for application such
> as OVS-DPDK.
> Please find my comments and questions inline below prefixed with [Sugesh].
> Most of them are from the
On 06.07.2016 15:24, Yuanhan Liu wrote:
> On Wed, Jul 06, 2016 at 02:19:12PM +0300, Ilya Maximets wrote:
>> On 01.07.2016 10:35, Yuanhan Liu wrote:
>>> Hi,
>>>
>>> Sorry for the long delay.
>>>
>>> On Fri, May 20, 2016 at 03:50:04PM +0300, Ilya Maximets wrote:
In current implementation guest
Fixed issue could occur when a Mbuf starvation happens in a middle of
reception of a segmented packet, in such situation, the PMD has to release
all segments of such packet. The end condition was wrong causing it to
free a Mbuf still handled by the NIC.
Fixes: 9964b965ad69 ("net/mlx5: re-add Rx
2016-07-08 08:17, Neil Horman:
> I suppose thats fine, sure, though I'm really not comfortable with an open
> source project requiring what appears to be non-open source components
> (though I
> can't really tell what the snow3g or kasumi license is).
Yes you're right.
IMHO, it is acceptable
On Mon, Jul 04, 2016 at 01:52:04PM -0500, Ajit Khaparde wrote:
> Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST
> flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous
> and multicast promiscuous settings from working correctly.
> This patch fixes it.
>
On Thu, Jun 30, 2016 at 05:04:53PM +0200, Jan Medala wrote:
> v2: As requested, big patch splitted into logical pieces for easier review.
> Improved style and fixed icc compiler issues.
>
> v3: Added commit messages to clarify patch purpose and minor changes
>
> Jan Medala (6):
> ena: update
On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
> On 6/30/2016 4:04 PM, Jan Medala wrote:
> > Signed-off-by: Alexander Matushevsky
> > Signed-off-by: Jakub Palider
> > Signed-off-by: Jan Medala
>
> The compilation error to fix is [1], it may be good to add what to fix
> into
> On Jul 8, 2016, at 4:56 AM, Yigit, Ferruh wrote:
>
> On 7/8/2016 9:05 AM, Adrien Mazarguil wrote:
>> On Thu, Jul 07, 2016 at 06:33:17PM +, Wiles, Keith wrote:
>>>
On Jul 7, 2016, at 10:49 AM, Adrien Mazarguil >>> 6wind.com> wrote:
DPDK uses GNU C language extensions in
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, July 08, 2016 1:18 PM
> To: De Lara Guarch, Pablo
> Cc: dev at dpdk.org; Richardson, Bruce; Thomas Monjalon; Stephen
> Hemminger; Panu Matilainen
> Subject: Re: [PATCH] crypto: normalize cryptodev
On Fri, Jul 08, 2016 at 07:11:28PM +0800, Liang, Cunming wrote:
Please Cunming, when replying in the middle of a long email - of which this
is a perfect example - delete the large chunks of content you are not replying
to. I had to page down multiple times to find the new comments you wrote, and
Avoid submitting doorbell when:
* no packets have been submitted to TX
* no free resources have been submitted while RX
Sending doorbell without actual work to be performed by device
violates ENA specification and can lead to unpredictable behavior.
Fixes: 1173fca25af9 ("ena: add polling-mode
v2: resend patch, as previous one probably had some format corruption.
Jan Medala (1):
ena: fix doorbell submission when not needed
drivers/net/ena/ena_ethdev.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
--
2.9.0
On 07/07/2016 23:59, Rasesh Mody wrote:
[..]
> We have submitted the QEDE and BNX2X PMD xstats patches with recent
> API changes.
Seen & Acked.
> During the xstats change verification, it was observed that the order
> in which xstats names are fetched don't seem to match the order in
> which
The author of this feature is Neil Horman.
Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
---
MAINTAINERS | 4
1 file changed, 4 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a59191e..f996c2e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -68,6 +68,10 @@ F:
Sphynx reports this error:
doc/guides/prog_guide/dev_kit_build_system.rst:337: WARNING:
Pygments lexer name u'C' is not known
Fixes: 737ddf3fb ("doc: add prog guide section documenting pmdinfo script")
Reported-by: Bernard Iremonger
Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
---
Remove include of rte_pci.h in the generic header rte_dev.h
and move the macro DRIVER_REGISTER_PCI_TABLE in rte_pci.h.
Fixes: cb6696d22023 ("drivers: update registration macro usage")
Suggested-by: David Marchand
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/common/include/rte_dev.h | 6
The name of the tool is pmdinfogen.
Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Signed-off-by: Thomas Monjalon
---
buildtools/pmdinfogen/pmdinfogen.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/buildtools/pmdinfogen/pmdinfogen.c
When compiled with a standard clang, pmdinfogen can raise a warning:
buildtools/pmdinfogen/pmdinfogen.c:365:1: warning:
control reaches end of non-void function
Actually there can be more warnings with stricter compilers.
In order to catch them early and fix most of them, the DPDK
When building with "make V=1" it is expected to see the output of each
compiler command in order to debug them.
Unfortunately the pmdinfogen related commands were always quiet.
It is fixed by defining the commands in some Makefile variables.
They are printed if the verbose mode is enabled.
The
The tool pmdinfogen was called from RTE_OUTPUT/app/ which does not exist
if building a driver outside of the SDK build.
When building DPDK, RTE_SDK_BIN is RTE_OUTPUT. When building an external
driver, RTE_SDK_BIN must point to the installed DPDK directory containing
includes, libs, etc.
That's
When compiling the drivers, some code is generated with pmdinfogen.
A fresh parallel build can fail if a driver is compiled before pmdinfogen:
build/buildtools/dpdk-pmdinfogen: Permission denied
There was a dependency declared in drivers/Makefile but it cannot work
because this file is
These are some patches that I think needed for RC2.
There are other patches needed as discussed on the mailing-list which
are not part of this series:
- overwritten driver name (reported by Pablo)
- pmdinfo.py on FreeBSD (reported by Bruce)
Note: RC2 is planned to be out at the end of this
2016-07-07 11:37, Neil Horman:
> -PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drvi, aesni_mb);
> -DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs= "
> +PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drv, CRYPTODEV_NAME_AESNI_MB_PMD);
>
On 07/07/2016 23:50, Rasesh Mody wrote:
> This patch adds support for extended statistics for BNX2X PMD.
>
> Signed-off-by: Rasesh Mody
Acked-by: Remy Horton
On 07/07/2016 23:50, Rasesh Mody wrote:
> This patch adds support for extended statistics for QEDE PMD.
>
> Signed-off-by: Rasesh Mody
Acked-by: Remy Horton
On Fri, Jul 08, 2016 at 04:42:22PM +0200, Thomas Monjalon wrote:
> Remove include of rte_pci.h in the generic header rte_dev.h.
>
> Fixes: cb6696d22023 ("drivers: update registration macro usage")
>
> Suggested-by: David Marchand
> Signed-off-by: Thomas Monjalon
Acked-by: Neil Horman
> ---
On Fri, Jul 08, 2016 at 04:42:20PM +0200, Thomas Monjalon wrote:
> When compiled with a standard clang, pmdinfogen can raise a warning:
> buildtools/pmdinfogen/pmdinfogen.c:365:1: warning:
> control reaches end of non-void function
>
> Actually there can be more warnings with stricter
2016-07-08 08:42, Wu, Jingjing:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Thank you for providing more doc.
> > I am just not convinced it is the right place
> > and it must be discussed.
> > Some questions below to help deciding where it must be.
> >
> > 2016-06-23 11:02,
On 7/8/2016 9:05 AM, Adrien Mazarguil wrote:
> On Thu, Jul 07, 2016 at 06:33:17PM +, Wiles, Keith wrote:
>>
>>> On Jul 7, 2016, at 10:49 AM, Adrien Mazarguil >> 6wind.com> wrote:
>>>
>>> DPDK uses GNU C language extensions in most of its code base. This is fine
>>> for internal source files
On Fri, Jul 08, 2016 at 04:42:18PM +0200, Thomas Monjalon wrote:
> The tool pmdinfogen was called from RTE_OUTPUT/app/ which does not exist
> if building a driver outside of the SDK build.
> When building DPDK, RTE_SDK_BIN is RTE_OUTPUT. When building an external
> driver, RTE_SDK_BIN must point
On Thu, Jul 07, 2016 at 09:25:27PM +, Mcnamara, John wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> > Sent: Thursday, July 7, 2016 6:55 PM
> > To: Thomas Monjalon
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH
Hello Thomas, Neil,
(will be back in a couple of days, thanks Thomas for pointing this thread)
On Thu, Jul 7, 2016 at 6:25 PM, Thomas Monjalon
wrote:
> 2016-07-07 12:11, Neil Horman:
>> On Thu, Jul 07, 2016 at 05:36:28PM +0200, Thomas Monjalon wrote:
>> > Remove include of rte_pci.h in the
On Fri, Jul 08, 2016 at 02:00:20PM +, De Lara Guarch, Pablo wrote:
>
>
> > -Original Message-
> > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > Sent: Friday, July 08, 2016 1:18 PM
> > To: De Lara Guarch, Pablo
> > Cc: dev at dpdk.org; Richardson, Bruce; Thomas Monjalon;
On Fri, Jul 08, 2016 at 04:03:40PM +0200, Thomas Monjalon wrote:
> 2016-07-08 09:56, Neil Horman:
> > On Fri, Jul 08, 2016 at 10:49:25AM +0200, David Marchand wrote:
> > > Hello Thomas, Neil,
> > >
> > > (will be back in a couple of days, thanks Thomas for pointing this thread)
> > >
> > >
> >
Hi Olivier,
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Thursday, July 07, 2016 11:49 PM
> To: Liang, Cunming ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 05/18] mbuf: add function to get packet type
> from data
>
> Hi Cunming,
>
> Thank
On Thu, Jul 07, 2016 at 06:33:17PM +, Wiles, Keith wrote:
>
> > On Jul 7, 2016, at 10:49 AM, Adrien Mazarguil > 6wind.com> wrote:
> >
> > DPDK uses GNU C language extensions in most of its code base. This is fine
> > for internal source files whose compilation flags are controlled by DPDK,
On Fri, Jul 08, 2016 at 10:49:25AM +0200, David Marchand wrote:
> Hello Thomas, Neil,
>
> (will be back in a couple of days, thanks Thomas for pointing this thread)
>
>
> On Thu, Jul 7, 2016 at 6:25 PM, Thomas Monjalon
> wrote:
> > 2016-07-07 12:11, Neil Horman:
> >> On Thu, Jul 07, 2016 at
1 - 100 of 110 matches
Mail list logo
