Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429753
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -308,33 +312,57 @@ public BitToUserHandshake
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429640
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -308,33 +312,57 @@ public BitToUserHandshake
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429494
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -308,33 +312,57 @@ public BitToUserHandshake
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429451
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationMechanismFactory.java
---
@@ -0,0 +1,182 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429414
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java
---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422631
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -297,4 +297,44 @@ SqlNode SqlDescribeSchema() :
{
return new
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422515
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -141,25 +141,41 @@ public void validate(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422352
--- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/Jar.java
---
@@ -0,0 +1,197 @@
+/**
--- End diff --
Not reviewed: this
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422394
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/beans/Registry.java ---
@@ -0,0 +1,175 @@
+/**
--- End diff --
Not reviewed:
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422323
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/beans/Func.java ---
@@ -0,0 +1,197 @@
+/**
--- End diff --
Not reviewed:
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422265
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -20697,6 +20697,2346 @@ public Builder clearDoubleValue() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422238
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/SchemaUserBitShared.java ---
@@ -2678,4 +2678,357 @@ public static int
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77422179
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -189,6 +189,15 @@ drill.exec: {
debug: {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421971
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -298,3 +298,17 @@ enum CoreOperatorType {
NESTED_LOOP_JOIN = 35;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421764
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -298,3 +298,17 @@ enum CoreOperatorType {
NESTED_LOOP_JOIN = 35;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421640
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -298,3 +298,17 @@ enum CoreOperatorType {
NESTED_LOOP_JOIN = 35;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421538
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -298,3 +298,17 @@ enum CoreOperatorType {
NESTED_LOOP_JOIN = 35;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421468
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -298,3 +298,17 @@ enum CoreOperatorType {
NESTED_LOOP_JOIN = 35;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421120
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -189,6 +189,15 @@ drill.exec: {
debug: {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77421023
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -189,6 +189,15 @@ drill.exec: {
debug: {
Vitalii Diravka created DRILL-4874:
--
Summary: "No UserGroupInformation while generating ORC splits" -
hive known issue in 1.2.0-mapr-1607 release.
Key: DRILL-4874
URL:
Khurram Faraaz created DRILL-4873:
-
Summary: Select from an array of empty maps results in NPE
Key: DRILL-4873
URL: https://issues.apache.org/jira/browse/DRILL-4873
Project: Apache Drill
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77403860
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -141,25 +141,41 @@ public void validate(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77403990
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -141,25 +141,41 @@ public void validate(final
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77403503
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValidator.java
---
@@ -69,6 +75,13 @@ public int getTtl() {
}
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77403393
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/AuthenticationUtil.java
---
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77403174
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropFunction.java
---
@@ -0,0 +1,79 @@
+/**
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77403003
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropFunction.java
---
@@ -0,0 +1,79 @@
+/**
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77402886
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateFunction.java
---
@@ -0,0 +1,79 @@
+/**
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77402584
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -106,11 +105,19 @@
String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77402402
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -106,11 +105,19 @@
String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77396647
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -337,4 +342,7 @@
String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77396445
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -106,11 +105,19 @@
String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77395696
--- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
@@ -38,7 +38,8 @@
"REFRESH",
"METADATA",
"DATABASE",
-"IF"
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77395651
--- Diff: distribution/src/resources/sqlline.bat ---
@@ -114,6 +114,10 @@ if "test%DRILL_LOG_DIR%" == "test" (
set DRILL_LOG_DIR=%DRILL_HOME%\log
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77395469
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -366,11 +366,18 @@ if [ $? -eq 0 ]; then
fatal_error "Java 1.7 or later is required to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77395331
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -366,11 +366,18 @@ if [ $? -eq 0 ]; then
fatal_error "Java 1.7 or later is required to
Hi everyone,
The next hangout is on Sept 6 (after the long weekend here). If there are
any topics folks wish to discuss, please let me know so that other who
might be interested can also join. You can always join and bring up new
topics at the last minute.
I have a couple of topics to
38 matches
Mail list logo