Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r81240983
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
@@ -104,6 +104,9 @@ public ScanBatch
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r81238209
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -664,27 +667,37 @@ private void
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r81244832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
---
@@ -207,6 +229,31 @@ public
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/595#discussion_r81240013
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -18,16 +18,62 @@
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81245030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81244826
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81244611
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81242837
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81238087
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
Rahul Challapalli created DRILL-4918:
Summary: Adding 2 dates results in AssertionError: Multiple
functions with best cost found
Key: DRILL-4918
URL: https://issues.apache.org/jira/browse/DRILL-4918
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81232963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/597
+1
LGTM.
If possible, please run a performance workload. The patch supposedly
should not impact the performance workload. But in case I might miss something,
it would be good to
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/597
updated with all review comments taken care of. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Dan Wild created DRILL-4917:
---
Summary: Unable to alias columns from subquery
Key: DRILL-4917
URL: https://issues.apache.org/jira/browse/DRILL-4917
Project: Apache Drill
Issue Type: Bug
Affects
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81196419
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -894,11 +910,21 @@ public GroupScan clone(List
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81196052
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -926,16 +952,22 @@ public GroupScan applyLimit(long
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81194437
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -926,16 +944,22 @@ public GroupScan applyLimit(long
Khurram Faraaz created DRILL-4916:
-
Summary: Drill UI - SCAN appears on top of PROJECT in Profiles tab
Key: DRILL-4916
URL: https://issues.apache.org/jira/browse/DRILL-4916
Project: Apache Drill
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/598#discussion_r81173247
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConstExecutor.java
---
@@ -143,116 +156,176 @@ public void
Alex Khomchenko created DRILL-4915:
--
Summary: IndexOutOfBoundsException while schema contains different
types
Key: DRILL-4915
URL: https://issues.apache.org/jira/browse/DRILL-4915
Project: Apache
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/598#discussion_r81115837
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/TestCaseNullableTypes.java
---
@@ -0,0 +1,107 @@
+/*
+* Licensed
Khurram Faraaz created DRILL-4914:
-
Summary: need better error message to handle invalid inputs to AGE
function
Key: DRILL-4914
URL: https://issues.apache.org/jira/browse/DRILL-4914
Project: Apache
Khurram Faraaz created DRILL-4913:
-
Summary: need a better error message when explicit cast DATE value
to TIME
Key: DRILL-4913
URL: https://issues.apache.org/jira/browse/DRILL-4913
Project: Apache
23 matches
Mail list logo
