[jira] [Created] (DRILL-4994) Prepared statement stopped working between 1.8.0 client and < 1.7.0 server

2016-11-02 Thread Laurent Goujon (JIRA)
Laurent Goujon created DRILL-4994: - Summary: Prepared statement stopped working between 1.8.0 client and < 1.7.0 server Key: DRILL-4994 URL: https://issues.apache.org/jira/browse/DRILL-4994 Project:

Re: Apache Drill Hangout Minutes - 11/1/16

2016-11-02 Thread Laurent Goujon
(+dev@drill.apache.org bcc u...@drill.apache.org) other options: - let the user decide between plain auth and sasl auth - let the client could send a flag to announce support for SASL auth, and do not send the credentials in the first handshake. An old server would then send AUTH_FAILED (and drop

Re: Apache Drill Hangout Minutes - 11/1/16

2016-11-02 Thread Laurent Goujon
That's a good point that the introduction of new request types for prepared statement and metadata introduced some incompatibility issues, and that's why I added a client/server version exchange so that client can make smart decisions about using these new methods or not (this is the approach used

[GitHub] drill pull request #619: DRILL-4946: redirect System.err so users under embe...

2016-11-02 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/619#discussion_r86069796 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/StdErrCapturer.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

[jira] [Created] (DRILL-4993) Documentation: Wrong output displayed for convert_from() with a map

2016-11-02 Thread Boaz Ben-Zvi (JIRA)
Boaz Ben-Zvi created DRILL-4993: --- Summary: Documentation: Wrong output displayed for convert_from() with a map Key: DRILL-4993 URL: https://issues.apache.org/jira/browse/DRILL-4993 Project: Apache

[jira] [Created] (DRILL-4992) Failing query with same case statement in both select and order by clause using using hash aggregate

2016-11-02 Thread Gautam Kumar Parai (JIRA)
Gautam Kumar Parai created DRILL-4992: - Summary: Failing query with same case statement in both select and order by clause using using hash aggregate Key: DRILL-4992 URL:

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-02 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/613 the only "refactoring" I can think of is between DrillCursor and DrillResultSetImpl, anything else is related to the feature. I'll try to split it, but hopefully in the current state, it should

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r86268011 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/security/SimpleServer.java --- @@ -0,0 +1,138 @@ +/** + * Licensed to the

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r86267336 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -246,28 +154,80 @@ protected void

[jira] [Created] (DRILL-4991) NPE when running CTAS auto partition on date and varchar columns

2016-11-02 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-4991: Summary: NPE when running CTAS auto partition on date and varchar columns Key: DRILL-4991 URL: https://issues.apache.org/jira/browse/DRILL-4991 Project:

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r86267015 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationMechanismFactory.java --- @@ -0,0 +1,182 @@ +/** + *

[GitHub] drill issue #613: DRILL-4730: Update JDBC DatabaseMetaData implementation to...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/613 I started looking into this. Can you please split the commit into two (refactoring changes, and the core changes that use new API) for quicker review? --- If your project is set up for it,

[GitHub] drill issue #632: DRILL-4969: Basic implementation of display size for colum...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/632 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] drill pull request #632: DRILL-4969: Basic implementation of display size fo...

2016-11-02 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/632#discussion_r86254267 --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java --- @@ -275,6 +275,84 @@ public static boolean isJdbcSignedType( final MajorType

[GitHub] drill pull request #632: DRILL-4969: Basic implementation of display size fo...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/632#discussion_r86253425 --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java --- @@ -275,6 +275,84 @@ public static boolean isJdbcSignedType( final

[GitHub] drill issue #610: DRILL-4674: Allow casting to boolean the same literals as ...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/610 Can you please squash and rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill issue #610: DRILL-4674: Allow casting to boolean the same literals as ...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/610 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Created] (DRILL-4990) Use new HDFS API access instead of listStatus to check if users have permissions to access workspace.

2016-11-02 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-4990: --- Summary: Use new HDFS API access instead of listStatus to check if users have permissions to access workspace. Key: DRILL-4990 URL:

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86231467 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86238839 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86230956 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] drill issue #642: DRILL-4987: Use ImpersonationUtil to get process user info...

2016-11-02 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/642 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Resolved] (DRILL-4986) Allow users to customize the Drill log file name

2016-11-02 Thread Sudheesh Katkam (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudheesh Katkam resolved DRILL-4986. Resolution: Fixed Assignee: Paul Rogers Reviewer: Boaz Ben-Zvi Fixed in

[GitHub] drill pull request #636: DRILL-4951: Do Guava.patch earlier so we can run si...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #641: DRILL-4986: Allow customization of the Drill log fi...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #643: DRILL-4989: Fix TestParquetWriter.testImpalaParquet...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/643 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #635: DRILL-4927 (part 2): Add support for Null Equality ...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86202063 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86201965 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86201969 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/BooleanType.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] drill issue #643: DRILL-4989: Fix TestParquetWriter.testImpalaParquetBinaryA...

2016-11-02 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/643 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] drill issue #643: DRILL-4989: Fix TestParquetWriter.testImpalaParquetBinaryA...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/643 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] drill pull request #643: DRILL-4989: Fix TestParquetWriter.testImpalaParquet...

2016-11-02 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/643 DRILL-4989: Fix TestParquetWriter.testImpalaParquetBinaryAsTimeStamp_DictChange Test `TestParquetWriter.testImpalaParquetBinaryAsTimeStamp_DictChange` expects sorted output but query does not

[jira] [Created] (DRILL-4989) Fix TestParquetWriter.testImpalaParquetBinaryAsTimeStamp_DictChange

2016-11-02 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-4989: --- Summary: Fix TestParquetWriter.testImpalaParquetBinaryAsTimeStamp_DictChange Key: DRILL-4989 URL: https://issues.apache.org/jira/browse/DRILL-4989 Project:

[GitHub] drill pull request #560: DRILL-4823: Fix OOM while trying to prune partition...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/560#discussion_r86104090 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/interpreter/InterpreterEvaluator.java --- @@ -378,8 +388,14 @@ public

[GitHub] drill issue #642: DRILL-4987: Use ImpersonationUtil to get process user info...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/642 No, you did not. User who is starting the drillbit should check if udf areas are writable. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r86103902 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SimpleCastFunctions.java --- @@ -48,14 +46,8 @@ public void setup() {

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r85954983 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() {

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r86107203 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() {

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r85978846 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +210,21 @@ private void

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r85974147 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -17,6 +17,7 @@ */ package org.apache.drill.exec;

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-11-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r85974663 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +210,21 @@ private void