Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/716
+1
The patch looks good to me. Thanks for the PR, @paul-rogers !
I'll squash and re-run the regression, before merge it to master branch.
---
If your project is set up for it, yo
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95490516
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun!
*
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95472935
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java
---
@@ -76,6 +75,22 @@
String textFileCo
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95471607
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -41,12 +39,87 @@
*/
public class CodeCompile
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95468443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun!
*
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95479214
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,14 +67,12 @@
* local variables. Have fun!
*
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95472493
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
---
@@ -44,6 +44,9 @@
@BeforeClass
p
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95469122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -141,7 +142,9 @@ public ClassBuilder(DrillConfig config, Opti
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95475935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95470389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95469066
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -13595,6 +13597,17 @@ public long getEnd() {
return end_;
Kunal Khatua created DRILL-5190:
---
Summary: Display planning time for a query in its profile page
Key: DRILL-5190
URL: https://issues.apache.org/jira/browse/DRILL-5190
Project: Apache Drill
Issu
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95461369
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun!
*
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95459877
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -41,12 +39,87 @@
*/
public class CodeCompiler
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/716
In the current code generator, we log both the source code and the size of
source / byte code, the time spent on compiling, and the complier (Janino vs
JDK) at debug level. It's probably debatable t
Chris Westin created DRILL-5189:
---
Summary: There's no documentation for the typeof() function
Key: DRILL-5189
URL: https://issues.apache.org/jira/browse/DRILL-5189
Project: Apache Drill
Issue T
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95442410
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
---
@@ -44,6 +44,9 @@
@BeforeClass
pub
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95442239
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -141,7 +142,9 @@ public ClassBuilder(DrillConfig config, Option
Attendees: Arina, Aman, Khurram, Karthik, Paul, Roman
1. Khurram wanted to know the status of Calcite rebasing. Roman indicated
it was in progress but currently on temporary hold due to couple of higher
priority issues.
2. Lazy initialization for UDFs: Paul wanted more backgroun
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95436174
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95432224
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime() {
Drill way of invoking UDFs without parenthesis
Best Regards,
Nagu.
On Tue, Jan 10, 2017 at 11:41 PM, Aman Sinha wrote:
> Hangout starting .. link: https://plus.google.com/hangouts/_/event/
> ci4rdiju8bv04a64efj5fedd0lc
>
> On 1/9/17, 5:24 PM, "Aman Sinha" wrote:
>
> Hi all,
>
> The bi
Hangout starting .. link:
https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
On 1/9/17, 5:24 PM, "Aman Sinha" wrote:
Hi all,
The bi-weekly hangout is tomorrow (01/10/17, 10 AM PST). If you have
any suggestions for topics for tomorrow, please add to this thread
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95411447
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -13595,6 +13597,17 @@ public long getEnd() {
return end_;
Khurram Faraaz created DRILL-5188:
-
Summary: TPC-DS query16 fails - IllegalArgumentException: Target
must be less than target count
Key: DRILL-5188
URL: https://issues.apache.org/jira/browse/DRILL-5188
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95344665
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime
Khurram Faraaz created DRILL-5187:
-
Summary: TPC-DS query 72 takes 32 minutes to complete
Key: DRILL-5187
URL: https://issues.apache.org/jira/browse/DRILL-5187
Project: Apache Drill
Issue Typ
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95327930
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -13595,6 +13597,17 @@ public long getEnd() {
return end_;
[
https://issues.apache.org/jira/browse/DRILL-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-4872.
-
Resolution: Fixed
> NPE from CTAS partitioned by a projected casted null
> ---
30 matches
Mail list logo