[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118619596 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/Utils.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118619502 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118616554 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118614384 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapDrillTable.java --- @@ -0,0 +1,73 @@ +/* --- End diff --

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118620276 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118617482 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118616406 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118617811 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118616240 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118615528 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118618438 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118616911 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to the

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118619851 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java --- @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/831#discussion_r118615907 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the

[GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/822#discussion_r118616162 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -205,10 +225,10 @@ drill.exec: { // Deprecated for managed xsort; used only

[GitHub] drill issue #832: DRILL-5504: Vector validator to diagnose offset vector iss...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/832 Fixed typo in log message and rebased onto latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Created] (DRILL-5541) C++ Client Crashes During Simple "Man in the Middle" Attack Test with Exploitable Write AV

Rob Wu created DRILL-5541: - Summary: C++ Client Crashes During Simple "Man in the Middle" Attack Test with Exploitable Write AV Key: DRILL-5541 URL: https://issues.apache.org/jira/browse/DRILL-5541 Project:

[GitHub] drill issue #822: DRILL-5457: Spill implementation for Hash Aggregate

Github user rchallapalli commented on the issue: https://github.com/apache/drill/pull/822 Based on the current design, if the code senses that there is not sufficient memory then it goes back to the old code. Now I have encountered a case where this happened and the old agg did not

[GitHub] drill issue #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/789 Cleaned up the multi-commit mess, rebased on the latest master, and fixed minor issues raised in code review comments. Should be read to commit. --- If your project is set up for it, you can

[GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/822#discussion_r118592786 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java --- @@ -133,6 +133,9 @@ the need to turn off

[GitHub] drill pull request #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/789#discussion_r118590127 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/BatchReader.java --- @@ -0,0 +1,164 @@ +/* + * Licensed

[GitHub] drill pull request #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/789#discussion_r118591443 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetInternalsTest.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to

[GitHub] drill pull request #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/789#discussion_r118591078 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -308,163 +232,50 @@ public

[GitHub] drill pull request #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/789#discussion_r118590602 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetColumnMetadata.java --- @@ -0,0 +1,151 @@ +/* +

[GitHub] drill pull request #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/789#discussion_r118591297 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetSchema.java --- @@ -0,0 +1,262 @@ +/* + *

[GitHub] drill pull request #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/789#discussion_r118590427 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetColumnMetadata.java --- @@ -0,0 +1,151 @@ +/* +

[GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/829#discussion_r118587783 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java --- @@ -219,12 +232,43 @@ public void

[GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/829#discussion_r118582764 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/UserClientConnection.java --- @@ -0,0 +1,69 @@ +/* + * Licensed to the

[GitHub] drill pull request #829: DRILL-5485: Remove WebServer dependency on DrillCli...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/829#discussion_r118580820 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractUserClientConnectionWrapper.java --- @@ -0,0 +1,101 @@ +/* + *

[GitHub] drill issue #828: DRILL-5229: update kudu-client to 1.3.0

Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/828 +1 The error seems unrelated to the changes, and all tests pass. Thank you for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Issues categorization suggestion

In Calcite we assign a "newbie" flag to some issues. A more detailed categorization takes significant effort for the person triaging the bugs, so isn't worth it. On Thu, May 25, 2017 at 9:23 AM, Paul Rogers wrote: > Great suggestion. > > What I’ve learned over the last year,

[GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/822#discussion_r118545693 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -179,6 +179,26 @@ drill.exec: { // Use plain Java compilation where available

[GitHub] drill issue #814: Add clickable localhost URL

Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/814 +1, @bbevens can you commit this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Drill custome function query

Hi Honey, Can you try using the ObjectHolder instead? Please let us know if it resolve the issue. Gautam From: honey francis Sent: Thursday, May 25, 2017 12:41:03 AM To: dev@drill.apache.org Subject: Drill custome function query

[GitHub] drill issue #789: DRILL-5356: Refactor Parquet Record Reader

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/789 Thanks. I'll clean up the messy commits today. Not sure how it picked up the other six commits... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] drill issue #789: DRILL-5356: Refactor Parquet Record Reader

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/789 I took the entire patch and applied it to master (use git am -3). Git manages to figure out that the commits are already applied. One commit caused a merge conflict and I skipped it. In the end

[GitHub] drill issue #789: DRILL-5356: Refactor Parquet Record Reader

Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/789 Are the changes only in 1494915dbef5dbd5996c19d0a2e89ca450a8ae3a (to cherry pick)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Drill custome function query

Dear Drill team I am writing a custom function which receives input from a Parquet file. The file contains data which is in a JSON format. The custom function requires a JSON element as input. For example, I want pass the following JSON element(one of the elements of the input JSON) to the

[jira] [Created] (DRILL-5540) Provide unit tests for the Drill shell scripts

Paul Rogers created DRILL-5540: -- Summary: Provide unit tests for the Drill shell scripts Key: DRILL-5540 URL: https://issues.apache.org/jira/browse/DRILL-5540 Project: Apache Drill Issue Type:

Re: Issues categorization suggestion

Great suggestion. What I’ve learned over the last year, however, is that if something in Drill seems simple, it is only because I’ve missed understanding some of the details. It is quite hard to determine the effort level to fix a bug without first doing a detailed analysis of the bug. If the

[GitHub] drill pull request #845: DRILL-5537: Display columns alias for queries with ...

GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/845 DRILL-5537: Display columns alias for queries with sum() when RDBMS s… …torage plugin is enabled For sum() queries DrillConvertSumToSumZero rule is applied. But during

Re: Issues categorization suggestion

+1 Sent from my iPhone > On May 25, 2017, at 09:34, Muhammad Gelbana wrote: > > Hi, > > I suggest to categorize issues according the level of expertise needed to > solve each one. This will encourage want-to-help\learn but > not-so-experienced-with-drill developers to

Issues categorization suggestion

Hi, I suggest to categorize issues according the level of expertise needed to solve each one. This will encourage want-to-help\learn but not-so-experienced-with-drill developers to take a thorough look into issues not requiring high level of experience with Drill. What do you think ?

[GitHub] drill pull request #844: DRILL-5538: Exclude ProjectRemoveRule during PHYSIC...

GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/844 DRILL-5538: Exclude ProjectRemoveRule during PHYSICAL phase if it com… …es from storage plugins Details in DRILL-5538 description. You can merge this pull request into a Git

[jira] [Created] (DRILL-5539) drillbit.sh script breaks if the working directory contains spaces

Muhammad Gelbana created DRILL-5539: --- Summary: drillbit.sh script breaks if the working directory contains spaces Key: DRILL-5539 URL: https://issues.apache.org/jira/browse/DRILL-5539 Project:

[jira] [Created] (DRILL-5538) Exclude ProjectRemoveRule during PHYSICAL phase if it comes from storage plugins

Arina Ielchiieva created DRILL-5538: --- Summary: Exclude ProjectRemoveRule during PHYSICAL phase if it comes from storage plugins Key: DRILL-5538 URL: https://issues.apache.org/jira/browse/DRILL-5538

[jira] [Created] (DRILL-5537) Display columns alias for queries with sum() when RDBMS storage plugin is enabled

Arina Ielchiieva created DRILL-5537: --- Summary: Display columns alias for queries with sum() when RDBMS storage plugin is enabled Key: DRILL-5537 URL: https://issues.apache.org/jira/browse/DRILL-5537