Correction for example II as Drill uses a single thread per pipeline (a
batch is fully processed before the next one is; only receive of batches
can happen concurrently):
- Using batch identifiers for more clarity
- t0: (fragment, opr-1, opr-2) = ([b1], [], [])
- t1: (fragment, opr-1, opr-2) =
Another point, I don't see a functional benefit from avoiding a change of
ownership for pass-through operators. Consider the following use-cases:
Example I -
- Single batch of size 8MB is received at time t0 and then is passed
through a set of pass-through operators
- At time t1 owned by operator
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1241
@sohami / @arina-ielchiieva can you review this? The change is not
extensive and fairly straightforward.
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1241
Screenshot of when UI node `kk127` goes down. The UI's javascript logic
queries other Drillbits in the list (in this case, `kk128`) and discovers two
new previously unseen Drillbits - `kk130` and
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/1241
DRILL-6364: Handle Cluster Info in WebUI when existing/new bits restart
As a follow up to DRILL-6289, the following improvements have been done:
1. When loading the page for the first time, the
Kunal Khatua created DRILL-6364:
---
Summary: WebUI does not cleanly handle shutdown and state toggling
when Drillbits go on and offline
Key: DRILL-6364
URL: https://issues.apache.org/jira/browse/DRILL-6364
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1184
```
What do you mean by "Json representation"?
```
Sorry, my mistake, got all tangled up.
```
we may want to further translate the Local [Date|Time|DateTime] objects
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1237
IMO, it will be good to understand what other operators do as well. For
example what Project or Filter operators do. Do they take ownership of incoming
batches? And if they do, when is the ownership
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184807153
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184804819
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1237
That was not my intention as my current change aimed at describing the
system the way it is.
@parthchandra, any feedback?
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1240
+1. Very nicely done.
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1237
@vrozov,
**What are we trying to solve / improve**
- Drill is currently not properly reporting memory held in Fragment's
receive queues
- This makes it hard to analyze OOM
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184747702
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184727914
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184730050
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184728292
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1225
@vrozov now PR contains two commits:
1. jmockit and mockito upgrade (DRILL-6363);
2. maven-embedder usage for unit tests (used latest version as you
suggested) (DRILL-6272).
Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184726839
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184724657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software
Arina Ielchiieva created DRILL-6363:
---
Summary: Upgrade jmockit and mockito libs
Key: DRILL-6363
URL: https://issues.apache.org/jira/browse/DRILL-6363
Project: Apache Drill
Issue Type: Task
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184701824
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184694930
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,266 @@
+/*
+ * Licensed to the Apache Software
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184693216
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1238#discussion_r184691926
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java ---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1214
When moving files around please preserve the history of modifications done
to the file.
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1214
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1231
---
Github user vladimirtkach commented on the issue:
https://github.com/apache/drill/pull/1230
@vvysotskyi made changes according to your remarks
---
29 matches
Mail list logo
