[GitHub] vrozov commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs

vrozov commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs URL: https://github.com/apache/drill/pull/1437#discussion_r212169818 ## File path: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ## @@ -63,7

[GitHub] vrozov opened a new pull request #1440: DRILL-6693: When a query is started from Drill Web Console, the UI becomes inaccessible

vrozov opened a new pull request #1440: DRILL-6693: When a query is started from Drill Web Console, the UI becomes inaccessible URL: https://github.com/apache/drill/pull/1440 This is an automated message from the Apache Git

Re: [Question] HiveStoragePlugin and NativeParquetRowGroupScan

Hi Tim, I don't have an answer. But, I can point out some factors to consider. Hive describes a set of data in a specific file system. Would make sense to associate that file system with the Hive configuration. Else, I could use a Hive metastore for FS A, with a DFS configured for FS B, and

[Question] HiveStoragePlugin and NativeParquetRowGroupScan

Hi All, I'm a bit confused and I was hoping to get some clarification about how the HiveStoragePlugin interacts with the FileSystem plugin. Currently the HiveStoragePlugin allows the user to configure their own value for fs.defaultFS in the plugin properties, which overrides the defaultFS used

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-415220804 @arina-ielchiieva @sohami thanks for the detail catch, done. This is an automated

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212088190 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java ##

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212097230 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ## @@ -65,107

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212098085 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTestBase.java ## @@ -278,27 +272,17 @@

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212087990 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DirPrunedEnumerableTableScan.java

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212092928 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ## @@ -419,279

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212095113 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ## @@ -162,1713

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212096389 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ## @@ -162,1713

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212095374 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ## @@ -162,1713

[GitHub] gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212091811 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ## @@ -419,279

[jira] [Resolved] (DRILL-6566) Jenkins Regression: TPCDS query 66 fails with RESOURCE ERROR: One or more nodes ran out of memory while executing the query. AGGR OOM at First Phase.

[ https://issues.apache.org/jira/browse/DRILL-6566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boaz Ben-Zvi resolved DRILL-6566. - Resolution: Fixed Reviewer: Timothy Farkas Commit ID 

[GitHub] jinfengni commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

jinfengni commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r212105336 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

[GitHub] vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212067079 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java

[GitHub] vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212068070 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java

[GitHub] vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212071585 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ## @@

[GitHub] vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

vvysotskyi commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212066256 ## File path: exec/java-exec/src/main/codegen/data/Parser.tdd ## @@ -85,13 +85,17 @@ # List of

Re: [DISCUSSION] Does schema-free really need

Join the club. We all forget that from time to time - until a perfectly simple change blows up in some huge QA test... - Paul Sent from my iPhone > On Aug 22, 2018, at 8:33 AM, Chris Cunningham wrote: > > Hmm. Right. Somehow I forgot about the very large result sets - stupid of > me. > >

[GitHub] HanumathRao edited a comment on issue #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao edited a comment on issue #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#issuecomment-415137941 @vvysotskyi Thank you for making these changes. I have few minor comments otherwise changes look good to me.

[GitHub] HanumathRao commented on issue #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao commented on issue #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#issuecomment-415137941 @vvysotskyi Thank you for making these changes. Changes look good to me.

[GitHub] HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212065323 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ## @@

[GitHub] HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212065022 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java

[GitHub] HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212064700 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillConditions.java

[GitHub] HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0 URL: https://github.com/apache/drill/pull/1425#discussion_r212064539 ## File path: exec/java-exec/src/main/codegen/data/Parser.tdd ## @@ -85,13 +85,17 @@ # List of

[GitHub] Ben-Zvi closed pull request #1438: DRILL-6566: Reduce Hash Agg Batch size and estimate when low available memory

Ben-Zvi closed pull request #1438: DRILL-6566: Reduce Hash Agg Batch size and estimate when low available memory URL: https://github.com/apache/drill/pull/1438 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sohami commented on issue #1334: DRILL-6385: Support JPPD feature

sohami commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-415126887 @arina-ielchiieva - Nice catch. @weijietong - Please remove [this

[GitHub] arjun-rajan removed a comment on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

arjun-rajan removed a comment on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-415117739 @ilooner Could you please review the changes.

[GitHub] arjun-rajan commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

arjun-rajan commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-415117739 @ilooner Could you please review the changes.

[GitHub] sohami commented on a change in pull request #1388: DRILL-6610: Add support for Minimum TLS restriction.

sohami commented on a change in pull request #1388: DRILL-6610: Add support for Minimum TLS restriction. URL: https://github.com/apache/drill/pull/1388#discussion_r212041919 ## File path: contrib/native/client/src/clientlib/channel.hpp ## @@ -82,11 +82,31 @@ class

[GitHub] sohami commented on a change in pull request #1388: DRILL-6610: Add support for Minimum TLS restriction.

sohami commented on a change in pull request #1388: DRILL-6610: Add support for Minimum TLS restriction. URL: https://github.com/apache/drill/pull/1388#discussion_r212043110 ## File path: contrib/native/client/src/clientlib/channel.hpp ## @@ -82,11 +82,31 @@ class

[GitHub] sohami commented on a change in pull request #1388: DRILL-6610: Add support for Minimum TLS restriction.

sohami commented on a change in pull request #1388: DRILL-6610: Add support for Minimum TLS restriction. URL: https://github.com/apache/drill/pull/1388#discussion_r212041002 ## File path: contrib/native/client/src/clientlib/channel.hpp ## @@ -82,11 +82,31 @@ class

[GitHub] kkhatua commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs

kkhatua commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs URL: https://github.com/apache/drill/pull/1437#discussion_r212038433 ## File path: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ## @@ -32,13

[jira] [Resolved] (DRILL-6569) Jenkins Regression: TPCDS query 19 fails with INTERNAL_ERROR ERROR: Can not read value at 2 in block 0 in file maprfs:///drill/testdata/tpcds_sf100/parquet/store_sales/1

[ https://issues.apache.org/jira/browse/DRILL-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-6569. Resolution: Won't Fix This is Hive issue - HIVE-19069. It fails in Hive too: {code} hive>

Re: [DISCUSSION] Does schema-free really need

Hmm. Right. Somehow I forgot about the very large result sets - stupid of me. On Tue, Aug 21, 2018 at 4:43 PM Paul Rogers wrote: > Hi Chris, > > Later, when Drill sees the first Varchar, it can change the type from, > say, batch 3 onwards. But, JDBC and ODBC generally require the schema be >

Re: [DISCUSSION] Replacing Preconditions.checkNotNull() with Objects.requireNonNull()

Using Java API in case of Objects.requireNonNull() does not help with avoiding dependency on the Guava library and its Preconditions class, so it is only question of consistency. Why to enforce consistency in code style and not to enforce consistency in API used? Thank you, Vlad > On Aug 22,

[GitHub] arina-ielchiieva commented on issue #1439: DRILL-6492: Ensure schema / workspace case insensitivity in Drill

arina-ielchiieva commented on issue #1439: DRILL-6492: Ensure schema / workspace case insensitivity in Drill URL: https://github.com/apache/drill/pull/1439#issuecomment-415061185 @vvysotskyi please review. This is an

[GitHub] arina-ielchiieva opened a new pull request #1439: DRILL-6492: Ensure schema / workspace case insensitivity in Drill

arina-ielchiieva opened a new pull request #1439: DRILL-6492: Ensure schema / workspace case insensitivity in Drill URL: https://github.com/apache/drill/pull/1439 1. StoragePluginsRegistryImpl was updated: a. for backward compatibility at init to convert all existing storage plugins

Re: [DISCUSSION] Replacing Preconditions.checkNotNull() with Objects.requireNonNull()

Obviously, I would intend to use Java API methods in first place since they do not introduce extra dependencies. I don't mind the replacements to Preconditions for consistency (though it's up the PR author in the scope of which Jira that should be done). Kind regards, Arina On Wed, Aug 22, 2018

Re: [DISCUSSION] Replacing Preconditions.checkNotNull() with Objects.requireNonNull()

Please elaborate on you preference regarding Objects.requireNonNull()? As currently there are only a few instances of requireNonNull() calls in Drill, why not to fix it now and avoid inconsistency in the future? Thank you, Vlad > On Aug 22, 2018, at 03:02, Arina Yelchiyeva > wrote: > > I

[GitHub] arina-ielchiieva edited a comment on issue #1334: DRILL-6385: Support JPPD feature

arina-ielchiieva edited a comment on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-415011082 @weijietong run the tests on your branch and have noticed that though all unit tests pass there are a huge amount of warnings during the

[GitHub] arina-ielchiieva commented on issue #1334: DRILL-6385: Support JPPD feature

arina-ielchiieva commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-415011082 @weijietong run the tests on your branch and have noticed that though all unit tests pass there are a huge amount of warnings during the

[jira] [Created] (DRILL-6704) Alter Session won't run on MapR 1.9(but runs on 1.8)

Marc McElhinney created DRILL-6704: -- Summary: Alter Session won't run on MapR 1.9(but runs on 1.8) Key: DRILL-6704 URL: https://issues.apache.org/jira/browse/DRILL-6704 Project: Apache Drill

Re: [DISCUSSION] Replacing Preconditions.checkNotNull() with Objects.requireNonNull()

I don't feel like banning Objects.checkNotNull() right now though even Guava suggests not using this method. I suggest we leave it as is in the scope of current PR#1397 (revert replacements where they were done) and discuss further approach on how we should treat checks at runtime. Kind regards,

[GitHub] arina-ielchiieva commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs

arina-ielchiieva commented on a change in pull request #1437: DRILL-6702: Disable CPU Reporting for non-HotSpot JDKs URL: https://github.com/apache/drill/pull/1437#discussion_r211894551 ## File path: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ##

[GitHub] arina-ielchiieva commented on issue #1334: DRILL-6385: Support JPPD feature

arina-ielchiieva commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-414973354 @weijietong thanks! This is an automated message from the Apache Git Service.