[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-25 Thread GitBox
vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Could you please provide the time of execution of the que

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-25 Thread GitBox
vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Besides setters added to the generated code, are there an

[GitHub] vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-25 Thread GitBox
vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Besides setters added to the generated code, are there any chang

[GitHub] lushuifeng opened a new pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-25 Thread GitBox
lushuifeng opened a new pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481 Details in DRILL-6763: Here is the descriptions of the change: 1. add system option `exec.optimize_function_compilation

[jira] [Created] (DRILL-6763) Codegen optimiztion of SQL functions with constant values

2018-09-25 Thread shuifeng lu (JIRA)
shuifeng lu created DRILL-6763: -- Summary: Codegen optimiztion of SQL functions with constant values Key: DRILL-6763 URL: https://issues.apache.org/jira/browse/DRILL-6763 Project: Apache Drill Is

Multi Commit PRs (Re: Drill Hangout tomorrow 09/18)

2018-09-25 Thread Boaz Ben-Zvi
   More on splitting a PR into multiple commits - link [1] below shows how to take the last commit and break it (thanks Hanumath.) I just practiced this method on a PR (1480 - see [2]); this separates the actual logic of the change from the less relevant definitions, cleanups, etc. This does

Re: [DISCUSS] Drill Hackathon/Drill Developers Day - 2018!

2018-09-25 Thread Charles Givre
HI there, I am interested in attending, but it may have to be virtual as I am based in DC. I’d love to hear about (and possibly present) use cases of how Drill is actually being used. I am also interested in further discussion about the possible Arrow integration. —C > On Sep 25, 2018, at 1

[GitHub] Ben-Zvi opened a new pull request #1480: DRILL-6755: Avoid building Hash Table for inner/left join when probe side is empty

2018-09-25 Thread GitBox
Ben-Zvi opened a new pull request #1480: DRILL-6755: Avoid building Hash Table for inner/left join when probe side is empty URL: https://github.com/apache/drill/pull/1480 This PR is split into two commits to help the reviewers: (1) Preparations and cleanups: No change to the code's logic

Re: storage plugin test case

2018-09-25 Thread Kunal Khatua
You can try looking for existing unit tests that look up the classpath to see where the resource might need to be.  You probably want it here: /src/test/resources/ For e.g., a lot of java-exec module's test files are here :  drill/exec/java-exec/src/test/resources https://github.com/apache/drill

[DISCUSS] Drill Hackathon/Drill Developers Day - 2018!

2018-09-25 Thread Gautam Parai
Hi Drill Developers, It has already been one year since our last Drill Hackathon/Developers Day! I would like to get the ball rolling for this year's Drill Developer Day ™. The tentative date is Nov 14 (Wednesday). The goal is to get the community together for a half-day long technical discussion

storage plugin test case

2018-09-25 Thread Jean-Claude Cote
I have writing a msgpack storage plugin from drill. https://github.com/jcmcote/drill/tree/master/contrib/storage-msgpack I'm now trying to write test cases like testBuilder() .sqlQuery("select * from cp.`msgpack/testBasic.mp`") .ordered() .baselineColumns("a").baseline

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r219799183 ## File path: exec/java-exec/src/test/java/org/apache/drill/TestOperatorDump.

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r219799239 ## File path: exec/java-exec/src/test/java/org/apache/drill/test/LogFixture.j

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220253584 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/im

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220254605 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/im

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r219799214 ## File path: exec/java-exec/src/test/java/org/apache/drill/TestOperatorDump.

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r219863225 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/Abst

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r219799067 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/im

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-25 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220261501 ## File path: common/src/main/java/org/apache/drill/common/exceptions/UserEx

[jira] [Created] (DRILL-6762) Dynamic UDFs registered on one Drillbit are not visible on other Drillbits

2018-09-25 Thread Kunal Khatua (JIRA)
Kunal Khatua created DRILL-6762: --- Summary: Dynamic UDFs registered on one Drillbit are not visible on other Drillbits Key: DRILL-6762 URL: https://issues.apache.org/jira/browse/DRILL-6762 Project: Apach

[GitHub] denysord88 commented on issue #1479: DRILL-6761: Updated table of contents on the REST-API page

2018-09-25 Thread GitBox
denysord88 commented on issue #1479: DRILL-6761: Updated table of contents on the REST-API page URL: https://github.com/apache/drill/pull/1479#issuecomment-424288851 @bbevens could you please review this PR? This is an automa

[GitHub] denysord88 opened a new pull request #1479: DRILL-6761: Updated table of contents on the REST-API page

2018-09-25 Thread GitBox
denysord88 opened a new pull request #1479: DRILL-6761: Updated table of contents on the REST-API page URL: https://github.com/apache/drill/pull/1479 This is an automated message from the Apache Git Service. To respond to th

[GitHub] denysord88 closed pull request #1478: DRILL-6761: Updated table of contents on the REST-API page

2018-09-25 Thread GitBox
denysord88 closed pull request #1478: DRILL-6761: Updated table of contents on the REST-API page URL: https://github.com/apache/drill/pull/1478 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[jira] [Created] (DRILL-6761) Documentation - broken table of contents on the REST-API page

2018-09-25 Thread Denys Ordynskiy (JIRA)
Denys Ordynskiy created DRILL-6761: -- Summary: Documentation - broken table of contents on the REST-API page Key: DRILL-6761 URL: https://issues.apache.org/jira/browse/DRILL-6761 Project: Apache Drill

[GitHub] denysord88 opened a new pull request #1478: Updated table of contents on the REST-API page

2018-09-25 Thread GitBox
denysord88 opened a new pull request #1478: Updated table of contents on the REST-API page URL: https://github.com/apache/drill/pull/1478 This is an automated message from the Apache Git Service. To respond to the message, p