[GitHub] [drill] paul-rogers commented on issue #2010: DRILL-7620: Fix plugin mutability issues

2020-03-11 Thread GitBox
paul-rogers commented on issue #2010: DRILL-7620: Fix plugin mutability issues URL: https://github.com/apache/drill/pull/2010#issuecomment-598014930 @agozhiy, thanks for finding the enable case. Added validation on enabling the plugin. To do this right, needed to copy the config

[jira] [Created] (DRILL-7638) Cannot login to Drill Web Console, if go to it from YARN Application Master Web-UI

2020-03-11 Thread Dmytro Kondriukov (Jira)
Dmytro Kondriukov created DRILL-7638: Summary: Cannot login to Drill Web Console, if go to it from YARN Application Master Web-UI Key: DRILL-7638 URL: https://issues.apache.org/jira/browse/DRILL-7638

[GitHub] [drill] dobesv commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
dobesv commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#issuecomment-597775846 @arina-ielchiieva It sounds a bit complicated, maybe this PR can proceed without it and we can look into adding a new UI for

[jira] [Created] (DRILL-7637) Add an option to retrieve MapR SSL truststore/keystore credentials using MapR Web Security Manager

2020-03-11 Thread Anton Gozhiy (Jira)
Anton Gozhiy created DRILL-7637: --- Summary: Add an option to retrieve MapR SSL truststore/keystore credentials using MapR Web Security Manager Key: DRILL-7637 URL: https://issues.apache.org/jira/browse/DRILL-7637

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r391122758 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r391122758 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r391114166 ## File path:

[GitHub] [drill] arina-ielchiieva commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#issuecomment-597737918 @dobesv what about having empty box where user can set options?

[GitHub] [drill] dobesv commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
dobesv commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#issuecomment-597726278 This PR doesn't include a way to set options via the Web UI any more, I guess that'll be something for a future PR. If

[GitHub] [drill] dobesv commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
dobesv commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r391084052 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java

[GitHub] [drill] dobesv commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
dobesv commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r391083173 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryResources.java

[GitHub] [drill] agozhiy commented on issue #2010: DRILL-7620: Fix plugin mutability issues

2020-03-11 Thread GitBox
agozhiy commented on issue #2010: DRILL-7620: Fix plugin mutability issues URL: https://github.com/apache/drill/pull/2010#issuecomment-597710417 @paul-rogers, the problem is: if a plugin is invalid and **disabled**, it is not being rejected. And later you can enable the plugin, causing the

[GitHub] [drill] arina-ielchiieva commented on issue #1962: DRILL-7554: Convert LTSV Format Plugin to EVF

2020-03-11 Thread GitBox
arina-ielchiieva commented on issue #1962: DRILL-7554: Convert LTSV Format Plugin to EVF URL: https://github.com/apache/drill/pull/1962#issuecomment-597676574 @cgivre / @paul-rogers also I suspect that after https://github.com/apache/drill/commit/88a84b9d088dad549e8489c487c55c9d7aecff9a

[GitHub] [drill] asfgit closed pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework

2020-03-11 Thread GitBox
asfgit closed pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework URL: https://github.com/apache/drill/pull/1993 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] asfgit closed pull request #1996: DRILL-7603: Allow default schema to be set for HTTP queries

2020-03-11 Thread GitBox
asfgit closed pull request #1996: DRILL-7603: Allow default schema to be set for HTTP queries URL: https://github.com/apache/drill/pull/1996 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] arina-ielchiieva commented on issue #2010: DRILL-7620: Fix plugin mutability issues

2020-03-11 Thread GitBox
arina-ielchiieva commented on issue #2010: DRILL-7620: Fix plugin mutability issues URL: https://github.com/apache/drill/pull/2010#issuecomment-597604478 @paul-rogers > if you run the UI scenario from your earlier comment, you should see that the plugin is rejected if invalid and

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r390928499 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#discussion_r390927527 ## File path:

[GitHub] [drill] arina-ielchiieva commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries

2020-03-11 Thread GitBox
arina-ielchiieva commented on issue #1997: DRILL-7604: Allow session options to be set in HTTP queries URL: https://github.com/apache/drill/pull/1997#issuecomment-597595565 @dobesv how user will set session options through web ui?

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework

2020-03-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #1993: DRILL-7601: Shift column conversion to reader from scan framework URL: https://github.com/apache/drill/pull/1993#discussion_r390917852 ## File path:

[GitHub] [drill] arina-ielchiieva commented on issue #1993: DRILL-7601: Shift column conversion to reader from scan framework

2020-03-11 Thread GitBox
arina-ielchiieva commented on issue #1993: DRILL-7601: Shift column conversion to reader from scan framework URL: https://github.com/apache/drill/pull/1993#issuecomment-597588370 +1, LGTM This is an automated message from

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390847156 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPrel.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390849669 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/TopNPrel.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390840286 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/Wrapper.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390841188 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390833446 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java ## @@

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390828845 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390830839 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390831009 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390828975 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390844001 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTrait.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes

2020-03-11 Thread GitBox
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes URL: https://github.com/apache/drill/pull/2020#discussion_r390847794 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/MetadataControllerPrel.java

[jira] [Created] (DRILL-7636) Extract Web-related code to a new drill-web module

2020-03-11 Thread Igor Guzenko (Jira)
Igor Guzenko created DRILL-7636: --- Summary: Extract Web-related code to a new drill-web module Key: DRILL-7636 URL: https://issues.apache.org/jira/browse/DRILL-7636 Project: Apache Drill Issue