I guess the question is do we de-lombok what has already been done? I really
like the builders for plugin configs, but I'm generally in agreement that if it
is causing problems building, we should ditch it.
Best,
-- C
> On Jan 22, 2022, at 5:02 PM, Ted Dunning wrote:
>
> The Lombok story
The Lombok story is better in Intellij, possibly because the Lombok devs
use IntelliJ like the majority of devs. Once I knew to install the plugin,
things were at least comprehensible.
But the problem is that it isn't obvious. As a newcomer, you don't know
what you don't know and because Lombok's
Hi all,
I have a story here. In Oct 2021, I upgraded Eclipse to the latest release
(2021–09) and then found out that the Lombok dependency was added Drill
repository, So I installed Lombok (as a new plugin) from Eclipse Marketplace as
I used to. Finally, restarted the IDE and prepared to open
luocooong commented on a change in pull request #2422:
URL: https://github.com/apache/drill/pull/2422#discussion_r790134758
##
File path:
contrib/storage-phoenix/src/main/java/org/apache/drill/exec/store/phoenix/PhoenixDataSource.java
##
@@ -21,13 +21,14 @@
import
luocooong commented on a change in pull request #2422:
URL: https://github.com/apache/drill/pull/2422#discussion_r790134460
##
File path:
contrib/storage-phoenix/src/main/java/org/apache/drill/exec/store/phoenix/PhoenixBatchReader.java
##
@@ -71,58 +74,64 @@ public
luocooong commented on a change in pull request #2419:
URL: https://github.com/apache/drill/pull/2419#discussion_r790131253
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/convert/WriterBuilder.java
##
@@ -0,0 +1,230 @@
+/*
Review comment:
Hi All,
I look at any tool as a cost/benefit tradeoff. If Drill were a typical
business app, with lots of "data objects", then the hassle of Lomboc might
be a net win. However, the nature of Drill is that we have very few data
objects. We have lots of Protobuf objects, or Jackson-serialized
luocooong commented on a change in pull request #2419:
URL: https://github.com/apache/drill/pull/2419#discussion_r790121506
##
File path:
contrib/format-httpd/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogFormatPlugin.java
##
@@ -40,18 +40,16 @@
private static
