Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/978#discussion_r147546965
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/MiniPlanUnitTestBase.java
---
@@ -360,7 +366,7 @@ public T columnsToRead(String
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/968
Project push-down rule may not work in the way we want in at least two
cases: 1) there is a bug in the code that we are not aware of, 2) it would not
push the list of columns for "select *&q
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/968
I'm not convinced that it's a good idea to back out the change to HBase
specific changes made in DRILL-5546.
You are right that project push-down in planner ideally should do its job
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/941
DRILL-5775: Expand * into list of column/column family for MapR-DB bâ¦
â¦inary table groupscan.
Move common code to HBaseUtils, so it's shared by both HBaseGroupScan
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/905
@vvysotskyi , what I'm thinking is not just comparing the ratio of column
count vs ratio of row count.
Let's take a step back. This SwapHashJoinVisitor is trying to correct the
join
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/905
This OOM problem exposes two problems. The first one is in planning time,
where we choose a sub-optimal plan, due to the inaccurate estimation of row
count because of missing of appropriate
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
The proposal from @vrozov makes sense to me. As long as Lilith is not
completely disabled, I'm fine with it.
---
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
We have run unit in our test clusters and I never hear that people
complained that unit tests failed due to Lilith.
---
If your project is set up for it, you can reply to this email and have
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
Per this hive doc, seems it's possible to change hiveserver2 port #.
Can you try to change hivesever2# if the other one is hardcoded?
1. https://cwiki.apache.org/confluence/display
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
I have some concern about this PR.
AFASIK, some of Drill developers use Lilith to debug issues when running
individual unit testcases. If remove it, does it mean people has to manually
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/906
@paul-rogers , thank you for your detailed review comments. I revised the
patch based on your comments, and rebased on latest master. Please see the 2nd
commit for the revised patch. Let me know
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136188895
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136188791
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136188197
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187915
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187789
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187804
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187598
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136186438
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136185442
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -125,4 +131,19 @@ public BatchSchema getSchema
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136185139
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -61,6 +63,10 @@ public IterOutcome innerNext
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136184973
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136182353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java
---
@@ -35,18 +35,43 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136181920
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java
---
@@ -160,12 +161,7 @@ public RelOptCost computeSelfCost
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136159563
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136157330
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136157172
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136154993
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136154585
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136152074
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136151330
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136149953
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136149852
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136143881
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135979350
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135977556
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135976739
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestEmptyBatchMiniPlan.java
---
@@ -0,0 +1,453 @@
+/*
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974928
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974916
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974905
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974302
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974310
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974133
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974107
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135925091
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135925006
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135924402
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135924386
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135924412
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/924
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135710183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -329,9 +326,11 @@ public TypedFieldId getValueVectorId
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135709915
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -252,14 +235,28 @@ public IterOutcome next
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135708467
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135424127
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135424090
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135423794
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135382803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135373441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351043
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -46,14 +56,18 @@ public Project(@JsonProperty("
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -35,9 +35,19 @@
static final org.slf4j.Logger
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/860
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/900
+1
LGTM. Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/906
DRILL-5546: Handle schema change exception failure caused by empty inâ¦
â¦put or empty batche.
1. Modify ScanBatch's logic when it iterates list of RecordReader.
1) Skip
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/882#discussion_r131446392
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
---
@@ -85,109 +91,231 @@ protected
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/882#discussion_r131447579
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
---
@@ -85,109 +91,231 @@ protected
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/882#discussion_r131449948
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
---
@@ -85,109 +91,231 @@ protected
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/882#discussion_r131450166
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/direct/MetadataDirectGroupScan.java
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/882#discussion_r131445381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
---
@@ -85,109 +91,231 @@ protected
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/882#discussion_r131447047
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
---
@@ -85,109 +91,231 @@ protected
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r125785209
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -445,12 +448,148 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r125784283
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1696,9 +1712,24 @@ public ColumnMetadata_v3(String[] name
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r125784066
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1008,8 +1008,24 @@ public void setMax(Object max
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/776
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/805
Thanks for the reminder, @paul-rogers . Somehow, I overlooked this PR. I
thought I have reviewed and merged a PR from @vvysotskyi . But looks like I
confused this one with another one I merged
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/844#discussion_r123631660
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/TopProjectVisitor.java
---
@@ -0,0 +1,139
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/844#discussion_r123632779
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java
---
@@ -459,7 +468,13 @@ protected Prel
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/853#discussion_r123312311
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillValuesRelBase.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/829
Seems @sohami has addressed @sudheeshkatkam 's comments. I'm going to merge
this PR.
+1
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/845
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/844#discussion_r118802952
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
@@ -180,9 +180,19 @@ public RuleSet getRules
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/818#discussion_r118755301
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -77,10 +81,43 @@
private final CodeGenerator
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/818
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117582970
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -508,21 +516,32 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117583804
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -181,6 +185,71 @@ else
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117585451
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -398,10 +399,115 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117584586
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -181,6 +185,71 @@ else
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117583114
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -508,21 +516,32 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117584380
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -181,6 +185,71 @@ else
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r117578486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -548,23 +567,57 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/818#discussion_r117573874
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -77,10 +81,43 @@
private final CodeGenerator
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r116336012
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestMiniPlan.java
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r116337155
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestMiniPlan.java
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r116335475
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/PhysicalOpUnitTestBase.java
---
@@ -82,6 +81,8 @@
* Look! Doesn't extend
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r116336861
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestMiniPlan.java
---
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r11670
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/MiniPlanUnitTestBase.java
---
@@ -0,0 +1,439 @@
+/*
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/823#discussion_r11618
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/MiniPlanUnitTestBase.java
---
@@ -0,0 +1,439 @@
+/*
+ * Licensed
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/819
I agreed with @paul-rogers that BatchSchema and MaterializedField should
consider all fields (I once briefly mentioned to @paul-rogers I feel there
might be bug in the equals/hashCode methods
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/819
+1
The revised commit looks good to me. Thanks for taking effort to separate
the return type inference logic from function scope logic. You may consider
adding brief description
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/819
Regarding Paul's suggestion of using sampling (either 1st batch, or `n`
batches), if the sampled length is returned to client as metadata for query
result set, it could cause quite big problems
1 - 100 of 539 matches
Mail list logo
