Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/858
@laurentgo Within the DrillCursor, the only place I could do such a check
was
https://github.com/kkhatua/drill/blob/c51473859d1dd81cf70e857f729c3a8491b2834a/exec/jdbc/src/main/java/org/apache
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/858
@laurentgo I'm hoping to commit and close the PR before the long weekend...
just waiting on your review of the changes :)
---
If your project is set up for it, you can reply to this email and have
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/826
@ppadma , Khurram [~khfaraaz] and I were looking at the details in the PR
and it's not very clear what new behavior does the PR allow. If you need to
specify the block-size as described
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/862#discussion_r124688876
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -409,9 +414,10 @@ public Void call
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/862
@parthchandra Can you please review this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/862
DRILL-5420: ParquetAsyncPgReader goes into infinite loop during cleanup
PageQueue is cleaned up using poll() instead of take(), which constantly
gets interrupted and causes CPU churn.
During
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/858
@laurentgo Updated based on the review comments. The Timeout Executor
Service is now maintained for the lifetime of a connection and closed during
shutdown. Also refactored by introducing
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r124068854
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123913767
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -98,6 +102,32 @@ private void throwIfClosed() throws
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123872136
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/858
@laurentgo I'm done with the refactoring. Please review.
@parthchandra , since this will be the basis of exploring the cause for
DRILL-5420 , perhaps you could do a review as well.
---
If your
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865572
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -64,13 +65,17 @@
org.slf4j.LoggerFactory.getLogger
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865562
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865524
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -159,24 +230,25 @@ public void cleanUp() {
public int
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865494
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865295
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1384,7 +1402,7 @@ public void updateRowId( String columnLabel
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865256
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -125,7 +154,7 @@ protected void cancel
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123331635
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -125,7 +154,7 @@ protected void cancel
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123330684
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -422,6 +507,9 @@ public ResultSet getGeneratedKeys() throws
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329050
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329155
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -497,14 +594,64 @@ public boolean isPoolable() throws
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123327737
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -159,24 +230,25 @@ public void cleanUp() {
public int
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123325595
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123325052
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/SqlTimeoutException.java ---
@@ -23,12 +23,17 @@
* Indicates that an operation timed out
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123324366
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -64,13 +65,17 @@
org.slf4j.LoggerFactory.getLogger
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/858
Got it... traced it to a change in the DrillResultSetImpl. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/858
@laurentgo I'm seeing JUnit test failures with this commit
> ConnectionTest.testPrepareStatementBasicCaseWorks:94 » ClassCast
org.apache
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/858
DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Allow for queries to be cancelled if they don't complete within the
stipulated time.
Tests added to test different query timeout scenarios
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/856
Existing negative Unit tests are failing. Look like we never had proper
unit tests. Will add them and update the PR.
---
If your project is set up for it, you can reply to this email and have your
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/856
@ppadma / @parthchandra ... can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/856
DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Allow for queries to be cancelled if they don't complete within the
stipulated time.
We submit a timeout-managing task that sleeps
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/826#discussion_r117108770
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -160,6 +160,9 @@
OptionValidator OUTPUT_FORMAT_VALIDATOR = new
GitHub user kkhatua reopened a pull request:
https://github.com/apache/drill/pull/834
DRILL-5481: Allow to persist profiles in-memory only with a max capacity
1. Introduced an InMemoryStoreProvider with the ability to maintain a max
capacity
2. DrillbitContext now explicitly
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/827
Closing this PR in favor of
[another](https://github.com/apache/drill/pull/834/)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/834
@sudheeshkatkam , @ppadma
Smaller commit that addresses the in-memory profile store requirement. This
one does not require me to change any existing functionality or tests. I'll
close the other
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/834
DRILL-5481: Allow to persist profiles in-memory only with a max capacity
1. Introduced an InMemoryStoreProvider with the ability to maintain a max
capacity
2. DrillbitContext now explicitly has
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/827
@sudheeshkatkam & @ppadma ... please review and bless the PR if everything
looks fine.!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/827
@ppadma, @sudheeshkatkam
Updated most of the changes except the flag itself. Waiting for a quick
review and final comment on whether I can change the flag from
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115564261
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
---
@@ -15,28 +15,42 @@
* See the License
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115563669
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -57,14 +59,14 @@ public
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115551170
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -136,9 +136,10 @@ drill.exec: {
},
sys.store.provider: {
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115548661
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -27,28 +27,30 @@
import
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115548554
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
---
@@ -93,6 +107,14 @@ public void put(final
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115547683
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -105,8 +105,10 @@
String HTTP_TRUSTSTORE_PATH
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115547194
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
---
@@ -15,28 +15,42 @@
* See the License
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115546712
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
---
@@ -15,28 +15,42 @@
* See the License
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/827
DRILL-5481: Persist profiles in-memory only with a max capacity
Refactored NoWriteLocalStore to EphemeralPersistentStore with the ability
to maintain a max capacity
Updated Default values
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/755
@sudheeshkatkam Can you please review the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/756
@paul-rogers Incorporated all changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103063332
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -35,6 +38,10 @@
public class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103062066
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/756
@paul-rogers
Incorporated most changes... except:
https://github.com/apache/drill/pull/756#discussion_r103000211
https://github.com/apache/drill/pull/756#discussion_r103005037
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103053243
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103032276
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103030867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String getContent
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103028479
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/756
@paul-rogers , checked in the final set of changes, accommodating most of
your comments.
TPCH Samples:
http://10.10.100.127:8047/profiles/275020fe-f51c-b8f3-a7b4-9f54461c4606
http
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102851729
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102841580
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102839683
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102840619
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102839508
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -83,56 +84,77 @@ public String getContent
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102836154
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102835175
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102830628
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102830458
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102824748
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,25 +215,25 @@ public String getContent
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102824195
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102823965
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102822445
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102821345
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820948
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820546
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102820217
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/756
DRILL-5195: Publish Operator and MajorFragment Stats in Profile page
Improved UI
1. Introduction of Tooltips
2. Share of each operator as a percentages of the major fragment and of the
query
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/756
@sudheeshkatkam This commit is rebased on top of another pending PR (#738):
DRILL-5190. You'll need to apply that before applying this.
---
If your project is set up for it, you can reply
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/755
For 8266 profiles, when measured from Chrome browser's Network tool:
```
Load First Time: 2.43s
Load Second Time (no new profiles): 829ms
```
---
If your project is set up
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/755
A summary of the performance is available in this
[comment](https://issues.apache.org/jira/browse/DRILL-5270?focusedCommentId=15877119=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/755
DRILL-5270: Improve loading of profiles listing in the WebUI
Using Hadoop API to filter and reduce profile list load time
Using an in-memory treeSet-based cache, maintain the list of most recent
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/742
This closes PR #742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/739
This closes PR #739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910265
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +192,13 @@ public QProfiles(List
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910137
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910132
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910087
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101879098
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +193,13 @@ public QProfiles(List
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101872793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +193,13 @@ public QProfiles(List
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101872723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -61,7 +64,7 @@
public class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101864433
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +193,13 @@ public QProfiles(List
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/751
DRILL-5259: Allow listing a user-defined number of profiles
Allow changing default number of finished queries in web UI, when starting
up Drillbits
-Ddrill.exec.http.max_profiles=100
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/742
@sudheeshkatkam Please review the PR and label the JIRA, so that @jinfengni
can get it into the commit list for master.
---
If your project is set up for it, you can reply to this email and have
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r101115347
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
---
@@ -122,6 +125,31 @@ public String getQueryId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r100925486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -417,6 +417,9 @@ private void parseAndRunPhysicalPlan(final
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/739
@paul-rogers Created a new SimpleDurationFormat class. We can expand to
have more formats, or reimplement on lines of SimpleDateFormat by passing
format strings in the future. Hope this helps
301 - 400 of 431 matches
Mail list logo
