[GitHub] [drill] cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions

2019-08-13 Thread GitBox
cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions URL: https://github.com/apache/drill/pull/1841#issuecomment-520893562 The reason I'd suggest this is that there are free functions, which are in widespread use, and there are also paid versions with the same functionality.

[GitHub] [drill] cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions

2019-08-13 Thread GitBox
cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions URL: https://github.com/apache/drill/pull/1841#issuecomment-520892090 Hi Arina, What if we just require that the files are in the classpath, don't ship them with Drill and if the user wants to use these functions, they

[GitHub] [drill] cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions

2019-08-13 Thread GitBox
cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions URL: https://github.com/apache/drill/pull/1841#issuecomment-520879157 @vvysotskyi Regarding the large files, they are the open version of the MaxMind geo-locational database for IP addresses.