[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-03 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-593929455 @arina-ielchiieva has applied your advice ,thanks. This is an

[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-02 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-593767181 Still on a pre-product stage at our env. But as I mentioned above , we could give a query a hint to open this feature not apply

[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control

2020-03-02 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: Support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-593361993 @paul-rogers please give a final review ,thanks. This is an

[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control

2020-03-01 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-593216689 @paul-rogers agree with your two configure item advice. But I suggest to configure `Enable/disable this feature` item as

[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control

2020-02-27 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-592380762 @vvysotskyi how to apply the path ? I have regenerated the native cpp code, but still failed at the CI error. thanks!

[GitHub] [drill] weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control

2020-02-27 Thread GitBox
weijietong commented on issue #2000: DRILL-7607: support dynamic credit based flow control URL: https://github.com/apache/drill/pull/2000#issuecomment-592024872 Anyone could explain the CI error about the protobufs ? This is