Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1043
I will but it's high time to learn how to do it :)
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
May be @arina-ielchiieva can help resolve squashing into one commit.
LGTM ... thanks for doing this!
+1
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1043
I made the requested fixes, and attempted to squash the commits into one,
but failed on that last step. I actually renamed the js director
`ace-code-editor`, which seemed descriptive to me.
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
@cgivre
Just edited the last comment to remove the +1 [ Learnt that I should wait
till there is a response to my asks first! :) ] .
To summarize, here are my 3 asks:
1. Change the theme
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
Oh.. just for a heads up (I guess you already knew this), I zeroed in on
the 2 themes based on copy-pasting a sample storage plugin into this:
https://ace.c9.io/build/kitchen-sink.html
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
Very nice, @cgivre ! I've been looking to do something similar for the SQL
side as well, but with autocomplete support. Let's talk about that separately.
We just need to make sure that there are no
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1043
@cgivre looks really nice, thanks for making the change! @kkhatua could you
please take a look at this PR?
---
