Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/374#issuecomment-184883435
I'm +1 on my patch assuming the manually testing that Sudheesh is asking
about.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/374#issuecomment-184833965
Since there are no unit tests for web UI, can you do some manual testing to
ensure there are no regressions?
Is there a simple way to test all persistent
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r53059667
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/CachingPersistentStoreProvider.java
---
@@ -0,0 +1,77 @@
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52962267
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -0,0 +1,74 @@
+/**
+ *
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52962256
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/ZookeeperPersistentStoreProvider.java
---
@@ -0,0 +1,85 @@
+/**
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52962203
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/CachingPersistentStoreProvider.java
---
@@ -0,0 +1,72 @@
+/**
+
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52962000
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -146,38 +154,37 @@ public QProfiles(List
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52961092
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -0,0 +1,74 @@
+/**
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960719
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/CachingPersistentStoreProvider.java
---
@@ -0,0 +1,72 @@
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960717
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreMode.java
---
@@ -6,22 +6,18 @@
* to you under the Apache
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/ZookeeperPersistentStoreProvider.java
---
@@ -0,0 +1,85 @@
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960456
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -217,11 +223,14 @@ private QueryProfile
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960464
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -267,9 +276,8 @@ public String
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960453
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -200,9 +207,8 @@ private QueryProfile
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52960439
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -146,38 +154,37 @@ public QProfiles(List
Github user hnfgns commented on the pull request:
https://github.com/apache/drill/pull/374#issuecomment-184463952
Please let me know of further comments and remember to +1 if you are comfy
with the patch. If nothing severe is seen, let's take all comments on follow-up
PRs. This patch
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52958072
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52957626
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52957306
--- Diff:
common/src/main/java/org/apache/drill/common/collections/ImmutableEntry.java ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52957167
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -206,6 +209,16 @@ public DistributedSemaphore
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52956885
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52956715
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -206,6 +209,16 @@ public DistributedSemaphore
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52956166
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/LocalClusterCoordinator.java
---
@@ -125,6 +127,11 @@ public
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52955476
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/LocalClusterCoordinator.java
---
@@ -125,6 +127,11 @@ public DistributedSemaphore
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52955131
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java
---
@@ -41,10 +39,8 @@
import
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52955096
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java
---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52954392
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java
---
@@ -41,10 +39,8 @@
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52954382
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
---
@@ -237,11 +237,17 @@ void unpauseExecutingFragments(final
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52954225
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStore.java
---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52954240
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreProvider.java
---
@@ -17,17 +17,26 @@
*/
package
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52954150
--- Diff:
common/src/main/java/org/apache/drill/common/collections/ImmutableEntry.java ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52954122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -146,38 +155,37 @@ public QProfiles(List
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953970
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/store/TransientStoreListener.java
---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953875
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
---
@@ -148,13 +154,13 @@ private void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953882
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953797
--- Diff:
common/src/main/java/org/apache/drill/common/collections/ImmutableEntry.java ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953622
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java
---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953108
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreProvider.java
---
@@ -17,17 +17,26 @@
*/
package
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953137
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
---
@@ -237,11 +237,17 @@ void
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953084
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -267,9 +277,8 @@ public String
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953078
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -146,38 +155,37 @@ public QProfiles(List
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953099
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStore.java
---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953080
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -200,9 +208,8 @@ private QueryProfile
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953064
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZkEphemeralStore.java
---
@@ -0,0 +1,145 @@
+/**
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953057
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/store/TransientStoreListener.java
---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953044
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
---
@@ -148,13 +154,13 @@ private
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52953040
--- Diff:
common/src/main/java/org/apache/drill/common/collections/ImmutableEntry.java ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user hnfgns commented on the pull request:
https://github.com/apache/drill/pull/374#issuecomment-184436146
I have retracted unrelated mongo changes. Thanks for the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52951701
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/serialization/InstanceSerializer.java
---
@@ -6,20 +6,20 @@
* to you under the Apache
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52951541
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/store/TransientStoreListener.java
---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52951273
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/PathUtils.java ---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52950999
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/ClusterCoordinator.java
---
@@ -60,16 +62,23 @@
public abstract DistributedSemaphore
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52950554
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/serialization/JacksonSerializer.java
---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52950533
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -206,6 +205,16 @@ public DistributedSemaphore
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52950537
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/ZookeeperPersistentStore.java
---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/374#issuecomment-184037187
Looks reasonable. I added a few comments.
I think the Mongo interface => class changes should be a separate patch. It
adds noise to this patch and is really a
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855320
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -206,6 +205,16 @@ public DistributedSemaphore
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855239
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/ZookeeperPersistentStore.java
---
@@ -0,0 +1,136 @@
+/**
+ * Licensed
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855204
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/serialization/JacksonSerializer.java
---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855187
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/serialization/InstanceSerializer.java
---
@@ -6,20 +6,20 @@
* to you under the Apache
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855145
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/PathUtils.java ---
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855121
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/store/TransientStoreListener.java
---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855054
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/ClusterCoordinator.java
---
@@ -60,16 +62,23 @@
public abstract
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52855063
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/MapBackedStore.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52797746
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52817125
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/374#discussion_r52818257
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -120,7 +120,7 @@ drill.exec: {
affinity.factor: 1.2
},
GitHub user hnfgns opened a pull request:
https://github.com/apache/drill/pull/374
DRILL-4275: create TransientStore for short-lived objects; refactor
PersistentStore to introduce pagination mechanism
ps: removed PR#395 mistakenly so starting over.
collections/
69 matches
Mail list logo
