[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169397851 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169397714 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -34,28 +34,47 @@ hive-exec compile +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169397544 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java --- @@ -143,7 +143,7 @@ private void

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169397509 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java --- @@ -86,7 +86,7 @@ protected

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169348315 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java --- @@ -86,7 +86,7 @@ protected

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169360386 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169351388 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java --- @@ -143,7 +143,7 @@ private void

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-20 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r169354613 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -34,28 +34,47 @@ hive-exec compile +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-16 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r167945192 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-16 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r167947402 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-16 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r167944958 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-16 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r167946336 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +512,49 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166842824 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166838809 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +512,49 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166832879 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166832638 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End diff

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166650425 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166651052 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r10444 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166651134 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -101,6 +105,7 @@ org.apache.calcite calcite-core +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166679633 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166672700 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r19844 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166683550 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-07 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r10333 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166513062 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166508479 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166508171 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -101,6 +105,7 @@ org.apache.calcite calcite-core +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166513403 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166510396 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166512235 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166513525 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166507937 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End diff

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166512379 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166246336 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java --- @@ -100,7 +103,9 @@

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166282137 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java --- @@ -264,6 +265,10 @@ private HiveStats

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166247024 --- Diff: pom.xml --- @@ -884,13 +884,33 @@ io.netty netty-all + +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166251399 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +509,51 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166198314 --- Diff: pom.xml --- @@ -884,13 +884,33 @@ io.netty netty-all + +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166202560 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java --- @@ -100,7 +103,9 @@ private

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

2018-02-06 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166213941 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +509,51 @@ public static boolean