[GitHub] drill pull request #1227: Drill-6236: batch sizing for hash join

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183181073 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -560,6 +554,40 @@ public void close() {

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183171726 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -560,6 +554,40 @@ public void close() {

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183169484 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -560,6 +554,40 @@ public void close() {

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183145171 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -147,7 +150,19 @@ NUM_BUCKETS,

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183145138 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -157,14 +172,20 @@ public int metricId() {

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183112258 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -147,7 +150,19 @@ NUM_BUCKETS,

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r183108078 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -300,13 +322,14 @@ public void setupHashTable()

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182929294 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -188,12 +196,18 @@ public int

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182929487 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -147,6 +149,12 @@ public int update(int

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182910955 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -346,6 +369,7 @@ public void executeBuildPhase()

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182911591 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -241,4 +261,41 @@ public int getOutputBatchSize()

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182919074 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java --- @@ -241,4 +261,41 @@ public int getOutputBatchSize()

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182910786 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -300,13 +322,14 @@ public void setupHashTable()

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1227#discussion_r182898395 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java --- @@ -147,7 +150,19 @@ NUM_BUCKETS,

[GitHub] drill pull request #1227: Drill 6236: batch sizing for hash join

GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1227 Drill 6236: batch sizing for hash join You can merge this pull request into a Git repository by running: $ git pull https://github.com/ppadma/drill DRILL-6236 Alternatively you can review and