[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103332364 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -392,22 +448,31 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103335045 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -1231,52 +1308,44 @@ private

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103332807 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -765,12 +838,12 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r10813 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -948,50 +1027,50 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103335368 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -238,6 +238,25 @@ public boolean copyFromSafe(int fromIndex, int

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103332576 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -392,22 +448,31 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103330903 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -357,9 +393,13 @@ public SpillSet(FragmentContext

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103331438 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -219,7 +220,18 @@

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103068736 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -948,50 +1027,50 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103069029 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -948,50 +1027,50 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103067062 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -238,6 +238,25 @@ public boolean copyFromSafe(int fromIndex, int

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103068095 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -765,12 +838,12 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103066042 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -357,9 +393,13 @@ public SpillSet(FragmentContext

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/761 DRILL-5284: Roll-up of final fixes for managed sort See subtasks for details. * Provide detailed, accurate estimate of size consumed by a record batch * Managed external sort spills